summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2020-02-20tdf#130187: Don't crash on exiting print preview with NotebookbarMike Kaganski1-12/+3
Crash caused by this sequence (tested in Writer): 1. Closing print preview, frame is attached to controller; 2. This calls SfxNotebookBar::StateMethod 3. There notebookbar's listener is added to list of the controller's context change event listeners 4. Then in SwPagePreview::~SwPagePreview, notebookbar's listener is added to that list again 5. ContextChangeEventMultiplexer::addContextChangeEventListener detects second addition, and throws an unhandled exception. I don't know why starting listening is needed in SwPagePreview dtor; unfortunately commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd doesn't say much about context and reasons. ControlListener is renamed to ControlListenerForCurrentController to emphasize that it operates on the current controller of notebookbar's frame; and its bListen parameter meaning was reverted: previously its "true" value awkwardly meant "stop listening". All direct operations with listener of notebookbar are replaced with calls to notebookbar's methods. In ContextChangeEventMultiplexer::addContextChangeEventListener, uno::UNO_QUERY_THROW was replaced with uno::UNO_QUERY, because not only chart controller may appear here, and it's not an error: e.g. SfxBaseController doesn't implement lang::XServiceInfo. Regression after commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd. Change-Id: Ief1aed188d8f02a6cfe3ea25f4d082dfdf449f32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86257 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87582 (cherry picked from commit fb2382ad4f33b885650ad5156ccaec4e90661806) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88229 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-01-31Adapt o3tl::span to P1872R0Stephan Bergmann1-1/+2
..."span should have size_type, not index_type" (<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1872r0.pdf>), as implemented by libc++ since <https://github.com/llvm/llvm-project/commit/ 1466335cf4b2854a0be1defcf279fe50772bad6f> "[libc++][P1872] span should have size_type, not index_type." All uses of index_type had been added to mitigate the previous std::span change from signed (ptrdiff_t) to unsigned (size_t) index_type, see 6ef8420fdbf8dff16de13147c5ab833bc5e01121 "Adapt o3tl::span to updated C++2a std::span". There is no easy solution to transparently support all three std::span variants currently out there (signed index_type, unsigned index_type, unsigned size_type), without causing compilation failures due to CPPUNIT_ASSERT_EQUAL with arguments of different types, or compiler warnings about mixed signed/unsigned comparisons. So rule out the oldest std::span variant (signed index_type) in configure.ac (so that o3tl::span will use its own hand-rolled code in that case) and simplify the uses of index_type to std::size_t (as had already been mentioned in 6ef8420fdbf8dff16de13147c5ab833bc5e01121). Change-Id: I6ddf424ffb7941da3f69ad66fd29ecd35f09afae Reviewed-on: https://gerrit.libreoffice.org/84652 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 8e6865188242bccb3d8aa857ddc990d72a058d3d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87757 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17tdf#129788: Revert "no need to use AlphaMask in RecentDocsViewItem"Xisco Faulí1-1/+2
This reverts commit 31bd8c4a4a4752dcff12ee35636193f79a6d6137. Similar to 5c54778aad677d6bb6e6687f0f43dffad1aefa1e Change-Id: Ibb4daa702df1f683888b92b8b8041f28e25e6b04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-08Bump copyright year to 2020Adolfo Jayme Barrientos1-1/+1
Change-Id: I6fb736591f32907c8977fbac8fbf1dcbaef1bb97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86092 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit a526e85a0d6371781482a9b7de4e05b8b2578de2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86093 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-12-18tdf#129311 don't allow temporary trusted certsJan-Marek Glogowski1-1/+9
This simply skips the DocumentMacroConfirmationRequest, if the macro security level (MSL) is *High* and the list of trusted authors is read-only. For the MSL *Medium*, the check box of the dialog is hidden with read-only trusted authors. Change-Id: If6c08e4fdbf200e778d181370cc73fd947cecff5 Reviewed-on: https://gerrit.libreoffice.org/84887 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 71c6f438cecc3ce5e8060efe1df840652885701c) Reviewed-on: https://gerrit.libreoffice.org/85299
2019-12-16tdf#129005 Make Infobar push buttons keyboard accessibleJim Raykowski1-3/+8
Also indicate infobar has keyboard focus by shading the close button when infobar gets focus. And as a bonus shade the close button on mouseover. Change-Id: Ie714f3e6d1f13d44ced94a02af398c5c75607b94 Reviewed-on: https://gerrit.libreoffice.org/83639 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit ac11dd8365c9e9de67717d18b7983af1eca17eaf) Reviewed-on: https://gerrit.libreoffice.org/85001 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-13tdf#128191 Show infobar when hyphenation info for text language is missingSamuel Mehrbrodt4-0/+37
During doc loading it's too early to add infobars, thus add a mechanism to display infobars once view is ready Change-Id: Ie963a304d2101a5bbdd59130c354d581ff7d2e9b Reviewed-on: https://gerrit.libreoffice.org/84634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03Disable macro menu entries when DisableMacrosExecution is setSamuel Mehrbrodt3-1/+16
Change-Id: Ica9a4f4a6510717dcd9fe53676e5a6f261f005ce Reviewed-on: https://gerrit.libreoffice.org/84231 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit e58eda7df5b384c0f054fcbd4a8dc4a47bed2080) Reviewed-on: https://gerrit.libreoffice.org/84293 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-03Don't disable "Send doc via email" when LockExport is setSamuel Mehrbrodt1-1/+1
Only sending as other formats should be disabled in this case Change-Id: I985d43ba314a1bda16dab33897d212ad27d3d115 Reviewed-on: https://gerrit.libreoffice.org/84240 Tested-by: Jenkins Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit b9930d0d05db39a8466b18dccf626bc3d8ae5c4e) Reviewed-on: https://gerrit.libreoffice.org/84292 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-02lok: add viewId to window painting, to allow special-casing on render.Michael Meeks1-0/+7
View switching should not cause the sidebar UX to re-build at all. Particularly it should not do this when we switch view just to render a sidebar. Change-Id: Iec0427cdc8308fc273d73ea56dd208bfa7036471 Reviewed-on: https://gerrit.libreoffice.org/84120 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 92814f3389de346f3ae32cddb38f079763e68ddf) Reviewed-on: https://gerrit.libreoffice.org/84129 Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/84223
2019-12-02tdf#118639: store ODF encryption data for autorecoveryMike Kaganski1-6/+12
When saving autorecovery information, ODF is used. If the original document is password-protected, its autorecovery is also generated password-protected (since ef87ff6680f79362a431db6e7ef2f40cfc576219). But when the stored encryption data for non-ODF document does not contain "PackageSHA256UTF8EncryptionKey" value, following ZipPackage::GetEncryptionKey fails, so the whole save fails. So just generate and append ODF encryption keys where we still have user password. Change-Id: I776e28de784489521e4941d1075690f90c056014 Reviewed-on: https://gerrit.libreoffice.org/84052 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 63634738dd03cc74806ce6843c16ff5e51a371a0) Reviewed-on: https://gerrit.libreoffice.org/84133 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-30Resolves: tdf#97086 Allow "unlimited" password length for OOXML encryptionEike Rathke1-4/+6
Change-Id: I51175424e19ad02b81120c3fdea22732cd481a8d Reviewed-on: https://gerrit.libreoffice.org/84097 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit adb7106a7c805d332c8098891996a75e6ec4caf8) Reviewed-on: https://gerrit.libreoffice.org/84100
2019-11-29tdf#128898 import text from file with text-decode failedNoel Grandin3-19/+13
regression from commit 8f6f9e4217d03d874fb1ce391730a1c893ab6844 tdf#127958 crash adding 2 or more files into writer master document just make SfxMedium use shared_ptr, rather than the sometimes yes, sometimes no, ownership. Reviewed-on: https://gerrit.libreoffice.org/83930 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit cc4dbe473b0b68dbe120065c1d6a64a087f41ba2) Resolves: tdf#129082 insert sheet from file fails since... tdf#127958 crash adding 2 or more files into writer master document commit 8f6f9e4217d03d874fb1ce391730a1c893ab6844 Date: Mon Oct 7 09:40:41 2019 +0200 used the SfxItemSet copy ctor to make a copy of the itemset, but the orig itemset was a SfxAllItemSet not a SfxItemSet. an SfxAllItemSet allows all items to be added but a plain SfxItemSet only allows items in certain ranges to be inserted. Upshot is that later on the filename property cannot be set in the itemset, so file can't be opened. since... tdf#128898 import text from file with text-decode failed commit cc4dbe473b0b68dbe120065c1d6a64a087f41ba2 Date: Wed Nov 27 11:47:57 2019 +0200 tdf#128898 import text from file with text-decode failed these are std::shared_ptr so we can return to passing in the original SfxAllItemSet again to fix the problem Reviewed-on: https://gerrit.libreoffice.org/84024 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Change-Id: I77559e9f766d84aca0f9dc0bd1b856c69f0f62f1 Reviewed-on: https://gerrit.libreoffice.org/84025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-26tdf#126043 fetch the command properties just onceCaolán McNamara4-12/+24
Change-Id: Iaf343e9858be36ca8772d9c12eee772d93b4c394 Reviewed-on: https://gerrit.libreoffice.org/83668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/83763
2019-11-26tdf#128557 Show disabled menu items in style lists context menuJim Raykowski1-0/+1
At present this doesn't work with gtk3 backend. Works with X11, tested by using SAL_USE_VCLPLUGIN=gen. I suspect it also works with kf5. Change-Id: I14b82bc7a6f25a4c88d547290d847217aa1b0de2 Reviewed-on: https://gerrit.libreoffice.org/83252 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 1906f3f2f7c39ea9a3e04f1081dbfc24a1de3212) Reviewed-on: https://gerrit.libreoffice.org/83365 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-26tdf#128557 Add tooltips to styles listsJim Raykowski2-0/+48
Change-Id: Ia8f00cd882c1c8c239b95de8e917ff317a6485e8 Reviewed-on: https://gerrit.libreoffice.org/83152 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit b8bbe9a3ca4758102ce6aa5d1e0fbb077eedbe64) Reviewed-on: https://gerrit.libreoffice.org/83364 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-26tdf#128557 Only show delete menu item when custom style is not in useJim Raykowski1-12/+4
or it has a parent style so when a custom paragraph style is in use it can be deleted and the style will revert to the parent Change-Id: I0e4ff953835c105241d3bb027d24841afdccc7ba Reviewed-on: https://gerrit.libreoffice.org/83008 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 30c9bc76d0718f0c01d34f81845d88413645b42c) Reviewed-on: https://gerrit.libreoffice.org/83367 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-23tdf#125359 Don't overlap multiple infobarsSamuel Mehrbrodt1-26/+7
Change-Id: Ieda7dce84daec2e94501c69584f3df21d63d60bb Reviewed-on: https://gerrit.libreoffice.org/83101 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 1562e094fc6a57cd9738109d5202497bcc043d80) Reviewed-on: https://gerrit.libreoffice.org/83505 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-23Add SolarMutexGuard to infobar api methodsSamuel Mehrbrodt1-0/+6
Change-Id: If7fab7df7566b1db770437090115b064b98257c6 Reviewed-on: https://gerrit.libreoffice.org/83255 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 9c9c047f42637c274b246fb4020ed0df4ee39ded) Reviewed-on: https://gerrit.libreoffice.org/83506 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-22tdf#97926 Add UNO API for InfobarSamuel Mehrbrodt5-67/+158
This allows creating, updating and removing infobars from macros/extensions. It also extends the infobar with a primary and a secondary text, so there can be a bold summary at the beginning at the infobar with a longer text following in normal letters. Macro sample: ------------------------------------------------------------ Sub AddInfobar dim buttons(1) as new com.sun.star.beans.StringPair buttons(0).first = "Close doc" buttons(0).second = ".uno:CloseDoc" buttons(1).first = "Paste into doc" buttons(1).second = ".uno:Paste" ThisComponent.getCurrentController().appendInfobar("my", "Hello world", "Things happened. What now?", com.sun.star.frame.InfobarType.INFO, buttons, true) End Sub Sub UpdateInfobar ThisComponent.getCurrentController().updateInfobar("my", "WARNING","Do not read this message.", com.sun.star.frame.InfobarType.WARNING) End Sub Sub RemoveInfobar ThisComponent.getCurrentController().removeInfobar("my") End Sub ------------------------------------------------------------ Change-Id: I5d0a223525845d23ffab17acdaa431e0eb783fec Reviewed-on: https://gerrit.libreoffice.org/29816 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 9e3ba7c3036c4d21e01d6f75ed29a1e8c4208141) Reviewed-on: https://gerrit.libreoffice.org/83405 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-21tdf#84183 Give infobar close btn some 'clicked' stateSamuel Mehrbrodt1-1/+6
Slightly smaller cross when the button is clicked on to have some feedback for the user Change-Id: If0486319e9816378b2011bbb366b4c577c1ad84a Reviewed-on: https://gerrit.libreoffice.org/83087 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 60c0874227201310c099fb717c0a665dbcf5bb33) Reviewed-on: https://gerrit.libreoffice.org/83190 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-19tdf#128723 Options Print Dialog updateandreas kainz1-318/+425
Change-Id: I2910a39602a596ed6afb7b5e80dd5290663f7ff6 Reviewed-on: https://gerrit.libreoffice.org/82474 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit bf88b78ee61936bb5e4b79d4ea1ab3ee049993e0) Reviewed-on: https://gerrit.libreoffice.org/83012 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-15Revert "tdf#126128 Reduce page properties dialog's height."Heiko Tietze1-5/+0
Discussion in BZ. This reverts commit 80109586e6cb6d3e2e0a53a9079c3125ec9b8368. Change-Id: I01e23a7eeaa78d60f106dfa67a54ff9d7904cb19 Reviewed-on: https://gerrit.libreoffice.org/82698 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 687c6761e84101f8a798ac7f622c2eab4f84d7b2) Reviewed-on: https://gerrit.libreoffice.org/82763 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-13Add document level option to lock down edit doc commandSerge Krot4-5/+49
Change-Id: I431fa4cd0daa52c885030dbadcc4052b5a890d34 Reviewed-on: https://gerrit.libreoffice.org/82553 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-on: https://gerrit.libreoffice.org/82576 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-13SystemPath does not need to be a classNoel Grandin2-4/+6
Change-Id: I02adb188ae75bd721d8e80cf0df11fde40a11d9b Reviewed-on: https://gerrit.libreoffice.org/82566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-12Property Dialog Description Tab fix expand optionandreas kainz1-0/+2
Change-Id: Ie5be03cf96fc520444616416d13985454994bb03 Reviewed-on: https://gerrit.libreoffice.org/82484 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-11tdf#118526 Reload Notebookbar if read mode has switchedJim Raykowski1-1/+1
Change-Id: I8d6edd57566c66165690808e853a74777bc8e14a Reviewed-on: https://gerrit.libreoffice.org/82371 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-09Template dialog updateandreas kainz1-12/+5
Change-Id: I76ee82ad3a80dac0bd3693e411fe1f55a26f34ed Reviewed-on: https://gerrit.libreoffice.org/82364 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-09Removed executable bit on source fileAndrea Gelmini1-0/+0
Change-Id: I22e35d5d5797f94496bd6dbf90ead252db851c71 Reviewed-on: https://gerrit.libreoffice.org/82359 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-09Switch to read-only mode: do not force reload document if possibleSerge Krot1-1/+3
Change-Id: I5f83e7626e58cb4b558b54130b725b1041b7142f Reviewed-on: https://gerrit.libreoffice.org/82313 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit b92e774bbfe83aba80c8d480399887394937cc96) Reviewed-on: https://gerrit.libreoffice.org/82314 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-08loplugin:indentation (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Id3031852a9e4d58c7caad68b91a0633bcd7a2489 Reviewed-on: https://gerrit.libreoffice.org/82270 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-08Writer Property Dialog updateandreas kainz5-54/+27
Change-Id: I22959d387d23fc28e2b7d8fa84b290d7f7d95995 Reviewed-on: https://gerrit.libreoffice.org/82260 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07Fix UBSan null-pointer-useStephan Bergmann2-5/+5
...during CppunitTest_sw_mailmerge (see below). Not sure why this started now, and no idea whether pWin can legitimately be null there in SfxWorkWindow::HidePopups_Impl, but the fix looks harmless enough to just do it. > sfx2/source/appl/workwin.cxx:1512:52: runtime error: reference binding to null pointer of type 'const vcl::Window' > #0 in SfxWorkWindow::HidePopups_Impl(bool, unsigned short) at sfx2/source/appl/workwin.cxx:1512:37 > #1 in SfxDispatcher::DoActivate_Impl(bool) at sfx2/source/control/dispatch.cxx:706:56 > #2 in SfxViewFrame::DoActivate(bool) at sfx2/source/view/viewfrm.cxx:1175:20 > #3 in SfxApplication::SetViewFrame_Impl(SfxViewFrame*) at sfx2/source/appl/app.cxx:308:21 > #4 in SfxViewFrame::SetViewFrame(SfxViewFrame*) at sfx2/source/view/viewfrm.cxx:3268:19 > #5 in SfxViewFrame::MakeActive_Impl(bool) at sfx2/source/view/viewfrm.cxx:1879:9 > #6 in SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) at sfx2/source/view/sfxbasecontroller.cxx:1254:33 > #7 in SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/sfxbasecontroller.cxx:532:9 > #8 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) > #9 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:714:13 > #10 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1157:37 > #11 in framework::LoadEnv::startLoading() at framework/source/loadenv/loadenv.cxx:390:20 > #12 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:171:14 > #13 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:621:12 > #14 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx > #15 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:48:62 > #16 in SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:764:23 > #17 in SwModelTestBase::load(rtl::OUString const&, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:719:16 > #18 in MMTest::executeMailMerge(bool) at sw/qa/extras/mailmerge/mailmerge.cxx:209:9 > #19 in testTdf95292::verify() at sw/qa/extras/mailmerge/mailmerge.cxx:593:5 > #20 in MMTest::executeMailMergeTest(char const*, char const*, char const*, bool, int, char const*) at sw/qa/extras/mailmerge/mailmerge.cxx:88:9 > #21 in testTdf95292::MailMerge() at sw/qa/extras/mailmerge/mailmerge.cxx:590:1 Change-Id: Id9499c62cca6e1fcf3ba50b82117395106a93765 Reviewed-on: https://gerrit.libreoffice.org/82246 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-07we want this size group to handle both dimensionsCaolán McNamara1-0/+1
Change-Id: I22647328dbcc1d4eb6b3841ea9a8e64d022cf252 Reviewed-on: https://gerrit.libreoffice.org/82236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07loplugin:unusedmethodsNoel Grandin1-17/+0
Change-Id: I65354c7476dfaede1a607441d7c1b0c7ad038df4 Reviewed-on: https://gerrit.libreoffice.org/82186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06fix translate bug in SfxPopupWindow::MouseMoveNoel Grandin1-2/+2
there since initial import Change-Id: Ic38ab070c22632dde00cdea0b109b236f8590654 Reviewed-on: https://gerrit.libreoffice.org/82117 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06make some classes module-privateNoel Grandin1-1/+1
Change-Id: I00ab3a3f6a8bbc85320e7b4fd1aa13af798e7e4c Reviewed-on: https://gerrit.libreoffice.org/82062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06loplugin:indentation find broken if statementsNoel Grandin2-30/+30
so I don't read the "then" block as being a sequential statements Change-Id: Ib2004acd3518bd4ebd2246f02a26c2c0a8bbab4c Reviewed-on: https://gerrit.libreoffice.org/82069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05make some classes module-privateNoel Grandin3-3/+3
Change-Id: Ice9a57eedb166672dbdfae6da2a172ab77566a19 Reviewed-on: https://gerrit.libreoffice.org/81983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-04Fix build with --disable-pch on WinGabor Kelemen2-8/+28
Broken after commit 2cd6ff8a54b0db76b2f4c5f75988367cfb0feaf0 - apparently vcl/svapp.hxx is needed Most of sfx2/source/appl/appdde.cxx is Windows specific so took the opportunity to clean it up with IWYU and commenting out ifdefs Change-Id: Ia0ad54f590cf19033e630ea4df98c244bfdc47a0 Reviewed-on: https://gerrit.libreoffice.org/81849 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-03make some classes module-privateNoel Grandin4-5/+4
improve the script, but it still generates some false positives Change-Id: If8ee1cba8c04ac0be11f73220149e6de15f24f44 Reviewed-on: https://gerrit.libreoffice.org/81929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03size some stringbuffer to prevent re-allocNoel Grandin3-3/+3
I started with 32 and kept doubling the size until the site did not need re-alloc, but clamped it at 512. Change-Id: I55fe36b31cd3d40f86e5729337a927cf920f2af6 Reviewed-on: https://gerrit.libreoffice.org/81960 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03loplugin:stringaddNoel Grandin4-18/+16
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-02ofz#18620 TimeoutCaolán McNamara1-7/+5
Change-Id: Ifecba03620328afd20c80501aaacaf5795aee704 Reviewed-on: https://gerrit.libreoffice.org/81947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02New loplugin:conditionalstringStephan Bergmann2-3/+3
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-02cid#1455212 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I21e39dbaaec6c74b1c7ae1f306cb8d5c3d32c174 Reviewed-on: https://gerrit.libreoffice.org/81938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02weld SfxRecordingFloat_Impl utility windowCaolán McNamara3-57/+70
we can't abuse action_name anymore as the uno command are not legal actions Change-Id: Iaf9306c6e3eec852d2a50df9161bd20383881a04 Reviewed-on: https://gerrit.libreoffice.org/81902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01tdf#126128 Reduce page properties dialog's height.Gülşah Köse1-0/+5
Change-Id: Ie35c9cb4c9b134a94f3a125dd800936b7160950c Reviewed-on: https://gerrit.libreoffice.org/81910 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-10-31we already have a suitable parent for the dialogCaolán McNamara1-2/+1
Change-Id: Ib5da2fe6a5b56dfff088b16639ec7a3f226b18f2 Reviewed-on: https://gerrit.libreoffice.org/81744 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Fix StringAdd::isCompileTimeConstantStephan Bergmann4-16/+8
...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-23 12:44:21 +0000