summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2021-03-05use container_focus_changed instead of toplevel_focus_changedCaolán McNamara1-2/+2
seeing as its the same thing, but available one level of inheritance down Change-Id: Ieedbf2bc8cea09cdafff1514eac5c35b85c2fdd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112023 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05emplace_back: use perfect forwarding if possibleThorsten Behrens1-1/+1
When using that new-ish method, try giving the compiler a chance to construct in-place. Left out harder cases using initializer lists, and might have missed slightly less obvious places. Change-Id: Ifcc3a6d4599474457e37dd17a35c41fc73e7a17e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111980 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-03-04SidebarPanelBase is always created with a PanelLayoutCaolán McNamara1-2/+3
Change-Id: I825452fbd56435edcc0a2ffb7abe0f834bf10fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04master slide panel shouldn't have "more options" buttonCaolán McNamara4-5/+5
default the toolbox to hidden and show it if "more options" is enabled Change-Id: I6ff867268809d949e7854e0e76d3e45c8806797b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03Fix non-valid json generation on NotifyOtherViewsmert1-3/+9
Change-Id: I82aa0aefcd1de14b4c1bb2bbe3f087b60d691beb Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111299 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111515 Tested-by: Jenkins
2021-03-01loplugin:refcounting in sfx2Noel5-13/+11
Change-Id: Iba7b1be688f1a7c1b0947c2423cc1965362386b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111682 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-28devtools: on demand create the content of tab pagesTomaž Vajngerl3-27/+84
Until now all the tree views in each tab page were populated at once when the object was inspected. With this change, the tree views are filled on demand when the user enters a tab page, and is cleaned when the user leaves a tab page. Change-Id: I7f2ff89ab4c09412563b71e6524d4529318dee85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111533 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-28devtools: object inspector toolbar and object stackTomaž Vajngerl3-61/+218
This change adds a toolbar to the object inspector with buttons for inspect (which just links to the same action added to the context menu) and back. Back uses the newly added object stack to return to the previously inspected object. Only the objects which we used the "inspect" command in the object inspector tree are added to the object stack. Change-Id: Icb5b6e841200d6e0e41e260092a195fc84729d0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111532 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-27hide some FloatingWindow detailsCaolán McNamara5-9/+3
Change-Id: I1dc8cb7adc9a26efb74634353b9d75286e31ebb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-27Resolves tdf#137922 - Tight extension in start centerHeiko Tietze1-1/+6
Button disabled in start center Change-Id: I69674a3d0636835751a6a34a7a824561ba84034a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105292 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-27Resolves tdf#139453 - Image for Base in start centerHeiko Tietze2-0/+9
Background image is themable taken from SFX_THUMBNAIL_BASE_192 and SFX_THUMBNAIL_BASE_256 Change-Id: I0401bbe33ae39d8c8250383f492d0620c845c61e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111534 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-27tdf#138097 - Update templates / FreshesHeiko Tietze1-1/+1
Taken from https://lumbung.libreoffice.id/ * Some content removed from templates * Special fonts replaced by Noto Sans * *language* and *country* removed from styles.xml * <dc:title> added to meta.xml * README added to directories Change-Id: Ic205c08b7734f92b4b1ef7f12eb1e74a39dabd07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111060 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-26Resolves tdf#139243 - UI glitch in start centerHeiko Tietze1-1/+1
Initial focus on Recent Files Change-Id: I8f1b49f5fdb3fdf8a84b779c1e8c4df22c3a91f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111478 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-26tdf#138097 - Update templates / Growing LibertyHeiko Tietze1-1/+1
Taken from https://lumbung.libreoffice.id/ * Some content removed from templates * Special fonts replaced by Noto Sans * *language* and *country* removed from styles.xml * <dc:title> added to meta.xml * README added to directories Change-Id: Ib3ac2806e96d711cf9ed98f074b63f071cebff0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111106 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-26tdf#138097 - Update templates / Yellow IdeaHeiko Tietze1-1/+1
Taken from https://lumbung.libreoffice.id/ * Some content removed from templates * Special fonts replaced by Noto Sans * *language* and *country* removed from styles.xml * <dc:title> added to meta.xml * README added to directories Change-Id: Ibfec0bfefe83fab3ce26f692b923a530c525a848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111107 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-26Missing string for Candy templateHeiko Tietze1-1/+1
Change-Id: Ia74b74a198caa7a06ba8006bdbe9ec3907ace036 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111598 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-26tdf#138097 - Update templates / Grey ElegantHeiko Tietze1-1/+1
Taken from https://lumbung.libreoffice.id/ * Some content removed from templates * Special fonts replaced by Noto Sans * *language* and *country* removed from styles.xml * <dc:title> added to meta.xml * README added to directories * all styles reworked Change-Id: Ib3461bd22885d69e6abbb9747ded0f18f5bf23dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111058 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-26tdf#138097 - Update templates / SunsetHeiko Tietze1-1/+1
This patch partially reverts 849c1e9c74c388df549098a8a4f60131c9b8c6a0 and brings back one of the deleted templates Change-Id: If2a4a1294a887c55fcc490263f84880edfaa2ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110996 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-26devtools: support showing type's name as valueTomaž Vajngerl1-0/+6
Change-Id: Ifd99e884efe229dee2d0b42c6c66d3d9c3c90e7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111531 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-26devtools: add popup menu for properties to inspect objectsTomaž Vajngerl3-0/+60
With this change it is possible to inspect an object that is listed in the properties (instead of expanding the tree view node). Change-Id: I8b2229af650b46064c82bdd3fe93192d352d32e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111530 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-26devtools: support XIndexAccess and XNameAccess in object inspectorTomaž Vajngerl1-0/+26
If the current object in the object inspector is an container that supports XNameAccess or XIndexAccess, we now show the named or index values in the property view. This way the user can navigate to sub-objects, which is sometimes needed because we get an object supporting this intefaces, but can't navigate further. Best example would be XShapeCollection, which is what you get when selecting a shape (because with a selection we can select multiple shapes), but it is not possible to navigate to the shape without this change. Change-Id: I6a18723eccbc41519e3eacf68bc5b6488e02fe22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111529 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-25drop archaic rollable supportCaolán McNamara1-2/+1
Change-Id: I69f94cd8013a31f8f6bcf62d703b99f659a1ebb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25drop WB_ROLLABLECaolán McNamara3-3/+3
as far as I can see Rollable isn't a thing anymore Change-Id: I274e9dc88c793a5833e26bce292b4e92617ae084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111554 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25dockwin.hxx doesn't need to include floatwin.hxxCaolán McNamara4-0/+5
Change-Id: Ib0408f715c9a12f32ce2f8049d2c9c7272201d76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111504 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24hide menubar detailsCaolán McNamara1-6/+1
Change-Id: If9d30b4f1408f16cb84636245fc9039a0dd6bad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111481 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24use GetMenuBarHeight to get menu bar heightCaolán McNamara1-1/+1
Change-Id: I632ead4c63a3064391366334d961b1767ead9af8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24use XPopupMenu::execute to run the menuCaolán McNamara1-5/+4
instead of cheating and pulling the vcl::Menu out of it Change-Id: I498f4577c1e677e860ccb3bf394adbca298f074a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24Don't build URL only to drop the result immediatelyMike Kaganski1-5/+2
Change-Id: I128ce053c78caa5212dc69ee617fd4985e3bbfd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111323 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-23loplugin:unusedfieldsNoel1-4/+1
Change-Id: Ieb1b890040964e755de5bdf5f8576d4d3bd8a407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111386 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23No need to check if parent is empty: utl::TempFile does it itselfMike Kaganski1-2/+2
... down in ConstructTempDir_Impl Change-Id: I04f4cdb0bd77b1bf0f20a2c72b32a5343e9e7e72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111324 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-23sfx2 store: fix export to PDF when dir name is URL-encodedMiklos Vajna3-10/+39
Regression from commit 5259ab8104cfba60c40748ed0cd59d93df038c5b (sfx2 store: create temp files next to local files, 2018-01-08), the problem was that the directory hosting the input ODT file was called "Bugzilla%C3%BF" (URL-encoded from "ÿ"), we got this as "Bugzilla%25C3%25BF" (encoded from directory name), but we forgot to decode it before passing this URL to the utl::TempFile ctor as a parent directory, which resulted in failing to save as PDF, and crashing on DOCX export. Note that in practice this only caused a problem on Windows. Change-Id: I5fc8a356b63efc2f16405a14ee59a061b52c5205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111359 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-22factor out as a ResizableDockingWindowCaolán McNamara3-29/+19
Change-Id: I557ccf866cc879b3cc22fcdbca882f4413cb57d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22move dockingwindow.ui to vclCaolán McNamara4-21/+2
Change-Id: I90f18ba755da8ade247330ed102ffcc95740ebab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22devtools: add implementation class to the methods categoryTomaž Vajngerl2-2/+18
Implementation class is the class where the method is implemented on. Change-Id: Ia415ce96a821b4335e1f378b6b7773548fd3e705 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111293 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-22devtools: add MethodNode to show the column values for methodsTomaž Vajngerl1-2/+79
This adds the MethodNode, which uses reflection to get the info for a perticular method - mainly the return type and input/output parameters. The types have been simplified for this view. Change-Id: I81f895d3cdf1472ae4b21227572b7ccfad607018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111094 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-22devtools: rework columns for all categories in the inspectorTomaž Vajngerl1-64/+9
The columns for services and interfaces has been simplified to just "Name" column. For methods the columns have been changed to "Method", "Return Type" and "Parameters". The properties tree view remained unchanged. Change-Id: Ie8db69e11a3ea5aa289305017ed024d2d0d627da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111093 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-22devtools: change the object inspector view to tabsTomaž Vajngerl3-201/+475
Until now we had only one tree view with top-level nodes for services, interfaces, properties and methods. The problem with this is that each one category has it's own distinct columns (especially methods) so they can't fit well into just one tree view. Services and interfaces categories are very simple so they can be presented in a simpler way. This change adds a tab-bar on top, for all the categories and each one is now presented in its own tree view, which makes it possible to modify the tree view to the specific category. Tree views are currently copies, but they will be modified in the future into what is more appropriate for the category. Change-Id: Ib532df9bb7b9e0920fff57085d6ec4f1031b3ed8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111092 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-20no need for this .ui to require LibreOffice libCaolán McNamara1-1/+0
Change-Id: Ifb202a34d745e08023c94a1646eca1d9e8b8cb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-20loplugin:refcounting in sfx2Noel14-55/+39
Change-Id: I22ca5dab32fb4bf9a1ab7d478105db2d12e14b14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111262 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-20drop some unneeded includesCaolán McNamara1-1/+0
Change-Id: I0fe18c3e535bee2213606b7189778c40403a97ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19uitest: sw: differentiate the elements in the custompropertieslinesXisco Fauli1-5/+13
Change-Id: Ic61cd1655df2bcd7b89c4dfadcda801b7160253c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111226 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-19update pchesCaolán McNamara1-1/+3
Change-Id: Ic4586057346b6de700c1bb6ff4cd759a11bb3e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111231 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19foward declare NotebookBarAddonsItem instead of using includeCaolán McNamara1-0/+1
Change-Id: I57e5a8f28a40994b61ab0f554401e4f70c8ffc12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19rename get_vscroll_width to get_scroll_thicknessCaolán McNamara1-1/+1
and add split customize_scrollbars to form a separate set_scroll_thickness Change-Id: Ia4b1c85d6ae85b0fb7aeb852d3a91b36b63143db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16weld sidebar "too-narrow" CloseIndicatorCaolán McNamara3-47/+40
Change-Id: Ifda6f56ba51d46bd35065c2230f39e837b037096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16loplugin:referencecasting in sfx2Noel20-74/+71
Change-Id: Id24f477ad6cc964215cc04852efc369247f70a5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110985 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-16tdf#140387 grab focus to first panel widget on panel gaining focusCaolán McNamara2-0/+10
otherwise focus is getting lost in these currently mixed vcl+gtk widget panels. Change-Id: I6488ddfc98afdedb55bb3217f3877e96258dd65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-15Related: tdf#140387 give toolbuttons a11y namesCaolán McNamara4-15/+17
Change-Id: I046957afaf89e3f88cde4c2a3cffa470af657175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-14tdf#140308 Crash import old OpenOffice templateNoel Grandin1-5/+12
regression from commit cfe5a5044845a3fc90e3634e996edb4d85808d3c sfx2: use the fastparser API when possible We end up using the OOo2OasisTransformer filter, which is not fastparser compatible Bisected with: bibisect-linux64-7.1 Change-Id: I7bd4191f098096034dc8ff368aba4b1ff313ce18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110883 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-14Move unit conversion code to o3tl, and unify on that in more placesMike Kaganski1-2/+3
This also allows to easily add more units, both of length and for other unit categories. The conversion for "Line" unit (312 twip) is questionable. Corresponding entries in aImplFactor in vcl/source/control/field.cxx were inconsistent (45/11 in; 10/13 pc; 156/10 pt). They were added without explanation in commit c85db626029fd8a5e0dfcb312937279df32339a0. I haven't found a spec of the unit (https://en.wikipedia.org/wiki/Line_(unit) is not specific). I used the definition based on "by pt", "by mm/100", "by char" (they all were consistent); "by pc" seems inverted; "by twip" was half as much. This accepted conversion makes unit test for tdf#79236 pass. Change-Id: Iae5a21d915fa8e934a1f47f8ba9f6df03b79a9fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110839 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>