summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2016-11-03loplugin:unnecessaryvirtualNoel Grandin2-14/+0
Change-Id: I572b83949c7e643536b7d62567760546509e4d9f Reviewed-on: https://gerrit.libreoffice.org/30514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#100352 Classification: Update French translationLaurent Balland-Poirier1-1/+1
Change-Id: Ie5efebfe4df73adca51638c85ba52e7901eac139 Reviewed-on: https://gerrit.libreoffice.org/30182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-03remove pParentFrame from SfxFrameNoel Grandin8-148/+21
Found by the singlevalfields loplugin. Dead as least as far back as commit 93a7b558588be1f12e137329548b706daccc07df Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Fri Nov 27 21:16:24 2009 +0100 [CWS autorecovery] merged SfxTopFrame into SfxFrame SfxTopFrame was the only class deriving from the abstract class SfxFrame, so both can effectively be treated as one class. Arguably when that commit was done, SfxFrame should also have been renamed to SfxTopFrame, since that it was it now seems to be. Expanding the nullptr value off that field means that: SfxFrame::GetTopFrame always return this SfxFrame::IsParent always returns false SfxViewFrame::GetTopFrame is now the same as SfxViewFrame::GetFrame SfxViewFrame::GetParentViewFrame now returns null Change-Id: Iac088fa485c3d7299d1553845ced2f5ced3c85f2 Reviewed-on: https://gerrit.libreoffice.org/30485 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02loplugin:singlevalfieldsNoel Grandin1-2/+0
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76 Reviewed-on: https://gerrit.libreoffice.org/30476 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02remove spurious "oh"Stephan Bergmann1-1/+1
Change-Id: Ia214ef9c683492226ab39c1fd1061ecc9cbc264c
2016-11-02It's ODF version, not document versionTor Lillqvist1-2/+4
Change-Id: I3e6a54dd92ebafebabf9e75b44b9f0b5f0b6aa8a
2016-11-02Add a comment wondering about "ODF Version", further explanations welcomeTor Lillqvist1-0/+8
Change-Id: Idc660ba71ccff02c97a018838974430c0206ace6
2016-11-01tdf#103624 Avoid double init of controls in SidebarToolBoxMaxim Monastirsky1-2/+4
Controls that created by the service manager are already initialized by it. At least in the case of SaveToolbarController such double init creates a problem, as SaveToolbarController will add itself as a modify listener twice, but remove only once in dispose method. Probably SaveToolbarController should be smarter about this, for both not adding a listener twice, and also not attempt to work after being disposed - but that doesn't make the behavior of SidebarToolBox correct. Change-Id: I3f0fcdff31c65198a2233c969d37a0015712fff5
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke3-3/+3
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01tdf#103481 fixed SIGABRT in embedded presentationSzymon Kłos1-1/+1
Change-Id: I51402aec953d58f92d8fe768bca0d2c2d1ce4474 Reviewed-on: https://gerrit.libreoffice.org/30368 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01loplugin:oncevar in sd..svgioNoel Grandin13-61/+26
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c Reviewed-on: https://gerrit.libreoffice.org/30459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31sfx2: Metadata has no need for cryptographic randomnessMichael Stahl1-6/+4
Change-Id: I911c15c0ea7a3cae0269c67d8bd6fd79e9b6d8c6
2016-10-30tdf#95014 initial support for 32 px icons in toolbarTomaž Vajngerl1-3/+10
This adds support for 32 pixel icons - mainly to get them into the toolbar. Most changes made are to change the behavior of having only small and large icons as a boolean choice, but not every code path was converted to non-boolean choice yet. Breeze icon theme has the 32px variants so it can be used already. Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87 Reviewed-on: https://gerrit.libreoffice.org/30398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-30Let Menu dispose submenusMaxim Monastirsky1-1/+1
(I'm not sure about how good are the changes from ScopedVclPtr to non-scoped, and disposeAndClear to clear. They aren't really needed, because of the VclReferenceBase::mbDisposed logic. But at least they should be safe, as long as we have disposeOnce calls in Menu's dtor.) See also previous commits: 4433d95b374c13a3501cdf3a6e273f68eb49873a ("MenuItemData now properly disposes the submenu") 89c23b4aaef931b5d6009efaf44ce6e6c976e8d4 ("Sub menus no longer need manual disposing") Change-Id: I9d455a94590f5eec9b097947f6984f1b3e477b52
2016-10-29convert usages of DPIScalingFactor from int to floatTomaž Vajngerl1-9/+9
Change-Id: I049b3d2cde4dcb8c8c0690d75a015a43cb71b0c0 Reviewed-on: https://gerrit.libreoffice.org/30381 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29HiDPI: remove unneeded image scaling when HiDPI is enabledTomaž Vajngerl1-13/+0
We don't need to scale images for HiDPI mode anymore - this is now done automatically when the image is loaded. Change-Id: Ie285cf4d672f4c098a468d3f7560ee2700365b92 Reviewed-on: https://gerrit.libreoffice.org/30340 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-28only draw menubutton separator when two sides do something differentCaolán McNamara1-0/+2
Change-Id: If6e3b72eacef2325f9f30770bbed32c627bc035c
2016-10-28rename and explain the MENUBUTTON_MENUMODE_TIMED stuffCaolán McNamara1-2/+2
Change-Id: Ifc6ddfb0cc249e537c01f28bab84b42c6b1577d9
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara2-4/+4
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28convert std::unique_ptr<VclAbstractDialog> to VclPtrNoel Grandin2-6/+7
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-27loplugin:expandablemethods in sfx2Noel Grandin19-173/+75
Change-Id: I5dcc9e6e7fef210f85a01057ddf59f8de14b847d Reviewed-on: https://gerrit.libreoffice.org/30320 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27make the AbstractDialog stuff extend from VclReferenceBaseNoel Grandin2-4/+5
Because some stuff wants to multiple-inherit from VclAbstractDialog and OutputDevice-subclasses, and we'd prefer to keep all the lifetime management through a single smart pointer class (VclPtr) The change in msgbox.cxx and window.cxx is to workaround a bug in VS2013 to do with virtual inheritance and delegating constructors. Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773 Reviewed-on: https://gerrit.libreoffice.org/29140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26normalize existing emacs/vim mode-lines in python filesMichael Stahl2-4/+4
Bunch of these were setting C++ or Make modes and icky tabs... Also, reportedly Emacs can figure out to enable python-mode automatically. Change-Id: I50072488fb92cb4d27aa3f74f717a28ae3967543
2016-10-26assemble SfxStyleFamilies from more generic resource componentsCaolán McNamara5-191/+45
Change-Id: I25aa0d8bca1f16f5fc27d3b299709479a1635ea3
2016-10-25split the creation of SfxStyleFamilies into a methodCaolán McNamara3-11/+18
Change-Id: I2590180fc30d75c89e758c72246a8294b5c4b9a2
2016-10-25m_pStyleFamiliesId is now unusedCaolán McNamara2-6/+0
Change-Id: Ibfd9810e8cfde596aee3189a3498d628d73fdc8b
2016-10-25we don't need to update the style icons anymoreCaolán McNamara2-36/+3
once this was a dialog but now its a panel and the case of a the document under the dialog changing type isn't an issue anymore Change-Id: I4680cf238675161c533852d843508a19c74a9073
2016-10-25separate two different uses of DLG_STYLE_DESIGNERCaolán McNamara3-3/+3
Change-Id: I1edbbb4e2f1326b189a80815b1c80bd0f9b52258
2016-10-25drop HID_CTRL_CUSTOMPROPS_YES_NO that does nowhereCaolán McNamara3-19/+5
Change-Id: Ibf64359936ea224dc7342585b99691f88630c6ca
2016-10-25drop HID_CTRL_CUSTOMPROPS_YES_NO that does nowhereCaolán McNamara2-3/+0
Change-Id: I1a82e91539947939667e0c458f964e7e13c50514
2016-10-24tdf#75280 Clean up usage of sal_uIntPtr.Hieronymous1-8/+8
doctempl.hxx doesn't contain any sal_uIntPtr instances. GetCount and GetRegionCount functions return sal_uInt16 hence sal_uIntPtr instances have been converted to sal_uInt16. Change-Id: Ifb48bf861c8ab5f262a535a7d34794eafd75fd6d Reviewed-on: https://gerrit.libreoffice.org/29904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-24loplugin:countusersofdefaultparams in sd..slideshowNoel Grandin2-2/+2
Change-Id: Iaf10935d8f231676333018a5954d97defe35acf6
2016-10-23fix short type for .uno: and slot: URLsJochen Nitschke1-1/+1
introduced in initial commit: 00885a1af84ae2f6697000702b439ca789f79627 INTEGRATION: CWS layoutmanager (1.27.18); FILE MERGED Change-Id: I7d59316dcaaca2986927bcaebe8029cf82e9eceb Reviewed-on: https://gerrit.libreoffice.org/30178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21loplugin:expandablemethodds in include/sfx2Noel Grandin8-48/+12
Change-Id: I1ec3ae33a71d154276e213a68c735476daa606b9
2016-10-20xmlsecurity: add initial PDF sign UIMiklos Vajna1-1/+1
An unsigned PDF can be signed now, but the stream still gets truncated on closing the dialog. Change-Id: I12dd50bf577cd23b3355f6c6d03e71a9c0dbcfab
2016-10-20loplugin:expandablemethodds in sfx2..starmathNoel Grandin1-3/+1
Change-Id: Ia4c411f5a9a68c2f344188ce6b6bc1815c89f993 Reviewed-on: https://gerrit.libreoffice.org/30055 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19tdf#103274 (10): Add default XCommandEnvironment referenceGiuseppe Castagno1-1/+3
Change-Id: Ic91553a513656b412bccd73a483ca7d7f131b657 Reviewed-on: https://gerrit.libreoffice.org/30047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-19Revert "CppunitTest_desktop_lib: add ModifiedStatus callback testcase"Miklos Vajna1-3/+1
This reverts commit cdf08b3aa74bb32ea18b583a9c0c41b91d7819ac. It breaks 'make -sr CppunitTest_desktop_lib CPPUNIT_TEST_NAME="DesktopLOKTest::testPaintPartTile DesktopLOKTest::testWriterCommentInsertCursor" VALGRIND=memcheck' (it is terminated by SIGSEGV), and also it's the reason why sometimes the lo_ubsan buildbot fails, see e.g. <http://ci.libreoffice.org/job/lo_ubsan/329/console>. This has to be re-introduced once I find a way to process all binding updates at once without side-effects. Conflicts: desktop/qa/desktop_lib/test_desktop_lib.cxx sfx2/source/control/bindings.cxx Change-Id: Id6c49b9b31095ef1a1a8c1cd92cbae5deb316500
2016-10-19tdf#96015 (part) link to Doc'tation in Help menuOlivier Hallot3-20/+30
Add the entry "Documentation" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/documentation/?&LOlang=<locale> <locale> is obtained from .getLocale() Patch2: create a member with try/catch for external URLs Patch3 Use sfx2::openUriExternally Revert to User Guides.. in UI. Change-Id: I8332253c31bd3be330cdd794f9e056b632b38037 Patch4: remove 1st '&' in URLs Reviewed-on: https://gerrit.libreoffice.org/28817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-18tdf#103274 (8): Add default XCommandEnvironment referenceGiuseppe Castagno1-1/+1
Change-Id: I583ed0714c0bf543c44c098613e1aab9d3b31452 Reviewed-on: https://gerrit.libreoffice.org/30007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-18tdf#103274 (7): Add default XCommandEnvironment referenceGiuseppe Castagno1-1/+1
Change-Id: I734f673c54956daf7070bf3e8faeac5102bac01f Reviewed-on: https://gerrit.libreoffice.org/29992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-18tdf#103274 (6): Add default XCommandEnvironment referenceGiuseppe Castagno1-1/+1
Change-Id: I71d83f1094800c3156f9159b6628e4d53d723b95 Reviewed-on: https://gerrit.libreoffice.org/29991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-18tdf#89307: Removed T* SvRef::opeartor &()Jacek Fraczek2-3/+3
Usage has been replaced with SvRef::get() or removed where applicable. Change-Id: I49f108910b668466134c40940b53fc3ab2acd816 Reviewed-on: https://gerrit.libreoffice.org/29780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18Lock SolarMutex in SfxAppDispatchProvider::queryDispatchStephan Bergmann1-0/+2
...which can be called remotely via UNO, as happens during JunitTest_sfx2_unoapi Change-Id: I9dbf83f9985124ccb84f33cdd30ec1225a4f183d
2016-10-18Resolves: tdf#101590 cannot interact with filepicker from import categoryCaolán McNamara1-4/+6
the post-execute category dialog is picked as the toplevel parent, and gtk3 vclplug will grab events to that hierarchy, but can't interact with them in this state. Just dispose the category dialog so its not a candidate for the file dialog parent. Change-Id: I063fc6d687d556db229e2e200bb280a6cd3425f5
2016-10-18tdf#102239 START CENTER: Cant activate template categories from split buttonAkshay Deep1-1/+9
Change-Id: I6a426c3449dac1d36aa63c22108ac6105fafea12 Reviewed-on: https://gerrit.libreoffice.org/29294 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-18tdf#103274 (5): Add default XCommandEnvironment referenceGiuseppe Castagno1-1/+1
Change-Id: I77e89d1250499687c6fadc4408c1bed409f8b167 Reviewed-on: https://gerrit.libreoffice.org/29982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-18tdf#103274 (4): Add default XCommandEnvironment referenceGiuseppe Castagno1-1/+1
Change-Id: I67ab0f37df9e8d239374d9a759f7c082b824c722 Reviewed-on: https://gerrit.libreoffice.org/29981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-18loplugin:unusedmethodsNoel Grandin1-16/+0
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-17let LanguageTag::convertToLocale() decide when to create a temporaryEike Rathke2-2/+2
Change-Id: Id4e718eb23d4acf2ee7bddc4da1cd4e8e811be78
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 16:05:16 +0000