path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2014-01-30fdo#63154 Removed unused solar.h ref. in linguc., sfx2, starmath, svl and svxAlexandre Vicenzi2-59/+1
Change-Id: I241661119371b75804fcf9215ff5e5da2a5b9265 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-01-30Introduce singleton.Matúš Kukan3-5/+5
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-30Introduce singleton.Matúš Kukan2-3/+3
Change-Id: If979db945b2f5e50e146fdadafd1559530c50122
2014-01-29Introduce singleton.Matúš Kukan4-8/+8
To replace single-instance service. Change-Id: I4262909c4396e3907d271a56696a06903168a58d
2014-01-29Introduce singletons:Matúš Kukan2-3/+3 To replace their single-instance service variants. Change-Id: I00586d0d61e63f9482cb659071e88aa9cf02d5b5
2014-01-29bool improvementsStephan Bergmann2-2/+2
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-29Fix the error of shutdownicon.cxx.yangzhang1-21/+21
Change-Id: I91d62edd72e884a0139d3aca46aff0db88b202be Signed-off-by: shaochunfang <>
2014-01-28coverity#1019411 : Uninitialized scalar fieldNorbert Thiebaud1-1/+5
Change-Id: If7cc1cd9be357c9b9bb82bfffe3f560ac29e61d9
2014-01-28bool improvementsStephan Bergmann54-345/+345
Change-Id: I4a09bffccc0049d81ea3113e79184f64b026a4ba
2014-01-28Fix apparently broken OSL_ASSERTs (that would have never fired)Stephan Bergmann1-5/+5
Change-Id: I10c5152ca09be49625f960e6dc3228ec2284ce58
2014-01-28Introduce singleton.Matúš Kukan5-9/+9
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28coverity#440971 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: I2bd6c0cffef5bf2e2d05781d4ec151f11d517cb6
2014-01-28coverity#440811 Dereference null return valueCaolán McNamara1-1/+4
Change-Id: Iccf2f6dd757fe8d14a2f68a0492ea898d2f95490
2014-01-28coverity#440882 Logically dead codeCaolán McNamara1-1/+1
Change-Id: Ia54cffe6368d320c717b941b4f3df036f924c343
2014-01-25coverity#440744 Dereference after null checkCaolán McNamara1-1/+2
Change-Id: Id9ab2ffde8eb82e49164350d1703e4d93f96663e
2014-01-25Related fdo#65826: Set StartCenter's min width to display one column of docsZolnai Tamás3-8/+40
If there is document to display. Otherwise set minimum to the width of greating background text. Updating minimum size is needed only when the list is cleared. Change-Id: Ic089571fd21d5ab9ded0f4cde7e1aa72fd508d32
2014-01-24Introduce singleton.Matúš Kukan3-4/+3
To replace single-instance service, incorrectly converted in 748aa84e9808ad31c6ff6b71459525c82de10e58 [including changes by Stephan Bergmann <>] Change-Id: I4cea2c63a20b5b22f6e1f822fb35fcc4d0397687 Reviewed-on: Reviewed-by: Stephan Bergmann <> Tested-by: Stephan Bergmann <>
2014-01-23coverity#440721 Dereference after null checkCaolán McNamara1-2/+3
Change-Id: I1a6d6f5d83f3b6c5f8d8d19b003f2e4f6976d6e9
2014-01-23SfxNoLayoutSingleTabDialog not needed anymoreCaolán McNamara1-132/+8
all single tab dialogs are .ui enabled now. So now we can remove SfxNoLayoutSingleTabDialog and merge SfxSingleTabDialog and ~SfxNoLayoutSingleTabDialogBase together Change-Id: If0acc792d85b7d399572257d7e9b0e12993ba3fe
2014-01-23Bin useless as96863, mb93783, mv76033 verbiage from SAL_INFO outputTor Lillqvist6-19/+19
Change-Id: I58b6c311e9f13e433468863e639467428e5b268e
2014-01-23Use the "sfx" log area consistently in sfx2Tor Lillqvist4-11/+11
Change-Id: I497d2d93e1a1819ff709c94007ae98f5ef312e77
2014-01-23Use assert() and SAL_WARN() instead of DBG_ASSERT() and OSL_FAIL()Tor Lillqvist1-45/+41
Change-Id: Id3be30bc95325e8f18cf8cb55da2217984a26035
2014-01-22convert more SvStream::operator<< callsNoel Grandin4-19/+19
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: Reviewed-by: Michael Stahl <> Tested-by: Michael Stahl <>
2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky14-80/+38
This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann2-21/+21
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22bool improvementsStephan Bergmann1-2/+2
Change-Id: Iab6343064ad002bd11660aeb8c88c54562109cbc
2014-01-22bool improvementsStephan Bergmann8-21/+18
Change-Id: I5f90d0acff506955d1cc5a44944311012f3b04b9
2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky14-32/+74
Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-21fdo#65826 and fdo#73605: set a minimum size to start centerZolnai Tamás3-1/+25
This minimum size calculated like this: width: sidebar optimal width + width of text appearing in the thumbnail view when no recent document is available. height: menu width + optimal width of GtkBox containing buttons. Change-Id: Ic1fd6e33a1ec93e61318af02c09ee88909a76cf4 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-01-21fdo#72639: send proper ACTIVE_DESCENDANT_CHANGED eventsJacobo Aragunde Pérez3-3/+52
At ThumbnailView::SelectItem the piece of code in charge of the accessible events related to selection change was mistakenly using the accessibility helper class ThumbnailViewAcc instead of ThumbnailViewItemAcc which is the proper one for managing the events related to ThumbnailViewItem objects. The methods FireAccessibleEvent and static getImplementation had to be added to ThumbnailViewItemAcc to provide the full functionality required. Change-Id: Ia5ffb24c920f3c48854021700819be683c979411 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann6-21/+21
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky14-50/+20
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-18Unify ctor functions for component implementations.Matúš Kukan2-7/+4
There is no need to use different styles for writing the same thing. It also makes it easier in future to use search & replace. But of course, there are also some more complicated functions. Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
2014-01-18Window::PreNotify should return boolStephan Bergmann4-30/+30
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17bool improvementsStephan Bergmann7-8/+8
Change-Id: I9f5564100aa64ff4940dd93a81ff5a8d8edc7a07
2014-01-17Be explicit when using bool as integral value (as Link return value)Stephan Bergmann1-1/+1
Change-Id: I3b345be909ed2cb93cd0d478af4b26c9909d2726
2014-01-17Window::Notify should return boolStephan Bergmann17-65/+63
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17Remove unused includes and sfx component prefix.Matúš Kukan2-31/+1
Change-Id: Ia6c1db331b5b4db04c46b75b2058bf2f1369070b
2014-01-17Resolves: #i123042# corrected reload of linked content...Armin Le Grand1-1/+3
to have access to its own path (cherry picked from commit bc89d402b3df00c2402ac86896eb2ce4c3f7b7d0) Conflicts: sfx2/source/appl/fileobj.cxx svgio/source/svgreader/svgimagenode.cxx svx/source/svdraw/svdograf.cxx Change-Id: I4f3e98588f17b4271465359a7f56f9845029e012
2014-01-17Constructor functions for singletons still need to pass out single instancesStephan Bergmann1-2/+18 they are not only called from the service manager (which takes care of singleton constructor functions since 997d21183322a0a94b96868073808841d2773902 "Support for singleton constructor functions") but potentially also directly from cppumaker-generated code (which is the raison d'être for constructor functions, after all). However, this change: * postpones the instance's destruction to atexit, with all dreaded consequences; lets see how that pans out. * makes it questionable whether the service manager holding references of these singletons (introduced in 997d21183322a0a94b96868073808841d2773902) is necessary after all; lets revisit that in another commit. Change-Id: I0a2c902ab62045df1af382d190747e34b80236d3
2014-01-16Revert "Revert "sfx: Use constructor feature for SfxGlobalEvents_Impl.""Stephan Bergmann6-532/+549
This reverts commit ef37781683e28d1837cfce86de990e59d2c10c5f, now that constructor function support for singleton implementations is in place and the proper singleton theGlobalEventBroadcaster has been introduced (and drops sfx_component_getFactory completely, which had become unused except for SfxGlobalEvents_Impl in the meantime). Change-Id: I2d587989dd0a1fbea6fe75f7dc2af954ac81c4ed
2014-01-16Introduce singletonStephan Bergmann4-6/+7 supersede single-instance service. Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin4-5/+5
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16Related: fdo#71764 allow extensions button to group with helpCaolán McNamara1-0/+20
even though they are in different containers Change-Id: I785166c577acab03608da10fb4a33072458a82cd
2014-01-16sfx: TEST_HANDLERS not definedMatúš Kukan1-75/+0
Change-Id: If02c029114e9531951b18abeb9d0afd0a18ceca3
2014-01-16sfx: Use constructor feature for BackingComp.Matúš Kukan4-293/+114
Change-Id: Ia461b8315ddd07adcb5609aefa85385db17ebba4
2014-01-16sfx: Constructor feature for two more implementations.Matúš Kukan4-122/+28
Change-Id: Icd387ff97c5df3cea9b20b0b893616812457e493
2014-01-16sfx: Use constructor feature for ShutdownIcon.Matúš Kukan4-18/+42
Change-Id: I3af683cdc273fa8cb9224a0f1f7d342a140c9dd7
2014-01-15Revert "sfx: Use constructor feature for SfxGlobalEvents_Impl."Matúš Kukan6-549/+489
This reverts commit 9b73d3a4cd9c1aea29b51b1b23d0a44c34f2f8a2 because it breaks unit tests. Conflicts: sfx2/source/appl/appuno.cxx Change-Id: I7b2d2dc6ff8ade2c8dd29602827313c7bb01f97d
2014-01-15DdeSetData should apparently return boolStephan Bergmann1-7/+7
Change-Id: Ie0e66ac6c76eabb80340d4c11b60dd7890c6a378