summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2021-08-13Resolves: tdf#143843 disable the recently-used widget during loadCaolán McNamara2-0/+2
We show a busy-cursor but the widget can still be interacted with so another document can be launched by clicking on another recently-used item while the first one is still loading, and the recently-used widget isn't prepared for this scenario so the second to complete load will crash. Disable the recently-used widget when its cursor is set to busy, and in the (unlikely) case that the load doesn't complete normally (missing document or load filter error) and the recently-used widget still exists and its cursor is unset from busy then reenable it for user input at that point. Change-Id: I8f4487f3dbede14c9778e49442366bd9445f1d63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120363 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-09tdf#143146 copy functor and arg before calling function that can delete thisCaolán McNamara1-2/+6
Change-Id: I4e29fe6fa4119b709e31156afc5c2a5d08cdc072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118625 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-07-02tdf#143149 fix crash if app exits while print progress is runningCaolán McNamara1-0/+1
dismiss the dialog if its parent goes away, but leave the print job running Change-Id: Ic29ee0300a7d9476ad27a2594a555312e30c74f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118254 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-07-02fix potential write-after-free in RecentDocsViewNoel Grandin2-3/+9
spotted while running a valgrind session Change-Id: I32c55ae2cc4b2d5abedca24c2f747aaa4183b3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2176084192dc46a1ef5d6dd79effa5cd5d1dcca2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118256
2021-07-01sfx2: try to fix lifecycle of SfxOfficeDispatchMichael Stahl2-1/+27
This can be created either from the global SfxApplication, or from a SfxViewFrame. Particularly in the latter case, the SfxDispatcher and SfxBindings members are owned by SfxViewFrame, so in case that is destroyed, the SfxOfficeDispatch must clear its pointers. It looks like the member pointers are checked before access already everywhere, so just listen at the SfxViewFrame. Change-Id: If08825734e94dd54e32cb77546684fd583c336ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118162 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 7cbd6d768d282077053c354254315f3dc89bf254) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118195 Tested-by: Jenkins
2021-06-22Resolves tdf#140360 - Provide option to turn off sidebar's minimum widthHeiko Tietze1-2/+3
Boolean option Sidebar:General:MinimumWidth introduced defaulting to true; if false the sidebar width is under full user control Change-Id: Iab1413a83adf90461feb5d6416aad174439392ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116715 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit f43fdcad400b6ff51f0810d923fe75d5a2cfde0c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117414 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-15Resolves tdf#142513 fix zoom caller handlingJim Raykowski1-2/+2
Calling ZoomPlus has always executed shell SID_ZOOM_OUT case handling. ZoomMinus, which replaced ZoomIn, does SID_ZOOM_IN case handling. This patch changes ZoomPlus to do SID_ZOOM_IN case handling and ZoomMinus to do SID_ZOOM_OUT case handling and makes appropriate changes required by these name changes to provide expected zoom results in all module shells that have handling for these calls. Change-Id: If148f4f7866bfc8fc6452ad1c1dace723a125ef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116287 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit ec629c5ee22d02f99d66a5cf975ce239876b7f4d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116702 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-27add missing xmlns:loext to example_sl-SI.xmlCaolán McNamara1-1/+1
added to example.xml by commit 71ee09947d5a71105d64fd225bb3672dfa7ce834 Date: Tue Sep 19 15:37:04 2017 +0200 TSCP: add advanced classification dialog but not to example_sl-SI.xml Change-Id: I8aa46554867db8c51bd118b6cc87e649b922cdfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116157 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-05-18tdf#138209 ODF export: work around forms problem in LO < 7.0Michael Stahl1-2/+11
LO without commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6 makes a mess when storing form documents it has loaded from ODF 1.3 documents: the XML parts are stored as ODF 1.2, but the storage (and therefore manifest entry) keeps version 1.3. To avoid this, store form documents as ODF 1.2 extended by default. Unfortunately a bunch of ODF export code accesses the global SvtSaveOptions variable; with this version override, only SvXMLExport::getSaneDefaultVersion() must be used. Change-Id: I5fa8e286f5103c578ed0d93da07a8a6cbe2f0ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115357 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 16de54a5c47fbc4691ee099c1f7bb559a8fe11ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115390 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-05-12fix some VirtualDevice leaksNoel Grandin1-1/+1
Change-Id: I645543fa27ca8b75b36ed7798f0af7b81fd09f49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115488 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-04tdf#142017 set default focus widgetCaolán McNamara1-0/+1
Change-Id: I5befe345d9c6ec499efdc1cf8305513ee8a53690 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114931 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-05-04Resolves: tdf#141857 update background to current themeCaolán McNamara1-1/+7
Change-Id: I1004bd9944f382ca66e48575b81170cf3314845f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115073 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-29tdf#135997: make sure that the two lists are same lengthMike Kaganski1-0/+13
This fixes the strange assumption that when searching the two lists (character names and font names) independently, the two found positions will necessarily correspond to each other. Instead, the positions of the match must be the same, which is implemented now. Also the input from configuration is sanitized. Change-Id: I920de7414387e181e11183b8a22776a72b6be419 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114722 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit b6ab5914d8b2fc7041430796890f086f8e3e6369) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114852 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-29tdf#135997: fix toolbar controlMike Kaganski1-2/+2
This is the same as fc7b4bfeba39a2479c9a2c9c8ef5ced5ab3c0de7, just for the toolbar control (the older one was for special character dialog). The problem was present since 800ac37021e3f8859a52c5eebca261a5d3bc5a11. Change-Id: Ib86aa7336a3078ff28b417de37fbd5bc492c85c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114719 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit b27de500b1412bacefc7144b5222c307ca1ae0fe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114731 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-27tdf#141902 Fix domain in ui files (found with ui-checkdomain.sh)Julien Nabet2-2/+2
Backport to 7-1 to fix a user visible problem Change-Id: I6ec07748616c6ddbe12a48077a777c91ffb8f96f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108046 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114682 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-20Resolves: tdf#141770 remove empty tagCaolán McNamara1-5/+0
Change-Id: I0e6c1b36c145c0eb464867e7a30a6d693598409b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114280 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-20Avoid unused parameter warning in the HAVE_FEATURE_MACOSX_SANDBOX caseTor Lillqvist1-0/+1
Change-Id: I7cc2f8f373440ca79694220818558ee092c895a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114320 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins
2021-04-20tdf#141244 Modify DDE Link dialog was emptyAron Budea1-20/+20
Regression from de01c0c1d0f80ffec3882625d77c02ab806f6c7a. Apparently <property> entries must precede <child> ones in .ui files. Change-Id: Ie91897d126527d3b30935a46b31f0a53b2837c53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114312 Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-06make Analog Clock sidebar extension demo workCaolán McNamara1-1/+10
from... https://wiki.openoffice.org/wiki/Sidebar_for_Developers#Example:_Analog_Clock_Extension http://people.apache.org/~af/clock/AnalogClock.oxt presumably compatibility was broken at: commit e66be44b69ee2a1b99bda32af93ea453c669b319 Date: Sun Jun 2 04:46:58 2013 +0200 sidebar: Restrict the minimal width of the sidebar. Change-Id: Id1531d4531a3e9bceb3d37a9e74a7a06497098e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111868 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113525 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-22tdf#140539 don't allow help to be relaunched during launchCaolán McNamara1-4/+15
its fine once it is launched to fire help again, just not during the launch itself via the yield-call done during html load that probably exists to let the progress bar redraw Change-Id: I42e0bf670023d91f70cb1de3fa0fda23e82d0678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112804 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-17tdf#141011: Postpone SwFieldDBPage::Reset to tab activationMike Kaganski1-1/+6
This way, it will only ask for password when dialog is switched to that tab. Change-Id: Ie2a453b0b6867ceb1ef3728a8565de4f6cbf4757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112469 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 0adf52a644aaf85ba2bd666147c62c134234ffbb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112516 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09master slide panel shouldn't have "more options" buttonCaolán McNamara4-8/+8
default the toolbox to hidden and show it if "more options" is enabled Change-Id: I6ff867268809d949e7854e0e76d3e45c8806797b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111955 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-23tdf#139039 sfx2 store: fix export to PDF when dir name is URL-encodedMiklos Vajna3-10/+39
Regression from commit 5259ab8104cfba60c40748ed0cd59d93df038c5b (sfx2 store: create temp files next to local files, 2018-01-08), the problem was that the directory hosting the input ODT file was called "Bugzilla%C3%BF" (URL-encoded from "ÿ"), we got this as "Bugzilla%25C3%25BF" (encoded from directory name), but we forgot to decode it before passing this URL to the utl::TempFile ctor as a parent directory, which resulted in failing to save as PDF, and crashing on DOCX export. Note that in practice this only caused a problem on Windows. (cherry picked from commit aaf7fe0326b3be088a5440525363317fb3d0f158) Change-Id: I5fc8a356b63efc2f16405a14ee59a061b52c5205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111372 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-17tdf#140387 grab focus to first panel widget on panel gaining focusCaolán McNamara2-0/+10
otherwise focus is getting lost in these currently mixed vcl+gtk widget panels. Change-Id: I6488ddfc98afdedb55bb3217f3877e96258dd65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110956 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-15tdf#140308 Crash import old OpenOffice templateNoel Grandin1-5/+12
regression from commit cfe5a5044845a3fc90e3634e996edb4d85808d3c sfx2: use the fastparser API when possible We end up using the OOo2OasisTransformer filter, which is not fastparser compatible Bisected with: bibisect-linux64-7.1 Change-Id: I7bd4191f098096034dc8ff368aba4b1ff313ce18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110883 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 228f43f2e3c2896c227f1ea30c5d16231acf66da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110866
2021-02-11tdf#140280 sfx2: fix crash on double-clicking a no-sign shape in read-only modeMiklos Vajna4-0/+132
Don't assume that all shapes provide an InteropGrabBag UNO property, check for it. (cherry picked from commit c76e6307b6cf33bda0cfa12647ed0342aecc1b29) Change-Id: I6347c54b0631c37154424babbfbd52f802af57d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-30Improve macro checksSamuel Mehrbrodt2-6/+22
Change-Id: Ie40801df8866b52c1458e020ffa9cba120720af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109552 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 1dc71daf7fa7204a98c75dac680af664ab9c8edb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110056 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-30tdf#139981: remove unsupported unused 'stock' propertyCaolán McNamara1-1/+0
which doesn't exist in GtkDrawingArea Reason: LibreOffice doesn't startup with GTK3 Change-Id: Ifbd3eb7c49df308f2e9d395a583072584183a500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-29tdf#123476 filter: Also handle empty ODFMike Kaganski1-2/+4
This builds on top of commit ada07f303e7cd1e39c73abe0741aefe7d9d73a57, to allow 0-byte ODT, ODS etc. Possible TODO would be somehow use default template for such empty files, getting the template name using SfxObjectFactory::GetStandardTemplate. That would enable using 0-byte ODF files as means to "create new document at this location from default template" workflow. Change-Id: I36e07b80f60c42aecdcc6a7357e5bdd18f62e4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109989 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 2854362f429e476d4a1ab4759c6a1f1c04150280) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110060 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-28Make brand image clickableHeiko Tietze3-19/+90
and link to LibreOffice volunteer page Change-Id: Ie422983d0e23faa16c2e2364b25798b938712a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109637 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 35713de9d0b4981a019edd25591285d0bc6107db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109972 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-27tdf#138727 help browser didn't flow textCaolán McNamara2-4/+2
because of its size request, while the paned shrink lets the pane shrink below the size request the contents stay at a min of the size request and aren't really shrunk, just clipped. Instead don't let the pane shrink but don't set a size.request letting it shrink to its natural min of its contents which are then truly resized so the text flow works. Change-Id: Iaf6738ace28c82379ac6322310de9a22f9653473 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109983 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-22tdf#135590 MapUnit::Map100thMM fallback is inappropiate for writerCaolán McNamara1-18/+11
which uses MapUnit::Twip so directly after insert, envelope, ok the new document sidebar was using MapUnit::Map100thMM to lookup paper sizes instead of MapUnit::Twip giving inconsistent results against format, page Change-Id: I6a92fddedfe9fef8ad7532ad00b2b38b9741bb69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109751 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-01-20silence "gsignal.c:2731: instance X has no handler with id Y" warningCaolán McNamara1-0/+1
Change-Id: Iafc0aa085338fb41758fa845252f584c2a8aea76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109584 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara19-0/+38
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109311 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-14Resolves tdf#139343 and tdf#139335 - Community/Enterprise flavorHeiko Tietze3-369/+393
* Switch CE/EE per --disable-community-flavor internally use HAVE_FEATURE_COMMUNITY_FLAVOR * Version info in about dialog shows text depending on this flavor * Start center also shows the brand image now * TDF builds use a brand image with TDF tagline in the about dialog * Brand images with just "Community" (no Edition) Change-Id: I363dd2b39df9aad951c9d79addf9bdedfc4a3495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108980 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 2d69acfde50cb0e06a9a057939078fd102d371a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109274 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-10Bump copyright year to 2021Adolfo Jayme Barrientos1-1/+1
Change-Id: I3159bfc21a35fc80aef57c7d809d8ea8c62a732e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108566 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 1f1f68d6e8a32d8884e8de322e32c588a87964db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108581 Tested-by: Jenkins Reviewed-by: Martin Srebotnjak <miles@filmsi.net>
2021-01-08Missing construction of SfxCmisVersionsDialog::m_xVersionBoxStephan Bergmann1-0/+1
...ever since b1baf73dc671069bedec18d170f8199b0766ea60 "weld SfxCmisVersionsDialog". (Found by GCC 11 trunk with --enable-optimized, > sfx2/source/dialog/versdlg.cxx: In constructor ‘SfxCmisVersionsDialog::SfxCmisVersionsDialog(weld::Window*, SfxViewFrame*)’: > sfx2/source/dialog/versdlg.cxx:435:36: error: ‘this’ pointer null [-Werror=nonnull] > 435 | m_xVersionBox->set_size_request(m_xVersionBox->get_approximate_digit_width() * 90, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 436 | m_xVersionBox->get_height_rows(15)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I2720d6bc49af717951a0af6a262fb013a27e09df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108886 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 29e36c699c610be4fe6f8a2fe21ae3e4c8bdbd38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108908 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23tdf#89709 Make statusbar page number/bookmarks control tooltip showJim Raykowski1-2/+2
Change-Id: I3a84ae29d4758799e1ee7e2ab1349ca3b30fb5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102883 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit c81fea2e78d66c1978cb2340868c938ba9d6c9f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107701 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-12-18Delete Category dialog includes '~' text in the titlebarCaolán McNamara1-1/+2
Change-Id: I8581e5219ffc690e686a0d563463c19b682ea04b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107910 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-16tdf#138938 put the tooltip on the toolbar item instead of the toolbarCaolán McNamara1-0/+1
Change-Id: I69ff3813a726f26daa20a00ce3a0bb311a162c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15tdf#138935 rsDeckId is invalid by the time collectUIInformation is calledCaolán McNamara1-2/+2
Change-Id: I4afc1ed1bbbfbbd510617a51b9aa6d627471d80d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-12tdf#138823 "Recent Files" --> "Recent Documents" in StartcenterSeth Chaiklin1-1/+1
Change-Id: I70121805e5b6ff4b6eed841e5f3a27302162f50b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107616 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit cb323d8616700eaf5052e4467396d6b56118b064) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107618
2020-12-11tdf#138762: crash when trying to open sidebar w chart in WriterAron Budea1-4/+7
In Writer when in chart edit mode, and the chart is deselected, the object selection remains. Opening Properties sidebar at this point crashed. Calc and Impress were unaffected. Regression from b5fdb148fe87a90f3e586efcea7aa6ef865fa42a Change-Id: I356c3a42c41dd38e4739df27c72c6d67722b1dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107500 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 7e5991dc695d1e590483615c2907811ce4117834) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107542
2020-12-09cid#1470371 Uninitialized scalar fieldCaolán McNamara1-0/+2
Change-Id: Ida60f251e83ea150e563bc0ef5a2be64f481fb08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-07Remove remaining bogus use of objc_msgSend()Tor Lillqvist1-15/+3
Follow-up to 5bf61e98b0746a4afeb68a80e54b4eb4bf4ea89f. Should avoid crashes when running as arm64 code on macOS on arm64. Change-Id: Id05d182684df82c8a7bf09f6bb7e8ccb01997b62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107259 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107324
2020-12-03tdf#107870 sw: don't jump to cursor setting Record ChangesLászló Németh1-1/+1
Using Edit->Track Changes->Record or Record Tracked Changes on Track Changes toolbar scrolled the pages back to the text cursor, breaking the review process of the document. Change-Id: I890e845ff94b636dd6edae19969d913e8d7a7b65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107005 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 1fd0919d92e792fa4af209a0fc7fde55c9958d1a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107103 Tested-by: Jenkins
2020-12-03uno:Printersetup: Allow preselecting a printerSamuel Mehrbrodt2-3/+3
When calling "uno:Printersetup" from a macro, allow preselecting a printer in the printer setup dialog by passing the printer name as an argument "PrinterName" Change-Id: I6b435f52a4123dc7fd49f6d771052ff1b8e743c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106634 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit ccb0b825305a158d9142e1a5316c6ff7905f6ecb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106678 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-12-03Add 'SinglePrintJobs' to PrintOptionsSamuel Mehrbrodt1-0/+9
So that this option can be set via UNO API Change-Id: I0b69162661a4327d59aaed82d5eff98cb50d852c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106593 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 2e2c162b7a816d990415fca434e6d3d5600b2858) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106677 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-12-01Resolves: tdf#138417 crash on customize sidebarCaolán McNamara1-0/+1
Change-Id: Icbb08b44e7f8729704d8278378a259fecb9bee4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-01cid#1470362 Uninitialized scalar fieldCaolán McNamara2-32/+0
Change-Id: I8828b7e098c1af9411b15b449f425242f5e64635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>