summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2014-07-13SfxModelessDialog ResId ctor bites the dustCaolán McNamara1-13/+1
Change-Id: Ia1bc255de0f38c058a3ab622d87af8b346a2075f
2014-07-11Convert DLG_TEMPLATE_INFORMATION to .uiPalenik Mihály6-63/+90
Change-Id: I66469c17a46c1157b8e3801c0dc2b252c569a4bd Reviewed-on: https://gerrit.libreoffice.org/10213 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-11new loplugin: externalandnotdefinedNoel Grandin7-20/+63
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-10make label translatableAndras Timar1-1/+1
Change-Id: I1e7703489ad9c41efbd22863fc9dbe86afee5e3e
2014-07-10MD_DDE_LINKEDIT conversion to .uiSzymon Kłos7-157/+220
Change-Id: Id058400bad5a8b100ef5a07060ea1c5013c6e6d6 Reviewed-on: https://gerrit.libreoffice.org/10146 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-10Related: #i125226# disallow absolute and relative paths for DDE serversHerbert Dürr1-2/+4
(cherry picked from commit 6b64ada6e3a902ac4b44fe49476514d49138d4d4) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I127add375a127dbbd0eaf12a10884e2636f1a332
2014-07-10Related: #i125226# some macro preferences are directly...Herbert Dürr1-4/+8
applicable to DDE servers (cherry picked from commit 2c835e761e1e9ddb6794895e6f3538b918160dd1) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: Ic16b3df34ac1b003a8a5cabab15ea655d05bdd18 Related: #i125226# typo fix (cherry picked from commit 727ea069c6342e01a50c8b068ec302574b251cbd) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I8db53b7e8529d05e660a2d69e669b44c9045712c
2014-07-10Related: #i125226# don't try to access known-bad DDE serversHerbert Dürr1-3/+8
(cherry picked from commit 88de6a59d9d7933b86fdcba733277aa4fbd5e132) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: If4dcd49cfe15188d06e4e06cd8e58cdcc66ed5a4
2014-07-10coverity#1224981 Dereference null return valueCaolán McNamara2-1/+3
Change-Id: I1623f7d61e849a59c8f23f2df18827df4a9c25c0
2014-07-10coverity#1132691 Dereference null return valueCaolán McNamara1-0/+5
Change-Id: I0da2f6956cf7675cce0d7d82a0ec797b50542c7f
2014-07-09provide a route to get the default document targetsCaolán McNamara1-9/+10
Change-Id: Ia163d2a69b33c18e18f81f0f82855d1caa4c2c1a
2014-07-08use SimpleReferenceObject in svtools moduleNoel Grandin1-0/+1
to replace hand-rolled version Change-Id: I7a1048ff1ea335c3934fe7e91a09489a4d7aeb96
2014-07-07Resolves fdo#80477: duplicate key for Help button in Start CenterAdolfo Jayme Barrientos1-2/+1
Change-Id: If46baf8613c6202e84a985ad7e2ce658e1d42193 Reviewed-on: https://gerrit.libreoffice.org/10102 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-07DBG_ASSERT->assert when followed by dereferenceCaolán McNamara1-1/+1
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-06coverity#706056 Unintended sign extensionCaolán McNamara1-3/+4
Change-Id: Iafb36f8135893186710ae3a939e50596a372d065
2014-07-06coverity#706055 Unintended sign extensionCaolán McNamara1-2/+3
Change-Id: Ie917cfd5f41a6f5e58a4c629a6a5b800e2e0b42f
2014-07-03error: reference cannot be bound to dereferenced null pointerStephan Bergmann2-10/+9
Change-Id: I4a5c83ba0f1e741104edc933459e7aea9c4aac1f
2014-07-03coverity#708816 Unused pointer valueCaolán McNamara1-7/+0
Change-Id: I2ea7d4a8b142d67afa43ce165b51d81f65d251de
2014-07-01salplug:literaltoboolconversionStephan Bergmann1-1/+1
Change-Id: I94b3bea97b6b4710bd4bf4c0fe88a1518a151de5
2014-07-01coverity#735850 Dereference after null checkCaolán McNamara1-2/+1
Change-Id: If164a92ed502502ce1b25ecddaa8852e83eb4f3c
2014-07-01Related: fdo#80633 cache optimal sizeCaolán McNamara1-2/+2
Change-Id: Ic2c3aefebd3061d294f339c6d262a3c3e381fbe4
2014-07-01clang scan-build: various warningsCaolán McNamara1-1/+1
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-06-30Make sure IMPL_STATIC_LINK's type matches Link::pFunc's typeStephan Bergmann1-1/+3
...to avoid -fsanitize=function warnings in Link::Call. Change-Id: I837b35bd3052716fbb41bf4f893961257d1f9b2c
2014-06-29Typo: beeing->beingJulien Nabet7-9/+9
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-27fdo#69036 do not try to create a sfxApplication when we are tearing-downNorbert Thiebaud1-15/+20
This was triggered by connectivity calc driver, which on shutdown was trying to 'dispose()' it's connection which in turn would, if the shutdown of calc was already done try to re-create an sfxApplication instance, just to delete illusory inexistant documents... Change-Id: Ic166367ca399d613743f379ebbfbffb5813701c0
2014-06-27remove SFX_APP() macro that was a mer wrapper for SfxGetApp()Norbert Thiebaud51-182/+182
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27Related: fdo#65634 make sidebar react to resizes when floatingCaolán McNamara1-29/+41
the parent isn't a SfxSplitWindow in this case, but it should still react to the resize Change-Id: Ia298d45b33fc272d6169df12cf2c58a881255163
2014-06-27Resolves: fdo#65634 improve wheel-scrolling sidebar panelsCaolán McNamara2-36/+3
Change-Id: I213d85a1e2bbd2377f6f0326433ddd57dc346721
2014-06-26loplugin:staticcallStephan Bergmann1-1/+1
Change-Id: Idea97df52106af64f6c5605460756d48296551e2
2014-06-26drop the functional partsCaolán McNamara1-4/+0
appears to work without it as far as I can see Change-Id: Ibe19addeeb38f853a515aef36d6bc83d338e1c0b
2014-06-26Resolves: #i124914# reset certain language dependent pool defaults...Oliver-Rainer Wittmann1-0/+4
before importing a document via <SfxObjectShell::ImportFrom(..)> (used for OOXML *.docx import) (cherry picked from commit 920bf1164fe0c3d232dc0f7d476eec1660f4690e) Conflicts: sfx2/inc/sfx2/objsh.hxx sw/inc/docsh.hxx sw/source/ui/app/docsh.cxx sw/source/ui/app/docsh2.cxx sw/source/ui/app/docshini.cxx sw/source/ui/app/docst.cxx sw/source/ui/app/docstyle.cxx Change-Id: Id32bd6a8ef081dd4af4d832aa42317de7f64184f
2014-06-26clang: Branch condition evaluates to a garbage valueCaolán McNamara1-1/+1
Change-Id: I522f9e9178dbda466a355bc84d97f5458005e131
2014-06-26OSL_ENSURE->assertCaolán McNamara1-3/+3
Change-Id: Ib8ba49e89d03eaf3b3aae94dbbf121898ba9e8de
2014-06-26clang: Use-after-freeCaolán McNamara1-4/+12
Change-Id: I5dd857dbf39c8cd62df8b8cd0323b873a79976ae
2014-06-25remove spurious com::sun::star::util prefixMichael Stahl1-1/+0
Change-Id: I002a14fe0cb0cbdb4d5da51db8da6c8208cf604e
2014-06-25remove spurious com::sun::star::chaosMichael Stahl1-1/+1
Apparently some time before inital CVS import a global search-and-replace went horribly wrong and added spurious namespace prefixes everywhere. Change-Id: I4009bc3ab4b1d4c80412f75ad0e4628a382f99f0
2014-06-24new compilerplugin returnbyrefNoel Grandin1-3/+3
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-23fdo#76203 - use consistent titlecase for UI title labelsJoren De Cuyper6-9/+9
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9 Reviewed-on: https://gerrit.libreoffice.org/9858 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-20Missing null checkStephan Bergmann1-3/+6
As Kendy found out, "In Writer: Enable the drawing functions [view -> toolbars -> drawing], choose 'Line Callout 1' among the presets Callouts [to the left from the stars], and attempt to click and drag in the document to insert it" triggers assert in SvRef<T>::operator* introduced in 160ae9889e4d16217a7cca7d930f776f5a645ec8 "Catch illegal null pointer dereferences early." Given how most places in sfx2/source/doc/sfxbasemodel.cxx already check for null m_pObjectShell, looks like this had just been missing here, and the SfxDocInfoListener_Impl's modified has probably never been called, so it went unnoticed that its m_rShell was a "null reference." Change-Id: I6b6dad831938d5fa89340895b98797686b60c5cc
2014-06-19fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida1-0/+17
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19GetFileTimeValue can produce a "null" DateTimeStephan Bergmann1-1/+5
Change-Id: I96bf1aa2d889c4d0925d073d1d7b4be47c23b3ac
2014-06-19Prevent null pointer dereferenceStephan Bergmann1-1/+4
Change-Id: Ia197152f6ece37dd2dd2ce1b41c1dfd1a985781c
2014-06-18coverity#1028261 Uncaught exceptionCaolán McNamara1-7/+3
Change-Id: I7dd08c182657084ffa635e1960f4d0def6d7a6bb
2014-06-18Use ImplInheritanceHelperStephan Bergmann1-21/+0
Change-Id: I259bf6012684e393765cfd73e813bcf2875abd5f
2014-06-17coverity#706054 Unintended sign extensionCaolán McNamara1-1/+1
Change-Id: I69df0aa6091263cbb6e500a5015915c6678764ec
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin13-59/+7
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13loplugin:staticcallStephan Bergmann10-12/+12
Change-Id: Ie5e9e21f4c592c58094afc954f1de54512719fd5
2014-06-11Change SfxTabPage ctor SfxItemSet param from ref to pointerStephan Bergmann7-29/+29
...and also corresponding param of CreateTabPage function type and corresponding Craete functions. There were some call sites that passed undefined "null pointer references" and SfxTabPage internally uses a pointer member pSet that is checked for null anyway. Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11Change SfxTabPage::Reset param from ref to pointerStephan Bergmann10-30/+30
...there was a call site that passed undefined "null pointer reference" (apparently in a case where the passed argument was actually unused) Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-10Change SfxTabPage::FillItemSet param from ref to pointerStephan Bergmann9-28/+28
...there were a number of call sites that passed undefined "null pointer references" (apparently in cases where the passed argument was actually unused) Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-20 22:35:32 +0000