summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin4-6/+5
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-30fix indentationMatúš Kukan1-28/+27
Change-Id: I41c9e96e2202f1dc52ed93c03846d4d37ae6c2cb
2013-10-29startcenter: Tweak StartCenter buttons and hotkeysKrisztian Pinter1-73/+105
Change-Id: Ica8bf110c3a76c47417a77488657e08ee2456ac7 Reviewed-on: https://gerrit.libreoffice.org/6312 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-29Related: fdo#67461 consider hierarchical viewCaolán McNamara1-22/+19
check for pTreeBox in the show/hide cases. assume pTreeBox means single-select hierarchical mode (select a few things in list mode, then switch to hierarchical view, it doesn't make sense then to care what is selected in the hidden list view) Change-Id: I8ee08e578e66e14d8dea6cd7a66c1dbbbedcd6d1
2013-10-29fdo#67461 add multiple selection support to hide/show multiple stylesJoren De Cuyper1-20/+21
With commit 439ac45925039aa7a537feedab3e731e8a60a8e5 I only add support to delete multiple styles. Hereby I add the possibility to hide and show multiple styles too. Change-Id: I46a8400c281c87b2881367f89ee92db2ba77bfb2 Reviewed-on: https://gerrit.libreoffice.org/5935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-28fixincludeguards.sh: sfx2Thomas Arnhold97-217/+217
Change-Id: I135d03fa8926e0fdba977005e97452045861b2a4
2013-10-28remove local css namespace definitionsThomas Arnhold9-14/+0
As we have it globally in sal/types.h those are not necessary. Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
2013-10-23clean up some include guardsThomas Arnhold2-4/+4
Conflicts: sw/source/ui/inc/content.hxx Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6 Reviewed-on: https://gerrit.libreoffice.org/6388 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-23convert code to use OUString::endsWithNoel Grandin1-1/+1
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-22sfx2: remove obsolete redefinitions of Win32 UINT64 etc. typesMichael Stahl1-10/+0
Change-Id: I6b7acb44c16bcf4d3f8bcc338cb785fb7262eae6
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist16-27/+27
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22vcl: mark more Image constructors as "explicit"Michael Stahl3-4/+8
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22Remove unused SfxObjectShell::bIsTmpStephan Bergmann2-2/+0
Change-Id: I14b495067e25e9a80c08b08ff2034b7bfe1e6759
2013-10-22fdo#54938: Adapt supportsService implementations..Marcos Paulo de Souza7-80/+15
to cppu::supportsService Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14 Reviewed-on: https://gerrit.libreoffice.org/6370 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-22Remove unused SfxObjectShell_Impl::bIsTmpStephan Bergmann2-2/+0
Change-Id: I4040d4758a3753c2177aa2a7d3dba6c85b089b25
2013-10-21Remove comphelper::ComponentContextStephan Bergmann1-5/+4
Change-Id: Idc5974e5a2ec68e8f1b2312a88fab15092c82788
2013-10-21remove uses of COMPARE_*Caolán McNamara5-11/+10
Change-Id: Icdc36b4b24d2f399f481065df3200feb98025135
2013-10-21fdo#68849 add some header guardsThomas Arnhold5-0/+20
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f Reviewed-on: https://gerrit.libreoffice.org/6364 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-10-20String -> OUStringStephan Bergmann1-5/+3
Change-Id: I7dfb8dfbc216cf4c80701bf7d0bd398afaca3f13
2013-10-20STRING_LEN is the same as STRING_NOTFOUNDCaolán McNamara1-1/+1
So use -1 here to realign logic to what it was before 35c24f9b6e08ef1328df01b2d3d11ef518897130. Though it doesn't matter because aThesLookUpStr is going to be empty in the case where we would examine the default value of nDelimPos Change-Id: I369c4e6903407b525dc0dcee9d507e90590eeb6b
2013-10-20drop unnecessary tools/string includesCaolán McNamara1-1/+1
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20fdo#52622 - Reduce copy and paste codeJosé Guilherme Vanz1-22/+1
This commit removes copy and paste code, creating a constructor for it Change-Id: I7a66cfda7fc7c11308d155a7a890352fdacfaacc Reviewed-on: https://gerrit.libreoffice.org/6356 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-17Bin --enable-desktop-gui-elementsTor Lillqvist3-3/+3
Nobody wants LO's own widgets in a touch / mobile app after all. Change-Id: I84f1e85cebce80b6ff4ec5e4e3254654b5f5e6ec
2013-10-16remove SID_INTERNET_ONLINEThomas Arnhold1-27/+0
We have no online/offline concept for the office anymore. Change-Id: Id7e71d9c4383b47d3fae6f8cb5dc18ec22a55934
2013-10-16[API CHANGE]: PreView -> Preview, including .uno:PrintPagePreView.Jan Holesovsky2-7/+7
Will be .uno:PrintPagePreview going forward. Change-Id: Ie5a35467917a54a60dab9eaacf0690c9df27e6f6
2013-10-15silence Non-Layout Enabled Page is visible warningCaolán McNamara1-0/+5
Change-Id: Ib5daaaae02d774e2d47ad0dbc36444a50e03b539
2013-10-15unused classCaolán McNamara1-10/+0
Change-Id: I820c9c79113007df096c4efe9e8fc30b93e2b7ae
2013-10-15fix warning about missing images in startcenterCaolán McNamara1-81/+81
persumably the intent is to show these ones Change-Id: I3110b7efb7acdf689825f78989aba4010abbcc59
2013-10-15CMIS file picker: it really does not like ID MarkCao Cuong Ngo1-1/+0
The file picker can't go back folder if we use ID mark in the URL. Conflicts: ucb/source/ucp/cmis/cmis_content.cxx Change-Id: I6985feec71dc23848ee022e0bab9e8515a21ffd2
2013-10-15callcatcher: update unused codeCaolán McNamara1-16/+0
Change-Id: Ia2452eb82139039e1e6dc98e61ffb32b4091b94f
2013-10-15update pchThomas Arnhold1-12/+2
Change-Id: I475bee35ca5d24903d85e7f2427fab0e47d8db4d
2013-10-13Reduce copypasta: Introduce SAL_NEWLINE_STRING and use itTor Lillqvist1-9/+3
Contains the platform-dependent on-disk line separator ("\r\n" for Windows, "\n" otherwise, and yes, I assume an ASCII-based world). Use it instead of static constant char array fields, with ifdeffed initialisations, in various classes here and there. Change-Id: Ibea1f2cc1acfb8cc067c3892a41f73bf44f2c78a
2013-10-12Test _WIN32 instead of UNX as it's Windows that is the special caseTor Lillqvist1-3/+3
Change-Id: I66e6167df47ac3051d543490ff780bc09dedd82d
2013-10-11have another shot at placing the expander checkitem optimallyCaolán McNamara1-1/+1
reverts 03569dc7d38e4edf3f3e50f7dff3252116c28ab1 "I hate the positioning of the expander checkitem in hierarchical view". I still hate it, so merge together the various places where different efforts are made to try and position the checkitem optimally and provide a single central place to do that. Change-Id: I047504945fb5bf94e5f451007eb74328b8b56785
2013-10-11SCNR: #include cleanupTor Lillqvist1-33/+33
Obviously just a question of personal taste, and we have no consensus here, and some say that <sal/config.h> should be included before any other LO headers, for instance. Oh well, if this commit breaks on some platform, please revert;) Change-Id: Ie02ec4e68b19961165608220f07808641d2e4fda
2013-10-11Don't display menu unless HAVE_FEATURE_DESKTOP_GUI_ELEMENTSTor Lillqvist1-0/+4
Idea from http://lists.freedesktop.org/archives/libreoffice/2013-July/054088.html . Sure, there must be tons of more code that should be ifdeffed for HAVE_FEATURE_DESKTOP_GUI_ELEMENTS. Change-Id: I1ef9ec749b795919c6e52e4f9e0a03bd0e874bc3
2013-10-11CID#1103767 uninitialized membersCaolán McNamara1-0/+1
Change-Id: I2b2a7728bf0a93cf3da033e8b1e1bfccdf6c1df2
2013-10-11CID#1103771 uninitialized membersCaolán McNamara1-0/+1
Change-Id: I3189f29d4632b8c04649dbded7250c1510e5b515
2013-10-11resolved fdo#69948 honor a detected FilterNameEike Rathke1-6/+21
TypeDetection::queryTypeByDescriptor() adds the FilterName property to the MediaDescriptor, use that if present. Strangely enough the sequence returned by XNameAccess::getByName(sType) of the type detection contains an empty PreferredFilter value so that is useless in this scenario. Change-Id: I5cdc9fe71e35bdb7c511739c7f7728134941649a
2013-10-09More OUString::copy out-of-bounds fixesStephan Bergmann1-1/+1
Change-Id: I45762d167d04252e32155a7b23a3290688bccdf6
2013-10-09Improve ErrorCodeIOException messagesStephan Bergmann6-48/+81
...and clean up some includes. Change-Id: Ia5843cd38f967722d7173a6c87fba26064e3ffd6
2013-10-09update unusedcode listCaolán McNamara2-26/+0
Change-Id: I201985753fc53f037807e7870c6786a442717d6e
2013-10-08CID#1079304 uninitialized membersCaolán McNamara1-0/+4
and CID#1079303 Change-Id: I52e70424ca83ae7c9c73dd28d93912a1228ce2bd
2013-10-08CID#1079305 uninitialized membersCaolán McNamara1-1/+11
Change-Id: I00d716a0f05d50fd7a7a1c43772af51224a6b15a
2013-10-08CID#1079306 uninitialized membersCaolán McNamara1-0/+3
Change-Id: I40838e5816439b95a33da6e6896f5ae0b89dbbef
2013-10-08CID#1078685 consider if there is < 3 %Caolán McNamara1-7/+9
Change-Id: I2807a16548af4202d42448c6ef66f240ab4cc920
2013-10-07startcenter: Hide template toggle button if no templatesKrisztian Pinter2-4/+28
Change-Id: I9c6f2058e67990156a4be928449c6ebe6614e486 Reviewed-on: https://gerrit.libreoffice.org/5913 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-07Use URL as fallback for DocumentBaseURL in css.document.MediaDescriptorStephan Bergmann2-5/+13
...in SfxDocumentMetaData::getURLProperties, to avoid "tools/source/fsys/urlobj.cxx:1741: cannot make <[...]> absolute against broken base <>" warnings when SvXMLImport::GetAbsoluteReference tries to make absolute against an erroneously empty base URI any relative URIs contained in the document's meta data. As a consequence, such relative URIs contained in the document's meta data will now be made absolute upon loading in SfxDocumentMetaData::getURLProperties. However, I saw no negative consequences of that (other than having to adapt sfx2/qa/complex/sfx2/DocumentProperties.java in the obvious way). Whether a document written out again contains such meta data URIs as absolute or relative is only controlled by "Tools - Options... - Load/Save - General - Save - Save URLs relative to file system" and not affected by this fix. (I verified that by loading sfx2/qa/complex/sfx2/testdocuments/TEST.odt, which contains a relative meta:auto-reload xlink:href="../TEST.odt" in its meta.xml, and saving it as a new file, with and without "Save URLs relative to file system" checked, and inspecting the resulting documen's meta.xml entries.) Change-Id: Ia1b6004c8597a726eb59c6b2234fd3ecb0bdcc09
2013-10-07sfx2: use a smart pointer in IMPL_SfxBaseModel_DataContainerMiklos Vajna1-6/+4
Change-Id: Ia13c94e05d26d66ebee00ca89030b6947c5efc0c
2013-10-07Use org.junit.Assert.assertEquals where appropriateStephan Bergmann1-68/+70
Change-Id: I3811578a76f6c5c98c955819ca004f2062d273b8
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-21 11:18:54 +0000