summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2019-09-27lok: deduplicate code related to notifyDocumentSizeChanged() callTamás Zolnai1-0/+13
co-author: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79498 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit e9260633df07b6796b19bc92523671cb345597a1) Change-Id: Ia4cef7b23fc682ec32aeb9be4dcdd582464c64e9 Reviewed-on: https://gerrit.libreoffice.org/79624 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-09-27lok: send an invalidation by document size changeTamás Zolnai1-0/+20
It was sent by the kit code earlier. Now we move it to the LO core code, so we can optimize it later. co-author: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79491 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit cd7ff1797d754018db1d47888781c9d7ecb24dcf) Change-Id: Id0a8991016dbe8d13891071e2d5b4c9250720da9 Reviewed-on: https://gerrit.libreoffice.org/79617 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-29sc: LOK: commit cell edits before saveascd-6.0-29-20190828Ashod Nakashian2-1/+7
Users typically don't recognize that changes done to a cell need to be committed (typically by hitting RETURN) before they are saved to file. This is especially true on the web. This patch commits any in-flight changes before SaveAs. This is currently done only for LOK and unconditionally at that. This can be controlled via a flag, if there is such a use-case. Change-Id: I2a88b2f1df47be764058f4505561b22830d9d67a Reviewed-on: https://gerrit.libreoffice.org/78012 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit cc7eb4d345e3fede698a3f255c1938d275305c14) Reviewed-on: https://gerrit.libreoffice.org/78149 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-12explictly exclude LibreLogo from XScript usageCaolán McNamara1-0/+13
Change-Id: I567647f0e2f8b82e4ef2995c673abe82f4564228 Reviewed-on: https://gerrit.libreoffice.org/73659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-12lok: Fix status of InsertPage, DeletePage and DuplicatePage.Jan Holesovsky1-6/+3
Status true / false means checked, status enabled / disabled means the visibility (enablement) of the uno command. Change-Id: Ib2671984f59ffd5e6f1823a65ea42b33bdfe67d6 Reviewed-on: https://gerrit.libreoffice.org/73384 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 0a8eefb55a2cd473bb7f07f19e23051d3e3a22c1) Reviewed-on: https://gerrit.libreoffice.org/73864 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-05-03WebDav: Don't unlock the file during saving of a documentTamás Zolnai1-9/+5
Otherwise it can happen that the file is locked by someone else during the saving method is running. I just extended the scope of the existing DisableUnlockWebDAV() calls a bit. In case of webdav it does not cause an issue to avoid unlocking the file before locking it again with an other SfxMedium. Change-Id: I6ac4e3326c63c9e184a7710ce8994cac1ed79449 Reviewed-on: https://gerrit.libreoffice.org/71484 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit fdab153636ad7e3ce4b09836a63d2fa11b42e728) Reviewed-on: https://gerrit.libreoffice.org/71512 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-05-03tdf#125063: Don't depend on content size for Page sizingMuhammet Kara3-7/+14
During redaction of Calc sheets Change-Id: If2a4f71c77a687a74b8f823152b76d2a7e2e21da Reviewed-on: https://gerrit.libreoffice.org/71658 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-04-16Protect page position during redactionMuhammet Kara1-0/+2
Users might accidentally move the main shape of the page being redacted. Let's prevent that. Change-Id: Ic0f3c2c819d1f974d203fa5fd70d57e5545ba8ef Reviewed-on: https://gerrit.libreoffice.org/70843 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-04-11tdf#116320: properly decode file name for File Locked dialogMike Kaganski1-1/+2
Change-Id: I51bd7c6695ef52b08e0b6d809160d74daebb8505 Reviewed-on: https://gerrit.libreoffice.org/65298 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8dc3fe631583228fe5bb49b44d2308470ec30df0) Reviewed-on: https://gerrit.libreoffice.org/70583 Tested-by: Aron Budea <aron.budea@collabora.com>
2019-04-09Enable redaction for ImpressMuhammet Kara1-6/+0
After the commit c2330b14e2bfa170131a83c375ec0b1a91c95415, different page sizes and orientations are handled properly, and Impress pages are converted to Draw perfectly. Change-Id: Ib9ab6b298e12fc0d8e9440bf63f31ad6dd05ab35 Reviewed-on: https://gerrit.libreoffice.org/69910 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit db76236efd5a6ec5d6f94e700a70408c916f8c91) Reviewed-on: https://gerrit.libreoffice.org/69917 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-04-09Handle different page sizes for redactionMuhammet Kara1-0/+8
Change-Id: I7136717936668fbb1d87b5d9491430c13c5e73fd Reviewed-on: https://gerrit.libreoffice.org/69909 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit 9683627f01d988be7958ee9a0311e20633598971) Reviewed-on: https://gerrit.libreoffice.org/69913 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-04-02Warn when getFileURLFromSystemPath() fails, not when it succeedsTor Lillqvist1-2/+2
Also, display the name that the call failed for in the warning message. Change-Id: I0b6b7baca1d534b5bada5286b2b0e5b8e94f1832
2019-03-30single source file for licensing info with conditional textTamas Bunth1-1/+1
... for easier maintenance. This commit only introduces the framework. Follow up commits will update the license file. Advantages: * single source, multiple outputs (html, txt) * conditional text, i.e. output will not include license terms of components that are not configured in the build Change-Id: I0ffad41119228a0a26fd1b6ce19930ca6085adb2 Reviewed-on: https://gerrit.libreoffice.org/69396 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-28Use SAL_FALLTHROUGHco-6.0-27Tor Lillqvist1-1/+1
Change-Id: I81729dba0bce380303bdbe7c8fcdeca943df477d
2019-03-27MSO lockfiles: Deduplicate MSO lock file reading codeTamás Zolnai1-71/+9
The removed code was extracted to MSODocumentLockFile class so use that class here too. Use openStreamNoLock() for reading MSO lockfiles, because otherwise we can not read lock files written by MSO. Change-Id: Ib31cb9f3783d0b0ce784f900821047b9d32156f2 Reviewed-on: https://gerrit.libreoffice.org/69759 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit ad47e9b1c0d3f1720665b2786090e8c0927b5b45) Reviewed-on: https://gerrit.libreoffice.org/69844 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Generate MSO lock files when the related MSO compat. option is setTamás Zolnai1-0/+46
Added a new compatibility option to the Tools -> Load / Save -> Microsoft. When this option is set on the UI or or set in the configuration files LO generates lock files for MSO supported file formats, similar to the lock files MSO generates itself. Reviewed-on: https://gerrit.libreoffice.org/69678 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 41dc917b9b55b8c0c4307ffc58a1fb7257df2b69) Change-Id: I2f882723841162add01be9d3f7285a5162a60331 Reviewed-on: https://gerrit.libreoffice.org/69843 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Introduce new lockfile handler for MSO like lockfilesTamás Zolnai1-1/+1
* Implement writing of MSO lockfiles * Grab the already implemented parsing code (tryMSOwnerFile method) and put it together into one class * Add tests about the generated URL for lockfiles and the lockfile content * MSO lockfiles are not written yet by LO, next step is to integrate this code into the locking mechanism. Reviewed-on: https://gerrit.libreoffice.org/69582 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 5db1e20b8b0942dac2d50f3cd34532bb61147020) Change-Id: I3b0ed1975cd57dfd006d4e1890b23c307890de5c Reviewed-on: https://gerrit.libreoffice.org/69842 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Create the SfxRedactionHelper classMuhammet Kara4-134/+261
And move some code pieces, related to the redaction functionality, from objserv.cxx to the new SfxRedactionHelper.cxx file. Change-Id: I6491c9b581ea6d3a05a72117c5b72e1dc19025dc Reviewed-on: https://gerrit.libreoffice.org/68338 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69839 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Add style options to redaction exportMuhammet Kara3-8/+55
* Add 2 new uno command aliases to handle 2 different styles of redaction export/sanitization: * .uno:RedactedExportBlack & .uno:RedactedExportWhite * Replace the single export button with the 2 new buttons * Add a new toolbox names .uno:RedactedExportToolbox which consists of the new 2 commands. It will be added to the Redaction toolbar after we solve the icon issue. * Now new redaction shapes are named as RectangleRedactionShape or FreeformRedactionShape based on their type. * While exporting to PDF, a seamless step of "Sanitization" takes place, in which, all shapes in the Draw doc are traversed and turned into opaq black or white (with black border) shapes, then the whole doc is converted into bitmap (page by page). * After the export operation is completed. All shapes are converted back to the usual redaction style (gray and transparent). * Icon issue: * We need 2 new icons for our new commands, one for black redaction shapes without border, and one for white redaction shapes with black border. * I tried adding links to a current icon, but it didn't work, so they are iconless for now. * Next to do: Handle icon issue, and take the redaction implementation into a separate helper class because it is growing fast. Change-Id: I9b2b7716289b800cdbe7bf3ffa4a442fe5afc474 Reviewed-on: https://gerrit.libreoffice.org/68072 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69836 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Use named shapes for redactionMuhammet Kara1-32/+14
Change-Id: Ibb55bd503d264b618c3fbebfdbcf3fe9958c6783 Reviewed-on: https://gerrit.libreoffice.org/68031 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69835 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Handle redaction finalization: BlackMuhammet Kara1-1/+173
Convert shapes on the document to black & opaque before sending it to the pdfexport filter. Convert them back to gray & transparent after the export operation. Change-Id: Iffe66e371710f16ef1c04f0da196fc5a561af344 Reviewed-on: https://gerrit.libreoffice.org/67517 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69834 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Support bitmap PDF export for RedactionMuhammet Kara3-1/+15
* Add a new parameter IsRedactMode (SID_IS_REDACT_MODE) to .uno:ExportDirectToPDF * Make sure the new param makes it into PDFExport as part of FilterData * Hijack the metafile before being sent to ImplExportPage(), convert to bitmap, and replace the original * Add a new entry to GenericCommands.xcu to make our button with param visible * Nitpick: For things to be included in the bitmap conversion, they need to be added to the metafile before the conversion in PDFExport::ExportSelection(). Things added after that point (inside ImplExportPage() for example) will not be bitmapped/pixelized Change-Id: Iec7020917da920a968ea969b98e53f17eadaa275 Reviewed-on: https://gerrit.libreoffice.org/67108 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69833 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Add Redaction ToolbarMuhammet Kara1-0/+32
* Consists of .uno:Rect, .uno:LineToolbox, and .uno:ExportDirectToPDF * Automatically shown when we are in the redaction process * Customizes the rectangle tool for our needs Also: * Adds new parameters to the SID_DRAW_RECT (.uno:Rect) to be able to set transparancy, fill color, and line/border style, and to make our button sticky/permanent Known problem: Button's icon is not shown after adding the parameters Change-Id: I7928264415769f7e0a4ded171b864adb99aed442 Reviewed-on: https://gerrit.libreoffice.org/66706 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69816 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Redaction: Adjust offset for multiple Calc pagesMuhammet Kara1-4/+32
* Add an enum and some methods to DocumentToGraphicRenderer to differentiate between the doc/module types: isWriter(), isCalc(), isImpress() * Put some checks for module/doc type * The result seems ok for a Calc document of multiple sheets with hundreds of pages Change-Id: Idf3e1966d4239df30a48a947a95c9085c25ee1bb Reviewed-on: https://gerrit.libreoffice.org/66605 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69815 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Add method DocumentToGraphicRenderer::getPageCount()Muhammet Kara1-13/+3
And use that in sfx2 Redaction code to be independent of the document/module type Change-Id: Ic206f7a10a27d8d44566df34a10d009a34adf0a5 Reviewed-on: https://gerrit.libreoffice.org/65971 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69813 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Redaction: Handle multiple Writer pagesMuhammet Kara1-29/+47
* Creates one GDIMetaFile from each Writer page * Inserts them as Shapes into the newly created Draw doc * Has some 'magic' numbers needs to be figured out * Tried with a 100-page Writer doc, seems okay * Seems slow, might need to be optimized * Seems like getDocumentSizeInPixels() and getDocumentSizeIn100mm() are consuming most of the cycles. Will look into this at the end. Change-Id: Ic6046af0c12e26185edf59862e55b17117495922 Reviewed-on: https://gerrit.libreoffice.org/65847 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69769 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27svtools: expose document position in DocumentToGraphicRendererMiklos Vajna1-1/+3
Writer pages always have an offset inside the root frame, and this is visible in the generated metafile as well. The offset is minimal for a small window and a single page, but the vertical offset increases with every page. Make this information visible, so sfx2 can compensate this. This is somewhat similar to what SfxObjectShell::DoDraw_Impl() does, but that works for the first page only (use case is thumbnail generation), while this is 0 offset for Calc/Impress and a proper offset for all Writer pages. Change-Id: I1075c98faf74f9e77c916572b4d63d40fbd80ab1 Reviewed-on: https://gerrit.libreoffice.org/65850 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/69758 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Redaction: First stepsMuhammet Kara4-2/+100
- Add an uno command to create an empty draw document - Create a meta file from the first page of a Writer document - Insert meta file to the draw page - Doesn't work with normal/default view on big/high-res screens because of a bug in the MapModes. Manually setting zoom level to %200 or "Page Width" (to get rid of the extra space around the actual page) works for now as workaround. Change-Id: I05a987617efdda6690400ef550b81b58b21aa27e Reviewed-on: https://gerrit.libreoffice.org/64858 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69728 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-20tdf#124168: We do need the BasicDLL thing also in the iOS appTor Lillqvist1-5/+3
For instance, simply inserting a table of contents needs stuff from it. But do keep use of the StarBASIC::* API inside #if HAVE_FEATURE_SCRIPTING. Change-Id: I348ce79899f468e104af336501706f88a6afa287
2019-03-15LOK: switch view before event emission if necessary.Michael Meeks1-0/+9
Unfortunately we still have large amounts of global state, and key event handling in some corners requires this in addition to the window. Change-Id: Id817030536f9cb45dbc39551dfb5332fc6998c62 Reviewed-on: https://gerrit.libreoffice.org/69269 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-03-15LOK: re-factor async key & mouse event re-posting.Michael Meeks2-21/+121
A fairly pure re-factor, although adding disposed window checking to a number of sites with a warning. Moves the event emission helpers from VCL into SfxLokHelper: we're going to need more view / integration here next anyway. Removes lots of copy/paste horror. Change-Id: I279c11a1d8093b4feeeb6b7850f500806fff80dd Reviewed-on: https://gerrit.libreoffice.org/69218 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69268 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-03-15lok: intercept the UNO command ".uno:ThesaurusDialog"Henry Castro1-1/+2
Change-Id: I085cb646037f260ada4d4d04c2419638dd235048 Reviewed-on: https://gerrit.libreoffice.org/69265 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-03-12Move the Help URL to a different config pathAshod Nakashian1-1/+2
This partially reverts e5a0bafa330c58d6c9352d3acbe4e97fafa1ad56 and simplifies the Help URL configuration. Change-Id: Icc7c31b8955f3df978b57dbd8aa8816a9e1f98ad Reviewed-on: https://gerrit.libreoffice.org/69106 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-12Make the Help URL configurableAshod Nakashian1-3/+2
When the Help URL is blank, the Help buttons are hidden LOK (but not desktop). Change-Id: Ibd76452108d1e3a92fb43f2c0af0586b0cbed073 Reviewed-on: https://gerrit.libreoffice.org/69071 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-07build: support disabling popplerAshod Nakashian1-3/+13
This adds --enable-poppler configure option. Poppler can be enabled/disabled by setting this parameter to yes or no. Change-Id: I42ba2d27de7b5014d28523394310616d20073b71 Reviewed-on: https://gerrit.libreoffice.org/68602 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-04sfx: fix -Wreturn-std-move warningAshod Nakashian1-1/+1
Change-Id: Ibd927983505a6924d32c45f6425a08f28bf75f9e Reviewed-on: https://gerrit.libreoffice.org/68259 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-01sfx2: warn when invoking LOK callback before setupAshod Nakashian1-1/+6
Change-Id: I2c845c357f73dbce71b1e420979aecf2cff38827 Reviewed-on: https://gerrit.libreoffice.org/68255 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-02-22tdf#116066: call DoSaveCompleted after SetReadOnlyUIMike Kaganski1-3/+12
Reviewed-on: https://gerrit.libreoffice.org/51051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 7dd704ab1f41086f81136e3987fa7f9aed5ccf5f) Change-Id: Ided8f12764585b2ba62e4c296af43ac07b9e31ed
2019-02-07lok: intercept the UNO command ".uno:EditRegion"Henry Castro1-1/+2
Change-Id: I3a1072e6ededbd0322c4b1dcd0ef4b16ace219d1 Reviewed-on: https://gerrit.libreoffice.org/67478 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-01-17Resolves: tdf#121641 properties invisible after 'reset'Caolán McNamara1-7/+10
Change-Id: Iedb2b11be0e008501273925d6ae7137b28c3b912 Reviewed-on: https://gerrit.libreoffice.org/64539 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 01e263bad891abea9bc671a29c95ea8a8b5fb842)
2019-01-03lok: add signDocument to "Office" iface - to sign not opened docs.Tomaž Vajngerl2-0/+126
LOKit function "signDocument" can sign document without the need to open them. This is useful to sign PDF documents after they are created from a currently opened (ODF, DOCX) document. This adds DocumentDigner to sfx2, which could also be used in desktop LibreOffice without opening them and in further tests. Reviewed-on: https://gerrit.libreoffice.org/65767 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit a8cb7cf68ff661b502e7c006fe4330098b5b0944) Change-Id: Id6f242e817f594aa672f94f9c6f9b34e4035d46a
2019-01-03Remove some useless whitespacesTomaž Vajngerl1-8/+8
Reviewed-on: https://gerrit.libreoffice.org/65764 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit a8d51dc85627514ce7f983eb4e0514ef00f84b1e) Change-Id: Iebf7add3dd937afb6dad07a10ecbe768c0a79d36
2018-12-29tdf#34171: check foreign lockfiles to tell who has locked documentMike Kaganski1-3/+105
MS Office (Word/Excel/PowerPoint) lockfiles are supported now. Note that Excel does *not* create lockfiles for pre-OOXML files. This changes osl_openFile implementation on Windows, to treat osl_File_OpenFlag_NoLock to also include FILE_SHARE_DELETE flag for CreateFileW. This is required to allow opening files created with FILE_FLAG_DELETE_ON_CLOSE flag, such as Excel's owner files. The shange should be consistent with the overall meaning of the osl_File_OpenFlag_NoLock to not impose any locking constraints to the file being opened. Change-Id: I7b99012f4bd60ab3821fb91d5166a286031b7e93 Reviewed-on: https://gerrit.libreoffice.org/64496 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 607b80ca3cddc239a35580470944a438ce144fc8) Reviewed-on: https://gerrit.libreoffice.org/65085 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-12-15lok: Handle Special character menu item's state correctly in onlineTamás Zolnai1-0/+1
Change-Id: Iaa962fe5a590ef16e710fdd49d02d564f10f0f9f Reviewed-on: https://gerrit.libreoffice.org/65188 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 13998b050f445bac3593a8bb77b7320d1be9990d) Reviewed-on: https://gerrit.libreoffice.org/65202 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-12-10use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin7-33/+32
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/64860 Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-06Use lazy-loading stock Image to simplify framework image lists.Michael Meeks1-6/+8
Project stock names through XGraphic via origin URL. Change-Id: Ib445694f7c142a163ef7e7bc0beea39b88b99e14 (cherry picked from commit 77b88eebaadebb626108172e4f2de36c60960051)
2018-12-06ViewShellBase const correctnessAshod Nakashian1-1/+1
Change-Id: I00bffe23f2f850f5e0cbf63a60aa1600f848edac (cherry picked from commit 4e6e33870a60a796c17c1e2d67ac6482b853ad28)
2018-12-01lokit: disable triggering of GUI when changing a signed docTomaž Vajngerl1-2/+3
When a signed document is changed and saved, the dialog pops up on the GUI to warn that the signature will be removed. When saving over the lokit this dialog isn't shown and assumes that we don't want to save (throws an exception) which means we can't save the document ever. This changes the behavior so that we allow removal of the signature and saving can proceed. Reviewed-on: https://gerrit.libreoffice.org/64293 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit c2ee336288dcee103f297a55287fbca596a6c7a1) Change-Id: I52e4a53f0cd3a326c767daee6301a78122af09d4
2018-11-30remove printfTomaž Vajngerl1-1/+0
Change-Id: I00394e7c9880bd96a4f68b6695f1b85fa95689b4 Reviewed-on: https://gerrit.libreoffice.org/63442 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 1874d71576d46e28b79fe2df87f379a28767dccc)
2018-11-16Be less eager to use a fallback in SfxViewShell::SetLOKLanguageTag()Tor Lillqvist1-1/+15
If the fallback language tag based on available localisations would have the same language as the original Bcp47 tag string, use a tag based on the original. For example, if the user locale is 'de-CH', the localisation for plain 'de' will be used automatically anyway, without making the LOK language tag 'de' which would actually end up being stored as 'de-DE' and thus be misleading. We will need to know that it's the 'de-CH' locale we are actually working with when handling Swiss German translations by replacing 'ß' characters in a generic German translation with 'ss'. In this branch, do this only for iOS. Change-Id: I5636d89e715d4881463881e19d4e77af93a0ecaa
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-05 13:55:30 +0000