summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2018-02-08init known ExtraLanguages before document loadsJustin Luth1-0/+4
Extensions can add RegisterOnTheFly languages for spell checkers. A late initialization of the LanguageTable resulted in the inability to recognize the available spell checker. So, if a .doc file had an onTheFly language inside, and it was the first document that LibreOffice opened, then the spell checking extension was disabled for any other document opened while LibreOffice was living, including docx and odt files. (Starting with a blank document, or a .docx or .odt file seems to initialize OK - and then subsequent .doc files are also ok in those sessions.) Ensuring that the static LanguageTable is intialized early in the process avoids this headache. In my case, .doc was failing with: LanguageTag::registerOnTheFly: not cross-inserted 0x7e0 for 'kbo' have 'en-US' but with this patch now matches .odt/docx with: LanguageTag::registerOnTheFly: cross-inserted 0x7e0 for 'kbo' [have 'kbo'] This fixes .ods .odg, odp, .xls .xlsx .ppt, pptx .doc and likely many others Change-Id: Ie6dcbfd73e063eef4573016c3c62d29cf8ad43ca Reviewed-on: https://gerrit.libreoffice.org/49142 Reviewed-by: Martin Hosken <martin_hosken@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 427c0804cd4aecde1cadb7cb3c4f3487991bd573) Reviewed-on: https://gerrit.libreoffice.org/49171 Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-01-30tdf#115090 keep internal BaseModel alive long enoughThorsten Behrens1-0/+6
There's reams of code already preventing a close during save (SfxSaveGuard), but this looks equally effective. Avoids SfxBaseModel::dispose() pulling the rug under us, when SfxBaseModel::postEvent_Impl() wants to access parts of the interface containers during notification. Plus this one: tdf#115090 prevent SfxBaseModel destruction during notifications Additionally ensure refcount stays above sea level while notifying clients (who might dispose their own references, causing our own refcount to drop to zero). Otherwise, 2nd loop in postEvent_Impl() might already operate on freed mem. Reviewed-on: https://gerrit.libreoffice.org/48871 Change-Id: Iace1f9922c47a97ab2e798b577c6aec8a729da48 Reviewed-on: https://gerrit.libreoffice.org/48709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1841fcf896f50b7df1375d431857ecddd5f5b392) Reviewed-on: https://gerrit.libreoffice.org/48762 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-24tdf#113755 - avoid null ptr de-reference during shutdown.Michael Meeks1-0/+7
Why the PostUserEvent's that should do the XTDataObject async destroy are not completed by here, is rather unclear; but - de-referencing NULL is not a great thing to do during shutdown. http://crashreport.libreoffice.org/stats/crash_details/a7d8fd19-0512-4292-b3a0-140dcff204c8 Change-Id: I3f294379f07f4cfc0106c1b5fc5e705c41e78b03 Reviewed-on: https://gerrit.libreoffice.org/48007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ad7e6339e5e5cf465a2ef25442099eb59f1a0deb) Reviewed-on: https://gerrit.libreoffice.org/48013 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-16tdf#114939 officecfg,sfx2: always use AES/SHA256 in ODF 1.2Michael Stahl1-12/+3
The setting ODFVER_012_EXT_COMPAT "1.2 Extended (compatibility mode)" no longer has an effect on the encryption algorithms. API CHANGE: Remove the configuration settings: Office.Common.Save.ODF.UseSHA1InODF12 Office.Common.Save.ODF.UseBlowfishInODF12 Rationale: * Every release since 2012, from LO >= 3.4 and AOO >= 3.4, can read AES/SHA256 encrypted files. * SHA1 is broken anyway * tdf#114939 causes SHA1 interop issues Retain SHA1/Blowfish only for ODF 1.1 export. (cherry picked from commit 0b7c3b7d9fa71f59eed75c3e80e5e12245c5e1c5) Change-Id: I007511d4830a90121e38bf5bb4534df5695621e9 Reviewed-on: https://gerrit.libreoffice.org/47999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-13tdf#114550: load back PGP encrypted filesThorsten Behrens1-0/+9
This squashes the following commits from master: gpg4libre: import PGP encryption manifest Change-Id: Iadd7f8f1194299cb50907d8594114c89c668ebd0 gpg4libre: open encrypted files also via gpg Change-Id: I1f626143e6c8443b4ad0c4fc5bdbd5ab8d56a451 tdf#114550 use 32 bit random session key for gpg encryption Change-Id: I7303be71fd855aa454d07fcae04d7f42e3c9cd9c tdf#114550 recognize sym key & init vec as valid f/ decrypt Change-Id: Ie366f086a3c14d6b54b91b4edee8cfef1a42c44b tdf#114550 don't use PBKDF2 in package for gpg encryption Change-Id: Ic96b2193f8541bbd109795fb9c0212a0a10c7344 gpg4libre: add initial unit test for encryption Change-Id: Id782dd865878ae7b8a60c7c80821b1370f6ac7e7 Change-Id: Id77b67a275bf91614ab62b65fdc69e4872247ffc Reviewed-on: https://gerrit.libreoffice.org/47784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-11tdf#114802 Emojis palette inserts code instead of emojiNoel Grandin1-2/+3
regression from commit 027b25ecd54ac97ea2471ca73e3ba89ce052fe76 use comphelper::InitPropertySequence in more places Change-Id: I587242427c00ebf1faf44ad6b12090a39a1a3ef7 Reviewed-on: https://gerrit.libreoffice.org/47705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-10lokdocview: android: tiled annotations is the cause of the problemPranav Kant1-21/+24
The earlier workaround only fixes it for android but keep other clients like gnome-documents broken. The real problem with these clients is that they ask lokit to render annotations in the tiles. This patch should keep the problem fixed for android and additionally make gnome-documents work, or any other lok clients who do not use comments API but render comments in tiles. Change-Id: I942f988698a9a43abedef7c998589be7f00a4ac0 Reviewed-on: https://gerrit.libreoffice.org/46976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-03tdf#104870 - Impress crashes switching views in read-only modeTamás Zolnai1-0/+3
We need to check read only mode similar to SidebarController::CreatePanels() method. Otherwise SfxUnoPanels::getByName() creates an invalid panel. Reviewed-on: https://gerrit.libreoffice.org/47116 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 23a83639f5a06708074b13bc13ea4f6f819f55f0) Change-Id: Ib7801b81c95f3f505a06c00f749ba4ed5809bfe0 Reviewed-on: https://gerrit.libreoffice.org/47138 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-27tdf#114088 tdf#113795 Improve Writer templatesLaurent BP1-6/+6
Main topic was to add Title in meta.xml to get names of templates localized Additionnal improvements: Businesscard-with-logo - set Title in meta.xml - remove configuration2 (update manifest.xml) - remove unused font - remove user defined styles - insert field Name instead of Name - remove language dependant information - links that need to be updated at the begining Modern business letter serif - remove configuration2 and settings.xml (update manifest.xml) - remove language dependant information Modern_business_letter_sans_serif - replace Open Sans font with Noto Sans - remove unused font - remove configuration2 and settings.xml (update manifest.xml) - remove language dependant information CV - set Title in meta.xml - remove unused font - remove configuration2 and settings.xml (update manifest.xml) - remove language dependant information Resume - remove unused font - remove configuration2 and settings.xml (update manifest.xml) - remove language dependant information - ODF validator does not accept 0in as first value of style:border-line-width-bottom, but seems valid in ODF 1.2 http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#property-style_border-line-width-bottom Default - set Title in meta.xml - add thumbnail.png (update manifest.xml) - remove language dependant information Modern - set Title in meta.xml - add thumbnail.png (update manifest.xml) - remove language dependant information Synchronize Templates names in strings.hxx Change-Id: I417c8398b0002a26e2f84d7efdaeddc0576f9a8c Reviewed-on: https://gerrit.libreoffice.org/46580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> (cherry picked from commit de14f0487118d8ea15db54d94c44d7bd28833c82) Reviewed-on: https://gerrit.libreoffice.org/47008 Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-21Revert the incomplete dialog tunneling, the API has changed completely.Jan Holesovsky1-46/+0
Change-Id: I50fb8c83365cefb8c8e76096fe257d31970a68b4 Reviewed-on: https://gerrit.libreoffice.org/46927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-21tdf#104229: properly switch to def sidebar deck on status changeAron Budea1-1/+1
regression since a64999511ae654131d997eec9a3d78478cfc1c75 Change-Id: Id1d0a76f89c41e88511f670f1aac4b866e4c15c6 Reviewed-on: https://gerrit.libreoffice.org/46840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit f2f5ebcee462472b27b610f53abc7f9a6378462b) Reviewed-on: https://gerrit.libreoffice.org/46881
2017-12-18TSCP: don't put a non-existing name into doc. propsTomaž Vajngerl1-2/+1
We combined the abbr. name with the name and put that as a value into doc. properties. This is not correct as such a name doesn't exist in the BAPolicy and con't be identified anymore, so removing this. Also use the values that were put into the ClassificationField instead of the extracted text. Change-Id: I3037bc90a7a394d430f7c0cca4d326473eff3147 Reviewed-on: https://gerrit.libreoffice.org/45316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ec9b555e8094f4552c068820cab633307fcf520f) Reviewed-on: https://gerrit.libreoffice.org/46720 Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-12-09tdf#114088 Translate default template namesGabor Kelemen2-11/+71
Change-Id: I173364d723e0afd7275b469aea1f2e8cb105fdab Reviewed-on: https://gerrit.libreoffice.org/45450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d635da1972f15862bb283e77787243fbff8361a6) Reviewed-on: https://gerrit.libreoffice.org/46160
2017-12-08gpg4libre: add error string for failed/untrusted encryptionThorsten Behrens1-1/+1
There's one rather common failure mode with gpg, in that untrusted keys are not accepted by gpgme for encryption. A user can override that with --trust-model config or cmd line params, but we can't do much from the gpgme client side: https://www.gnupg.org/documentation/manuals/gnupg/GPG-Configuration-Options.html Change-Id: Ia140a7fd25bd3f428aa11a7ceb0b7bdc47b2c900 Reviewed-on: https://gerrit.libreoffice.org/46060 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit d46dc8e547810208287aab77f0313f1971901464) Reviewed-on: https://gerrit.libreoffice.org/46084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-07gpg4libre: permit multi-select encrypt certThorsten Behrens1-2/+20
And pass down all necessary parameters everywhere Change-Id: I152b9d84c0e35be9e5193a9a6f67de9fb86133b0
2017-12-06tdf#113343 Floating charmap window must not have a context menuHeiko Tietze1-1/+2
Change-Id: I76c567047b0033ae766ab6c5161c96416e478e8e Reviewed-on: https://gerrit.libreoffice.org/45475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 2246ab1a187a5ca73b35ca700c1db63c9b74054e) Reviewed-on: https://gerrit.libreoffice.org/45966
2017-11-25tdf#114025 - minimal and not entirely convincing fix for assertion failure.Michael Meeks1-0/+1
Almost certainly most of the sfx code needs guarding with the SolarMutex. Change-Id: Ied52f1e57c44c20486777e08a901060c191043a2 Reviewed-on: https://gerrit.libreoffice.org/45233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-24unused header fileCaolán McNamara1-30/+0
Change-Id: I7ee12c4b0b58098e0600d6d56409529a639aa6fd Reviewed-on: https://gerrit.libreoffice.org/45224 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-24set new document window as parent for dialogs during loadCaolán McNamara2-2/+19
and exit typedetection early and completely if application quits while detecting During typedetection, before loading proper, we have the hidden window as parent so warnings are not modal to existing windows and they are cancelled on exit. Once we do have a window, then reinit interaction handler to have that window as the parent for any further dialogs. Change-Id: I5c6711557266bf7d1eb9291f1c454cbfaf766886 Reviewed-on: https://gerrit.libreoffice.org/45148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Resolves: tdf#113962 save detected filter outside file dialogCaolán McNamara2-7/+18
different file dialog impls work differently so store the detected filter outside the file dialog Change-Id: I144d8df06e5265fed8f11b284a2f40c17c3e09ef Reviewed-on: https://gerrit.libreoffice.org/45166 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Related: tdf#113160 set a temporary dialog parent during type detectionCaolán McNamara2-1/+121
to get warning dialogs that don't block the existing windows but whose lifecycle can be controlled to avoid crashes during exit Change-Id: I57965301c3d8a031acb33e83bf7715fe132385d0 Reviewed-on: https://gerrit.libreoffice.org/45044 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23move preventduplicateinteraction from framework to sfx2 consumerCaolán McNamara4-3/+471
Change-Id: I1388a88ba20b5cde65cd1d88694775b071a0dff6 Reviewed-on: https://gerrit.libreoffice.org/45099 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin2-2/+2
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22tdf#113935 Switching from read-only to edit mode slowNoel Grandin1-0/+5
Regression introduced by commit 389da66dfc96d06c407bff156c4ea21e940c5e06 remove unused uno::Reference vars I'm guessing this variable keeps some kind of cache alive which prevents us from re-parsing the PDF file when we switch to edit mode - which is clearly what we are doing when I remove the line. Change-Id: Iea2cf9640d876028a78806e717b930d4a063dc9b Reviewed-on: https://gerrit.libreoffice.org/45093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann1-1/+1
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22replace check of eof and GetError with goodCaolán McNamara1-1/+1
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291 Reviewed-on: https://gerrit.libreoffice.org/45076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara2-2/+2
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin1-2/+2
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd95ada4477d7d21ffbadd355226f91f2a2371e1 Reviewed-on: https://gerrit.libreoffice.org/45004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-20cosmetics: Drop duplicate semicolonTakeshi Abe1-1/+1
Change-Id: I96d2ffb903f9ed15070572552c9564b5089df12f Reviewed-on: https://gerrit.libreoffice.org/44914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin4-11/+11
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-19Fix typosAndrea Gelmini1-2/+2
Change-Id: I964528cf4f3b81230c683011e1878b28378b0014 Reviewed-on: https://gerrit.libreoffice.org/44915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-18Updated liborcus to 0.13.1.Kohei Yoshida1-3/+3
Change-Id: Id5aa07f87603879fe7a21dc96cad207f1b168286 Reviewed-on: https://gerrit.libreoffice.org/44850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-11-17Notebookbar: PriorityMergedHBox, OptionalBoxSzymon Kłos10-196/+578
Change-Id: I7822fb1b6a342065d66a3fd62f1277e43c2562dd Reviewed-on: https://gerrit.libreoffice.org/44694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-17TSCP: disable toolbar pop-up if category was set with dialogTomaž Vajngerl2-22/+115
In addition move reading of origin to classificationhelper as we need to read it there. Change-Id: I472b073587e68e6896f915477603a25db9b310d3 Reviewed-on: https://gerrit.libreoffice.org/44848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17TSCP: resolve identifier to name, abbr. name is for category onlyTomaž Vajngerl1-0/+15
In paragraph classification we store only the identifier and not the name, but for the ClassificationDialog we use the name as an identifier, so we need to resovle the identifier to the name when reading in the input classification results. It might make sense to switch to identifiers in the dialog also as they are language independent. Abbreviated name is only for the classification category and has no effect for other classefication elementslike markers and IP parts, so always fill them with the full name directly. Change-Id: I23bd0e8e92b16807a5b4d3162e503b799aa40718 Reviewed-on: https://gerrit.libreoffice.org/44845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-15lokdialog: Expose cursor visible statusPranav Kant1-3/+11
Change the notifyDialog API a bit. Use a std::vector to keep track of each payload item that needs to be fed to the resulting JSON. Change-Id: If3229a88d2df5368e14290a0e80ebe6206780639 Reviewed-on: https://gerrit.libreoffice.org/44722 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-14Translate German comments and debug stringsJohnny_M2-3/+3
Change-Id: I12c92ecc270e65cb99e38e9179cf354a8c0708aa Reviewed-on: https://gerrit.libreoffice.org/44633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-13Fix typosAndrea Gelmini3-3/+3
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-12use copy constructor to clone PoolItemsJochen Nitschke3-5/+5
Change-Id: I2a45a62fd56cc5a768406c7a6e4c72456f962367 Reviewed-on: https://gerrit.libreoffice.org/44648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-11sfx2: Replace SfxViewShell::DiscardClients_Impl()Takeshi Abe3-23/+2
with DisconnectAllClients() because both do the same ever since 17a91c18edea240a35a12a573933917240e9fb4a. Change-Id: I17639670d0fb787c69a53e8992f706937665d7b3 Reviewed-on: https://gerrit.libreoffice.org/44447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10rework tdf#113647 solution to be safeCaolán McNamara3-6/+23
rather than passing the pointer around, tragic use of uno apis means monstrous awt::Window thingy has to be passed around and still smuggled through the dispatch arguments to get through the eye of the XDispatch::dispatch needle Change-Id: I353f8a3b0bb698bb58f75576e49efd701f3db8bf Reviewed-on: https://gerrit.libreoffice.org/44585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-09TSCP: restore paragraph classification from DOC(X)Ashod Nakashian1-0/+3
Change-Id: I81f9a98f618b32e13c5ce92489846a4e20cc23d7 Reviewed-on: https://gerrit.libreoffice.org/44325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-09new loplugin simplifydynamiccastNoel Grandin3-8/+8
simplify dynamic_cast followed by static_cast Change-Id: I965afcf05d1675094cfde53d3590a0fd00f26279 Reviewed-on: https://gerrit.libreoffice.org/44460 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-09fix bugs in StateView_Impl and TransformItemsNoel Grandin2-2/+6
where it was only incrementing the pointer once, meaning it was not iterating in pairs Change-Id: I26cc9b4262bc869c72231ef9eabca2d29da0a724 Reviewed-on: https://gerrit.libreoffice.org/44462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-09lokdialog: Support painting parts of the dialogPranav Kant1-4/+7
Pass the dimensions of the region to the paintDialog call to paint only that much of the region in the dialog. The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in the payload that tells the region of the dialog invalidated. It can be used in combination with the new paintDialog call then to paint only the invalidated region in the dialog. Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906 Reviewed-on: https://gerrit.libreoffice.org/44472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-09rename AvoidConfig to FuzzingCaolán McNamara7-16/+16
cause that's what its really used for and a couple of cases are not specifically about avoiding config but avoiding uninteresting disk acccess and what not Change-Id: I4c6454f98388579fcd0bf9798321d30408ab65ee Reviewed-on: https://gerrit.libreoffice.org/44491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08ofz#4106 Integer-overflowCaolán McNamara1-8/+15
Change-Id: I91109f652bc032811ade350b77d30424b5764ad8 Reviewed-on: https://gerrit.libreoffice.org/44449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08tdf#100922 Refactor Custom Properties pageSzymon Kłos1-153/+204
This commit solves problems with big number of entries. Window is loaded quickly and is responsive even with over a thousand custom properties. Change-Id: I4745c69aaff95661ca930e303ab65591e374a24d Reviewed-on: https://gerrit.libreoffice.org/44429 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-08sw lok: add Accept/Reject All tracked changes, tdf#101977Henry Castro1-1/+4
Change-Id: I04d747343e24cb498a621c965d034d0791411d83 Reviewed-on: https://gerrit.libreoffice.org/44311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-23 22:13:57 +0000