summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2021-05-10Improve checkStephan Bergmann1-1/+1
Change-Id: I8280a81eef2ced0ff0ace51ea9f094421abafe13 Reviewed-on: https://gerrit.libreoffice.org/78108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 761e6dd25782420bf06e4a2ff3205a79b6cbb136) Reviewed-on: https://gerrit.libreoffice.org/78129 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit ffad51e9e625a22f1efab3da7886baf4134b444f)
2021-05-10expand pyuno path separatorsCaolán McNamara1-1/+2
Change-Id: Ic97649ed6d4be595b308922c7bdc880cbb60b239 Reviewed-on: https://gerrit.libreoffice.org/77102 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 75903a0298218f89a199a5ac151ee0166f4469d7)
2021-05-10Properly obtain locationStephan Bergmann1-9/+12
Reviewed-on: https://gerrit.libreoffice.org/77019 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit a9cde2557242a0c343d99533f3ee032599c66f42) Reviewed-on: https://gerrit.libreoffice.org/77023 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 28c6af3ddc283ca9c5712359a9abcb385c1575b4) Change-Id: I9fb0d883a3623394343cd54ef61e5610544198c8
2021-05-10decode url escape codes and check each path segmentCaolán McNamara1-1/+28
Change-Id: Ie8f7cef912e8dacbc2a0bca73534a7a242a53ca1 Reviewed-on: https://gerrit.libreoffice.org/76378 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins (cherry picked from commit 7942929685fafb0f9c82feb8da7279e5103c87f0) Reviewed-on: https://gerrit.libreoffice.org/76451 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit aab62f2b21c331ff8c31b7c856d5e59080b9d64a) (cherry picked from commit 3098810911ccf76da1591d8f6cfceebfda13dcbd)
2021-05-10expand LibreLogo check to global eventsCaolán McNamara2-11/+13
Reviewed-on: https://gerrit.libreoffice.org/76189 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4a66c7eda6ccde26a42c4e31725248c59940255d) Change-Id: I7f436983ba0eb4b76b02d08ee52626e54b103d5f Reviewed-on: https://gerrit.libreoffice.org/76305 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit b14742734481ae0a4731989a99db487d8ae1986a) (cherry picked from commit 139d6207488d5e9ae7904f9ea07f058c531898ef)
2021-05-10explictly exclude LibreLogo from XScript usageCaolán McNamara1-0/+13
Change-Id: I567647f0e2f8b82e4ef2995c673abe82f4564228 Reviewed-on: https://gerrit.libreoffice.org/73659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit cb0024e3668979dfdef44db5aa15ddfaf035e695)
2018-05-07tdf#117039: update infobar instead of removing and re-adding itKatarina Behrens3-21/+67
Apparently AppendInfoBar ends up calling back into SID_SIGNATURE status function at some point, creating an endless recursion. I'm too lazy to debug why so I'm cowardly avoiding it Reviewed-on: https://gerrit.libreoffice.org/53519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 43459bac67363f49aadd851e686d4a74b8ddc256) Reviewed-on: https://gerrit.libreoffice.org/53648 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8853067a29e091a230a6397bd7c100494ae9f5bf) Reviewed-on: https://gerrit.libreoffice.org/53672 (cherry picked from commit 65936059966f92e983ac0d3553ade9ff37884a4e) Change-Id: Ib1e4b7f12fea197887b099e9a9f03b4e58884ec1 Reviewed-on: https://gerrit.libreoffice.org/53741 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-04-11tdf#115853: save current custom property when adding lineJulien Nabet1-0/+14
by reloading current lines before adding a brand new one indeed the info are deleted by ClearCustomProperties each time SfxDocumentInfoItem destructor is called Change-Id: Id1e2e652e90c720f00b8612aa9afbfa91b784d1d Reviewed-on: https://gerrit.libreoffice.org/50070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/52349 Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-03-21tdf#91106 sfx2: Stylist hierarchical: sort the Default Style firstMichael Stahl1-0/+4
(regression from 41af2a9e26f3ee6b505b343120d5df3617ba5c49) (cherry picked from commit fd67ee14e769ebdf1e43d55e0117f70f90d53053) Change-Id: I47377447dd1e04a44033dea27ce7307a65821737 Reviewed-on: https://gerrit.libreoffice.org/51244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 21f220fce05bb99964f098247786eec014e56902) Reviewed-on: https://gerrit.libreoffice.org/51591
2018-03-01tdf#115795 Solve wrong redirect behavior of "Get Online Help"Franklin Weng1-7/+1
When under locale zh-TW, Help > Get Online Help would use only "zh" as the parameter of LOLang and sent it to hub.libreoffice.org, which would redirect to Simplified Chinese forum instead of zh_TW ask.libreoffice.org forum. After discussing with Guilhem he refactored the behavior of the Hub, use LOlocale instead of LOLang, and keep LOLang for backward compatibility. The LibreOffice sent LOlocale instead to avoid this problem happening again. Change-Id: Ia9348cff88723210f693e65260bb987826a3f3ea Reviewed-on: https://gerrit.libreoffice.org/50503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-on: https://gerrit.libreoffice.org/50519 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-13tdf#113755 - avoid null ptr de-reference during shutdown.Michael Meeks1-0/+7
Why the PostUserEvent's that should do the XTDataObject async destroy are not completed by here, is rather unclear; but - de-referencing NULL is not a great thing to do during shutdown. http://crashreport.libreoffice.org/stats/crash_details/a7d8fd19-0512-4292-b3a0-140dcff204c8 Change-Id: I3f294379f07f4cfc0106c1b5fc5e705c41e78b03 Reviewed-on: https://gerrit.libreoffice.org/48007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ad7e6339e5e5cf465a2ef25442099eb59f1a0deb) Reviewed-on: https://gerrit.libreoffice.org/49103 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-08init known ExtraLanguages before document loadsJustin Luth1-0/+4
Extensions can add RegisterOnTheFly languages for spell checkers. A late initialization of the LanguageTable resulted in the inability to recognize the available spell checker. So, if a .doc file had an onTheFly language inside, and it was the first document that LibreOffice opened, then the spell checking extension was disabled for any other document opened while LibreOffice was living, including docx and odt files. (Starting with a blank document, or a .docx or .odt file seems to initialize OK - and then subsequent .doc files are also ok in those sessions.) Ensuring that the static LanguageTable is intialized early in the process avoids this headache. In my case, .doc was failing with: LanguageTag::registerOnTheFly: not cross-inserted 0x7e0 for 'kbo' have 'en-US' but with this patch now matches .odt/docx with: LanguageTag::registerOnTheFly: cross-inserted 0x7e0 for 'kbo' [have 'kbo'] This fixes .ods .odg, odp, .xls .xlsx .ppt, pptx .doc and likely many others Change-Id: Ie6dcbfd73e063eef4573016c3c62d29cf8ad43ca Reviewed-on: https://gerrit.libreoffice.org/49142 Reviewed-by: Martin Hosken <martin_hosken@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 427c0804cd4aecde1cadb7cb3c4f3487991bd573) Reviewed-on: https://gerrit.libreoffice.org/49171 Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit d51c01846afb9bea5a39fd48fbb30b9fd02c2870) Reviewed-on: https://gerrit.libreoffice.org/49449 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-03tdf#104870 - Impress crashes switching views in read-only modeTamás Zolnai1-0/+3
We need to check read only mode similar to SidebarController::CreatePanels() method. Otherwise SfxUnoPanels::getByName() creates an invalid panel. Reviewed-on: https://gerrit.libreoffice.org/47116 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 23a83639f5a06708074b13bc13ea4f6f819f55f0) Change-Id: Ib7801b81c95f3f505a06c00f749ba4ed5809bfe0 Reviewed-on: https://gerrit.libreoffice.org/47144 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-21tdf#104229: properly switch to def sidebar deck on status changeAron Budea1-1/+1
regression since a64999511ae654131d997eec9a3d78478cfc1c75 Change-Id: Id1d0a76f89c41e88511f670f1aac4b866e4c15c6 Reviewed-on: https://gerrit.libreoffice.org/46840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit f2f5ebcee462472b27b610f53abc7f9a6378462b) Reviewed-on: https://gerrit.libreoffice.org/46884
2017-12-01tdf#113647 bullet dialog has wrong modal parentCaolán McNamara3-6/+23
Reviewed-on: https://gerrit.libreoffice.org/44554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 31b26130d90d4746cbb126fd9b6c1cb3487f644f) Change-Id: Ia2e6171a1aeb3b8ad679a547a63ccaeac20481df Reviewed-on: https://gerrit.libreoffice.org/44978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-23tdf#113935 Switching from read-only to edit mode slowNoel Grandin1-0/+5
Regression introduced by commit 389da66dfc96d06c407bff156c4ea21e940c5e06 remove unused uno::Reference vars I'm guessing this variable keeps some kind of cache alive which prevents us from re-parsing the PDF file when we switch to edit mode - which is clearly what we are doing when I remove the line. Change-Id: Iea2cf9640d876028a78806e717b930d4a063dc9b Reviewed-on: https://gerrit.libreoffice.org/45093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 5ee141ee2fb77c3cc452ac656235d7e83e15072c) Reviewed-on: https://gerrit.libreoffice.org/45108 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-28tdf#113446 Make EditStyle appear in customization dialogYousuf Philips1-3/+3
Change-Id: Ic9c13ec0b1a009a1fb3998517ca21471c9c2f23f Reviewed-on: https://gerrit.libreoffice.org/43967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-19tdf#99537 set expand for re-used sidebar panelsJan-Marek Glogowski1-0/+1
When re-using a panel, reset the expand state from the stored state in the PanelContexDescriptor. Change-Id: I00851982bbd36cacdc57459bb6e5be9fcc719e81 Reviewed-on: https://gerrit.libreoffice.org/43466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit ce2e94a98f5fc85bef7623a0227b3a95d8093288) Reviewed-on: https://gerrit.libreoffice.org/43481 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-03tdf#91106 sfx2: Stylist: sort top-level styles in hierarchical modeMichael Stahl1-0/+6
(regression from 8f04b172c5c78fa80c3692a729f0191425195869) Change-Id: I111d12a622390afc02eb73a42b1d3c714f046bd2 (cherry picked from commit 41af2a9e26f3ee6b505b343120d5df3617ba5c49) Reviewed-on: https://gerrit.libreoffice.org/42952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-05Resolves: tdf#95960 improve custom properties pageCaolán McNamara1-248/+137
wrt widget heights and positions and other flakiness take the natural combobox height as the line height, use a vclgrid element for each row to get everything set to the same height move the positioning code into Resize, etc. Reviewed-on: https://gerrit.libreoffice.org/41734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 14afb688d3a24be302867ea614b0e30e01d168be) Change-Id: I22de98ef91e39d1e7e45bbe62f68496d55c0c1cb Reviewed-on: https://gerrit.libreoffice.org/41749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-05tdf#112027: avoid leaks in FillTreeBox (sfx2)Julien Nabet1-0/+1
Next step could be using std::unique_ptr<StyleTree_Impl> instead of StyleTree_Impl* Change-Id: Ifbf5313fedf1fc0310073918f91edd6fe75d0afc Reviewed-on: https://gerrit.libreoffice.org/41710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c82e5db9626e4d84300f84842b837e852be828be) Reviewed-on: https://gerrit.libreoffice.org/41925 Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-29Resolves: rhbz#1400287 resizing properties dialog hides widgetsCaolán McNamara1-5/+7
Change-Id: I5d066f53c5bdfb4dd50d60c5cb4b66e425c0293c Reviewed-on: https://gerrit.libreoffice.org/41698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-23tdf#111844 infobar icons on high dpiheiko tietze1-2/+2
scaling factor added Change-Id: Iccfc76832ccfaaffb9950d4b591b379dfb0d9eca Reviewed-on: https://gerrit.libreoffice.org/41401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> (cherry picked from commit 4438849e400ecef3cdf2f267dc75a76d4b11aba1) tdf#111844 infobar icons/text on high dpi scaling factor added to text position Change-Id: Iaeb48fd4ac0439680fa3b6ca43f23a617efe1457 Reviewed-on: https://gerrit.libreoffice.org/41417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> (cherry picked from commit 4d60d96a22ef2f67db7c7e99981447bd81f776c4) Reviewed-on: https://gerrit.libreoffice.org/41461 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-11tdf#111567: fix memleak in TemplateLocalView::insertItemsJulien Nabet1-2/+0
Clearing mItemList at the begin of insertItems is a bad idea because it prevents ImplDeleteItems (called by updateItems, itself called at the end of insertItems) from clearing correctly mItemList See comments from bugtracker for more info (Thank you Alex for the precious info attached with memleak reports! :-)) Change-Id: I04976dbb065d1369562649fc97c33f7fd599b107 Reviewed-on: https://gerrit.libreoffice.org/40995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 05a338159761e012c2c8779f8927b0d709b4416f) Reviewed-on: https://gerrit.libreoffice.org/41002 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-09tdf#108802 : In SfxControllerItem::dispose do not directly...Dennis Francis1-1/+1
call pBindings->Release(), but call UnBind() instead which correctly sets the state to "UnBound" by setting pNext = this. Thanks to Miklos Vajna for pointing this out ! Change-Id: I08e85496cff6df0952d6c5ec4ee979a93b8862d0 Reviewed-on: https://gerrit.libreoffice.org/40882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> (cherry picked from commit 2585eb9d15f5c047d846ccb4b4d606d9ac89e518) Reviewed-on: https://gerrit.libreoffice.org/40907 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-10tdf#108852: Put signature infobar into the right frameKatarina Behrens1-1/+1
and thus avoid crash when user clicks 'show signatures' button in a window where signature bar shouldn't even be Change-Id: I5eba8d1ddd8c76dd10acedfa03d732df586748de Reviewed-on: https://gerrit.libreoffice.org/39705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27tdf#108814 sfx2: fix crash in sidebar when XUpdateModel not implementedMichael Stahl1-1/+4
com.sun.star.ui.XUpdateModel was added in 5.1 so pre-existing extensions don't implement it. (regression from 0635208edf1cdee4235ea87666a473ac81007555) Change-Id: I6749a9cf2fc82b9cd90d85a682247104e369e167 (cherry picked from commit d109948f0dd4190d7aca1e0fa7e2706ef3f40a6c) Reviewed-on: https://gerrit.libreoffice.org/39311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-16tdf#105566: Account for 'signature used to be ok but isn't anymore'Katarina Behrens2-19/+22
because the user has modified the document Change-Id: Ib32ea2ff41f41a81c9a382585f6afbec12fe6a35 Reviewed-on: https://gerrit.libreoffice.org/38284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 2e11bbd288ec59d0ff3368cc5c5ef83e2f5133a2) Reviewed-on: https://gerrit.libreoffice.org/38876
2017-06-16tdf#106366 Show infobar for all read-only documentsSamuel Mehrbrodt1-1/+2
Except those who were set open r/o with the File->Properties checkbox Change-Id: Id44daac364cae73636b6f1c051521928743b88f4 Reviewed-on: https://gerrit.libreoffice.org/36258 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 630186ff4e0eba7317e542f8c3eca39ebd068721) Reviewed-on: https://gerrit.libreoffice.org/38874 Tested-by: Jenkins <ci@libreoffice.org>
2017-06-07Eliminate dynamic_cast<const SfxVoidItem*>, use SfxPoolItem::IsVoidItem()Eike Rathke6-9/+9
Change-Id: I09dafffd64dd107e802d016494d884f32363521a (cherry picked from commit ca8a4a7abc81a53a88fc0daa61447f9562f532f5) Reviewed-on: https://gerrit.libreoffice.org/38463 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-06-04Watermark: updated Put and QueryValueSzymon Kłos1-12/+23
Change-Id: Ica65be783130b1981093204edd03dc793a16343b Reviewed-on: https://gerrit.libreoffice.org/38027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 6533c30f7f8b62671fef9e636c49b11127812ed1) Reviewed-on: https://gerrit.libreoffice.org/38380 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-06-01tdf#105566: Add/remove infobar when the signature status changesKatarina Behrens3-36/+79
this time without stack overflow. Updating existing infobar needs some work still This patch is partially based on work of samuel_m Change-Id: I2c44c14e27cf85a1014b01e5588b7b53990033b9 Reviewed-on: https://gerrit.libreoffice.org/38148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit e744e9f4492d3013742fcdb6254cd76528870e9d) Reviewed-on: https://gerrit.libreoffice.org/38255
2017-05-22Watermark: extended configurationSzymon Kłos2-8/+25
* it is possible to set font family, color, angle and transparency Change-Id: Idea2fb9ee748394bb3d706fa790e109238584cdb Reviewed-on: https://gerrit.libreoffice.org/37793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 48906a5e899e517af76e04afb5659232b336e206) Reviewed-on: https://gerrit.libreoffice.org/37835
2017-05-21make string translation loading more uniformCaolán McNamara52-258/+184
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2155e04d6343638ca9815d394cbc4f78c2b17c3a) drop toString Change-Id: I0f67c8931523bbe90bfbc8cc7d9a5bd523758ee5 (cherry picked from commit 8b1101023f01b2c7478a014b5ead73ada4fd4861) pNameResId is unused Change-Id: Ic1fe6abc7066517187695266c4d1a0888b41ffe7 (cherry picked from commit c2667d7ff558a1b7bf83e694909465f00d1a16f6) Reviewed-on: https://gerrit.libreoffice.org/37843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18Watermark: Insert watermark commandSzymon Kłos4-0/+86
* added new command .uno:Watermark * if no arguments are provided the dialog is opened where user can enter the text * with provided Text argument the watermark is created * created SfxWatermarkItem to transfer watermark properties * dialog loads current setings * SetClassification use SetWatermark Change-Id: Ifc1319f5aa7c11bb141f8e4b5b9a5088613021c2 Reviewed-on: https://gerrit.libreoffice.org/37599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-05-18SID_ADDONS sdi slot is unusedMaxim Monastirsky2-20/+0
We only need a label in officecfg, and an icon in icon-themes. Change-Id: I88482f85b282742c5d6dc7f6ec7ba6442c09a639
2017-05-16lok: sc: make row/col header updating, on row/col operations, tab-awareMarco Cecchetti1-11/+0
Now, on inserting/removing or resizing a row/col, the row/col header invalidation callback is notified to another view only if it is displaying the same tab of the view where the row/col operation is occurring. Conflicts: sc/source/ui/view/tabvwshc.cxx Change-Id: Ic65fd82b2e3009420c7b481e7e8c1ff8bb11bcce Reviewed-on: https://gerrit.libreoffice.org/37241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-05-16lok: sc: address and formula text field empty on creating a new viewMarco Cecchetti1-0/+6
When the client starts the address and formula text field were empty because the updating callbacks occurred before the view callback handler had been registered. So a new method `afterCallbackRegistered` has been added in order to perform any needed updating/initialization soon after the view callback handler has been registered. Change-Id: Ia47234e32796f7e4bc1a8408736102054b4666e2
2017-05-15loplugin:useuniqueptrNoel Grandin1-4/+2
ignore SAL_LOG type stuff in the destructor Change-Id: If014382ca0c96edd3f2b325a28451d83b3d1f278 Reviewed-on: https://gerrit.libreoffice.org/37539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-14tdf#58134 Reset Button in Options Dialogues does not Work with all Optionsmelikeyurtoglu1-0/+3
Change-Id: I99ef82f6b82674e67aa10d270361828545864f8b Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/37569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12remove unused uno::Reference varsNoel Grandin8-14/+1
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11Clean up uses of SAL_U/SAL_W: sfx2Stephan Bergmann1-1/+2
Change-Id: I91a7af532a3b94e8096d99d1c4cf63d315e2f446
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin10-15/+15
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke2-2/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09In LazyDelete'd SearchDialog::dispose, SfxHelpTextWindow_Impl is already goneStephan Bergmann4-6/+5
Came across this in a UBSan build via menu "Help - LibreOffice Help" -> "LibreOffice Help" window: "Find on this Page..." icon -> "Find on this Page" dialog: "Close" button, then close help window: > sfx2/source/appl/newhelp.cxx:2291:1: runtime error: member call on address 0x618001188880 which does not point to an object of type 'SfxHelpTextWindow_Impl' > 0x618001188880: note: object has a possibly invalid vptr: abs(offset to top) too big > 81 04 00 13 0e 07 00 08 5e 7f 00 00 00 00 00 00 00 00 00 00 60 62 9a 51 5e 7f 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > possibly invalid vptr > #0 0x7f5e4700f276 in SfxHelpTextWindow_Impl::LinkStubCloseHdl(void*, sfx2::SearchDialog*) sfx2/source/appl/newhelp.cxx:2291:1 > #1 0x7f5e47f6d13a in Link<sfx2::SearchDialog*, void>::Call(sfx2::SearchDialog*) const include/tools/link.hxx:84:45 > #2 0x7f5e47f66c5f in sfx2::SearchDialog::dispose() sfx2/source/dialog/srchdlg.cxx:70:17 > #3 0x7f5e209af22c in VclReferenceBase::disposeOnce() vcl/source/outdev/vclreferencebase.cxx:42:5 > #4 0x7f5e1edb81b9 in VclPtr<vcl::Window>::disposeAndClear() include/vcl/vclptr.hxx:239:19 > #5 0x7f5e1fc47199 in vcl::LazyDeletor::~LazyDeletor() include/vcl/lazydelete.hxx:148:36 > #6 0x7f5e1fc473af in vcl::LazyDeletor::~LazyDeletor() include/vcl/lazydelete.hxx:122:9 > #7 0x7f5e21dfdb50 in vcl::LazyDelete::flush() vcl/source/helper/lazydelete.cxx:52:9 > #8 0x7f5e21fa552f in ImplYield(bool, bool, unsigned long) vcl/source/app/svapp.cxx:513:9 > #9 0x7f5e21f7fdc3 in Application::Yield() vcl/source/app/svapp.cxx:558:5 > #10 0x7f5e21f7fb06 in Application::Execute() vcl/source/app/svapp.cxx:458:9 > #11 0x7f5e5cbd18d4 in desktop::Desktop::DoExecute() desktop/source/app/app.cxx:1359:5 > #12 0x7f5e5cbd9e06 in desktop::Desktop::Main() desktop/source/app/app.cxx:1679:17 > #13 0x7f5e21ffb0cb in ImplSVMain() vcl/source/app/svmain.cxx:191:35 > #14 0x7f5e220085f1 in SVMain() vcl/source/app/svmain.cxx:229:16 > #15 0x7f5e5cdfec4b in soffice_main desktop/source/app/sofficemain.cxx:166:12 > #16 0x511c69 in sal_main desktop/source/app/main.c:48:15 > #17 0x511c13 in main desktop/source/app/main.c:47:1 > #18 0x7f5e5b37d400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289 > #19 0x419e59 in _start (instdir/program/soffice.bin+0x419e59) indicating that the SfxHelpTextWindow_Impl target of the m_aCloseHdl.Call is already dead. Looks like there is no good reason for that call from dipose() anyway, which also means the Call's argument is unused. Change-Id: Ifc33e74e346902dc0208350f5bac79bec182ef12
2017-05-09make loplugin constantparam smarter about string paramsNoel Grandin2-2/+1
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09gnome-documents: rework SfxPickList as pimplCaolán McNamara2-26/+41
and call impl dtor with SolarMutex held Change-Id: I06931ca9ab4384a5e3c255847cf3533ed03b77dc Reviewed-on: https://gerrit.libreoffice.org/37395 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-08fold SfxPickList::Get and ::ensure togetherCaolán McNamara2-4/+2
Change-Id: Iab68095a9733393b656623ddd6bb8705f7cfda82
2017-05-08cleanup tools/debug.hxx includesJochen Nitschke3-3/+0
with command > git grep -l tools/debug.hxx | xargs grep -L DBG_ | xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d' don't change files in includes/ and */pch Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08 Reviewed-on: https://gerrit.libreoffice.org/37349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin3-6/+4
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-18 10:45:57 +0000