summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2015-03-24tdf#90095 Fixed wrong behavior of template delete dialogMichael Horn1-2/+2
The template delete dialog was coded in such a way that the default behavior was to delete the template/folder unless the user pressed no. This caused the template to be deleted if the dialog was closed using the "x" button. I changed the logic so that the dialog will only delete the template if the user presses yes. Any other button press will do nothing but close the dialog. Change-Id: I7977fd48b3e0cc440cc1e15056b448e7ae23476f Reviewed-on: https://gerrit.libreoffice.org/14937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 093846124b06961daa400735eaf0d50115cf8690) Reviewed-on: https://gerrit.libreoffice.org/14963 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-01-20fdo#88241 Floating sidebar second call to same item should dismiss itTrent MacAlpine1-2/+11
fixed in master by commit# 592984cea1a9cc545358b8d6077113a658834aa5 Note that this was written to be used in combination with commit 304e2002a053e9eb54e36462165eca831da8aeb2 to give back the behavior of calling and dismissing the styles and formatting dialog. Change-Id: I087f60c4bc0fa46b59bc17abf447553d7fda4074 Reviewed-on: https://gerrit.libreoffice.org/14027 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-20fdo#87217 Inconsistent floating sidebar close behaviorTrent MacAlpine1-11/+2
fixed in master by commit# 304e2002a053e9eb54e36462165eca831da8aeb2 Remove code that caused an undocked sidebar to reenable a docked sidebar when you attempt to close it using the window manager. It should simply be closed instead. Change-Id: Iabf45d5f7e81408e2e18d2fbad817ab34a9f3549 Reviewed-on: https://gerrit.libreoffice.org/14025 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19fdo#86147: Do not reset r/o mode for SID_SAVETOStephan Bergmann1-2/+7
...(aka "Save Copy as...", as is used when the document is actually a DB form) but only for true "Save As..." For reasons remaining un-debugged, calling SetReadOnlyUI(false) on the former would somehow lose the connection to the embeddedobj Interceptor instance. (cherry picked from commit cfce342e6bba803349f9234bdcd9351df68be824, plus trivial "nullptr" -> "0" de-C++11-ification) Change-Id: I334cd6c5ebd596e408357bb6820800075217d2d1 Reviewed-on: https://gerrit.libreoffice.org/14016 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19Re fdo#80538: Remove read-only infobar after "Save As..."Stephan Bergmann1-0/+1
...on a doc in r/o mode, which will switch to the newly saved document in r/w mode. Was missing from c6270de939d5ee51b61dc4ac02c52f1d9b5b1e47 "fdo#80538 Show an infobar when document is in read-only mode." Change-Id: Ie17f4213f989cb4b9d3f7fc114392ec6f516a965 (cherry picked from commit 02f76dec4c54ec7fb28729941c7044307058665a) Reviewed-on: https://gerrit.libreoffice.org/14012 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-15Resolves: fdo#87353 Start Center 'Help' button not functioning any moreCaolán McNamara2-2/+18
Change-Id: I81607ea1951c4a71c003e639b3ebe871a6943374 (cherry picked from commit f2efbca82d70451b0e8582bb699f33d709152e24) Reviewed-on: https://gerrit.libreoffice.org/13901 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-07fdo#87031 Sidebar tabs not visible when Sidebar deck is shownSamuel Mehrbrodt1-1/+1
Change-Id: I292421770f02436819d1361c4ba9a6fa4dbaf35c Reviewed-on: https://gerrit.libreoffice.org/13312 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e9dd158a866e60ffa5e3724f4aafdfca793da80a) Reviewed-on: https://gerrit.libreoffice.org/13501
2014-12-11Remove resizable:False property from dialogs containing GtkEntry.Jan Holesovsky4-4/+0
As agreed with Adolfo (and others) at the Design hangout on 2014-12-10. Change-Id: Ibe0e8075566523e746866b9d2c15c348c345d2df
2014-12-06fdo#72811: Revert "Broken security/password when saving to older odf (sx?)Michael Stahl1-1/+1
... formats." This exports ODF 1.1 files as ODF 1.2 packages, which is quite wrong. Since we don't support OOoXML export any more, just revert it. This reverts commit 06b918053fb9cf455cf431ca001a63030092d018. (cherry picked from commit ebfec3517d001f8aa8baaabde7c4af6b01347b95) Change-Id: I27bdd83f96e46be054f808ff6782ad16ecc90da5
2014-12-05sfx2: reset the error code before 2nd load with repair (related: fdo#56245)Michael Stahl1-0/+1
(regression from c7c385bb8e42d2051bcf05fd75b2146fe9852317) Change-Id: I39eca96b45ad974a7e1a6913aa811c6b03ceced7 (cherry picked from commit ef1f3b6713118c5eb43da7fa85caf40107b468c1)
2014-12-04fdo#85937 Add 'Close Sidebar' command to Sidebar menuSamuel Mehrbrodt3-0/+16
Change-Id: I83248398a9a8f2a8abb4e10d7ef9f1c203dddbf5 Reviewed-on: https://gerrit.libreoffice.org/13297 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-01Resolves: fdo#86799 fix insert special char in Find/Find and ReplaceCaolán McNamara1-1/+1
regression from 7f7d2213209dd8e23292ec5a85fbab6127824c49 author Caolán McNamara <caolanm@redhat.com> 2014-10-13 09:25:26 (GMT) osl_Module -> osl::Module Change-Id: Idb8fec23bdd0ee3ea0488047aadaf21e3cd2900f (cherry picked from commit 8fc14413d9dadede63743ec76603d95eb587f580)
2014-11-24sfx2: add missing locks to FrameActionListenerMichael Stahl1-0/+4
Change-Id: I67db5c42d1aea39cbf650de7854be853fc78e8a9 (cherry picked from commit 4950c30e633ac2d1a12a9e4b086478ac7d4f790c)
2014-11-24fdo#86633: sw: remove bad tab pages from SwParaDlg for drawing objectsMichael Stahl1-1/+2
"Area" and "Transparence" only supported by Writer paragraphs. (regression from 7d9bb549d498d6beed2c4050c402d09643febdfa) Change-Id: I732e8d40fdeafaebf219fc7c5ddd53b850d8eca6 (cherry picked from commit 5c31a1b5474f5284cf694d04de5734921891915c)
2014-11-23Default to collapsed sidebars everywhere but in Impress.Jan Holesovsky1-0/+13
Change-Id: I2fe092189c922ddf36efc8dd8d0fba14f91fc0b0
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18Resolves: fdo#75066 add TABSTOP and DIALOGCONTROL bitsCaolán McNamara1-1/+1
to this custom widget to state that is is a candidate for tabstopping to, and that its a (old-school) container widget which has subwidgets which should be candidates too Change-Id: I39452f906b30c3962026ab9c4dba625ecd2d06a8
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl7-4/+9
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17fdo#85478 Avoid destroying bitmaps after VCL is shut downMatthew J. Francis1-23/+5
Change-Id: I1ece738e7f60b6bbbdc802339f8b9deec9396e1b Reviewed-on: https://gerrit.libreoffice.org/12469 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna1-3/+3
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-16vcl: let the ModelessDialog ctor take an OUStringMiklos Vajna1-1/+1
Change-Id: Iae88a9889c674337fb999a23a799d8730d2793d5
2014-11-15TabDialog ctor: take an OUStringMiklos Vajna1-2/+2
Change-Id: Ie390fb9debe3a80b3ebc5e609119723c78eadba2
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava15-19/+19
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl1-0/+1
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-12coverity#735490 reimplement bit countingCaolán McNamara1-12/+7
with a classic solution rather than a bizarro one that confuses coverity Change-Id: Id9427a47693897683193c0c778f0cd6c39740f6f
2014-11-12sal_uIntPtr->sal_uInt32 for BitSetCaolán McNamara2-14/+14
because this ancient horror expects a 32bit type here Change-Id: Icf8b775ea67afa0ead559a55b8c335ad1afc4010
2014-11-12ditch this unused idpool horrorCaolán McNamara3-58/+0
Change-Id: I527b310126518357f9830f75d16b4848c9383999
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini32-56/+56
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84582 : fixed label in the 'Insert Version Comment' dialogSzymon Kłos3-1/+9
When user's data are empty, dialog shows "(no name set)". Dialog: Writer->File->Versions...->Save New Version Change-Id: I6780cbe452fbc206b3e153975dbb1c1d9570718b Reviewed-on: https://gerrit.libreoffice.org/12307 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-11HIG fixes for sfx2Adolfo Jayme Barrientos20-389/+213
Change-Id: Ide13fff6a3d5d82847c4886967283cb4b59bcfbb Reviewed-on: https://gerrit.libreoffice.org/12321 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin1-1/+1
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-09SfxTabDialog ctors: take an OUStringMiklos Vajna2-5/+5
Change-Id: I91b9b2ffd19b2412ac01dd12429d6460b4c4812c
2014-11-09fdo#82707 Unify click behavior in Statusbar (Writer)Samuel Mehrbrodt1-4/+4
Use single click for primary action, right click for context menu Change-Id: Ia707a88b48f4af144588c45d37acea547e77773e
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin1-3/+3
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann11-21/+27
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin11-27/+21
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#67627 fdo#85791 Allow to show/hide sidebar decks with the same commandSamuel Mehrbrodt6-4/+36
This also reintroduces the code to switch the decks asynchronously (removed unintentionally before) Change-Id: I825b4d7c5777097e9d3b3d82adbe1f646510dc9d
2014-11-05markup with event type not checker typeCaolán McNamara1-0/+1
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin1-1/+1
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-24/+20
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin5-11/+11
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31Removed duplicated includesAndrea Gelmini1-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin1-1/+1
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30HIG fixes for Document Properties dialogAdolfo Jayme Barrientos4-37/+47
* Add missing colons to labels that precede controls * Standardize Help button’s position * Better label for Add Property button * Add a frame for the lonely Embed Fonts option Change-Id: If12708161f2345e66ab3f49fd744bcad00d4ecc6 Reviewed-on: https://gerrit.libreoffice.org/12096 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-29Resolves: fdo#85111 put a border around the custom properties boxCaolán McNamara1-5/+19
Change-Id: Ibdbfb4a88c1c75aaf5d33672d8639a9ea55afbac
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin9-9/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29coverity#1028106 Dereference before null checkCaolán McNamara1-16/+0
Change-Id: I77a910542cf1b7889f69a1d3b7989779d9ecc7e8
2014-10-29ref-counting vcl::Window subclassesNoel Grandin1-1/+0
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-28coverity#704019 Unchecked return valueCaolán McNamara1-2/+2
Change-Id: I605861dd741b1899924c0079b931da418be5d647
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 16:56:31 +0000