summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2015-04-15fix crash on re-export of fdo50057-2.odt to odtCaolán McNamara2-7/+15
(cherry picked from commit 66c9aec156d974b939b680dccbb27e18fb153a23) Conflicts: sfx2/source/appl/fileobj.hxx Change-Id: Ice7a754dd4f42b5cf62ae2038b63d893b8a92fd8 Reviewed-on: https://gerrit.libreoffice.org/15326 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-12-07fdo#72811: Revert "Broken security/password when saving to older odf (sx?)Michael Stahl1-1/+1
... formats." This exports ODF 1.1 files as ODF 1.2 packages, which is quite wrong. Since we don't support OOoXML export any more, just revert it. This reverts commit 06b918053fb9cf455cf431ca001a63030092d018. (cherry picked from commit ebfec3517d001f8aa8baaabde7c4af6b01347b95) Change-Id: I27bdd83f96e46be054f808ff6782ad16ecc90da5 Reviewed-on: https://gerrit.libreoffice.org/13325 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-11-01fdo#71248 Excel VBA: ActiveDocument is not tracking currently selected DocJustin Luth1-1/+1
Change-Id: I86606646206ec26e2822a6e27888537d44351b7b Reviewed-on: https://gerrit.libreoffice.org/11725 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> (cherry picked from commit 4108bd9b7a41eaa0f3bf8b8173f27f57e009ee34) Reviewed-on: https://gerrit.libreoffice.org/11827 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
2014-10-22error: 'fprintf' was not declared in this scopeMiklos Vajna1-2/+0
Change-Id: Ib7730481bdefdd33fd8354ff6f5bba36fc27c2fd
2014-10-20Resolves: fdo#72587 make template dialog ModalCaolán McNamara3-3/+8
(cherry picked from commit 60126254eba8a6a6b94c60b2101ee90986161e24) Change-Id: Ifb6d7ebbe297d17fc99426b501c92daf8577dd20 Reviewed-on: https://gerrit.libreoffice.org/11978 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-09sfx2: missing semicolonMiklos Vajna1-1/+1
Change-Id: Id1c6357c84e03c71136eb92434002e5e0a4b71d7 (cherry picked from commit 86c4762790823c338f018fb2f06c4a5fa4497916) Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-08Do not terminate desktop from a TimerStephan Bergmann1-18/+1
<sberg> kendy, as you recently changed Timer handling on Windows: debugging why quickstarter no longer works on Windows, I run into the phenomenon that IdleTerminate::Timeout (sfx2/source/appl/shutdownicon.cxx) executes on the main thread, and from within the m_xDesktop->terminate() call Timer::ImplDeInitTimer is called which deletes the pTimerData corresponding to our IldeTerminate, so that Timer::ImplTimerCallbackProc, after the return from IdleTerminate::Timeout, will operate on a stale pTimerData and crash; could that be related to those recent changes? <kendy> sberg: I think mst told that we were previously never deleting the timer, and that he did some changes there [...] <mst__> sberg, IdleTerminate needs a different implementation <mst__> sberg, does it work to do this via PostUserEvent, as "Application::Quit()" does? <sberg> mst__, do you think calling terminate from a Timer did work in the past? [...] <mst__> sberg, perhaps it did before [a recent] commit but i would guess it would be more by accident than by design Change-Id: I23b14ba59a963cc2209a261a1459d532a88acdc0 (cherry picked from commit d8a0ecc94bfbfc1d9c8403f0e894d3b7e40384f2) Reviewed-on: https://gerrit.libreoffice.org/11852 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-10-08Don't even attempt to unload libqstart_gtklo.so againStephan Bergmann3-109/+54
...for no apparent gain. IdleUnloader introduced in a8b42ddd66bba4b6f26a4d2d793051752989938e "Fix i#101245#" was probably a misguided reaction to osl::Module's dtor starting to call dlclose back then. (cherry picked from commit 73aaa3cf5e18d008268f4b67bbb60070b2cafc6a) Conflicts: sfx2/source/appl/shutdownicon.cxx sfx2/source/appl/shutdowniconunx.cxx Change-Id: I9a5e99d8cfba13e3750331597d64f58135537e9b Reviewed-on: https://gerrit.libreoffice.org/11851 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-10-08fdo#80927: css.office.Quickstart should be single-instance service.Matúš Kukan2-1/+23
Incorrectly converted in a384b21cc40818bf3c918951a086a30b5d9d8022 where SFX_IMPL_ONEINSTANCEFACTORY was used. AFAICS it's the first converted single-instance service which implements css::lang::XInitialization. That's kind of strange but can do its job. sbergman@redhat.com: Three things were necessary in order to not call the ~ShutdownIcon code too late during exit now: * Move the relevant code from ~ShutdownIcon to ShutdownIcon::disposing. * Add a dummy <singleton name="com.sun.star.office.theQuickstart"/> so the service manager will eventually dispose the (single) instance. * In cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments do not shortcut updateDisposeSingleton in that odd case of calling createInstanceWithArguments on an implementation that (effectively) is a singleton (as otherwise the service manager would still not dispose it). It looks to me like that "return inst;" was an inadvertent leftover in 874c481801434d4fac3c50f076bff0fe3a3988b6 "Simplify service manager's tracking of singletons" and wasn't intended to serve some subtle purpose. Change-Id: Icd4d3168ec0bbb820b17ac321fe897ac9f9ce7fc (cherry picked from commit 98bb53a5609f8651b0841e8326d7aa53fd56ab3b) Reviewed-on: https://gerrit.libreoffice.org/11850 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-09-26fdo#82043: Instead of the bold font, use a higher multiplifier (4.3 backport)Yousuf Philips1-1/+1
Change-Id: I835e5c645ef52f23254178c782f2d484c5c0d20f Reviewed-on: https://gerrit.libreoffice.org/11651 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-15Resolves: fdo#81635 crash after 3rd call to ApplicationScriptLibraryContainercp-4.3-branch-pointCaolán McNamara1-6/+6
in PackageImpl::processPackage_ xComponentContext->getServiceManager()->createInstanceWithContext( "com.sun.star.script.ApplicationScriptLibraryContainer" does not increment the refcount, so on leaving the method the refcount is decremented by 1, because on the first enter the refcount happens to be three, then if the extension has more than 3 items in it the refcount hits 0 here and falls over some of fdo#79301, fdo#70607, fdo#66706 might be dups of this regression from 306efefe22e02248eff14f8be2cef68d75d26e55 I believe (cherry picked from commit 9128507579246b1559b0bc195d7e9f89541cbbbf) Conflicts: sfx2/source/appl/appbaslib.cxx Change-Id: I3da50693fe656b68c5555b641d9b32246c8fc208 Reviewed-on: https://gerrit.libreoffice.org/11457 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-04fdo#44081 don't remove 'edit' pop-up menu entry from form in design modeLionel Elie Mamane1-2/+9
Conflicts: sw/source/core/uibase/app/docsh.cxx Change-Id: I009b0e1a155c298bd7f461547125df4ba76805d9 Reviewed-on: https://gerrit.libreoffice.org/11232 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-09-04fdo#82278 SfxUInt16Item -> SfxInt16ItemMaxim Monastirsky2-2/+2
A regression of 2245288574ef77b09416872326b4543c82790815. VerbID can be negative. Change-Id: Ib242376696346ab310031d1b7c5c74362fb4b3d1 Reviewed-on: https://gerrit.libreoffice.org/10823 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 154c20cb320fb62cdd54cd248c3b981acc3903c8) Reviewed-on: https://gerrit.libreoffice.org/10858 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-08-26fdo#80755 Don't generate thumbnails for encrypted filesMaxim Monastirsky1-1/+3
(cherry picked from commit a75e0f8e4e5f0baa5805d01c5f8edc7b40fceb0f) Change-Id: If52532b8e8ca38e82fd95c13080d521d9cb529aa Reviewed-on: https://gerrit.libreoffice.org/11120 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-12Resolves: #i125386# secured user request and changed some bools to bitfieldArmin Le Grand1-1/+11
(cherry picked from commit 5e3cbe056c19bea5018dbf1fd4b2bc8f8b030ff3) Conflicts: comphelper/inc/comphelper/embeddedobjectcontainer.hxx comphelper/source/container/embeddedobjectcontainer.cxx sfx2/source/appl/linkmgr2.cxx svtools/source/misc/embedhlp.cxx Change-Id: I7e9b20a87ca6afe8cb91c577860a6c6b72368ee9 (cherry picked from commit d005acae3aa315921f2c331612131626c470bd22)
2014-08-07rhbz#1079672: FileDialogHelper: don't hand out stale preview GraphicMichael Stahl1-13/+10
The maGraphic is updated from a timer, and if you double-click on a file then the dialog may exit with the previous file still previewed in maGraphic, so the wrong image is returned by the dialog. Change-Id: I99094d85d8d68d5c8a842f52e7039dbbbf095995 (cherry picked from commit f1589f768bbd1d8baea6e442f392831851bdbb3b) Reviewed-on: https://gerrit.libreoffice.org/10802 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-06hidpi, startcenter: Don't set fixed font heigt in the startcenter.Jan Holesovsky1-12/+13
Change-Id: I68efbd08d21b514ab1659cd6bddfc2c4788c4a74 Reviewed-on: https://gerrit.libreoffice.org/10682 Reviewed-by: Zolnai Tamás <tamas.zolnai@collabora.com> Tested-by: Zolnai Tamás <tamas.zolnai@collabora.com>
2014-08-04avoid buffer overflow by using wrong bufferMarkus Mohrhard1-1/+1
Found by Asan. (regression from CWS mba34issues01) Change-Id: Ia7159c9bed9d7f823448acd02e18568a5f3f2093 Reviewed-on: https://gerrit.libreoffice.org/10717 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 955c5539a1ea5e971f111989d6c5bec11d936416) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2014-07-30Related: #i125226# expect DDE servers to be already upHerbert Dürr1-61/+11
"soffice" is always up anyway and other DDE apps should be started manually (cherry picked from commit e0bfdb26cef87c8d3b3435293116a33cf99c11f0) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I52ebb26528952a4abf33ac95cb67c598f08b2790 (cherry picked from commit f4a8d7cd10cda57143b22519e16cdf8d5f19e759) Reviewed-on: https://gerrit.libreoffice.org/10288 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-07-29Resolves: fdo#81641 the new style shouldn't be a conditional styleCaolán McNamara2-11/+19
regression from commit 715d79bcc59d68c77dc84a1038998dd873df92e9 Author: Cédric Bosdonnat <cedric.bosdonnat@free.fr> Date: Fri Nov 30 11:51:46 2012 +0100 Styles & Formatting: added SFXSTYLEBIT_ALL_VISIBLE and show hidden styles commit 2fd9c2bf9af0c50dae3af3dbe5e22965ccdb4ae7 Author: Cédric Bosdonnat <cedric.bosdonnat@free.fr> Date: Sun Nov 25 15:24:42 2012 +0100 Allow to hide styles in the "Styles & Formating" dialog In its current state, the feature only hides the styles. Things to sort out are: + Add some automatic filter to show hidden styles + Make the visibility persist in the file format (cherry picked from commit 1af0e46102350114dd5e854b7692c640dae2727f) Conflicts: sw/source/uibase/app/docst.cxx Change-Id: I7244d424765db0d5ed3aeaf380a8e1af56aa7eaf Related: fdo#81641 exclude 'all styles' category from organizer page it doesn't make sense to be able to assign a style to 'all styles' Change-Id: I632c62f293b553e436ceb8da0baf2bb39941fd39 (cherry picked from commit 2223ff6cb99df097a357674801835c7a260b551d) style category listbox depends on being unsorted regression from commit 6ecfbf153a7c11c63d208630ac6a27064058099d Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Mar 13 15:10:25 2013 +0000 drop unused resources and toggle label to activate replacement widget Change-Id: I65ca8ec58ed984120f3c2e7ba68507cbf8acf089 (cherry picked from commit 11fab6b705638359b2ca0e3e85590aa7cc70a03a) Related: fdo#81641 create new styles with an initial name instead of creating with a blank name and changing it later this way undo of a style creation is initialized with its name and so create a style followed by deleting a style and undoing all those steps doesn't crash (cherry picked from commit e904562af54545684b32d2042ded6bdb9459edca) Conflicts: sw/source/uibase/app/docst.cxx Change-Id: Ida7a34410d5d7b05edcb86950aabb3c672b82c8f Reviewed-on: https://gerrit.libreoffice.org/10502 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-25Related: fdo#81457 skip setting an empty allocationCaolán McNamara1-19/+44
if the dimension is 0, don't bother calculating a bunch of <= 0 sizes, rely on the parents clipping to hide the lot instead Change-Id: I5b593a5b6b6c3614beb7f9bf3328fa469b700972 (cherry picked from commit 13807fbf9f3a4aae6767da8bcf796bea4b065159) and Related: fdo#81457 quadratic time required when setting a11y name when calling SetAccessibleName GetAccessibleName is called in order to send a name changed a11y event. Getting an Accessible Name is very slow in a non-layout aware widget because it scans for a "nearby" label and there is none in this widget, but it has a huge pile of other widgets to iterate over. call add_mnemonic_label before hand to cut off that entire branch. While we're at it, only call InitControl to adjust to a new width if the new width is different from the old width Change-Id: Ie4ba1276127226e49442278e46447b84bbeb1cde (cherry picked from commit aff263c8b814c6bf352312403d3c1e448c8013a3) Reviewed-on: https://gerrit.libreoffice.org/10461 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-25Remove 1 px border around Start CenterAdolfo Jayme Barrientos1-1/+1
It leaks workspace background color (behind the sheet in Writer etc.), which looks bad as it's much darker now under Windows and OS X. Change-Id: I29034be86d3cf5537384b325fc6734b4dc05f077 Reviewed-on: https://gerrit.libreoffice.org/10521 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0867b96d84a2da081b648fe33a1009c820bf9f40) Reviewed-on: https://gerrit.libreoffice.org/10529
2014-07-24Resolves: fdo#80476 Start Center sidebar button are too largeCaolán McNamara1-5/+6
Change-Id: Iedf67b5591d84963e1caf3e8d9d17d42175bb604 (cherry picked from commit 9a5e81fa80d1e90bd73ae4e19c89b28537aed334) Reviewed-on: https://gerrit.libreoffice.org/10512 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-07-22fdo#81304 don't parse file name as part of URLDavid Tardon1-1/+2
... because the name is not URL-encoded at this point, so parsing it as a part of the URL will interpret special characters, e.g. #. Change-Id: I780baed1753e9674d835dc296d31c088b67d8ba7 (cherry picked from commit f3d7734af45f30a87d6de76aa3de7593d541bdc8) Reviewed-on: https://gerrit.libreoffice.org/10294 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-07-21fdo#63756 build libxml2 with ICU supportDavid Tardon2-8/+8
Change-Id: I0523e49e640812be435ba4c97b1881ca253eb2ab (cherry picked from commit 7515b1a90fac9e31733c0fdcc1156adadf0e6f99) Reviewed-on: https://gerrit.libreoffice.org/10428 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-11Related: #i125226# don't try to access known-bad DDE serversHerbert Dürr1-4/+15
(cherry picked from commit 88de6a59d9d7933b86fdcba733277aa4fbd5e132) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: If4dcd49cfe15188d06e4e06cd8e58cdcc66ed5a4 (cherry picked from commit b16f164650f8345e51bf0b0c73bf9c8eee775bc2) Related: #i125226# some macro preferences are directly... applicable to DDE servers (cherry picked from commit 2c835e761e1e9ddb6794895e6f3538b918160dd1) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: Ic16b3df34ac1b003a8a5cabab15ea655d05bdd18 Related: #i125226# typo fix (cherry picked from commit 727ea069c6342e01a50c8b068ec302574b251cbd) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I8db53b7e8529d05e660a2d69e669b44c9045712c (cherry picked from commit 13b68e24db26374ca17572de9abb429edeac32e9) Related: #i125226# disallow absolute and relative paths for DDE servers (cherry picked from commit 6b64ada6e3a902ac4b44fe49476514d49138d4d4) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I127add375a127dbbd0eaf12a10884e2636f1a332 (cherry picked from commit d1fc47793c1efbe9ff5271656283211647dd0b33) Reviewed-on: https://gerrit.libreoffice.org/10200 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-04fdo#78908 Revert "Merge back branch alg_writerframes to trunk"Miklos Vajna1-14/+2
This reverts commit 6e61ecd09679a66060f932835622821d39e92f01. Better not to have this on libreoffice-4-3 without 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02). Conflicts: cui/source/inc/backgrnd.hxx cui/source/inc/cuitabarea.hxx cui/source/tabpages/backgrnd.cxx cui/source/tabpages/tparea.cxx include/basegfx/numeric/ftools.hxx include/svx/svxids.hrc include/svx/unoshprp.hxx sc/source/ui/drawfunc/drawsh.cxx sd/source/ui/func/fuarea.cxx sfx2/source/dialog/tabdlg.cxx sw/inc/fillattributes.hxx sw/inc/format.hxx sw/inc/frmatr.hxx sw/inc/swatrset.hxx sw/inc/unobrushitemhelper.hxx sw/qa/extras/rtfexport/rtfexport.cxx sw/source/core/attr/format.cxx sw/source/core/attr/swatrset.cxx sw/source/core/doc/docfly.cxx sw/source/core/doc/notxtfrm.cxx sw/source/core/inc/frame.hxx sw/source/core/inc/frmtool.hxx sw/source/core/layout/fillattributes.cxx sw/source/core/layout/paintfrm.cxx sw/source/core/txtnode/fntcache.cxx sw/source/core/uibase/shells/frmsh.cxx sw/source/core/unocore/unobrushitemhelper.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unostyle.cxx xmloff/source/text/txtexppr.cxx xmloff/source/text/txtprhdl.cxx Also: Revert "cppcheck: Prefer prefix ++/-- operators for non-primitive types" This reverts commit 80ec4885e97b3fcb34b93e71ced52a4aab43ce93. Revert "WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'" This reverts commit d5d10b03b1f3e4bf784ad35254cb55d719a8c1b3. Revert "i#124638 support for DrawingLayre FillStyle for GraphicFrames and ..." This reverts commit 4a0b5e569d070c286daefb0fdfe45c0dd15d241c. Revert "svx: fix SID_OFFER_IMPORT and SID_ATTR_CHAR_GRABBAG having the same SID" This reverts commit b66d87086804460c1986df1b832fd6b2ea075a90. Revert "SwXStyle::getPropertyValue: don't try to read a float into a sal_Int32" This reverts commit 1e3c7b854baac2502bed72ff8e3e1b21b507735b. Revert "SwXTextFrame: also restore semi-lost BackColorTransparency property" This reverts commit 102bb87ca1a5dee3a09442bf503a54bb703c79ea. Revert "SwXTextFrame: restore semi-lost BackColor property" This reverts commit 5ce92b73ce06c805c66e53c48aa2c70c722aaf60. Revert "DocxAttributeOutput: port to FillAttributes" This reverts commit ec221b7339f8fe5520926ef85b450daa94392780. Revert "MSWordExportBase::OutputItemSet: handle fill attributes as frame ones" This reverts commit 84c40768f8acb0342dcfa223133497f57620fc14. Revert "sw: put getSvx* and setSvx* to a namespace, now that these are public" This reverts commit ebf960960a69c1edb5da1994c330ddddbecac44d. Revert "sw: fix DOC/DOCX/RTF export of TextFrame background color" This reverts commit c7837b8caad61b8c0dfd3704a133cdeaffd69b06. Revert "sw: still use SvxBrushItem for page style background" This reverts commit e826950e9d7736a6e3f9042755ba1b528f58a505. Revert "cui: unused code in SvxAreaTabPage::ClickBitmapHdl_Impl" This reverts commit 2032e9f5d7683e49b8753d7c7362899c690005b6. Revert "cui: unused code in SvxAreaTabPage::ClickGradientHdl_Impl" This reverts commit f4fa202b31277276dc4f05046c82152c0830ef21. Revert "cui: unused code in SvxAreaTabPage::ClickColorHdl_Impl" This reverts commit 1478e89e08a54f02a137c74c0cde6ae75e80d9f3. Revert "cui: unused code in SvxAreaTabPage::ClickHatchingHdl_Impl()" This reverts commit e9c9f3f793a91525ac4fb74f8791ba74222515e4. Revert "svx: fix Writer's insert -> frame crash" This reverts commit 831b8751fc9f423fd4e459623e54801c0a020eb3. Revert "sw: adapt frame/templatedialog4.ui to FillAttributes" This reverts commit 55916fc50a5b2d6273bca8c9ef6253011cf4fdbc. Revert "-Werror,-Wunused-variable" This reverts commit d0542fe7251d9c6538331b22a4b5e2e294a92e97. Revert "loplugin:implicitboolconversion,literaltoboolconversion" This reverts commit 47862e75de51a4ac7476acff773b504fdc0d6e76. Revert "loplugin:saloverride" This reverts commit be89e8b8ac19c0feca8850ccaddd90205c63dbe5. Revert "loplugin:literaltoboolconversion" This reverts commit 355b31fe347479f63906e41300042ec5cb38837c. Revert "-Werror,-Wunused-private-field" This reverts commit df9d13dd2e754184a4c6e321b8910ee1bc0cafa1. Revert "-Werror,-Wunused-const-variable" This reverts commit d757a98001a65baf4066c2eda037a08ab1beda46. Revert "unused XFillStyleItem ctor" This reverts commit b735fe1d67e6ad7ad448e448f237dcabef1a1c38. Revert "unused XGradient::VclGradient" This reverts commit 5bbc90be755aae4b87125f9d748828d74efe645d. Revert "fix "transparency" of floating tables in docx import (fdo#77723)" This reverts commit 313b59d787357ef3da34e2833fefcf1143b09b5e. Change-Id: If855b090f94288d384f8733f88ef1172e68c50a6 Reviewed-on: https://gerrit.libreoffice.org/10077 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-06-27Related: fdo#65634 make sidebar react to resizes when floatingCaolán McNamara1-29/+41
the parent isn't a SfxSplitWindow in this case, but it should still react to the resize Change-Id: Ia298d45b33fc272d6169df12cf2c58a881255163 (cherry picked from commit df630b8f8c2c92ec2cd1e4be6a3f54a4e4960e92)
2014-06-27clang: Use-after-freeCaolán McNamara1-4/+12
Change-Id: I5dd857dbf39c8cd62df8b8cd0323b873a79976ae (cherry picked from commit 112645f75816c4902ccf8a2a97ef57e8f13429b8)
2014-06-23fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida1-0/+17
(cherry picked from commit 1d38cb365543924f9c50014e6b2227e77de1d0c9) Conflicts: sd/source/ui/view/sdview3.cxx xmloff/source/chart/SchXMLExport.cxx Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a Reviewed-on: https://gerrit.libreoffice.org/9836 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-06-10fdo#79676: Fix the Java UNO API test with regard to chart tests.Kohei Yoshida1-0/+4
The Java tests rely on the "undocumented" behavior that, when loading an empty chart document, the chart automaticallly created a "default chart" which is a column chart with many of its properties filled. Unfortunately this behavior caused ugly side effects when loading documents with charts via flat ODF filter. I believe fixing the test this way is the right fix. Change-Id: If3e6c8979da9d0731346ebeedc23c0d3363e83fd (cherry picked from commit d44b58beed743871df03909e7d9545e488f3d7c8)
2014-06-06html export: More standard time specification in <meta/>.Jan Holesovsky1-15/+8
Change-Id: I1a62d12531029cc36fb8aeabecb9d92a8af837f7
2014-06-06html export: Close the <meta> tags.Jan Holesovsky1-1/+1
Change-Id: Icca58dd1531f2442fe5878ed9524a3611c0601ea
2014-06-05fdo#79597 Password UI: correct typo for 1 characterLaurent Balland-Poirier2-3/+14
Display a different string in case of 1 character for minimum length Change-Id: Iba2fbbb7d4101718def7c79ce5354debf5d97041 Reviewed-on: https://gerrit.libreoffice.org/9631 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a4440671a9de18ebf944ed09c432a98908d79f5e) Reviewed-on: https://gerrit.libreoffice.org/9646
2014-05-30Resolves: fdo#79360 impress hangs on using sidebar new styleCaolán McNamara3-47/+21
because those styles are "pseudo-styles" and a new one cannot be added. The possibility is supposed to be disabled, and it is disabled in the floating stylelist. The old code assumes there can only be one of these stylelists and when a stylelist queries if the "new" should be disabled the callback asks the stylelist what family is selected, but only asks the floating one. So, floating closed, sidebar open, the new is not disabled. Implement the ancient TODO now that we have to. Instead of asking the stylelist what family is selected, query the frame for what is the current SID_STYLE_FAMILY as set by whatever is the active stylelist. What's disturbing is the SID_STYLE_FAMILY values are not SfxStyleFamily, but indexes that have to be mapped to SfxStyleFamily. I bet there are a pile of bugs around that, especially with little islands of different conversion codesites (cherry picked from commit 7a211e834fc271d3f28d7f8c49197c925242d862) Conflicts: sfx2/source/appl/appmisc.cxx convert from NId to FamilyId instead of FamilyId to NId should be equivalent for comparison purposes (cherry picked from commit f48f5138ecedd3bb9ec0b454b9fe216001610156) remove unused virtual method, slim this down initially (cherry picked from commit fa551c422426962194b6bff4234f12eb5bdf57ca) Change-Id: I85c8032d7c26ae6eea245685748f89b2a860e767
2014-05-29speed-up writer conversion in headless modeTomaž Vajngerl1-1/+1
Change-Id: Ie5ccd62608c0643e3c8f019aea136ba74b282274
2014-05-28Related: fdo#79142 make SetName default to ReindexingCaolán McNamara1-11/+3
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5 (cherry picked from commit 05e2fd162ef86ebe4ea2a2a679cabeae33e844f0)
2014-05-28Resolves: fdo#79142 When Creating Styles - The 2nd One Always Replaces the 1stCaolán McNamara1-3/+11
regression from 0c17ccc493d0c7a80f37600dae76a09a119bef78 I think it might actually make more sense for SetName to always Reindex and have another SetNameNoReindex for selective use where its known safe to get away with it Change-Id: I6bf7e1f45130f741954ab525b838f3ac5ff61a89 (cherry picked from commit aa8b268935b07c9bf95a596ee84c76eed4c03634)
2014-05-27Resolves: fdo#79275 File Properties dialog’s layout is subparCaolán McNamara1-99/+87
Change-Id: I594d93c0630528841a1f243e6b6e9eda67b6138d (cherry picked from commit 9b47595a34c0b687cc02290b0a9cbf8508407082)
2014-05-25Resolves: fdo#79161 sidebar crash on deactivatingCaolán McNamara1-1/+4
Change-Id: I0d559bd8c16243fdc398f6bff0aa915a83a29dff (cherry picked from commit f3c9e8471a83e6ceb9258d3a4ab7d3354adcfb3a)
2014-05-22Update also revision and editing time when setting 'modified' properties.Matúš Kukan1-3/+1
Change-Id: Id756ef6dd62ca8df2e62265b9cc930f07d13f2e3 (cherry picked from commit 6e87f0bb75734e464bb0160dc00ab2fbe1a8fac3)
2014-05-22Use proper constructor to fill with system time.Matúš Kukan1-1/+1
Probably 86adb5cacb4fe3e7fb869299447da5876f0da30d did not mean to change the behaviour here. Change-Id: If39c150973c502323b3c785a9738cf65cdd74e5d (cherry picked from commit fee87c6fda46923a564cd2574827a7beeffb1a1f)
2014-05-22cp#1000077: Set 'modified' document property more consistently.Matúš Kukan1-0/+2
Update document info at one place, so that it works for other formats like .doc, .docx, ... too. Change-Id: If71799b491d2210f0d3bdbdb05f91f26c986a260 (cherry picked from commit 5c2ab70cc2dfb7cf0c2418433b3aa89d225742a4)
2014-05-21cp#1000072: Skip styles import for external link cache documents.Kohei Yoshida1-1/+5
This reduces external link update time by 10%. Change-Id: Ic14d9ea7530818f839330a2004f6aa67ef1e831e
2014-05-21Use varying aElement nameStephan Bergmann1-1/+1
Change-Id: Idc135ef5031a01961cc18d897a734b598bc833f4
2014-05-20Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18Julien Nabet7-56/+56
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20enhance pass-by-ref plugin to detect large argumentsNoel Grandin4-4/+4
Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-19Fix overriding exception specificationStephan Bergmann1-1/+1
Change-Id: I6eb46f1ffccc1d98b1a1485486cbc355ce296cd3
2014-05-19fdo#78536: sfx2: remove (likely) accidentally duplicated callMichael Stahl1-3/+0
It looks like commit dda842bec338efb06457551136678340d0718807 wanted to #ifdef this Execute_Impl() call but somehow duplicated it. Change-Id: I745e16cb0be19cf38eb70dd261204c879aa6986e
2014-05-19fdo#78536: sfx2: template dialog: make the am-i-dead-yet check reentrantMichael Stahl2-5/+11
In the fine tradition of our enterprise-grade code base, this lets the check in SfxCommonTemplateDialog_Impl::Execute_Impl() do an early return if the "this" instance has signalled its untimely demise even if there are multiple calls of Execute_Impl() on the stack; extending the scheme with further epicycles to make it work if the Execute_Impl() calls happen on 2 different threads is left as an exercise for the interested reader. (regression from bcc52fb2ebdf77a1cc089857775fd742085b45b6) Change-Id: I1d9f0d82bf6d9f5da8f9bd2be57d01937d71fd26
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-08 20:49:50 +0000