summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2017-02-28Run macro:// via LOKitKatarina Behrens1-1/+17
Change-Id: I54d3c734d86d4b44e1dfe1ad7728e2f51cd26d53 Reviewed-on: https://gerrit.libreoffice.org/34538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e7729f458409f7fef2b7dab752205e3b230acb65)
2017-02-28sfx2: fix incorrect debug outputPranav Kant1-2/+3
Fallback from 9351353b63886f494782f28f5400f5d71d22bcbd While at it, add one more such statement in Execute_ Change-Id: Ibebc6f007542751718b53ed978ee52c300d14439 (cherry picked from commit e4a0b50943921dcf6a914983cb693f9f6d20e145)
2017-02-28lok: listen for DeleteAnnotation state changesPranav Kant1-0/+1
Change-Id: I2ea0d237cbbfd912b012ed400a328bfb6546cdfb (cherry picked from commit 866582435fa8ea0a76ad08d07e7df3a344072c94)
2017-02-18Build the json message a much less expensive way.Jan Holesovsky1-10/+4
Change-Id: I10911deb52f6a0c65262f9d6af459cf6ddd2fae9 (cherry picked from commit 230f04e92d3a3c492e12e0ef2392fc45c73dd762)
2017-02-18loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin9-16/+14
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e6ffb539ee232ea0c679928ff456c1cf97429f63)
2017-02-17lok: Listen for state change events for cell alignment commandsPranav Kant1-1/+4
We used to use HorizontalAlignment uno command for cell alignment both in online and gtktiledviewer. To make things simpler, lets use separate cell alignment uno commands for spreadsheets like we have in writer and impres. Change-Id: I2a959d1892f6b02db7a9ce51d55309216e4b3c6c Reviewed-on: https://gerrit.libreoffice.org/33444 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit a27e09079596eeae81cced01eaeabf94d6675085)
2017-02-17lok: Fix state feedback for ToggleMergeCellsPranav Kant1-2/+13
Now it broadcasts "disabled" to disable the command and true/false to tell the status of the command which automatically means "enabled" Change-Id: I3314da77fb2b84d97f64b9832d65791b84fcd7df Reviewed-on: https://gerrit.libreoffice.org/32086 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit c5ceb0134dddb79207d3b8ddb7a36ee1ca294329)
2017-02-17lok: Sort ascending/descending is enabled/disabled statePranav Kant1-4/+4
... and not true/false Change-Id: Ie9ae6cbf70c1934dda1002deabda23c9f461c8b1 Reviewed-on: https://gerrit.libreoffice.org/32085 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 3ab307e568156b0fdafe1ee592870ef8c0e44750)
2017-02-11Resolves: tdf#101648 disable new/modify of table stylesCaolán McNamara1-0/+7
cause there is no ui for it at the moment, so it crashes Change-Id: I703449ff69f93b6385d3bf9225abe81682d3b893 (cherry picked from commit 5f8b6166115cd92bed202d3d8f2ce2d3f74256d4) Reviewed-on: https://gerrit.libreoffice.org/34099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-01Resolves: tdf#104884 print preview replaces the frame controllerCaolán McNamara1-0/+14
so the sidebar is listening to the old controller which has been disposed[1] so when print preview exits and yet another controller replaces the print preview one then the sidebar still doesn't listen to the current one. framework broadcasts COMPONENT_DETACHING/COMPONENT_REATTACHED around these changes, so if we listen to them we can keep attached to whatever is the current component [1] note that ContextChangeEventMultipler doesn't inform clients that the controller has been disposed, this remains unchanged here Reviewed-on: https://gerrit.libreoffice.org/33758 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3e27ba70ce212642026874ba73021930a06cdbbd) Change-Id: I141509d4a262307afd7dcfc3d77de6cdd6dbfa5f Reviewed-on: https://gerrit.libreoffice.org/33760 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-01-27Resolves: tdf#105450 calc navigator gets 0 height on toggle off/on when dockedCaolán McNamara1-8/+8
Change-Id: Icd346cdf0a208ccaeddd77e6803f4f906361324c (cherry picked from commit b37ac48935621fcc7b71f81a8b892f24e85e5b6f) Reviewed-on: https://gerrit.libreoffice.org/33498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-01-26tdf#101828 handle rtf/richtext correctlyOliver Specht1-0/+1
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 048e30c1f8231e6cd144a9251061f6fa127b353e) Reviewed-on: https://gerrit.libreoffice.org/33567 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-17sfx2: fix race in JunitTest UndoManager.checkBrokenScripts()Michael Stahl1-0/+5
1) checkBrokenScripts(complex.sfx2.UndoManager) java.lang.NullPointerException at complex.sfx2.UndoManager.impl_clickButton(UndoManager.java:432) at complex.sfx2.UndoManager.checkBrokenScripts(UndoManager.java:188) impl_clickButton() gets the wrong accessible object and throws. The .uno:SwitchControlDesignMode is dispatched async, so make sure it's processesed before trying to click the button. See UnoControl::getAccessibleContext() "in design mode, use a fallback". This was running in "rr record --chaos". Change-Id: Iee9f25c2fff56d32e6b579b5d44ee6df9870fd8b (cherry picked from commit e19cdeaf7ddbcf39da47d9685d8e79e775dde7f4) Reviewed-on: https://gerrit.libreoffice.org/33171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-16in extremis dump Ole10Native payload and launch system viewer on itCaolán McNamara1-1/+1
so embedded plain text documents/source code/etc in word documents can be viewed by us under Linux Change-Id: I19e19619070841fe097c70297adc2e8b96d1c581 (cherry picked from commit 75367918028dffb7a137d29644a7a6e1f7af7c9b) Reviewed-on: https://gerrit.libreoffice.org/32992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-11Bump copyright year to 2017Adolfo Jayme Barrientos1-1/+1
Change-Id: I26ddcdd7bb9616c0599eec9101603d4be1ea4147 (cherry picked from commit e5da108ef01872f460c176b6a9173e346e1d59a4) Reviewed-on: https://gerrit.libreoffice.org/32597 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-31tdf#105011, tdf#104795: copy string until its end if there's no commaJulien Nabet1-2/+4
5 0x00002aaab055f81e in rtl::OUString::copy (this=0x7fffffff29d0, beginIndex=3, count=-4) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223 6 0x00002aaab070acd2 in (anonymous namespace)::GetContentPart (_rRawString="CN=timur.davletshin@gmail.com", _rPartId="CN") at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:748 7 0x00002aaab070dd85 in SfxDocumentPage::ImplUpdateSignatures (this=0x55555ca2e0b0) at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:901 so do the same as GetContentPart from uui/source/secmacrowarnings.cxx (I suppose we should avoid the redundancy but that's another story) Change-Id: Ief3ce1cce7035fb572778bdee02a1073b7dfe1c1 Reviewed-on: https://gerrit.libreoffice.org/32530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 5e149b630bd837ca6c8cae609a5c148f25f9ee82) Reviewed-on: https://gerrit.libreoffice.org/32532 Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-31tdf#104622 Add duplicate node entry to elements in emoji.json databaseGaurav Dhingra2-349/+698
Add boolean field "duplicate": true Change-Id: I8e45ed4694bfc75b18c2405146e5eaa142559c1b Reviewed-on: https://gerrit.libreoffice.org/31997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> (cherry picked from commit 9fa5439cb6aa695ca2e3fefd4426bdd150091cbe) Reviewed-on: https://gerrit.libreoffice.org/32217 Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-12-14That's probably not meant to be a C++ reference to a uno::ReferenceStephan Bergmann1-1/+1
...as introduced with e75f6e549eb825c310d16d11babf0fba5ee7fd7a "sfx2: make SfxClassificationHelper not require a full doc shell". Made CppunitTest_sfx2_classification crash now when dereferencing m_xDocumentProperties in SfxClassificationHelper::Impl::pushToDocumentProperties, when built with a recent Clang trunk build. Change-Id: Id0b7fa0627b9642f748f07d7dfa05353114225fa (cherry picked from commit e90b004a41153770e672bb1d4524852499ab0ca5) Reviewed-on: https://gerrit.libreoffice.org/32002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt1-5/+30
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 0fda52cc4a5c78c55f96850faa734ea66891808c) Reviewed-on: https://gerrit.libreoffice.org/31937 Tested-by: Jenkins <ci@libreoffice.org>
2016-12-09Related: rhbz#1397939 crash with null pSidebarControllerCaolán McNamara1-2/+2
Change-Id: I7627ff30564b2de61669c71dafd15e7b1778b5c6 (cherry picked from commit f5edbb4158e86bfea7267115395b64e60fd61dc7)
2016-12-02usageinfo causes one of our more frequent fedora 25 crashesCaolán McNamara1-2/+10
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=17ba9a57f40d5ca29778866a9f96c1c0dfc7593c&bth=2f1801e44e9cb0be2b013624521fb0959dc2c73a&bth=5e8a1e07503f53b13b3a6779084f8b0637aaf5a7&bth=8033013a2ce586bccc23245583fa86ef4a761dce&bth=975271167132418534cb07336601efb5b0c711f0&bth=de75c2ad7917bc889d6307b152f79d34e79ce74d Change-Id: Ie93afa476eca9fdbf7ea17ff0189fbaa493a5531 (cherry picked from commit a064f1226b9864f0d0ef6d969f2ae53cc413eb51)
2016-12-01tdf#101870 - Template manager thumbnail view control needs a borderAkshay Deep3-4/+4
Change-Id: If1773b99aa816b2b45fe16127ff09a646e3702ae Reviewed-on: https://gerrit.libreoffice.org/31324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> (cherry picked from commit 9abc547ef28f3f6891030597fd304ca757b102da) Reviewed-on: https://gerrit.libreoffice.org/31450
2016-11-30ScTabViewShell::InnerResizePixel must not mark document as modified...Stephan Bergmann2-7/+10
...when merely toggling the edit mode of a Calc document embedded in another document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet"). Interestingly, none of the other document kinds seem to have this problem. (Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls SetDocumentModified() at all?) Anyway, pass this inplaceEditModeChange information down there. Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe (cherry picked from commit 424d17e62e0d670aa79a890f85bb98c19169f9f5) Reviewed-on: https://gerrit.libreoffice.org/31428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-30Emoji Control: Larger emoji renderingAkshay Deep2-0/+11
Change-Id: Iec51d4e73926cf8203638d2ad013ddfdd47d8ee4 Reviewed-on: https://gerrit.libreoffice.org/31256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 70c03ec408360bb1285478b08bd7edcdbb090376) Reviewed-on: https://gerrit.libreoffice.org/31398 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-11-28tdf#104106 Enable save whenever edit mode activeMaxim Monastirsky2-3/+4
but in case of a r/o medium do "save as" instead. Change-Id: If99602481deb053c2f834b1c7f5d24eb725df9c1 Reviewed-on: https://gerrit.libreoffice.org/31308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit afe7f739106124542712ec50dbe2917a8dd14db3) Reviewed-on: https://gerrit.libreoffice.org/31315 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-28These don’t need to be translatableAdolfo Jayme Barrientos1-9/+9
Change-Id: I889c5130bd32f038cb0b45d959b40bf63c0b3a58 (cherry picked from commit b28b05053b1a6967b0cfa189da68e8d36a1ad443) Reviewed-on: https://gerrit.libreoffice.org/31321 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-23make strings localizableAndras Timar1-1/+1
Change-Id: Ic74b55b12926a23e9e98308407a88e73dc9cb0c7 (cherry picked from commit 666eb88b3125e8d62e05f6e0fc75cc6653ab42d5)
2016-11-21Kill the AutoPilotPresentations UNO commandGabor Kelemen3-26/+0
The presentation wizard was removed in bb8040595c9b6f0ccde39e6833f27a50abb891d8 but the corresponding UNO command is still available. Change-Id: I54e676672bb53d0283394a0ebffbe9f94f29d9c0 Reviewed-on: https://gerrit.libreoffice.org/30983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-21add missing depDavid Tardon1-0/+4
Change-Id: I0d2a2c32d99ee11e63a2363f8a17bd4efd72cc22
2016-11-21use the right config depDavid Tardon1-1/+1
Change-Id: I1d387ac566008efd5b0fe7e5e4a4f1bc8462107f
2016-11-21add missing deps on ui filesDavid Tardon2-0/+8
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud1-1/+1
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-18editeng: assert SfxPoolItem::operator==Michael Stahl2-2/+2
Change-Id: Ia6c6f4f5af1e3a803b464ab410558984c3861a65
2016-11-18sfx2: let .uno:SignPDF result in a warning before editing the docMiklos Vajna3-7/+130
Editing such a document is most probably not what you want, help the user to avoid the trouble. Change-Id: I87d52d89e12658675b580b7dc21fb38fe41dd777 Reviewed-on: https://gerrit.libreoffice.org/30955 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-18includes should be at the top of the fileNoel Grandin4-12/+13
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17sfx2: let .uno:SignPDF result in a custom infobar textMiklos Vajna2-14/+21
To make the intention a bit more explicit. Change-Id: I70ce053b9f068a2288e4a05eba55fb3e2451b561 Reviewed-on: https://gerrit.libreoffice.org/30935 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-16make the element names in dumpAsXml match the class namesNoel Grandin1-1/+1
Change-Id: I955facfe3e901fcb76798dab342f96a67d5ac63f Reviewed-on: https://gerrit.libreoffice.org/30894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16new loplugin finalprotectedNoel Grandin1-2/+0
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Fix typosSamuel Mehrbrodt1-1/+1
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15loplugin:constantparamNoel Grandin1-4/+4
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14tdf#103897 No space between template previews from Start CenterNoel Grandin1-2/+4
regression from commit 96e9ffa64706f523d67659a20a0ccce6fbd0cb91 (patch) loplogin:singlevalfields in include/ I did not notice that the mnItemPadding field was shadowing a declaration in a superclass Change-Id: I52cf9945da43fa3d1049b624a6b24bc6d974d445
2016-11-14minor opt tweaksCaolán McNamara1-4/+7
Change-Id: I418d0e04f8d4373c0d9f1f106ac0cc7779029802
2016-11-14loplugin:unusedmethodsNoel Grandin4-252/+0
Checked a couple of them: StandardCheckVisisbilityRedirector is unused since commit b1f8cf37828d5f37527e54774aa4935610aa6325 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Nov 2 10:57:21 2016 +0200 loplugin:singlevalfields SfxQueryStatus is unused since commit 64a708cba9b954afe3331f63c58218eb53b3d0ce Author: Caolán McNamara <caolanm@redhat.com> Date: Sat Nov 5 20:28:27 2016 +0000 Revert "Reverts a commit series that cripple windows ci." Change-Id: If1c9fe26c3ebc573d8c53c8f060b05c27f2711e5 Reviewed-on: https://gerrit.libreoffice.org/30840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14tdf#94262: fix performance of MakeTree_Impl(...) in templdlg.cxxAron Budea1-48/+21
1. replace 2nd level for-loop with a helper unordered_map that maps style name to its pointer 2. replace 3rd level for-loop with std::lower_bound, since the children are inserted sorted (based on natural sort) ...and a few related, minor changes. Change-Id: I48f59f2e1ca416de1e2957e0d1d3708ed6e67112 Reviewed-on: https://gerrit.libreoffice.org/30744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-14tdf#68118: Pass current document frame to SvxScriptSelectorDialogMike Kaganski2-5/+23
... through MacroChooser Without this, current document's macros library is unavailable in "Assign" dialog Change-Id: I83baa3b98858260eab61e8f4fefde3f9979c6d83 Reviewed-on: https://gerrit.libreoffice.org/30600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-13sot: fix loplugin:cppunitassertequals warningsMiklos Vajna1-20/+20
Change-Id: Ib4ec7d5c3dc89c80cc46bbbe8a14f6b1393ffa76 Reviewed-on: https://gerrit.libreoffice.org/30767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11Resolves: rhbz#1391418 wayland toolbars can't be docked after undockingCaolán McNamara1-1/+3
see gnome#768128 for extra details under wayland, given the misery here I'm going to just disable toggling between docked and undocked under wayland, and throw away user config on toggling docked/undocked away from the defaults. You can still drag docked things around to new docking position, but you can't pull them out of the dock to float. non-wayland is unaffected Change-Id: Iaa859f3420e6d1b103a8b93d1ad8f82dbffe75d4 Reviewed-on: https://gerrit.libreoffice.org/30752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin18-24/+24
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann1-2/+2
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann1-8/+1
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456