path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin1-1/+1
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-11-09SfxTabDialog ctors: take an OUStringMiklos Vajna2-5/+5
Change-Id: I91b9b2ffd19b2412ac01dd12429d6460b4c4812c
2014-11-09fdo#82707 Unify click behavior in Statusbar (Writer)Samuel Mehrbrodt1-4/+4
Use single click for primary action, right click for context menu Change-Id: Ia707a88b48f4af144588c45d37acea547e77773e
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin1-3/+3
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann11-21/+27
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin11-27/+21
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#67627 fdo#85791 Allow to show/hide sidebar decks with the same commandSamuel Mehrbrodt6-4/+36
This also reintroduces the code to switch the decks asynchronously (removed unintentionally before) Change-Id: I825b4d7c5777097e9d3b3d82adbe1f646510dc9d
2014-11-05markup with event type not checker typeCaolán McNamara1-0/+1
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin1-1/+1
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: Tested-by: LibreOffice gerrit bot <> Reviewed-by: Noel Grandin <>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-24/+20
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin5-11/+11
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-10-31Removed duplicated includesAndrea Gelmini1-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: Tested-by: LibreOffice gerrit bot <> Reviewed-by: Michael Stahl <>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin1-1/+1
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: Reviewed-by: Bryan Quigley <> Reviewed-by: Michael Stahl <> Tested-by: Michael Stahl <>
2014-10-30HIG fixes for Document Properties dialogAdolfo Jayme Barrientos4-37/+47
* Add missing colons to labels that precede controls * Standardize Help button’s position * Better label for Add Property button * Add a frame for the lonely Embed Fonts option Change-Id: If12708161f2345e66ab3f49fd744bcad00d4ecc6 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-10-29Resolves: fdo#85111 put a border around the custom properties boxCaolán McNamara1-5/+19
Change-Id: Ibdbfb4a88c1c75aaf5d33672d8639a9ea55afbac
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin9-9/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-10-29coverity#1028106 Dereference before null checkCaolán McNamara1-16/+0
Change-Id: I77a910542cf1b7889f69a1d3b7989779d9ecc7e8
2014-10-29ref-counting vcl::Window subclassesNoel Grandin1-1/+0
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-28coverity#704019 Unchecked return valueCaolán McNamara1-2/+2
Change-Id: I605861dd741b1899924c0079b931da418be5d647
2014-10-28coverity#704020 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I0f8b49bb43d88549ba90db63ce7041e6d5e0fe64
2014-10-24loplugin: cstylecastNoel Grandin2-2/+2
Change-Id: Ia0f5f0d0efbe4693aba347bff32cd694117251fe
2014-10-23fdo#84935: basic: avoid silly SolarMutex asserts on exit on MacMichael Stahl1-2/+3
Change-Id: If22b8ff962d2b68130176de3b7b9eccacfc850dc
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky5-28/+28
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky4-16/+16
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23Related: fdo#83003 Jay wants equal space above and below this buttonCaolán McNamara1-2/+1
Change-Id: I9babf256eabfd8a168097e28d0a9ffae0e281403
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin3-14/+14
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-22callcatcher: update unused codeCaolán McNamara2-143/+27
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-22Save precious vertical space by removing some redundant heading labelsAdolfo Jayme Barrientos3-172/+52
Change-Id: I6aaa7602f57f6cb2d0f9bc3ee897a9c3576d47d3 Reviewed-on: Reviewed-by: Samuel Mehrbrodt <> Tested-by: Samuel Mehrbrodt <>
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist16-66/+80
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-21The only SID supported by PropExec/State_Impl is SID_ATTR_UNDO_COUNTStephan Bergmann2-119/+8
...apparently, given that the SID_ATTR_UNDO_COUNT entry in sfx2/sdi/appslots.sdi is the only place that mentions those functions. That reveals that all the other SIDs mentioned there are completely unused. (Also, there seems to be no need to wrap the remaining PropExec/State_Impl functionality in #ifndef DISABLE_SCRIPTING.) Change-Id: Iea7a41aa323b7876d316794cebe962e6e086236d
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin6-8/+8
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin4-14/+14
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-10-17Remove unused SID_s from sfx.sdiStephan Bergmann1-464/+0 least, removing them has no effect on the generated workdir/SdiTarget/ *.hxx Change-Id: I0e3fffe27593cfbf5aed267c3f47bc85581954c8
2014-10-17Revert "fdo#67627 Clicking on icons of the sidebar should both open and ↵Samuel Mehrbrodt1-7/+0
close Decks" This caused a regression, see fdo#84351 This reverts commit 04e96b6d6eb55b9ff2a6ec9c4ce52260e33df121.
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon4-16/+16
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16usage info: Checkbox to turn it on and off (Tools -> Options... -> General).Jan Holesovsky1-1/+5
Change-Id: I67143e604314f5553026c369bbed3fdd683c39a6
2014-10-15coverity#735333 flush out pointless calls to IsRemote and IsOpenCaolán McNamara1-5/+2
etc. Change-Id: I588d4486071b1e31897d4e6468a2c634d6856832
2014-10-15SfxMedium::IsRemote can be made constCaolán McNamara1-5/+1
Change-Id: Id6b14366d11c15ec1440482cfb725e497807fa2e
2014-10-15osl_Module -> osl::ModuleCaolán McNamara1-4/+4
related coverity#1242504 Resource leak but it still leaks a dlopen handle here of course Change-Id: Iaf692e7b2753c1c0af580e236bc147dc30a39e9f
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann4-7/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15remove unused DECL_OBJHINT and IMPL_OBJHINT macrosNoel Grandin1-2/+0
these have been unused since we switch to using normal C++ RTTI with the SfxHint subclasses Change-Id: Ia271cfa01d2f49ed335e90f78309cd26d6ec9d8f
2014-10-15coverity#1244937 Unchecked return valueCaolán McNamara1-2/+3
Change-Id: I7691103b5011861d9e84860671be8e46651a27b1
2014-10-14Resolves: fdo#72587 make template dialog ModalCaolán McNamara2-1/+4
Change-Id: Iefb63bc7cdbff2217f16c1a72fc271361227588b
2014-10-14coverity#1078471 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I2eb340eddf77ef5f007b5588e78d2b03bb5eb059
2014-10-14coverity#735851 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I8f6e5803efe0db06d081903b9b852d1a1f881f7b
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin3-4/+4
Signed-off-by: Stephan Bergmann <>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-11too risky to dlclose basctl once openedCaolán McNamara2-0/+3
e.g. use macro organizer for the first time and launch a macro, user event with handle to basctl function posted Change-Id: I2f0f4a7536f071926ea1bd6994f8178fbd4a796f
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin21-69/+69
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin9-19/+20
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: Tested-by: LibreOffice gerrit bot <> Reviewed-by: Noel Grandin <>