summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2021-07-06Fix typo in codeAndrea Gelmini1-1/+1
Change-Id: Iabd6c07614df7b0335c1609b62116f26a1db2d06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118451 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-07-06tdf#142459 Fixed long class names are truncated(gen)Gizem Ozgun1-0/+6
Change-Id: I9c88beb3fc83c23b2e866824985d50567b056f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118035 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-07-05tdf#138906 prevent built-in category deletionVert D10-1250/+423
*Remove category selection dialog for Delete Category. *Delete Category now deletes the current Category. *Import now imports to current category. *Remove Buttons, add items to menu. *Enable delete multi selection. *Change Dialog titles. *Remove searchview class. (I see no reason for it, it just copies code from localview and localview can handle search results on its own.) Change-Id: I5add4aa9fa68ac68c796a6b98fb54a5d0da93bd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113712 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-07-05Resolves tdf#143174 - UNO MoreDictionaries not workingHeiko Tietze1-0/+4
Missing exec method added Change-Id: I2272654ae6ed9d9525c98392a9f65a74a108af02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118395 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-07-04move SfxSetItem to own header fileNoel Grandin1-0/+1
Change-Id: I77ba873ed236091443627e26e6127e89cd8e15bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118360 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-02tdf#143149 fix crash if app exits while print progress is runningCaolán McNamara1-0/+1
dismiss the dialog if its parent goes away, but leave the print job running Change-Id: Ic29ee0300a7d9476ad27a2594a555312e30c74f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-01can allocate these SfxItemSet on the stackNoel Grandin1-7/+7
Change-Id: Ib2b89613ad3e8f2bcdd51bee10bab3559a64fce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01sfx2::FileDialogHelper allocate SfxItemSet on stackNoel Grandin4-15/+15
and pass around the explicit sub-type, instead of doing static_cast in various places Change-Id: I28ba8fd6f5c9e2a1ffbf5ec091bcf0ebdd1d18b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118210 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01can pass this SfxItemSet around on the stackNoel Grandin1-7/+7
Change-Id: Ie2e67ec19cfacdfdd0a6dd85c464cfa326b6500d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118209 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30sfx2: try to fix lifecycle of SfxOfficeDispatchMichael Stahl2-1/+27
This can be created either from the global SfxApplication, or from a SfxViewFrame. Particularly in the latter case, the SfxDispatcher and SfxBindings members are owned by SfxViewFrame, so in case that is destroyed, the SfxOfficeDispatch must clear its pointers. It looks like the member pointers are checked before access already everywhere, so just listen at the SfxViewFrame. Change-Id: If08825734e94dd54e32cb77546684fd583c336ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118162 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-29constructing SaveOptions just to read default versionNoel Grandin3-11/+6
can be a little expensive sometimes, since it loads a bunch of other stuff at the same time. So create a custom method that just loads the version Change-Id: Ic480d95c4d64c68e57faf1b52f1d102141b7e246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118047 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-29uitest: combine execute_dialog_through_command methodsXisco Fauli1-1/+1
Change-Id: Iaa03d37a9ac3862b8cb08a81e37a611632433880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118077 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29uitest: guard remaining execute_dialog_through_commandXisco Fauli1-7/+4
Mostly done with a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: Ib8e7c5f5e2c9b8a7756fe533ea4f30349dd68761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118076 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29Added a UI dialog box for running the VCL backend testshomeboy4453-0/+29
The UI dialog box will allow the user to run the VCL graphics tests and will allow them to view the results as well. Change-Id: Ice289444ff425496a3e400a4c2bc06c307168c62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117384 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin5-5/+5
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-25loplugin:finalclasses in sfx2Noel Grandin22-35/+30
Change-Id: I8125d5447e13a6dadfde9c19c8cab6004693589a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-22uitest: guard load_fileXisco Fauli1-11/+9
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: Ia924293dc2a12230fd13f69fd734875ced86be8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117593 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-22configure: Improve help-options handlingJan-Marek Glogowski1-4/+4
This patch includes: * A README.help.md as a general documentation for the different help types, the LO code and help-related build options. * Adds --disable-xmlhelp for removing the xmlhelp support from the build. Disable for iOS, Android and Emscripten. This was partly included in HAVE_FEATURE_DESKTOP before. * Rename WITH_HELP define to WITH_HELPPACKS, which reflects the actual usage AFAIK. * Depend --with-omindex on --with-help=online and don't override the --with-help setting. Error out on conflicting options. * Depend --with-helppack-integration on build help variants, which actually result in help packs. Kind of reverts commit 2c38ea6d16b910294220cefaf8ae6a0683e6405a ("Building without --with-help is not supposed to disable help functionality"). Change-Id: Ie4cb73905b3ed94e991d9f1bd75cfbd6de9da385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116222 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-21give folderpicker an optional parentCaolán McNamara1-3/+28
so, like a file picker, it can make its parent modal while its operating. Otherwise its possible to interact with the parent dialog in undesirable ways, e.g. file, export as, export as epub, the folder picker of 'media directory' Change-Id: Ib61f8e630e176b6d81e80798fd0d282d16e8c086 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21bundle the FolderPicker instantiations behind a single callCaolán McNamara2-2/+8
in prep to add parent support Change-Id: I2aa4b9343f895ae866f600dd3260b7fdc4e1efec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21remove some unnecessary OUString::internNoel Grandin1-2/+2
Change-Id: Ia0f41dfc8a00c115ad544b8236d751e6b2dae5ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117577 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-19use more TellEnd()Noel Grandin1-2/+1
which has the potential to be more efficient than STREAM_SEEK_TO_END Change-Id: I64d84632bc4751e07309332c9dff7a02bcd507fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-19Update of TSCP example file for Simplified Chinese (zh-CN)Kevin Suo2-0/+90
See l10n discussion in: https://listarchives.libreoffice.org/global/l10n/2021/msg00193.html Change-Id: I8ced7f4128b6e633d35770759fa4b82e03356084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117285 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-18tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)13-23/+23
Rename ::StateChanged methods using SfxItemState to allow better analysis of SfxItemState/SfxPoolItem usage(s), discussion see tdf#130428 comment 30 Change-Id: I736be0160ad7a9b7882c1c8a4cc05d9396ee3305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117366 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-18Add Last 4 UNO Commands To CrashReport DumpGopi Krishna Menon1-0/+6
Adds last 4 uno commands executed in CrashReport to assist in investigating the crashes Change-Id: Ib7307ffc62d6d51d52f9d5e7fabefc2eaf858e5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117388 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-18Add Active Sfx Object Name To CrashReport DumpGopi Krishna Menon2-41/+16
Adds Active-SfxObject field in CrashReport to assist in investigating the crashes Change-Id: I08637a66ae95977e7afe4f5dce634b46c928a423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117318 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-18VCL graphics rendering tests that a run on LO version changehomeboy4451-10/+2
This commit includes the implementation of graphics rendering tests which would be automatically triggered at first installation or upgrades of LibreOffice. These tests check the graphic rendering interface of LibreOffice by drawing and checking various graphical rendering tools (eg:. by drawing lines, polygons etc.). After the successful completion of tests, their results are stored in the user folder for future reference. Change-Id: I59c94b57a1f3f3a9cba55af1067a9702b6da98d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116779 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-17fix potential write-after-free in RecentDocsViewNoel Grandin2-3/+9
spotted while running a valgrind session Change-Id: I32c55ae2cc4b2d5abedca24c2f747aaa4183b3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-17use string_view in the Translate APINoel Grandin2-2/+2
Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-16Add Active App Name Field To Crash ReportGopi Krishna Menon2-0/+46
Adds a Active-App field in Crash Report to assist in investigating the crashes Change-Id: I30e5f307045b8e5def9986447551f39e70b94edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116786 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-15Update TSCP config for pt-BROlivier Hallot1-12/+30
Sample file updated Change-Id: I5fc8e6f65d13e44e8ebaacbb049cf997e839241f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117267 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-15remove some unnecessary LanguageType copiesNoel Grandin1-2/+2
Change-Id: Iec4374627c931ccecf05a712682ed18ef90bf359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-14only one of the radiobuttons in a group should be activeCaolán McNamara1-1/+0
Change-Id: I0475bdd0633b54a644e205628577fac18a3af974 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-13Assert on valid order of which ids in ranges on SfxItemSet creationMike Kaganski2-27/+18
This allows to make sure we actually use sorted which ranges, and then it's safe to call SfxItemSet::MergeRange when needed. Also this change relaxes the previous requirement that ranges must be separated by at least one; this allows to have adjacent ranges, like in RES_FRMATR_BEGIN, RES_FRMATR_END-1, RES_GRFATR_BEGIN, RES_GRFATR_END-1, where RES_FRMATR_END is equal to RES_GRFATR_BEGIN. Allowing this makes possible to (1) self-document the ranges, so it's clear which ranges are included; and (2) be safe in case when these constants would change, so that the one merged range would not unexpectedly contain everything inserted between RES_FRMATR_END and RES_GRFATR_BEGIN. Change-Id: Iaad0f099b85059b3aa318a347aa7fbd3f6d455c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116909 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-11Simplify Sequence/vector initializationsJulien Nabet2-7/+2
Change-Id: Ib02e25b4600666185cf0f8d0cc8d5c64186789c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117064 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)1-7/+7
Another place where SfxItemState was used as placeholder Change-Id: I54e549db50b7485024a305eb39fda848cbed6b78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117036 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)1-5/+8
Another place where SfxItemState::UNKNOWN was used as placeholder Change-Id: Ie2757e8356bfea7010b0442d72ef7865cbb18d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117034 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-09Simplify Sequences initializations (sfx2)Julien Nabet4-55/+23
Change-Id: I1384dd80e910ba1c55ec7481ab481bc48740fc5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116937 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-09-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann1-7/+0
...after e79e8117dcc7475d8d90afeaaac9eb7050ff244e "loplugin:unusedfields in sfx2" had removed the (only) read of sPattern Change-Id: I2413af34b15dec45c46df0ffabf1d910f92dd695 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116822 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-08set entry to expand and combobox to fill its assigned spaceCaolán McNamara1-2/+3
Change-Id: Ia70513d3d6d6fa5ce69936231202f3a52fc56fe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116857 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08resave with latest gladeCaolán McNamara1-3/+3
Change-Id: Ia2aa23dfa82728ac38e18bcc15e20ad72b35aa6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08Resolves tdf#131817 - Option to globally switch toolbar locking on/offHeiko Tietze3-2/+53
Reverts 6993d5d0f1079fe720a7da004b70b57361c99fc6 and sets Locked in GlobalSettings to true New UNO command ToolbarLock to toggle the state added to the toolbars menu Change-Id: I246280b2b7930f2bf686e6fc26383da4799b5028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115797 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-06-08Remove SfxItemState::READONLYArmin Le Grand1-1/+1
As I experimented with redesigning the whole Item/ItemSet/ItemPool paradigm, I alredy checked that SfxItemState::READONLY is not used (and no one really knows what it should do or stands for). Since a removal of complexity is needed to get forward with that redesign and I already made some experiences in branch item_refactor2, I propose to remove this state. It is not really used (gets never set). It is mirrored/used in the UNO API in css::frame::status::ItemState as 'READ_ONLY', but also not used in the office's code. ItenmState itself is used in three places, but all set the Item involved by using a SfxVoidItem to state SfxItemState::DISABLED, which I described in ItemState.idl. This means that no state of READ_ONLY in UNO API is ever imported to office code as DISABLED state at all, so not used. I also marked it as deprecated in the *.idl file. I think - including the experimenting in the mentioned branch - that this is safe for now. I already run a full 'make check' on the changed stuff. Change-Id: I8c15cf7b4f803076ecaaea67659f6e022ac7ef70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-07tdf#132667 - Grab focus on the last inserted propertyAndreas Heinisch1-1/+7
On removing/adding custom document properties, grab the focus on the last empty shown name box. Change-Id: Ifd66566d4ae9fa57b9f1a9aae5f9cb93dbb74070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115872 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-06-07Resolves tdf#142513 fix zoom caller handlingJim Raykowski1-2/+2
Calling ZoomPlus has always executed shell SID_ZOOM_OUT case handling. ZoomMinus, which replaced ZoomIn, does SID_ZOOM_IN case handling. This patch changes ZoomPlus to do SID_ZOOM_IN case handling and ZoomMinus to do SID_ZOOM_OUT case handling and makes appropriate changes required by these name changes to provide expected zoom results in all module shells that have handling for these calls. Change-Id: If148f4f7866bfc8fc6452ad1c1dace723a125ef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116287 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-06-07Resolves tdf#140360 - Provide option to turn off sidebar's minimum widthHeiko Tietze1-2/+3
Boolean option Sidebar:General:MinimumWidth introduced defaulting to true; if false the sidebar width is under full user control Change-Id: Iab1413a83adf90461feb5d6416aad174439392ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116715 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-06-06enforce indicator consistencyCaolán McNamara1-1/+1
so there is either a standard indicator shown or one of a small subset of named icons a) adds an indicator to show the MenuButton provides a dropdown to the spelling dialog when there are multiple user dictionaries the word could be added to b) use open-menu-symbolic instead of gear icon for the sidebar menu Change-Id: If4f0842fb0f805dde45e375061f23d2aaea0990c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-06use open-menu-symbolic for menubutton gear menusCaolán McNamara1-1/+1
https: //wiki.gnome.org/Initiatives/GnomeGoals/GearIcons Change-Id: Ia95451f950728c4174887a042a6666e1dd7cc1ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-04gtk4: undo bootstrapping conditional page removalCaolán McNamara1-7/+1
now menubutton is available again Change-Id: If3112cde3e5231245088740ab0217a0e61b3579c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116733 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-04lok: Interaction handler for FilterOptionsmerttumer1-1/+2
This will enable Text Import Dialog to be executed before the document is loaded Change-Id: I263e69f0739f4971f4c4eec032ebf22ffbdeebb7 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114638 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116294 Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 09:49:11 +0000