Age | Commit message (Collapse) | Author | Files | Lines |
|
(regression from 8f04b172c5c78fa80c3692a729f0191425195869)
Change-Id: I111d12a622390afc02eb73a42b1d3c714f046bd2
(cherry picked from commit 41af2a9e26f3ee6b505b343120d5df3617ba5c49)
Reviewed-on: https://gerrit.libreoffice.org/42952
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
wrt widget heights and positions and other flakiness
take the natural combobox height as the line height, use a vclgrid
element for each row to get everything set to the same height
move the positioning code into Resize, etc.
Reviewed-on: https://gerrit.libreoffice.org/41734
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 14afb688d3a24be302867ea614b0e30e01d168be)
Change-Id: I22de98ef91e39d1e7e45bbe62f68496d55c0c1cb
Reviewed-on: https://gerrit.libreoffice.org/41749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Next step could be using std::unique_ptr<StyleTree_Impl>
instead of StyleTree_Impl*
Change-Id: Ifbf5313fedf1fc0310073918f91edd6fe75d0afc
Reviewed-on: https://gerrit.libreoffice.org/41710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit c82e5db9626e4d84300f84842b837e852be828be)
Reviewed-on: https://gerrit.libreoffice.org/41925
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I5d066f53c5bdfb4dd50d60c5cb4b66e425c0293c
Reviewed-on: https://gerrit.libreoffice.org/41698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
scaling factor added
Change-Id: Iccfc76832ccfaaffb9950d4b591b379dfb0d9eca
Reviewed-on: https://gerrit.libreoffice.org/41401
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
(cherry picked from commit 4438849e400ecef3cdf2f267dc75a76d4b11aba1)
tdf#111844 infobar icons/text on high dpi
scaling factor added to text position
Change-Id: Iaeb48fd4ac0439680fa3b6ca43f23a617efe1457
Reviewed-on: https://gerrit.libreoffice.org/41417
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
(cherry picked from commit 4d60d96a22ef2f67db7c7e99981447bd81f776c4)
Reviewed-on: https://gerrit.libreoffice.org/41461
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Clearing mItemList at the begin of insertItems is a bad idea
because it prevents ImplDeleteItems (called by updateItems,
itself called at the end of insertItems) from clearing
correctly mItemList
See comments from bugtracker for more info
(Thank you Alex for the precious info attached with memleak reports! :-))
Change-Id: I04976dbb065d1369562649fc97c33f7fd599b107
Reviewed-on: https://gerrit.libreoffice.org/40995
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 05a338159761e012c2c8779f8927b0d709b4416f)
Reviewed-on: https://gerrit.libreoffice.org/41002
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
call pBindings->Release(), but call UnBind() instead which
correctly sets the state to "UnBound" by setting
pNext = this.
Thanks to Miklos Vajna for pointing this out !
Change-Id: I08e85496cff6df0952d6c5ec4ee979a93b8862d0
Reviewed-on: https://gerrit.libreoffice.org/40882
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
(cherry picked from commit 2585eb9d15f5c047d846ccb4b4d606d9ac89e518)
Reviewed-on: https://gerrit.libreoffice.org/40907
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
and thus avoid crash when user clicks 'show signatures' button
in a window where signature bar shouldn't even be
Change-Id: I5eba8d1ddd8c76dd10acedfa03d732df586748de
Reviewed-on: https://gerrit.libreoffice.org/39705
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
com.sun.star.ui.XUpdateModel was added in 5.1 so pre-existing extensions
don't implement it.
(regression from 0635208edf1cdee4235ea87666a473ac81007555)
Change-Id: I6749a9cf2fc82b9cd90d85a682247104e369e167
(cherry picked from commit d109948f0dd4190d7aca1e0fa7e2706ef3f40a6c)
Reviewed-on: https://gerrit.libreoffice.org/39311
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
because the user has modified the document
Change-Id: Ib32ea2ff41f41a81c9a382585f6afbec12fe6a35
Reviewed-on: https://gerrit.libreoffice.org/38284
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
(cherry picked from commit 2e11bbd288ec59d0ff3368cc5c5ef83e2f5133a2)
Reviewed-on: https://gerrit.libreoffice.org/38876
|
|
Except those who were set open r/o with the File->Properties checkbox
Change-Id: Id44daac364cae73636b6f1c051521928743b88f4
Reviewed-on: https://gerrit.libreoffice.org/36258
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
(cherry picked from commit 630186ff4e0eba7317e542f8c3eca39ebd068721)
Reviewed-on: https://gerrit.libreoffice.org/38874
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I09dafffd64dd107e802d016494d884f32363521a
(cherry picked from commit ca8a4a7abc81a53a88fc0daa61447f9562f532f5)
Reviewed-on: https://gerrit.libreoffice.org/38463
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Ica65be783130b1981093204edd03dc793a16343b
Reviewed-on: https://gerrit.libreoffice.org/38027
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
(cherry picked from commit 6533c30f7f8b62671fef9e636c49b11127812ed1)
Reviewed-on: https://gerrit.libreoffice.org/38380
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
this time without stack overflow. Updating existing infobar needs
some work still
This patch is partially based on work of samuel_m
Change-Id: I2c44c14e27cf85a1014b01e5588b7b53990033b9
Reviewed-on: https://gerrit.libreoffice.org/38148
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit e744e9f4492d3013742fcdb6254cd76528870e9d)
Reviewed-on: https://gerrit.libreoffice.org/38255
|
|
* it is possible to set font family,
color, angle and transparency
Change-Id: Idea2fb9ee748394bb3d706fa790e109238584cdb
Reviewed-on: https://gerrit.libreoffice.org/37793
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 48906a5e899e517af76e04afb5659232b336e206)
Reviewed-on: https://gerrit.libreoffice.org/37835
|
|
change various ResId classes that use conversion operator to OUString to
functions that return a OUString
drop various defines
drop unnecessary toString calls
Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92
Reviewed-on: https://gerrit.libreoffice.org/37817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 2155e04d6343638ca9815d394cbc4f78c2b17c3a)
drop toString
Change-Id: I0f67c8931523bbe90bfbc8cc7d9a5bd523758ee5
(cherry picked from commit 8b1101023f01b2c7478a014b5ead73ada4fd4861)
pNameResId is unused
Change-Id: Ic1fe6abc7066517187695266c4d1a0888b41ffe7
(cherry picked from commit c2667d7ff558a1b7bf83e694909465f00d1a16f6)
Reviewed-on: https://gerrit.libreoffice.org/37843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
* added new command .uno:Watermark
* if no arguments are provided the dialog
is opened where user can enter the text
* with provided Text argument the watermark
is created
* created SfxWatermarkItem to transfer
watermark properties
* dialog loads current setings
* SetClassification use SetWatermark
Change-Id: Ifc1319f5aa7c11bb141f8e4b5b9a5088613021c2
Reviewed-on: https://gerrit.libreoffice.org/37599
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
We only need a label in officecfg, and an icon in icon-themes.
Change-Id: I88482f85b282742c5d6dc7f6ec7ba6442c09a639
|
|
Now, on inserting/removing or resizing a row/col, the row/col header
invalidation callback is notified to another view only if it is
displaying the same tab of the view where the row/col operation is
occurring.
Conflicts:
sc/source/ui/view/tabvwshc.cxx
Change-Id: Ic65fd82b2e3009420c7b481e7e8c1ff8bb11bcce
Reviewed-on: https://gerrit.libreoffice.org/37241
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
|
|
When the client starts the address and formula text field were empty
because the updating callbacks occurred before the view callback
handler had been registered.
So a new method `afterCallbackRegistered` has been added in order to
perform any needed updating/initialization soon after the view
callback handler has been registered.
Change-Id: Ia47234e32796f7e4bc1a8408736102054b4666e2
|
|
ignore SAL_LOG type stuff in the destructor
Change-Id: If014382ca0c96edd3f2b325a28451d83b3d1f278
Reviewed-on: https://gerrit.libreoffice.org/37539
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I99ef82f6b82674e67aa10d270361828545864f8b
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/37569
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
found by temporarily marking Reference as SAL_WARN_UNUSED.
Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I91a7af532a3b94e8096d99d1c4cf63d315e2f446
|
|
found with:
git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return
Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02
Reviewed-on: https://gerrit.libreoffice.org/37463
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
with command
> git grep -l osl/diagnose.h *.cxx |
xargs grep -L -w 'OSL_\w*' |
xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'
headers need more work
Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Came across this in a UBSan build via menu "Help - LibreOffice Help" ->
"LibreOffice Help" window: "Find on this Page..." icon -> "Find on this Page"
dialog: "Close" button, then close help window:
> sfx2/source/appl/newhelp.cxx:2291:1: runtime error: member call on address 0x618001188880 which does not point to an object of type 'SfxHelpTextWindow_Impl'
> 0x618001188880: note: object has a possibly invalid vptr: abs(offset to top) too big
> 81 04 00 13 0e 07 00 08 5e 7f 00 00 00 00 00 00 00 00 00 00 60 62 9a 51 5e 7f 00 00 00 00 00 00
> ^~~~~~~~~~~~~~~~~~~~~~~
> possibly invalid vptr
> #0 0x7f5e4700f276 in SfxHelpTextWindow_Impl::LinkStubCloseHdl(void*, sfx2::SearchDialog*) sfx2/source/appl/newhelp.cxx:2291:1
> #1 0x7f5e47f6d13a in Link<sfx2::SearchDialog*, void>::Call(sfx2::SearchDialog*) const include/tools/link.hxx:84:45
> #2 0x7f5e47f66c5f in sfx2::SearchDialog::dispose() sfx2/source/dialog/srchdlg.cxx:70:17
> #3 0x7f5e209af22c in VclReferenceBase::disposeOnce() vcl/source/outdev/vclreferencebase.cxx:42:5
> #4 0x7f5e1edb81b9 in VclPtr<vcl::Window>::disposeAndClear() include/vcl/vclptr.hxx:239:19
> #5 0x7f5e1fc47199 in vcl::LazyDeletor::~LazyDeletor() include/vcl/lazydelete.hxx:148:36
> #6 0x7f5e1fc473af in vcl::LazyDeletor::~LazyDeletor() include/vcl/lazydelete.hxx:122:9
> #7 0x7f5e21dfdb50 in vcl::LazyDelete::flush() vcl/source/helper/lazydelete.cxx:52:9
> #8 0x7f5e21fa552f in ImplYield(bool, bool, unsigned long) vcl/source/app/svapp.cxx:513:9
> #9 0x7f5e21f7fdc3 in Application::Yield() vcl/source/app/svapp.cxx:558:5
> #10 0x7f5e21f7fb06 in Application::Execute() vcl/source/app/svapp.cxx:458:9
> #11 0x7f5e5cbd18d4 in desktop::Desktop::DoExecute() desktop/source/app/app.cxx:1359:5
> #12 0x7f5e5cbd9e06 in desktop::Desktop::Main() desktop/source/app/app.cxx:1679:17
> #13 0x7f5e21ffb0cb in ImplSVMain() vcl/source/app/svmain.cxx:191:35
> #14 0x7f5e220085f1 in SVMain() vcl/source/app/svmain.cxx:229:16
> #15 0x7f5e5cdfec4b in soffice_main desktop/source/app/sofficemain.cxx:166:12
> #16 0x511c69 in sal_main desktop/source/app/main.c:48:15
> #17 0x511c13 in main desktop/source/app/main.c:47:1
> #18 0x7f5e5b37d400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289
> #19 0x419e59 in _start (instdir/program/soffice.bin+0x419e59)
indicating that the SfxHelpTextWindow_Impl target of the m_aCloseHdl.Call is
already dead. Looks like there is no good reason for that call from dipose()
anyway, which also means the Call's argument is unused.
Change-Id: Ifc33e74e346902dc0208350f5bac79bec182ef12
|
|
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294
Reviewed-on: https://gerrit.libreoffice.org/37426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and call impl dtor with SolarMutex held
Change-Id: I06931ca9ab4384a5e3c255847cf3533ed03b77dc
Reviewed-on: https://gerrit.libreoffice.org/37395
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iab68095a9733393b656623ddd6bb8705f7cfda82
|
|
with command
> git grep -l tools/debug.hxx |
xargs grep -L DBG_ |
xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d'
don't change files in includes/ and */pch
Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08
Reviewed-on: https://gerrit.libreoffice.org/37349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9
Reviewed-on: https://gerrit.libreoffice.org/37280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
To complete commit 076758857a98
Change-Id: I6424109e3aee8a3236e40168bdd98c725a7afafb
Reviewed-on: https://gerrit.libreoffice.org/37306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
|
|
Change-Id: I3facbef60a0d629db8f3028dd1b9f38e8f17e83e
|
|
Change-Id: I8b5fdf6c36908704dfc90cd77d4f258373354042
|
|
Change-Id: I38daa42f0f764e05c8894f26faad14e947ee77ef
|
|
Change-Id: Id1db5c17a346916a326529b750d2ff0a765af5da
|
|
Change-Id: I1c7a4e657601e28d9d50d86e24c4e0ba7579b9d4
Reviewed-on: https://gerrit.libreoffice.org/37289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I0f25f68e3fda79da36921e1b0ac603a6e158fe6f
|
|
Change-Id: I6d63ee582ad5530ecb713dd65350912ee27dc15d
|
|
Alternatively, we could build a higher wall.
Change-Id: Id2ba91c85557ed6ac9e45ba2d9f51ca0e019cd32
|
|
About commit 34f7e618ddd3399d9e7f3998e25545256255d02d
Change-Id: I9142116305dc2cf2ecae66835facadee56ac836a
Reviewed-on: https://gerrit.libreoffice.org/37214
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Iea88ddd619f10a2a2586ee24edbf07e246dcbb49
Reviewed-on: https://gerrit.libreoffice.org/37191
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0
Reviewed-on: https://gerrit.libreoffice.org/37146
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
found with:
git ls-files | xargs grep -Pzl '/\*\*
(\*|\s|
)*\*/'
Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597
Reviewed-on: https://gerrit.libreoffice.org/37159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
removes starmaths InsertCommand in favour of InsertCommandText
Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6
Reviewed-on: https://gerrit.libreoffice.org/37113
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iaccf16f29b6f4b1a2c712d1e5e2bd0fa4fdb5e71
Reviewed-on: https://gerrit.libreoffice.org/37108
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
sdi files have two ways to specify the type of a slot:
(a) Put it at the beginning of the first line
(b) Using the SlotType property
Where (b) have higher priority, and (a) is actually
ignored for "method slots" (i.e. the ones that have
parameter parentheses, even empty, and therefore get
the SfxSlotMode::METHOD flag), which is very
confusing.
The goal here is to make exclusive use of (a) for all
kinds of slots, and eventually remove the SlotType
support code from svidl (in a follow-up commit).
Change-Id: Ib6654d34e2f8aa8ebd0bd3c41aa2a86e30e9a634
|
|
Also expand nested methods.
Only diff in workdir/SdiTarget is for SID_STYLE_WATERCAN
from sw/sdi/_basesh.sdi which changed the .uno name from
WatercanStyleModeOnOff to StyleWatercanMode, to match the
name in sfx2/sdi/sfx.sdi (it was forced by svidl to have
the same name).
Change-Id: Iaeac9f4f10a36cb0b3afe3de2b6def8cd90edc6d
|