summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2018-05-23tdf#115853: save current custom property when adding lineJulien Nabet1-0/+14
by reloading current lines before adding a brand new one indeed the info are deleted by ClearCustomProperties each time SfxDocumentInfoItem destructor is called Change-Id: Id1e2e652e90c720f00b8612aa9afbfa91b784d1d Reviewed-on: https://gerrit.libreoffice.org/50070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/52349 Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit c522b4017915b3a12203ac39f48a75ae6f4a5bc0) (cherry picked from commit 4e82bfb26fcb189d18ca6f0e3dbdf79c8b28bf90)
2018-04-20sw lok: Accept / reject change is always enabled in the context menuTamás Zolnai2-17/+16
Use conditional fastcall for allow executing these two uno commands even if there is no tracked changes at the cursor position instead of enable the menu slots unconditionally. See also: b6011f07254f8003929320ad842d8d09daca0e09 Reviewed-on: https://gerrit.libreoffice.org/53148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 67919621cb0b95074c4401bdfced9d87b230cc2f) Change-Id: Iaf8a8082961cd174c038fc021d2c41fb7cb97bff Reviewed-on: https://gerrit.libreoffice.org/53181 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-04-20Don't crash when opening templates via WebDAVJan-Marek Glogowski1-2/+3
When loading a ODT template via HTTP, it crashes LO with an lang::IllegalArgumentException in LockFileCommon::ResolveLinks. This happens when closing the loaded template, as LO tries to remove a not-existing lock. aDocURL at this point is empty, so HasError() is true. As stated in the comment, we don't need a lock for documents created from templates, as this opens an internal copy of the document, so don't mark the teplate document as locked. Change-Id: Ide60020b6287aa67861dbcc8ec1b94f37896b7ef Reviewed-on: https://gerrit.libreoffice.org/42485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit f95e7ef38e0bf79fa9662bfd50de612d50ef71de) Reviewed-on: https://gerrit.libreoffice.org/53194 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-04-18tdf#116420: Windows: Test if a filepath redirects to a WebDAV resourceMike Kaganski1-1/+8
In Windows, filesystem redirectors can map WebDAV resources to UNC paths, or to drive-based "local" paths; so a WebDAV URI of the form "http://WebDADServer/root/directory/File.ext" may be accessed using "\\WebDADServer\root\directory\File.ext" or "Z:\directory\File.ext". When using these paths, failure to create a lockfile aside the opened document should not be considered an error; so this patch checks for this. Regression from commit 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e. Change-Id: I1de55b66447dc91d22b6d2b5b121de96bf32e4ee Reviewed-on: https://gerrit.libreoffice.org/53070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 642a49e8d3006d000bc6c58def34d4e96764c6cc) Reviewed-on: https://gerrit.libreoffice.org/53080 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-04-10sw lok: View jumps to cursor position even if it is moved by an other view.Tamás Zolnai1-0/+16
Scrolling is done twice. Once in SwCursorShell::UpdateCursor() by SCROLLWIN flag. Here we can check the actual viewid and avoid scrolling if the cursor is move by an other user. The second instance in the LO online code, for it we need to pass the viewid identifying the view which moved the cursor. Change-Id: I033274f88ce41acbb632e2aeb0d986ab11cd2d52 Reviewed-on: https://gerrit.libreoffice.org/52220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/52675 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-04-06tdf#116628: Fix expanding the entries in Help's Contents tab.Jan Holesovsky1-1/+2
Change-Id: I50627ca577bf89810c716bf9e1db9ae74cec58d1 Reviewed-on: https://gerrit.libreoffice.org/52474 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2018-03-19lokdialog: Set parent for AutoCorrect Options... so that it can be tunneled.Jan Holesovsky1-1/+2
To get this dialog: Right-click on a mis-spelled word, and it's in the tunneled context menu. Still it should be converted to async though. Change-Id: Ia8f2aaf0d04f144c74999107de98e52cd51876e7 Reviewed-on: https://gerrit.libreoffice.org/51441 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-14tdf#104349, tdf#104668 MS Word compatibility trailing blanks optionVitaliy Anderson1-1/+6
The commits: 1c1747ac13a9d895df0fcba2fbb1bd266dccd74b and 4a410dd147f7160c1d62e3e0b67388a178d5136c make trailing spaces and their highlighting compatible with the Ms Word. The option is enabled by default for imported MS Word formats: .doc, .docx, .rtf For the ODF files the option is disabled by default Also it allows saving and loading the option state to the ODF UserData. It may be manually set in Tools->Options->LibreOffice Writer->Compatibility Reviewed-on: https://gerrit.libreoffice.org/33046 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 7fa20da88a4778bdf20d6ca0491fe97ae03ab554) Change-Id: I5a86359c52d18e50bbb54b9f37c79b672591c369
2018-03-12tdf#115742: allow ignoring stale lockfile on saveMike Kaganski1-14/+37
This change reuses TryLaterQueryBox, but only uses the new option to ignore the lock and save. Other options ("Try Again" and "Save As") are not used, because this functionality is not implemented currently (TODO/LATER). Change-Id: Idf825be23cf97d2b338c0cf5d532f8460843bf48 Reviewed-on: https://gerrit.libreoffice.org/50371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50409 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-03-12Let sysadmins disable individual file format filtersAndras Timar3-4/+21
It makes sense to disable a filter, as a temporary security measure, when there is a 0-day vulnerability in it. E.g., when 0-day found in AbiWord filter, this config snippet disables it: <item oor:path="/org.openoffice.TypeDetection.Filter"> <node oor:name="Filters"> <node oor:name="AbiWord"> <prop oor:name="Enabled" oor:finalized="true"> <value>false</value> </prop> </node> </node> </item> Reviewed-on: https://gerrit.libreoffice.org/50961 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 4547fa2c1e205e1989611b1c4493cbbd12541372) Change-Id: I8b84250c7e4aac3555877d23f58ed13a2210ebfc Reviewed-on: https://gerrit.libreoffice.org/51058 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-27lo chart2: The LokChartHelper must post the mouse events too.Jan Holesovsky1-19/+22
Calling directly causes freezes in Execute() when instantiating dialogs. Change-Id: I3aa09b99e5a13027892aeba02860e87e29b172da Reviewed-on: https://gerrit.libreoffice.org/50419 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2018-02-21lok: support of AutoCorrect -> While Typing menu in WriterAndras Timar1-0/+1
Change-Id: I7c07f3a6269cd4b92cc50f7aaf847faf04665029 Reviewed-on: https://gerrit.libreoffice.org/50068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit e73cba0cea07eedee5507535f585e89e42ea0124) Reviewed-on: https://gerrit.libreoffice.org/50076 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-14Windows build fixTamás Zolnai1-2/+2
Related to this commit: 83202ea1341c98a216871f14702548ce5aabd94a Change-Id: Ied2184f27650219d807095838941400590731817 Reviewed-on: https://gerrit.libreoffice.org/49743 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Henry Castro <hcastro@collabora.com>
2018-02-09-Werror=int-in-bool-context (GCC 7)Stephan Bergmann2-2/+2
Change-Id: I69f31a94f3e57b3488c576f8d8e0569f459a2117 (cherry picked from commit c65d6e9e5dc4f7d13be582bfb5206caeb7b51ba4)
2018-02-09sw lokit: add page syles to header & footerHenry Castro1-3/+22
Change-Id: I3c0b0603d1e03f1cc19af4324dd2b909320d9d4a Reviewed-on: https://gerrit.libreoffice.org/47687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/48236 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-09tdf#108210: Allow to ignore a lock file if there's no filesystem lockMike Kaganski4-58/+165
Two cases are handled: when a file is being opened, and when it was opened read-only already, and one tries to reopen it in edit mode. The option to ignore locking and open the file anyway is only offered when there is no filesystem lock present on the file. Change-Id: I377d3cae4c949ae64d449634acea8fb3f68a5700 Reviewed-on: https://gerrit.libreoffice.org/49448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/49470 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-02-09Improve tdf#106942: always erase empty/corrupt lockfileJuergen Funk1-2/+4
also when we could not create lockfile, not only when open as readonly Change-Id: Ied53bbfe47669f62553d97d81f0bed156ae58887 Reviewed-on: https://gerrit.libreoffice.org/39054 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/49469 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-02-09tdf#106942 Wrong message when lock file is empty or corruptJuergen Funk1-53/+95
1. Erase empty or corrupt lockfile, when reading it fails and skip "Locked Document Dialog" in that case 2. Show Dialog (use LockFileIgnoreRequest -> LockFailedQueryBox) when create lock file is not possible. Two Dialogs: "lock file create error" and "empty lockfile is present" Set the document to read-only when creating lockfile is not possible. If lockfile is corrupt or empty, inform the user. They can interrupt loading the document or open it read-only, which also erases the corrupt lock file after closing the document 3. Handling for the two Dialogs Use LockFileIgnoreRequst for create lockfile error and add a new LockFileCorruptRequest, (lock file is corrupt). Change and generate new messages for both dialogs in english Change-Id: I35c377f85b5113e8ffb89d83b9544b8ebc81d89f Reviewed-on: https://gerrit.libreoffice.org/36658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/49468 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-02-08add EULA button to Help - License Information... dialogAndras Timar2-2/+43
Change-Id: I62b9293c68059389a63e523ea5747fdb267b1a99 Reviewed-on: https://gerrit.libreoffice.org/49398 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 97d66828b6a2fcf495c89211a3d0cd648516e72a) Reviewed-on: https://gerrit.libreoffice.org/49432 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-01-25lokdialog: No need to notify 'close' callback herePranav Kant1-7/+0
This is now handled in Dialog::dispose Change-Id: If6703dbf1fa02c3d83debcc17eba3c6b1ee49a1c Reviewed-on: https://gerrit.libreoffice.org/48622 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-25lokdialog: Fix incorrect dialog sizes sent to clientPranav Kant1-3/+2
GetSizePixel triggers pending resize handler and gives more correct sizes than GetOptimalSize(). Some of the dialog with inconsistencies in sizes like EditStyle, Manage Changes, etc. are fixed with this patch. Change-Id: I0661b7d2e98233edf0cd2c9c525b271d0724da08 (cherry picked from commit 668deca97d8dd049bb17b6d8b73c4ea73f7b8b9c) Reviewed-on: https://gerrit.libreoffice.org/48560 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-24lok: Send the enabled / disabled state of .uno:TransformDialog.Jan Holesovsky1-1/+2
Change-Id: If2d8e0da6c289deb65dc8a6b38a21dfd5bbfc1bd Reviewed-on: https://gerrit.libreoffice.org/48535 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-01-24lok dialog: enable MessageDialog tunnelingHenry Castro4-45/+12
(cherry picked from commit 18dcf1dca74123659a9fe786921915f7307da147) Change-Id: I344530471c650b3b70c5c9900d86df735c09a09d Reviewed-on: https://gerrit.libreoffice.org/48122 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18sw lok: enable Page Header/FooterHenry Castro1-1/+3
Reviewed-on: https://gerrit.libreoffice.org/39782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 3ba914c229adfed5c917d1ee23d35b9184b092c4) Change-Id: I5e0d080c53079069a086f06c2a314b6372bf6391 Reviewed-on: https://gerrit.libreoffice.org/47830 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-18lokdialog: No modal mode in LOKPranav Kant1-0/+5
... otherwise the cursor in the document goes invisible as soon as the dialog is launched. Change-Id: I77bc30879550b354e1a9593db3c2db7ad3c68193 Reviewed-on: https://gerrit.libreoffice.org/48126 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 0e8d0fe001ceecea95ad7115b835527e13252a17) Reviewed-on: https://gerrit.libreoffice.org/48127 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18sfx2 store: handle NoFileSync for Save (not SaveAs)Miklos Vajna4-2/+10
The code-path in SfxMedium and lower layers is the same, but not in SfxObjectShell. (cherry picked from commit e90a16d71cdcfbd785401613a2e5a29cb1167acf) Conflicts: sfx2/sdi/sfx.sdi sfx2/source/doc/guisaveas.cxx Change-Id: I85542d17cd6b3c2a0d257f5ff196e6504a194e51 Reviewed-on: https://gerrit.libreoffice.org/47980 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18ODT export: handle NoFileSync store optionMiklos Vajna1-0/+9
SfxMedium already had a m_bDisableFileSync member; if the medium has a storage, then forward this flag to it, so at the end SwitchablePersistenceStream::waitForCompletion() (and the called fileaccess::XStream_impl::waitForCompletion()) does not call osl_syncFile(), either. Times for 100 hello world inputs: 12594 -> 5281 ms is spent in XHTML-load + ODT export + close (42% of original). (cherry picked from commit 16a522361698ea53ab253d67e31cb51802210d71) Conflicts: package/inc/ZipPackage.hxx package/source/xstor/xstorage.cxx Change-Id: I2aab6c9e6baf133b211620004dcea66bd41ffc6f Reviewed-on: https://gerrit.libreoffice.org/47979 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18sfx2 store: add API to allow avoiding the fsync of the output fileMiklos Vajna4-7/+21
The use-case is when the consumer of the output file will read it right after SfxBaseModel::storeToURL() returns, in which case an expensive fsync is pointless. Times for 100 hello world inputs: 8516 -> 2785 ms is spent in ODT-load + HTML export + close (33% of original). (cherry picked from commit d03a754722980a4eaf14fce38d73ae23b604295b) Conflicts: sfx2/sdi/sfx.sdi Change-Id: I05e424a43ebfeea363f82b57af60f5aaa28696b4 Reviewed-on: https://gerrit.libreoffice.org/47978 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18lokit: add .uno:DocumentRepair commandHenry Castro5-1/+41
Change-Id: I5b13ea6f4785bc91c29111fa63c4a1b0ea9b2660 Reviewed-on: https://gerrit.libreoffice.org/38908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/47915 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-15lokdialog: Allow closing the Format Cell dialogs in any order.Jan Holesovsky2-13/+41
Includes also lots of infrastructural changes, making the conversion of the rest of the dialogs much easier. StartExecuteAsync should be used in-place of StartExecuteModal and the latter removed from the code-base incrementally. More common code from Dialog::Execute should be moved to ImplStartExecuteModal in a next step, as this is used more widely. Change-Id: Idb2c1ec790e38f582438471a0419a56cdcf1439d Reviewed-on: https://gerrit.libreoffice.org/47817 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-05lok: send modified status when applying cell-formula before savingAshod Nakashian1-0/+11
Without this, the modified status resulting from applying the cell-formula immediately before saving is lost, since it is clobbered after the save. Change-Id: Ie402812d0fc0528020161fffe57e8220c5abfeb5 Reviewed-on: https://gerrit.libreoffice.org/47368 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 530f163eee03fffe60f2c2a6413441693f682496) Reviewed-on: https://gerrit.libreoffice.org/47396
2018-01-04lokdialog: Use only one of the installed langpacks when setting locale.Jan Holesovsky1-0/+7
Change-Id: I446775b121b7806a549f4dbbaa1f2dcf019d9bc2 Reviewed-on: https://gerrit.libreoffice.org/47334 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-04lokdialog: Allow language switching in SfxModule(s).Jan Holesovsky1-8/+15
Change-Id: Icef0b3610c3bfa858cdd61de6ef3f5edc1e3c96b Reviewed-on: https://gerrit.libreoffice.org/47333 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-12-21tdf#104229: properly switch to def sidebar deck on status changeAron Budea1-1/+1
regression since a64999511ae654131d997eec9a3d78478cfc1c75 Change-Id: Id1d0a76f89c41e88511f670f1aac4b866e4c15c6 Reviewed-on: https://gerrit.libreoffice.org/46840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit f2f5ebcee462472b27b610f53abc7f9a6378462b) Reviewed-on: https://gerrit.libreoffice.org/46900 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2017-12-20tdf#99537 set expand for re-used sidebar panelsJan-Marek Glogowski1-0/+1
When re-using a panel, reset the expand state from the stored state in the PanelContexDescriptor. Change-Id: I00851982bbd36cacdc57459bb6e5be9fcc719e81 Reviewed-on: https://gerrit.libreoffice.org/43466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit ce2e94a98f5fc85bef7623a0227b3a95d8093288)
2017-12-18vcl: rename Window::Notify to EventNotifyMichael Stahl13-49/+55
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49 (cherry picked from commit 6bb20609a2fd1d591cedc7fa2b9cabb589c346c7) (cherry picked from commit 03bfafb36107d18c0cccf53efdd550c0b7a81b8f)
2017-12-18convert SFX_VISIBILITY constants to scoped enumNoel Grandin5-79/+98
* split the position and the flags information * remove unused DESKTOP constant Change-Id: Ibfccb44c7567e89d4527bfd36b3915a73682e6e2 (cherry picked from commit 5af0071d42e5962ed849261134ef0630c7ec3b45) (cherry picked from commit 82577130d5a1e40396053e86fd0d7beb14170fbd)
2017-12-18convert SFXWB_ constants to scoped enumNoel Grandin1-8/+8
Change-Id: I63d442e51b7e22093da1c232e1b575bc961c0e69 (cherry picked from commit 0e04b531448d7915b40c59dccef7a9313bd28c11) (cherry picked from commit e14539d0ed367e377346cbc0247b4c3e3637c35e)
2017-12-18convert DecodeMechanism to scoped enumNoel Grandin37-178/+178
(cherry picked from commit bfde4866e07746eafa2f0d6173c29d805cc35ad0) (cherry picked from commit 3de922d4a695e253d4ca2d42b70e0b35b52e9b7c) Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2017-12-18convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin6-31/+31
(cherry picked from commit 803215142efa6437515348f63bd70ffdcf5d45f1) (cherry picked from commit 736cd289d4cdb0db61d92134bcc9d48aa7e79613) Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2017-12-15Handle resmgr lifecycle with vcl's de-init more cleanly.Michael Meeks1-2/+3
Change-Id: Iee5f54edc09d0df7062ffdcb301876fcec791373 Reviewed-on: https://gerrit.libreoffice.org/46562 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-12-15lokdialog: If we already have the title, emit it during creationPranav Kant2-8/+16
Some dialogs load the UI before we "Execute()" the dialog, or before the dialog fires the InitShow event. In those cases, the title event has already been fired and won't be fired after dialog is created. Make sure that we send the title for such dialogs. While at it, remove the superfluous std::make_pair calls to emplace_back. And consistently use emplace_back everywhere, not push_back Change-Id: Ib66238298ad9b0dc85bd269aff37aeadf1fc82e4 Reviewed-on: https://gerrit.libreoffice.org/46461 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-12-14lokdialog: Send close callback when dialog dissappears tooPranav Kant1-8/+14
Change-Id: I88bea3dc1ae938d31462e85ca1a8f48dd13e8e89 (cherry picked from commit 76de866e162502518acbc0ab020c257b80946c2d) Reviewed-on: https://gerrit.libreoffice.org/46439 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-12-14LOK: Honor the user's language when issuing help.Jan Holesovsky1-0/+3
Change-Id: I2cfe5e5ae0e10dffb7b5672fccdc71af6060491d Reviewed-on: https://gerrit.libreoffice.org/46435 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-14lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky1-11/+10
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-14LOK: fix URL launching, so that Help buttons work.Michael Meeks2-0/+42
Change-Id: I9efe0173c35341043c3402042d9aa364a03e4fc5 Reviewed-on: https://gerrit.libreoffice.org/46419 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-12-13lokdialog: State change events for dialogs uno commandsPranav Kant1-1/+7
Change-Id: I92f60e717cd2a0695c8b86b103076d26c0c22cef (cherry picked from commit 98da350c7c9bcb96937f1397a34c2c68ede44011) Reviewed-on: https://gerrit.libreoffice.org/45941 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-12-12lokdialog: Allow windows / dialogs in different languages.Jan Holesovsky2-0/+18
Change-Id: I9f32161981aed73e6d97696e5f976af276d1625a Reviewed-on: https://gerrit.libreoffice.org/46327 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-09lokdialog: Make hyperlink dialog workPranav Kant1-0/+1
(partially cherry picked from commit 7bcb9a8416d61bdd3c7fc345f87de5aa8c3054f9) Change-Id: Ifd8c721b001b09ddab8d4fe06ae6818980d6ee76 Reviewed-on: https://gerrit.libreoffice.org/46017 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-05remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2e8acde112e1c6754df26902e79a78346ba45a2d) Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/45452 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 2887aefa4d4f60ba8b0cd7efd5d3a73ffb209781)