summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2017-01-01tdf#105011, tdf#104795: copy string until its end if there's no commaJulien Nabet1-2/+4
5 0x00002aaab055f81e in rtl::OUString::copy (this=0x7fffffff29d0, beginIndex=3, count=-4) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223 6 0x00002aaab070acd2 in (anonymous namespace)::GetContentPart (_rRawString="CN=timur.davletshin@gmail.com", _rPartId="CN") at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:748 7 0x00002aaab070dd85 in SfxDocumentPage::ImplUpdateSignatures (this=0x55555ca2e0b0) at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:901 so do the same as GetContentPart from uui/source/secmacrowarnings.cxx (I suppose we should avoid the redundancy but that's another story) Change-Id: Ief3ce1cce7035fb572778bdee02a1073b7dfe1c1 Reviewed-on: https://gerrit.libreoffice.org/32530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 5e149b630bd837ca6c8cae609a5c148f25f9ee82) Reviewed-on: https://gerrit.libreoffice.org/32533 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-14That's probably not meant to be a C++ reference to a uno::ReferenceStephan Bergmann1-1/+1
...as introduced with e75f6e549eb825c310d16d11babf0fba5ee7fd7a "sfx2: make SfxClassificationHelper not require a full doc shell". Made CppunitTest_sfx2_classification crash now when dereferencing m_xDocumentProperties in SfxClassificationHelper::Impl::pushToDocumentProperties, when built with a recent Clang trunk build. Change-Id: Id0b7fa0627b9642f748f07d7dfa05353114225fa (cherry picked from commit e90b004a41153770e672bb1d4524852499ab0ca5) Reviewed-on: https://gerrit.libreoffice.org/32003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-10Related: rhbz#1397939 crash with null pSidebarControllerCaolán McNamara1-2/+2
Change-Id: I7627ff30564b2de61669c71dafd15e7b1778b5c6 (cherry picked from commit f5edbb4158e86bfea7267115395b64e60fd61dc7) (cherry picked from commit 5768416761756a386cba54314f783cb9c0d0d093) Reviewed-on: https://gerrit.libreoffice.org/31787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-05usageinfo causes one of our more frequent fedora 25 crashesCaolán McNamara1-2/+10
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=17ba9a57f40d5ca29778866a9f96c1c0dfc7593c&bth=2f1801e44e9cb0be2b013624521fb0959dc2c73a&bth=5e8a1e07503f53b13b3a6779084f8b0637aaf5a7&bth=8033013a2ce586bccc23245583fa86ef4a761dce&bth=975271167132418534cb07336601efb5b0c711f0&bth=de75c2ad7917bc889d6307b152f79d34e79ce74d Change-Id: Ie93afa476eca9fdbf7ea17ff0189fbaa493a5531 (cherry picked from commit a064f1226b9864f0d0ef6d969f2ae53cc413eb51) Reviewed-on: https://gerrit.libreoffice.org/31554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-11tdf#100352 Backport ca-ES, fr-FR and nl-NL classification filesLaurent Balland-Poirier4-0/+229
Change-Id: I561ff1906c1ddfde5d66d31270633fc4de94589b Reviewed-on: https://gerrit.libreoffice.org/30775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07tdf#62625 - reopen temp stream to readBasic .xls VBAJustin Luth1-1/+2
InputStream was closed, but an InStream was still open, so InputStream was not being re-created. Apparently either most web protocols aren't properly closed, or else a second stream is needed for these kinds of protocols. Required on Linux for INetProtocol::Http, Generic, Smb, Sftp and perhaps more. Required on Windows/Mac for Remote WebDAV (although http://xx/xx.xls worked) Change-Id: Icb732518fb8185168c5ed1cb9e32c84c9d8d71bb Reviewed-on: https://gerrit.libreoffice.org/30303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit d9c7b0a01162254240a1328fa594991eccf6bc65) Reviewed-on: https://gerrit.libreoffice.org/30662 Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-10-18Resolves: tdf#101590 cannot interact with filepicker from import categoryCaolán McNamara1-4/+6
the post-execute category dialog is picked as the toplevel parent, and gtk3 vclplug will grab events to that hierarchy, but can't interact with them in this state. Just dispose the category dialog so its not a candidate for the file dialog parent. Change-Id: I063fc6d687d556db229e2e200bb280a6cd3425f5 (cherry picked from commit c7ac773480bfbfcaac15c9bfdeeab400028a96d4) Reviewed-on: https://gerrit.libreoffice.org/29993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-17tdf#92817: re-implement empty lockfile fixMike Kaganski1-4/+2
As stated in original commit 8d411a4a1ef6844c00bc714f8b144d3729e4f4e8, An empty lock file doesn't have OOOUSERNAME and SYSUSERNAME. Change-Id: I17fc6d3375f411749fcbbe80535beb8ba53a0e71 Reviewed-on: https://gerrit.libreoffice.org/29836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-12tdf#101812 Dont switch to templates view when opening template managerYousuf Philips1-5/+0
Change-Id: I3671de21b04f50045c1b7d209e745e2678b7c6f9 Reviewed-on: https://gerrit.libreoffice.org/28808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-12Resolves: tdf#101921 no tab navigation in style&formatting sidebarCaolán McNamara1-1/+1
Change-Id: I737ed446d0ead9d748873fec90b62dcced35e328 Reviewed-on: https://gerrit.libreoffice.org/28767 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3d7d318914bd69262da647e0db23ec47d6550afe) Reviewed-on: https://gerrit.libreoffice.org/28770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-06tdf#101779 Allow multiline tooltips in template managerMaxim Monastirsky1-0/+14
Based on 0c3a9aa403c209e522dc5c32258c33381677c91e Also includes: Related: tdf#101779 TipStyleBalloon for ShowQuickHelp too 681294d55b6b4edcdef08982596cb4bcee32e635 converted TableDataWindow::RequestHelp to use ShowQuickHelp, but it wants to set TipStyleBalloon to be able to use line break. Also I want to do the same in the template manager dialog, in the following commit. (cherry picked from commit 331d3a8b23cdbff0e1434aa5a553efdcc2c7c822) Change-Id: Ie2569a5ab29620a5f4474dafd2309513c08bd7d2 Reviewed-on: https://gerrit.libreoffice.org/28701 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-06tdf#101115 Make save as template dialog accessibleYousuf Philips1-0/+4
Change-Id: I59dba20aa0a812d0ea27dd3a3a58d856b736318c Reviewed-on: https://gerrit.libreoffice.org/28674 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-01let's make Impress crash less - SfxStyleFamily editionMichael Stahl3-33/+42
Commit bcb41235deaf4b7ca90522bda3ba21a686819e6e - in addition to introducing the enum SfxStyleFamily - inconsistently converted one call of DrawDocShell::SetStyleFamily to use enum SfxStyleFamily instead of a mysterious "5", but did not adapt all of the code that extracts the SfxUInt16Item that subsequently extracts this value and expects a number 0-5. Since it's clearly inexcusably stupid to have 2 different public sets of integers identifying styles, make the usage of the second "array index" integers private to templdlg.cxx; the SfxUInt16 item now always contains enum SfxStyleFamily. (regression from bcb41235deaf4b7ca90522bda3ba21a686819e6e) (cherry picked from commit 75c39b903f06b656293edf20ec4a5173a0755fb6) sfx2: SfxCommonTemplateDialog_Impl can't even decide if... ...no family selection should be represented as "0" or "0xffff". (cherry picked from commit 813a8944bdb337a0018208381aa30118151872ff) Change-Id: I333575c504277c2046f8f5a6b36ae3f86b3b3201 Reviewed-on: https://gerrit.libreoffice.org/28569 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-16gtk3: style combobox never becomes sensitive if it starts insensitiveCaolán McNamara1-14/+25
Place cursor inside a protected section in writer, e.g. a table of contents. Save, and reload. The cursor starts inside the protected section. With the native gtk3 menubar the styles dropdown in the top left is grayed out. Moving the cursor outside the protected area does not make it active again. Under gen it works fine. *Extensive* debugging shows that there is a cache based on the numeric slots of commands to their dispatcher, e.g. SfxBindings::GetStateCache so if you SfxBindings::QueryState for a given uno command then it will look up what dispatcher to listen to by slot id. This StyleApply command appears in a number of places in LibreOffice, the toolbar as .uno:StyleApply, *but* .uno:StyleApply?A_Bunch_Of_Args elsewhere in the menus. In the gtk3 plugin it so happens that all the menu items are parsed and listeners set before the toolbar is created. While in the gen plugin the toolbar is created, and the menus are on-demand later. So under gen the dispatcher is created for ".uno:StyleApply" and other .uno:StyleApply?* go through that one. Under gtk3 the dispatcher is created for ".uno:StyleApply?A_Bunch_Of_Args". So, when SfxDispatchController_Impl::StateChanged is called, the aDispatchURL.Complete argument is ".uno:StyleApply?A_Bunch_Of_Args", but, because it was supplied as a cached result from the shared slot, some listeners have been added that want to listen to ".uno:StyleApply". The name doesn't match, so looking up the listeners listening to the command with argument finds nothing, so those listeners on the name without argument are not fired. Here I look up all the property names that the listeners were added to listen to (1 in all cases I've seen in casual testing) and if either the name with full args or no args matches then inform that listener that something has changed. Change-Id: Ib5858ccb16dce41e249ee911751053fd277551b8 (cherry picked from commit d9bf3df8143779f0caea2094efa4891370038977) factor this status change code out no logic change intended Change-Id: I74e58f61fdb5d9684384dac5ba9803fc2d411ca7 (cherry picked from commit f2a60c783a8099f07b05f25301833f405c161d59) Reviewed-on: https://gerrit.libreoffice.org/28058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-09no range based for loop when container is modified, tdf#100870, tdf#101320Markus Mohrhard1-1/+2
This crash has been responsible for around 20% of the 5.2.0.4 crashes with backtraces for the modification of the container similar to: sxlo.dll!SfxWorkWindow::SetChildWindowVisible_Impl(unsigned long lId, bool bEnabled, unsigned short nMode) Line 1834 C++ sfxlo.dll!SfxDispatcher::Update_Impl_(bool bUIActive, bool bIsMDIApp, bool bIsIPOwner, SfxWorkWindow * pTaskWin) Line 1452 C++ sfxlo.dll!SfxDispatcher::Update_Impl(bool bForce) Line 1326 C++ sfxlo.dll!SfxApplication::SetViewFrame_Impl(SfxViewFrame * pFrame) Line 372 C++ sfxlo.dll!SfxViewFrame::SetViewFrame(SfxViewFrame * pFrame) Line 3138 C++ sfxlo.dll!SfxViewFrame::MakeActive_Impl(bool bGrabFocus) Line 1697 C++ sfxlo.dll!SfxFrameWindow_Impl::Notify(NotifyEvent & rNEvt) Line 111 C++ vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747 C++ vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198 C++ vcllo.dll!DockingWindow::Notify(NotifyEvent & rNEvt) Line 633 C++ vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747 C++ vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198 C++ vcllo.dll!DockingWindow::Notify(NotifyEvent & rNEvt) Line 633 C++ sfxlo.dll!SfxDockingWindow::Notify(NotifyEvent & rEvt) Line 1655 C++ vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747 C++ vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198 C++ vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747 C++ vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198 C++ vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747 C++ vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198 C++ vcllo.dll!Control::Notify(NotifyEvent & rNEvt) Line 274 C++ vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747 C++ vcllo.dll!vcl::Window::GetFocus() Line 1842 C++ svtlo.dll!SvTreeListBox::GetFocus() Line 2096 C++ swlo.dll!SwContentTree::GetFocus() Line 2571 C++ vcllo.dll!vcl::Window::CompatGetFocus() Line 3716 C++ vcllo.dll!vcl::Window::ImplGrabFocus(GetFocusFlags nFlags) Line 384 C++ vcllo.dll!vcl::Window::GrabFocus() Line 3004 C++ swlo.dll!SwNavigationPI::SwNavigationPI(SfxBindings * _pBindings, SfxChildWindowContext * pCw, vcl::Window * pParent) Line 835 C++ swlo.dll!VclPtr<SwNavigationPI>::Create<SfxBindings * __ptr64 & __ptr64,SwNavigationChild * __ptr64 const,vcl::Window * __ptr64 & __ptr64>(SfxBinsfdings * & <arg_0>, SwNavigationChild * const && <arg_1>, vcl::Window * & <arg_2>) Line 131 C++ swlo.dll!SwNavigationChild::SwNavigationChild(vcl::Window * pParent, unsigned short nId, SfxBindings * _pBindings, SfxChildWinInfo * __formal) Line 1306 C++ swlo.dll!SwNavigationChild::CreateImpl(vcl::Window * pParent, SfxBindings * pBindings, SfxChildWinInfo * pInfo) Line 69 C++ sfxlo.dll!SfxChildWindow::CreateContext(unsigned short nContextId, SfxBindings & rBindings) Line 457 C++ sfxlo.dll!SfxWorkWindow::CreateChildWin_Impl(SfxChildWin_Impl * pCW, bool bSetFocus) Line 1436 C++ sfxlo.dll!SfxWorkWindow::UpdateChildWindows_Impl() Line 1328 C++ sfxlo.dll!SfxWorkWindow::UpdateObjectBars_Impl() Line 1283 C++ sfxlo.dll!SfxFrameWorkWin_Impl::UpdateObjectBars_Impl() Line 1114 C++ sfxlo.dll!SfxDispatcher::Update_Impl(bool bForce) Line 1329 C++ sfxlo.dll!SfxBaseController::ConnectSfxFrame_Impl(const SfxBaseController::ConnectSfxFrame i_eConnect) Line 1326 C++ sfxlo.dll!SfxBaseController::attachFrame(const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & xFrame) Line 584 C++ sfxlo.dll!`anonymous namespace'::SfxFrameLoader_Impl::impl_createDocumentView(const com::sun::star::uno::Reference<com::sun::star::frame::XModel2> & i_rModel, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & i_rFrame, const comphelper::NamedValueCollection & i_rViewFactoryArgs, const rtl::OUString & i_rViewName) Line 604 C++ sfxlo.dll!`anonymous namespace'::SfxFrameLoader_Impl::load(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & _rTargetFrame) Line 721 C++ fwklo.dll!framework::LoadEnv::impl_loadContent() Line 1122 C++ fwklo.dll!framework::LoadEnv::startLoading() Line 379 C++ fwklo.dll!framework::LoadDispatcher::impl_dispatch(const com::sun::star::util::URL & rURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments, const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> & xListener) Line 116 C++ fwklo.dll!framework::LoadDispatcher::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments) Line 55 C++ sfxlo.dll!RecentDocsView::ExecuteHdl_Impl(RecentDocsView * __formal, void * p) Line 335 C++ sfxlo.dll!RecentDocsView::LinkStubExecuteHdl_Impl(void * instance, void * data) Line 327 C++ vcllo.dll!Link<void * __ptr64,void>::Call(void * data) Line 84 C++ vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1949 C++ vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2497 C++ vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 282 C++ vcllo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4110 C++ vcllo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, int & rDef) Line 5774 C++ vcllo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5907 C++ [External Code] vcllo.dll!ImplSalDispatchMessage(tagMSG * pMsg) Line 572 C++ vcllo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 591 C++ vcllo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents, unsigned __int64 nReleased) Line 654 C++ vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents, const unsigned __int64 nReleased) Line 510 C++ vcllo.dll!Application::Yield() Line 556 C++ vcllo.dll!Application::Execute() Line 472 C++ sofficeapp.dll!desktop::Desktop::DoExecute() Line 1327 C++ sofficeapp.dll!desktop::Desktop::Main() Line 1646 C++ vcllo.dll!ImplSVMain() Line 177 C++ vcllo.dll!SVMain() Line 216 C++ sofficeapp.dll!soffice_main() Line 165 C++ soffice.bin!sal_main() Line 48 C soffice.bin!main(int argc, char * * argv) Line 47 C soffice.bin!WinMain(void * _hinst, void * _dummy, char * _cmdline, int _nshow) Line 47 C [External Code] Change-Id: I4f699952d144a9c276ce53604dc66418abc4baee Reviewed-on: https://gerrit.libreoffice.org/27977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit b0f4291e5c0fe6d61d621e692cbc8bea4cb4c401) Reviewed-on: https://gerrit.libreoffice.org/27985 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara13-31/+31
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-03Fix the WebDAV lock owner name shown on file locked dialog UIGiuseppe Castagno1-0/+10
Probably due to 8d411a4a1ef6844c00bc714f8b144d3729e4f4e8. See comment in the added code for details. Change-Id: I3e8a856a715385ed2ab1d9ecda31dd25e05e6c59 Reviewed-on: https://gerrit.libreoffice.org/27716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> (cherry picked from commit 97353e5c43815b45a6f365ccaea474899683d38e) Reviewed-on: https://gerrit.libreoffice.org/27728 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-23tdf#101087 Add Hungarian example xml for classificationGabor Kelemen2-0/+72
Change-Id: Ic35a2c12973863545397c417704a1e68703daec4 Reviewed-on: https://gerrit.libreoffice.org/27459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 22155f9adbbe853b6e03729605331c06f43972ca) Reviewed-on: https://gerrit.libreoffice.org/27462
2016-07-22tdf#100351 example_pt-BR.xml for classificationOlivier Hallot2-0/+72
Change-Id: I2857d1209b7261cbbbf6908d7e8dde84be3e1da5 Reviewed-on: https://gerrit.libreoffice.org/27371 Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk> Tested-by: Olivier Hallot <ohallot@collabora.co.uk> (cherry picked from commit 2158eb10b4b1013af57c2cbe64575ad7889940ff) Reviewed-on: https://gerrit.libreoffice.org/27449 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-07-20tdf#100351 attempt to fix untranslatable stringOlivier Hallot1-2/+1
string "National Security" was not ported to pootle. Change-Id: I35b4659f5b5e239e86a7c0517c5a9a719a2aa612 Reviewed-on: https://gerrit.libreoffice.org/26309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk> Tested-by: Olivier Hallot <ohallot@collabora.co.uk> (cherry picked from commit ee24e7f2b689bf0f63ba618fc7ee7ac6bc644172) Reviewed-on: https://gerrit.libreoffice.org/27332 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-07-18tdf#100600 sfx2 classification: never replace the control with labelMiklos Vajna1-1/+3
Thanks to Caolán McNamara for pointing out where is the condition of the replacement in VCL. (cherry picked from commit 8192da8e4de7a058ef95253f992f4143f83fa0f1) Change-Id: I7e1ef4a016a37b25e084c4c6467a42ca557069a4 Reviewed-on: https://gerrit.libreoffice.org/27214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-17Resolves: tdf#100910 yes/no doesn't clear bgCaolán McNamara1-2/+2
Change-Id: If6a31cefe7137d338a57b5a28dfda63809957190 (cherry picked from commit 997c7accd393bc665538403a5738ce1a626d9665) Reviewed-on: https://gerrit.libreoffice.org/27259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-10tdf#100352 Make the watermarks and colored infobar work in SlovenianAdolfo Jayme Barrientos1-15/+15
The elements <baf:Scale> and <baf:Identifier> must match the values set in sfx2/source/view/classificationhelper.cxx to work. I moved the translated words to their proper place. Change-Id: Id860a375654e371742ba15435d3e73506ef5ef0e Reviewed-on: https://gerrit.libreoffice.org/26685 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 30f81c01d247cdffa0de86367d5f2be80887a251) Reviewed-on: https://gerrit.libreoffice.org/27076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-07-08Resolves: tdf#100692 crash in sidebar on deleting image from writerCaolán McNamara1-3/+3
stumbled on this in passing and it has the same bt as http://crashreport.libreoffice.org/stats/signature/vcl::Window::setPosSizePixel(long,long,long,long,PosSizeFlags) Change-Id: I1f19275029b05f353dfa823a2ff435e5045250a6 (cherry picked from commit 675c8faefd8756f7c43312f23eb341797bcbca4d) Reviewed-on: https://gerrit.libreoffice.org/26804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-06-26Slovenian example.xml (related: tdf#100352)Andras Timar2-0/+72
Change-Id: I2538b3d1b0197abb07d76b903b824ebbd36695c3 Reviewed-on: https://gerrit.libreoffice.org/26597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 9b6a02d8d48c135103aaa980fd27eec07b9223b6) Reviewed-on: https://gerrit.libreoffice.org/26678 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-24package: fix exception handling in DeflateThread (related tdf#91807)Michael Stahl1-3/+3
In the bugdoc of tdf#91807 there are at least 49 corrupt zip streams that raise exceptions in the DeflateThreads. Because the maximum allowed number of threads happens to be 48, this results in an infinite loop in ZipOutputStream::reduceScheduledThreadsToGivenNumberOrLess(). (regression from 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14) In case an exception is thrown, don't re-throw it immediately, which might cause trouble such as leaking all of the ZipOutputEntry instances in m_aEntries. (cherry picked from commit 8d8b9b80b114b94b20b0bf1438d80e925b49e3bf) sfx2: exception on storage commit is an error (related: tdf#91807) For no good or obvious reason, SfxMedium::StorageCommit_Impl() swallows embed::UseBackupException if there is a pTempFile, which (as the comment claims) is "always now". This results in the temp file actually being copied to the user-visible file and the SaveAs "succeeding", when it clearly did not. Also move the exception throwing to the end of ZipOutputStream::finish() to avoid more memory leaks. (cherry picked from commit 9084c11fb472f2024e609770ce922c911227e7a8) Change-Id: I448cc43291754ef20adfa6b65916282fcc365a11 Reviewed-on: https://gerrit.libreoffice.org/26619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-21tdf#100352 sfx classification: support localized policy filesMiklos Vajna1-0/+14
The example policy is at: instdir/share/classification/example.xml If there is a localized version, e.g.: instdir/share/classification/example_hu-HU.xml (same syntax as already used for the autocorrect files), then use that instead of the configured policy. (cherry picked from commit 1811e656f08ba011a3c2a51cc60e90d2fa58e4c2) Change-Id: I0369e69f90a633af0676981f0c5760f8477b3c8c Reviewed-on: https://gerrit.libreoffice.org/26549 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-17tdf#79198 START CENTER: Close button doesn't reappear after being clickedAkshay Deep1-0/+6
Change-Id: I23e3aed71eec85e8b8f0aceac125809fd56be4d5 Reviewed-on: https://gerrit.libreoffice.org/26399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 27bd030aa033565dfdff56c298c797c80cee5160) Reviewed-on: https://gerrit.libreoffice.org/26415 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-17tdf#100423 Template Manager: ctrl + A and del should work correctlyAkshay Deep4-5/+12
Change-Id: Ibe0326827e6dacb670bb948ca4f6e9797ab7edeb Reviewed-on: https://gerrit.libreoffice.org/26374 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 5b8c86f2a3eb5e092fb96f5ae2eaf58c10c8f4f0) Reviewed-on: https://gerrit.libreoffice.org/26403 Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-15Template Export: Don't overwrite the existing template in a directoryAkshay Deep1-1/+1
Change-Id: I19470c7eeb961665cb5248861b030479a0796a24 Reviewed-on: https://gerrit.libreoffice.org/26290 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 4f61b652323e1bde5c45bc9dece3c61b2f69b83d) Reviewed-on: https://gerrit.libreoffice.org/26312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-15Hide Notebookbar in 5.2Samuel Mehrbrodt1-3/+3
Make it inaccessible since it's highly incomplete. Change-Id: Ia3f04fdcd2fcf7552edd5a93b6095228d8367406 Reviewed-on: https://gerrit.libreoffice.org/26296 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13Code cleanup: No need to explicitly show tooltips in Template ManagerAkshay Deep1-6/+0
Change-Id: I32b0bb79c38a91cbafb3075963155d3b38b3012a Reviewed-on: https://gerrit.libreoffice.org/26231 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit a8bd44573b75d1399257d6f5d052611439607189) Reviewed-on: https://gerrit.libreoffice.org/26233 Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-10GSoC: Template Manager: Enable Keyboard shortcutsAkshay Deep5-55/+128
delete key: delete operation shift-f10 and contextmenu: create context-menu ctrl + A: select all Conflicts: sfx2/source/control/templateabstractview.cxx Reviewed-on: https://gerrit.libreoffice.org/26044 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Conflicts: sfx2/source/doc/templatedlg.cxx Change-Id: I97486c050c5dbb88b8551aa8a9bb9ba4285ad003 Reviewed-on: https://gerrit.libreoffice.org/26178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-10GSoC: Template Manager: Add respones for User InteractionAkshay Deep5-35/+46
1. Success message when templates are successfully exported 2. Query message before copy executes when moving templates Reviewed-on: https://gerrit.libreoffice.org/26143 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit ef9e713f6a06191d327dbf236fcc7607d16f61e3) Change-Id: I11048aa7946d623840e45130affe1b848a3da357 Reviewed-on: https://gerrit.libreoffice.org/26162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-10Resolves: tdf#100181 quickstart crashes immediately without QuickstarterCaolán McNamara1-9/+2
Change-Id: I0257651b3841dea596077cfacbf7d69a20b04252 Reviewed-on: https://gerrit.libreoffice.org/26134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit dfb2a8deab1324047a4ed81a131a1ef3552c3e8e)
2016-06-10GSoC: Templates: Display titles and category as tooltipsAkshay Deep7-6/+30
Tooltip text: 1. Template Manager: All Categories: Title + Category Category: Title 2. Start center: Title Conflicts: sfx2/source/doc/doc.hrc Conflicts: sfx2/source/doc/templatedlg.cxx Reviewed-on: https://gerrit.libreoffice.org/26040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Conflicts: sfx2/source/control/templateabstractview.cxx sfx2/source/doc/doc.src Change-Id: I0bfd5e78120f13338f88c1b0617df3a057cce02f Reviewed-on: https://gerrit.libreoffice.org/26139 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09GSoC: Template Manager: Improve "Rename Category" functionalityAkshay Deep1-30/+31
Change-Id: I0b32179133eca5cf01df6d581a25843da40a8a7e Reviewed-on: https://gerrit.libreoffice.org/26043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-on: https://gerrit.libreoffice.org/26137 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-09tdf#100260 Template Manager: Cannot open context menu without mouseAkshay Deep6-14/+61
Change-Id: I900cc79e2834c1942840ee9fb1a8ab680b646c92 Reviewed-on: https://gerrit.libreoffice.org/26082 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 40ca34340e4b387bdce92b86cb572556c5437c7d) Reviewed-on: https://gerrit.libreoffice.org/26104 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-09Hide Default Template icon when resetting default using toolbox menuAkshay Deep2-0/+6
Change-Id: I7a3e7c9413edbdfb74e0415dd7e203d65201eb08 Reviewed-on: https://gerrit.libreoffice.org/26081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> (cherry picked from commit 4599858e21925f2f5febed8eebf4f5bd0fa97163) Reviewed-on: https://gerrit.libreoffice.org/26083 Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-08Template Manager: Enable "Move" and "Export" buttons on right clickAkshay Deep2-0/+2
Change-Id: Ibdf3d0cd721333730638e71d2d5258092074af93 Reviewed-on: https://gerrit.libreoffice.org/26042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit e07f23b148fe95b2418cb9dc5f1d335db8713c9f) Reviewed-on: https://gerrit.libreoffice.org/26065 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-08Missing selected + hover state in Template ManagerAkshay Deep3-3/+13
Change-Id: I35c91cea34953a5c4a78031eb809001e902197f1 Reviewed-on: https://gerrit.libreoffice.org/26013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 934908168ebdb4a021e18e6bea57accc21d5ad86) Reviewed-on: https://gerrit.libreoffice.org/26067 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-08Reset Default in Context Menu for default templatesAkshay Deep6-16/+46
Reviewed-on: https://gerrit.libreoffice.org/25995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Conflicts: include/sfx2/templateabstractview.hxx sfx2/source/doc/doc.hrc Conflicts: include/sfx2/templateabstractview.hxx Change-Id: Ifedb4f5b4dada0e9e0ac40ffcaed4c2821df501d Reviewed-on: https://gerrit.libreoffice.org/26068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-07loplugin:unusedvariablecheckTor Lillqvist1-1/+0
Change-Id: Icbf2138d3ac69fb0022134fb7ceab34935ccdc2a (cherry picked from commit d6efb4e417b3f85782c82fd97788db6b26740a19) Reviewed-on: https://gerrit.libreoffice.org/26034 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-06-07loplugin:passstuffbyrefTor Lillqvist1-1/+1
Change-Id: Ie1cd7d63aaf2963137138def86cf5f4e141569b2 (cherry picked from commit 043b2900aed2f6e2c22e90710302b15afec312b4) Reviewed-on: https://gerrit.libreoffice.org/26033 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-06-07Switch "Delete" and "Rename" in Template context menuAkshay Deep1-4/+4
Change-Id: Ib40a27c25d15c4dd65bbfc4d50f55b16496c7a0a Reviewed-on: https://gerrit.libreoffice.org/26024 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com> (cherry picked from commit 665844d8dd0cf4b3fc6cdb56f3e155704ba76b00) Reviewed-on: https://gerrit.libreoffice.org/26025
2016-06-07Mark Default Templates in Template ManagerAkshay Deep5-1/+71
Reviewed-on: https://gerrit.libreoffice.org/25816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Conflicts: include/sfx2/templateviewitem.hxx Change-Id: I1dff486605efce09e862d2924b24949601ae0f17 Reviewed-on: https://gerrit.libreoffice.org/25974 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-06Hitting return in search field should not open a templateAkshay Deep1-0/+7
Change-Id: I85d8096489debdbda1b3883f9335dd1218e567ec Reviewed-on: https://gerrit.libreoffice.org/25915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 1efbab1eb4e01ae3116301df861067a2e488c717) Reviewed-on: https://gerrit.libreoffice.org/25958 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-06tdf#94131 Easier access to set a default template when saving a templateAkshay Deep2-3/+48
Change-Id: I2a3732a178f47ce49c77089a6e0865b609efd499 Reviewed-on: https://gerrit.libreoffice.org/25916 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit f944195baabfda068cc37bd4e8ddf60e6cc990b7) Reviewed-on: https://gerrit.libreoffice.org/25957 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-04tdf#100195 Enable Keyboard Navigation in Template Manager and Start CenterAkshay Deep5-10/+35
Reviewed-on: https://gerrit.libreoffice.org/25848 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Conflicts: sfx2/source/control/templateabstractview.cxx Change-Id: Ic5447a4af091a4e3dcab4d909fc6bfb9e559defb Reviewed-on: https://gerrit.libreoffice.org/25881 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-03Template Manager: Ctrl + A to select all templatesAkshay Deep2-0/+28
Change-Id: I8398268752c78a30d5fc076d6f2b6249cbf89ec2 Reviewed-on: https://gerrit.libreoffice.org/25860 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 74f6f03f55eb6d641d2b26aae883943c69683563) Reviewed-on: https://gerrit.libreoffice.org/25882 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 00:55:09 +0000