summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2021-10-29jsdialog: enable Digital Signatures dialogSzymon Kłos1-5/+22
In LOK case run it in the readonly mode. In readonly mode we can run it asynchronously. Change-Id: I721dd14fa23d4e30255dd976e0cc2a4f30470a3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124253 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-10-21online: keep sidebar openedSzymon Kłos1-0/+3
when we switch mode in online keep sidebar in opened state. For example when switching from notebookbar to classic mode - sidebar is set to "Tabs" what makes sidebar hidden in online. The same happened when crash occured. Change-Id: I5d0d1dba4c89b5e380a0bf717fabf4337016894c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119496 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 2d9c05d615c2bf8dc494f4eec1213d27c74d24ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123975
2021-08-04improve LOK notifyInvalidationNoel Grandin1-4/+6
(*) tweak buffer in SfxLokHelper::notifyInvalidation to be a bit larger, so we avoid the cost of a resize&copy (*) use our optimised OString concatentation instead of going via std::stringstream (*) pass down a pointer to rectangle, instead of a string. later we will use this to avoid doing the stringify until later Change-Id: Ia3e3042bc919d9b9cb80e47a93704eb236438605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119994 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-07-16Revert "Notebookbar: skip early init in all apps"Szymon Kłos1-1/+2
This reverts commit 6af0a488a059982a8b5d72fe399c7e8841a2e9b4. Delayed notebookbar init in Calc causes "number format" combobox to not work. (it works after some number is typed into document only). Original problem fixed by reverted change doesn't exist anymore because new shortcuts for paste special and paste unformatted text were introduced Change-Id: Ie112ae0df7b6d3782916b98c96f1a17b15396115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118771 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-07-09sfx2: fix uninitialized SfxViewShell::mbLOKIsFreemiumViewMiklos Vajna1-0/+1
Introduced in commit 1b9fe58acb7b5bbbc83ecca30e17663fff7f0db4 (LOK: introduced Freemium LOK API, 2021-06-02). Change-Id: Ifdd6c13a64a167fa00b0305441c52340167f3809 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118632 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> (cherry picked from commit d6811bd47a255d40aeb4509c7011fa7d9e75e3f3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118639 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-28LOK: introduced Freemium LOK APIPranam Lashkari2-0/+44
also block the uno commands from deny list Change-Id: Iee994411891b73b865e6496403682f996d5e9321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116384 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117799 Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-05-26tdf#134582 sfx2: when storing, set Version on embedded object storageMichael Stahl1-0/+33
This previously wasn't needed because there was only one version for which it was checked (1.2) but since commit a541cd91951eca15e40764244b34c72b347f9f26 there's a second version so when loading an existing embedded object in one version and storing it in another, the Version must be updated so the attribute in META-INF/manifest.xml matches the one in content.xml. Change-Id: Ic2fc303c6f6bc254050d531d578029377976ecb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98521 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98459 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit a24a4cc1838e3a2d55261a8edf6cb63186f4c38f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108950 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-05-05Fix style previews widget with multiple languagesSzymon Kłos1-3/+8
Broadcast also universal name (English identifier) for styles on change. This allows to select correct style without knowledge about all languages that other users use in other views. Fixes style previews widget in online with multiple sessions in different languages Change-Id: I9b9bcc92d96b5a5482a97a5947f148a638f257d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115093 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-04-26lok: Interaction handler for FilterOptionsmerttumer1-1/+2
This will enable Text Import Dialog to be executed before the document is loaded Change-Id: I263e69f0739f4971f4c4eec032ebf22ffbdeebb7 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114638 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-04-14notebookbar: minify for onlineSzymon Kłos1-2/+9
Notebookbar load takes some time. We don't use most of the items in online so minify .ui file to contain only needed widgets. Change-Id: I4796caae14bb63e3e04d318093209adfb87a77df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113623 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-04-12lok: intercept indentation and decimals state change eventsGabriel Masei1-1/+5
This solves some toolbar buttons enabling issues in online when dynamically changing UI mode to classic. Change-Id: I3301b92c35effce905f1283ae645d8ad2b168ece Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113723 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 8859e62d7dfaa71c35f80b5eff99b0788b49c9fa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113766 Reviewed-by: Gabriel Masei <gabriel.masei@1and1.ro> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-03-31lok: fix nullptr de-referenceHenry Castro1-1/+2
Change-Id: I8a9a7444d66e5e6449a0215bde174253a41f09b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113317 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 949085b12a8a57b2257f4e59cc597e4c59b42f76) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113285 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-03-29SfxInPlaceClient: avoid crash when chart deleted by other viewSzymon Kłos1-1/+2
Be sure m_pClient still is valid. In case when one view was in the chart editing mode and other view deleted the slide, m_pClient was cleared in the meantime what caused a crash Change-Id: Ie433946799abef4c75af7b96f3e5cf9ba0e7ec47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113032 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-03-26Revert "lok: switch to the correct view before any UI update is doneTamás Zolnai1-23/+0
via SfxBindings." In online Impress the status bar content didn't get filled in a 2nd view. This reverts commit 35b81a05c7c58d0db2276627a9387a738c409974. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112997 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit bdbb5d0389642c0d445b5779fe2a18fda3e4a4d4) Change-Id: I29adf767d2bf3fa0f19b13f8eae3d2464cd90601 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113186 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2021-03-24online: send selection coordinates with inplace modeSzymon Kłos1-1/+12
Change-Id: I38964fc522924b61313bc38ecf03e007fc6f3b8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112742 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
2021-03-24online: Don't send chart selection to all viewsSzymon Kłos1-6/+0
Steps to reproduce fixed bug: 1. open spreadsheet with chart in two sessions 2. session A: doubleclick on chart (grey overlay appears), then click somewhere else to exit chart editing mode (grey overlay disappears) 3. session B: doubleclick on chart result - grey overlay present in both views Change-Id: I43b390fcf9bb1a3f3cbbbce4cea1052c54255dc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112736 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-23Notebookbar: skip early init in all appsPranam Lashkari1-2/+1
for more details 42cc32c95db2484961a65c906af1a899c1a6aa2b Change-Id: I64f1ce22f7e1cbdbab3aea17841030a6313c1c0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112978 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-22Also throw IllegalArgumentException for arguments of wrong typeStephan Bergmann1-18/+42
Change-Id: I1b52accc3f0eec3e6232b8211bf7bcbf65ed18f8 Reviewed-on: https://gerrit.libreoffice.org/84350 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit ebd70d476c392b2c5a87295e01b8ea9c2e8de258)
2021-03-22tdf#135244: move LockAllViews to SfxObjectShellMike Kaganski1-0/+2
... so that it may be called from SfxObjectShell::SaveTo_Impl, and handle export cases in addition to save (as) handled in tdf#41063. Change-Id: Ie39196656dd1a95dcb6bab3ae8138c2f5c8729e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99714 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112825 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-19lok: switch to the correct view before any UI update is done via SfxBindings.Tamás Zolnai1-0/+23
Change-Id: I541e53b4219340233ed5a4bec407ded5adf6a841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112538 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2021-03-16tdf#141011: Postpone SwFieldDBPage::Reset to tab activationMike Kaganski1-1/+6
This way, it will only ask for password when dialog is switched to that tab. Change-Id: Ie2a453b0b6867ceb1ef3728a8565de4f6cbf4757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112469 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 0adf52a644aaf85ba2bd666147c62c134234ffbb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112422 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-16check for quit when calling Yield in loopNoel Grandin2-3/+3
so we don't get stuck threads when the main application quits Change-Id: Id36e99267ceb4154873b6ef8ef494622fff6c19a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112409 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit c880d3e30405342a5ae6239cc77f69ed3ca6cc15) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112491 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-08lok: show error message dialog for VBA macrosHenry Castro1-0/+21
It creates and exclusive message dialog to show the VBA errors to client side. Otherwise the IDE window to show the source code and the error message is not supported yet. Change-Id: Ie74f911b109cb13aebd39de2cb8e899d779c1cf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111854 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-03-04sidebar: use real height to determine preffered sizeSzymon Kłos1-0/+1
There was a bug causing to crop the sidebar in online: 1. open odt file in 2 sessions 2. select image in session A 3. move mouse over sidebar in session B 4. move mouse over sidebar in session A Result: sidebar A was cropped PosSizePropertyPanel on context change did some windows visibility changes in the meantime. get_preffered_size() returned lower height than real value in SidebarPanelBase::getHeightForWidth call queue_resize to invalidate cached optimal size Change-Id: I8080259ffb12ae3f6613e7749e908d6ef55c1f3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110894 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-02-24Fix non-valid json generation on NotifyOtherViewsmert1-3/+9
Change-Id: I82aa0aefcd1de14b4c1bb2bbe3f087b60d691beb Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111299 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-02-09lok: send help even when document not readySzymon Kłos1-0/+7
Change-Id: I44855ef00a6c54a774965b3c951a4476ed5c8b01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110593 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-02-02Improve macro checksSamuel Mehrbrodt2-6/+22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109552 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 1dc71daf7fa7204a98c75dac680af664ab9c8edb) Change-Id: Ie40801df8866b52c1458e020ffa9cba120720af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110076 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-01-28tdf#123476 filter: Also handle empty ODFMike Kaganski1-2/+4
This builds on top of commit ada07f303e7cd1e39c73abe0741aefe7d9d73a57, to allow 0-byte ODT, ODS etc. Possible TODO would be somehow use default template for such empty files, getting the template name using SfxObjectFactory::GetStandardTemplate. That would enable using 0-byte ODF files as means to "create new document at this location from default template" workflow. Change-Id: I36e07b80f60c42aecdcc6a7357e5bdd18f62e4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109989 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 2854362f429e476d4a1ab4759c6a1f1c04150280) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110061 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-28lok: avoid a set of invalidations per view on re-size.Michael Meeks1-0/+3
Unfortunate to have N^2 invalidations in the number of views on resize - particularly for calc, when you re-size/wrap-text on a row during editing. Change-Id: I93f75c4543ad072684e5575a2cbe0e8abcab0d80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109913 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-01-22tdf#139830: keep the right sidebar context for chart after view switch (calc).Tamás Zolnai2-0/+33
There is a general behavior to switch to the default sidebar context by view deactivation and switch back to the right context by view activation. See SfxShell::Activate() and SfxShell::Deactivate(). By activation, we use the selection to find out the right sidebar context. See GetContextForSelection_SC() method for example. However, for charts, this does not work, because the chart window is a separate environment and the shell does not know what is selected inside the chart window. So let's avoid context switches when we have a chart window active. Let the chart controller handle sidebar context changes. Change-Id: I272ee5c35ac30221eed2930201c4710a9a5877c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109790 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2021-01-21Use the hello@collaboraoffice.com for user feedbackAndras Timar1-1/+1
Change-Id: I8a779b98e60a9037188674a0ad6fd60aa8ea32ee
2021-01-18lok: run async the Macro Selector DialogHenry Castro1-17/+22
Required to be called by the client side Change-Id: I9c9d22dd249839009bdc6a701553f3b9d776347a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107246 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109137 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-01-18sidebar: avoid invalidation thrash with LOK.Michael Meeks3-2/+16
Avoids complete sidebar invalidate when entering text into a cell and hitting enter. Change-Id: I88ee3792589a1c0a16ae555da77ed7c12ca5f296 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109455 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com>
2021-01-18sidebar: only invalidate when things change.Michael Meeks2-6/+15
Change-Id: Icc9c5bcde224cc979b834585531b847f1c5f7d0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109454 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com>
2021-01-12Missing construction of SfxCmisVersionsDialog::m_xVersionBoxStephan Bergmann1-0/+1
...ever since b1baf73dc671069bedec18d170f8199b0766ea60 "weld SfxCmisVersionsDialog". (Found by GCC 11 trunk with --enable-optimized, > sfx2/source/dialog/versdlg.cxx: In constructor ‘SfxCmisVersionsDialog::SfxCmisVersionsDialog(weld::Window*, SfxViewFrame*)’: > sfx2/source/dialog/versdlg.cxx:435:36: error: ‘this’ pointer null [-Werror=nonnull] > 435 | m_xVersionBox->set_size_request(m_xVersionBox->get_approximate_digit_width() * 90, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 436 | m_xVersionBox->get_height_rows(15)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I2720d6bc49af717951a0af6a262fb013a27e09df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108886 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 29e36c699c610be4fe6f8a2fe21ae3e4c8bdbd38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108909 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07officecfg,unotools,cui: add ODF 1.2 Extended / ODF 1.3 versionsMichael Stahl1-1/+1
... to configuration and UI. The new default is ODF 1.3 Extended, which is now ODFVER_LATEST and stored as value "3" in configuration. Adapt a few places related to DocumentDigitalSignatures etc. to new default. Change-Id: I420da4f7787cc864c6bd88470d61b146b9399aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93177 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2021-01-07comphelper,sfx2,dbaccess: add ODFVER_013_TEXT constantMichael Stahl2-4/+11
This is used for Version of package in API. Change-Id: I23d162c4dfff2f56c541a7c6c2e21c87ed7d8213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93087 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2021-01-06lok: send linespacing updatesSzymon Kłos1-1/+4
Change-Id: I2dd123b04a2d6a03eac92aca5db5a4413b386e7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108877 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-12-30lok: send uno command state update to the right view.Tamás Zolnai1-1/+1
We get the correct view as a parameter(pViewFrame). Change-Id: I36e99a7660fee69c6c7cb10977763b1136eb6e22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108511 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-12-29lok: send sidebar dialog update to the right view.Tamás Zolnai1-7/+7
SfxViewShell::Current() might point to wrong client, not the actual owner of the sidebar. Better to use the LOKNotifier which points to the correct view. Change-Id: I2a3f18eaf51e4bf9a9f811595ec4fc02ce86fa7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108444 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-12-21replace ODFDefaultVersion usage with ODFSaneDefaultVersionMichael Stahl3-11/+11
Compare with ODFSVER_012 mostly works the same, except for places where namespaces are defined where the ODFSVER_EXTENDED bit should be checked. Conflicts: sc/source/filter/xml/XMLExportDataPilot.cxx xmloff/source/chart/SchXMLExport.cxx Change-Id: I86469b763bc2f903632976bc9d6ec04d543d705e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108107 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-21Fix translation domains in .ui filesGabor Kelemen1-1/+1
Found with bin/ui-checkdomain.sh Change-Id: I2a3ec2593b9ce0a19efced9020b95dff796e4702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94153 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2020-12-18tdf#138762: crash when trying to open sidebar w chart in WriterAron Budea1-4/+7
In Writer when in chart edit mode, and the chart is deselected, the object selection remains. Opening Properties sidebar at this point crashed. Calc and Impress were unaffected. Regression from b5fdb148fe87a90f3e586efcea7aa6ef865fa42a Change-Id: I356c3a42c41dd38e4739df27c72c6d67722b1dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107500 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 7e5991dc695d1e590483615c2907811ce4117834) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107544 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-12-05Remove remaining bogus use of objc_msgSend()Tor Lillqvist1-13/+3
Follow-up to 5bf61e98b0746a4afeb68a80e54b4eb4bf4ea89f. Should avoid crashes when running as arm64 code on macOS on arm64. Change-Id: Id05d182684df82c8a7bf09f6bb7e8ccb01997b62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107262 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-25sw tiled rendering: fix paint->invalidation loop when paint is started by vclMiklos Vajna1-2/+12
SwViewShell::PaintTile() already calls comphelper::LibreOfficeKit::setTiledPainting(), so by the time it would rearch SwViewShell::Paint(), callbacks (e.g. invalidations) are ignored during paint. Do the same for SwEditWin::Paint(), where we processed invalidations during paint, potentially leading to paint->invalidation loops. Conflicts: sw/qa/extras/tiledrendering/tiledrendering.cxx sw/source/uibase/docvw/edtwin2.cxx Change-Id: I8280f5c2571beeae6c0f2986d275dde3c2d33161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106543 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-19lok: don't log warningsSzymon Kłos1-11/+14
Change-Id: If0ecee7d01eb0efc8b1096a9097c7d0d7ef0fd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106129 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-16Avoid unused parameter 'pImpl'Tor Lillqvist1-4/+6
Change-Id: I8dd30ed3ffffa0e5340b32ce4399dd05cc57e2b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105962 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-15LOK: send state of SheetRightToLeftPranam Lashkari1-1/+2
Change-Id: I4b58ab74003065a63e4274293b868c909f4f583f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105428 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-08lok: sidebar: disable context deactivationHenry Castro2-8/+4
In the Collabora Online, for every SfxViewFrame instance, it has a relationship with a user name, and it is not allowed to deactivate the sidebar of the other user. However, in the Desktop case, a user name has a relationship to many SfxViewFrame instances and it can deactivate the sidebar when a SfxViewFrame instance receives the input focus. Change-Id: If1936f1dc3779664970bd584e2b9d6f595c4b072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104115 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 663de10f95bb72630658a5a06501e37d1810e0c7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105451
2020-11-03notebookbar: don't block init in calcSzymon Kłos1-1/+1
Change-Id: I7fdebcf317c8ebd3e322c1f73d9a4e7df30ecd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105240 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 12:30:34 +0000