summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2022-06-10sw: restore UI language to en while savingAshod Nakashian2-0/+41
Because the XML writer used in sw invokes the translation logic, which uses the UI language, saving can fail in case there are multiple views with different langauges. This restores the language used for loading before saving to avoid such issues. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I6675204bb68ea33b1395c779a64ab3e9b339d73e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135482 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-08LOK: send state of Protect, UnsetCellsReadOnlyPranam Lashkari1-1/+3
Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I92675ed0033088233fb442138b39a3c8d663c614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135454 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
2022-06-05tdf#125931: Enable sidebar in MathMike Kaganski1-0/+2
No panels yet, only one default deck (PropertyDeck). It is needed to have the uniform default deck like in all other modules (see commit c09f59eb6173a4a53a2d40ed80aebed18e3882ac); the panels for formula properties might appear later. Change-Id: If1785dc780111fe496638418f43e7b90a250ffce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135398 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-06-05Drop special-casing for Chart's sidebar property deckMike Kaganski2-11/+2
Introduced in commit b33b2afe6a8b4224450da7c686beb81dbf5cd24a Author Markus Mohrhard <markus.mohrhard@googlemail.com> Date Thu Jul 09 20:39:06 2015 +0200 big step towards real chart sidebar later in commit da57c32c5cb27eee38e32d10232b31d459c399df Author Tor Lillqvist <tml@collabora.com> Date Fri Feb 28 17:02:30 2020 +0200 tdf#130348: Add special case for ChartDeck, too and then in commit ff23d87cb00388095a94b90e061564fc179e1823 Author Mert Tumer <mert.tumer@collabora.com> Date Fri May 08 17:23:12 2020 +0300 mobile: fix calc chart wizard properties is not shown The normal PropertyDeck can host all the chart-specific panels, and the other decks that had "all" application context, but are not needed for charts, have their context fixed. This cleanup is needed for a following introduction of sidebar in Math. Change-Id: I5bb24d52b8dec2133213d7dddfeb91359ed4cb4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133262 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135395 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-05-30lok: sidebar: notebookbar: don't change view mode for other viewsSzymon Kłos1-0/+8
We should change view mode (notebookbar/toolbars) only for current view. This prevents the closed sidebar from showing when other view joins the session. Change-Id: Iaeec1bee0afab7552e223f17dd7afac27d288db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134690 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 08891ae798b1e59719684d1b0343767c9d136a11) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135001 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-05-28Resolves tdf#119447 - Improve sidebar height in start centerHeiko Tietze1-4/+7
Reduced the font size multiplier from 1.4 to 1.2 to fit the window into 768px height and added the branding image to the height calculation Change-Id: I05473155f0068880298a461fe8491468b07079b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134867 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit ed45b67db66ef0f6c69887c75013a178c4412f74) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135006
2022-05-18Revert "sw: restore UI language to en while saving"Andras Timar1-31/+0
This reverts commit f4ef1e3e580f7a590496d62aaa3dc7e092510a9c. Reason: T35383 Writer: Page breaks saved in German UI/locale turn into line breaks Change-Id: Iea7c41b361beb0bc6f455e72ab48cef3604305d6
2022-05-13tdf#108188, tdf#131190 - Verify that the page style is actually usedAndreas Heinisch1-15/+0
Change-Id: I007d26c6fcaf60d2a2378cc00e630da447f95a8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134022 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit ad79900cd62c487bda9d2515892d62b3b08a5dfa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134067 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-02sw: restore UI language to en while savingAshod Nakashian1-0/+31
Because the XML writer used in sw invokes the translation logic, which uses the UI language, saving can fail in case there are multiple views with different langauges. This restores the default language before saving to avoid such issues and to make sure the document xml is generated in the default language. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: Ibc0813de33cf7cf3528b0ff1d95560e799903fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133676 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit f4ef1e3e580f7a590496d62aaa3dc7e092510a9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133610
2022-04-25sfx2: do reload on SID_EDITDOC in SfxViewFrame::ExecReload_Impl()Michael Stahl1-1/+2
commit b505ca5b9c31b3d9c639406d03a25bea4e914242 "Switch to read-only mode: do not force reload document if possible" replaced "true" with "bNeedsReload" here - but this is a problem when switching from read-only to editable. 1. Start LO and load a document from WebDAV editable 2. Start other LO and load the same document from WebDAV read-only 3. In first LO, edit document, store it and close it 4. In second LO, click "Edit Document" button 5. LO doesn't reload the document and shows stale content It's not clear what problem that commit was trying to solve, but let's assume that it intended to change only what happens when switching from editable to read-only. Change-Id: I69c779c5c0c5c2ccda677ea8cb353c8716916861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133171 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit c929c563e2029bbb969dc417a688cca8934e69b0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133141 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-25tdf#148101 don't autocomplete remote files dialog entry on delete/backspaceCaolán McNamara1-0/+1
Change-Id: Ieddb41eb37e7090416a418afeffb76ce0eddf90a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132873 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-23lok: reset ui mode state when switch to notebookbar cancelledSzymon Kłos1-1/+26
We have to keep state in the register in sync with the view. When we cancelled notebookbar usage we need to revert Default state so next time we will be able to activate notebookbar. Change-Id: Ie5f7d0160c9c22c6621aca73b2cdd7197f86ff78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133325 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-19lok: report state for sparkline UNO commandsTomaž Vajngerl1-0/+8
Change-Id: Ic1e8464ec97ef91f631944dbaa3de0e5bff26c89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133006 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ee76783d2b2718a66bceefc6f8a71019daa7cc5b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133060 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-04-15jsdialogs: added WidgetTestDialog to test different vcl widgets in online siderash4193-0/+32
Signed-off-by: rash419 <rashesh.padia@collabora.com> Change-Id: I27cbb72b4ccd486b58934503b1d3d5d7ff47cbfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132865 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-04-15lok: send status update for .uno:SplitCellSzymon Kłos1-0/+1
Change-Id: Ic972d3ff3334f4c3a507868a95ac955c9ffbc614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132585 Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132909 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-14Resolves: tdf#141625 give enough space to see full date+timeCaolán McNamara2-8/+8
Change-Id: I31193783231f27494ed1507faa143697e8facc30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132987 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-06Resolves: rhbz#2069486 classic help index entry autocompletes on del/backspaceCaolán McNamara2-1/+17
when it shouldn't Change-Id: I90fa338479e0d5612d7b09f94c45e356ea71f89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132596 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-06add infobar to prompt to refresh to replace old formatCaolán McNamara1-0/+38
Change-Id: Id99cbf2b50a4ebf289dae6fc67e22e20afcda35b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131976 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bbd196ff82bda9f66b4ba32a412f10cefe6da60e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132187 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-03-25tdf#111924 - Special characters: don't lose focus on context menuAndreas Heinisch1-1/+2
Don't lose focus on the favorite or recently used items in the special characters dialog when right-clicking them to show the context menu. Change-Id: Iaedc4bbc6fb627591b9c0cd9a2c44940312eeb1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131721 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit ce3e760f9155ac8d80f60054be036e862df7029a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131858 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-22tdf#147782 retain focus in launching frame on first activateCaolán McNamara2-0/+16
Change-Id: I813c675ecf7c4a364f9d770af12e99275f510e7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131017 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-14Send Calc Insert Headers and Footers state change to LOKAron Budea1-0/+1
Change-Id: Id51b4cf1eb962f22ee1e381873f4670789675525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131293 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 0090e414341f7ca9c70a2191a53d5b8fc855f4c8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131476 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-03-14lok: Fix freshly added comments are not displayedMert Tumer1-0/+1
Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: Ice772eff8b9f8ae8c23ec1e66675e33a80492028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128217 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131521
2022-02-20lok: render image preview with lower resolutionSzymon Kłos1-0/+16
renderShapeSelection callback is used to render image previews which are later used during eg. rotation. Do not render preview with original size which slows down app a lot. Use 1280x720 max. Change-Id: Ia8365a67d87cea869ef74cb70ce4830439a523b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129497 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-02-20sfx2: introduce SfxBindings::QuerySlotIdHenry Castro3-0/+29
In order to invoke QueryState with the slot id, which it is easier to invoke UNO command states in unit test. Change-Id: I36d72a4381ff8386b1f1af33284ce674cf26acd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123063 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129464 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-18tdf#143817 Fix HUD deleting text contents in WriterRafael Lima1-0/+1
Change-Id: Ie28388016c475907c5d8fbe51906bc4a01d6b0d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130091 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3c94a0f7729f1638ab3b273a186c48de859cfb49) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130092
2022-02-14lokit: double check for disposed windows & fix leak.Michael Meeks1-4/+7
it seems we can get windows disposed before we get to the emission. <segv> vcl::Window::IsTracking() const vcl/source/window/window2.cxx:341 (anonymous namespace)::LOKPostAsyncEvent(void*, void*) sfx2/source/view/lokhelper.cxx:725 LokChartHelper::postMouseEvent(int, int, int, int, int, int, double, double) include/rtl/ref.hxx:112 SwXTextDocument::postMouseEvent(int, int, int, int, int, int) sw/source/uibase/uno/unotxdoc.cxx:3561 Change-Id: I93aea931dad1e7f43d3d610568424c53d2b22fbc Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127907
2022-02-14lokCalcRTL: global RTL: fix chart edit mode renderingDennis Francis1-4/+14
If global RTL flag is set, vcl-window X offset of chart window is mirrored w.r.t parent window rectangle. This has to be undone to get the correct chart bounding box in negative X document coordinates so that the offset calculations for tile rendering remains the same for RTL documents irrespective of the system/global RTL setting. Conflicts: include/sfx2/lokcharthelper.hxx sfx2/source/view/lokcharthelper.cxx Change-Id: I3e1666681af4e7ab1257bcc88d44bbdb053a7d47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129704 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 4fd2a14c6ee68f0574766ec7ec3dca35debe9d20) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129778 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-14Fix ambiguous error in VSSzymon Kłos1-2/+2
Change-Id: If18ef06f5a27a4266b21df4ba07bd5bc01255f55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128381 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit af168ae749dfd816fe029bbca5967fc3d5a1aa81) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129439 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-14lokCalcRTL: fix rendering of charts in edit modeDennis Francis2-4/+28
Inform Sfx2InPlaceClient and LokChartHelper when negated X coordinates are used. Ensure that invalidation rectangles have positive coordinates in all cases. Conflicts: include/sfx2/lokcharthelper.hxx sfx2/source/view/ipclient.cxx Change-Id: I8f5440718e288d8f0d379c8da5f49a29e51f6940 (cherry picked from commit 284068c7eb473bafd5cafeb30a78daab4538cff6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129362 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-14Add image preffered DPI document setting, use it in Writer, ImpressTomaž Vajngerl2-17/+134
This adds a "image preferred DPI" document setting, which is used as a suggestion of the DPI that an image should have in the document. This is currently used when the image is inserted into the document (Writer, Impress/Draw) to resize it to the preferred DPI value. Change-Id: I3ee9d409257e3c6aa2ead05144ecbba7b3b916f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126334 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-14filter: try to detect 0-byte DOC files based on extensionMiklos Vajna1-1/+9
Commit ae1f51b4888a3aa14837ac6e4083f33b2176ca45 (tdf#123476 filter: try to detect 0-byte files based on extension, 2020-10-28), already implemented this UNO-based import filters, do the same for built-in filters as well. Another problem in filter/ was to pick the WW6 filter for .doc -- require export+preferred support in the filter to get WW8 instead. An additional filter that may kick in is MS Word 2003 XML: this is avoided by requiring "preferred". Change-Id: I46e280beb5341213b0fe7a09a549b52c0c1ea3f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127219 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-14do not unnecessarily lock XLayoutManager for menubar changesLuboš Luňák1-8/+0
The XLayoutManager documentation says that lock() prohibits layout updates until unlock() is called, so it's not any kind of mutex or anything, it just allows grouping updates. Which means it's useless to put around a single call to change menubar visibility. To make things worse, unlock() will always trigger a layout, so even if nothing changes, it still does an unnecessary layout update. And since this gets called from SfxLokHelper::setView(), it may get called often and it's rather costly. Change-Id: I3e3e37b6763b15d454e76b4bef0b22f84cf479d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126483 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-14jsdialog: use string identifiersSzymon Kłos1-1/+4
Thanks to that it is easier to debug and find widgets in maps. Sidebar and notebookbar are now in different map entries. This fixes the issue when destroying notebookbar deleted sidebar's widgets. After this patch sidebar works correctly when using notebookbar mode in lok. Change-Id: Ie9dcb82675129bdb567b766e29779744f500cb48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125216 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128853 Tested-by: Jenkins
2022-02-14jsdialog: enable Digital Signatures dialogSzymon Kłos1-5/+22
In LOK case run it in the readonly mode. In readonly mode we can run it asynchronously. Change-Id: I721dd14fa23d4e30255dd976e0cc2a4f30470a3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124058 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128838 Tested-by: Jenkins
2022-02-14use more cppu::BaseMutexNoel Grandin2-10/+4
Change-Id: Iddd7438161ead93b27cf8e8058ca5b1eae3d8001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-13[cp] remove donate and community involvement infobarsAndras Timar1-58/+0
Change-Id: I37c9c76eb88dea4effa786b62755ea8738efc3e0 Reviewed-on: https://gerrit.libreoffice.org/75600 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-02-13[cp] Send feedback to hello@collaboraoffice.comAndras Timar1-4/+2
Change-Id: Ic734235426001e4aa7119476c1e6884b7c39776d
2022-02-13[cp] add EULA button to Help - License Information... dialogGülşah Köse2-9/+66
Forward port of acd8acfa89d9 from distro/collabora/cp-6.0 Rewritten for weld API Change-Id: I62b9293c68059389a63e523ea5747fdb267b1a99 28a21f5831e0b2e99eb11f1c1ac2b8845c462669 Reviewed-on: https://gerrit.libreoffice.org/79110 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2022-02-01tdf#122708: on GetFocus, select something also when items are filteredKatarina Behrens1-1/+8
Previously if nothing was selected, we picked item with ID 1 to select/highlight. But if a filter is active, such item may not match the active filter (case in point: document template no. 1 matches 'Writer templates' filter, but not 'Impress templates' one) Try harder to find an item to select by looking at the list of filtered items too Change-Id: I9cb053b884dc724c7a6199ec002d83024ed83976 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129117 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit 4bb0ffa4684dada708ecdf727f4fc9f500a9bced) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129081 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25tdf#146571 Ignore focus changes after closing Manage changes dialogCaolán McNamara1-0/+7
Change-Id: Ib588310410a265acdd129a8e51adf56bb5973bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128910 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-21tdf#140020: Disable also menu File->SaveAll for docs with LockSaveVasily Melenchuk1-2/+2
If LockSave attribute is applied, docs with it are not affecting File->Save All menu item: these documents are not enabling this menu and also not saved during this process. Change-Id: I00bcd251fccfab3f13cb42c20ccb61b54ab49346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128650 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> (cherry picked from commit 87fe449c4c1ed46003e9d5fdaf1919f11a53b959) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128676
2022-01-20tdf#140019: Revert "Don't disable "Send doc via email" ..."Vasily Melenchuk1-1/+1
Locked export should also disable ability to send document. This reverts commit b9930d0d05db39a8466b18dccf626bc3d8ae5c4e. Change-Id: I3b7b423c0e17a59872065ec7ceadbaf1cda45ccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128550 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> (cherry picked from commit f4559274154324e132f82ba9c21676326f6db7e5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128546
2022-01-12tdf#146375 Cannot rename user-defined categories in template managerNoel Grandin1-17/+10
Regression from commit 3624a703361b108d22448bd60a97733f05e37820 tdf#135316 remove OTempFileService pessimisation So fix two things here (1) make it so the tempfile service flushes the SvStream buffer and resets the file position, so we can read the data after writing it. (2) Simplify the UCB usage to just write the contents of the tempfile via the tempfile InputStream, which is simpler and safer Change-Id: I15ed3b02c2d6415d10a9579f66374e6268188d5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128195 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128274 Tested-by: Jenkins
2022-01-02Bump copyright year to 2022Adolfo Jayme Barrientos1-1/+1
Change-Id: Icbb000677066127fa67e8c22fb0ab6880acc0169 (cherry picked from commit fb32c4d96141ccc1766fa4e39405130fcf409a6a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127848 Reviewed-by: Martin Srebotnjak <miles@filmsi.net> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-15tdf#131850: avoid encryption check for recent docs overlayMike Kaganski2-4/+6
Change-Id: I673de978c39492bf9be78945ece95ade2a943ffc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126849 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 2f848eb5dc6f6f9344f250ac9860065130aaf436) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126869 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-09tdf#117280: derive SfxEvents_Impl from css::document::XDocumentEventListenerMike Kaganski2-12/+12
It abused XEventListener, and created a DocumentEvent object from the incomplete data passed to notifyEvent in EventObject. That way, the data initially created for the document event (in Supplement) was lost on the way. Change-Id: I409611482ce2323a3192c68f3525f450a9395815 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126090 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 28eef82cb16faef0b8ddc9912560efb779baa9f9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126093 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-06increase maximum document thumbnail size from 256 to 512Luboš Luňák1-1/+1
It's 2021. Something's telling me people now care more about document previews not being blurry than an insignificant size increase of documents. See e.g. comments #21,#25 in the HiDPI bugreport tdf#144214. It also doesn't make much sense for the thumbnail creation to try hard to make the image smooth and then downscale it too much. Change-Id: I8df778dda05cf42cd27adf8f7757097fc7650acb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126376 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 374e261ad1ea8b41f5ecdd850c27fdc961c4868b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126301 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-11-29tdf#117280: fix multiple Macro execution when triggered by Document print eventJulien Nabet2-4/+9
Change-Id: Ibfebcc1a31464b2610afea2035e3d723a0c79167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126018 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 774c6a6e1603bf3f12f1573b0778e0f0f9783169) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126006 Tested-by: Jenkins
2021-11-29cid#1494452 sfx2: fix null ptr deref in SfxInPlaceClient_Impl::saveObject()Miklos Vajna1-1/+1
Null-checking "this->m_pClient" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Add the missing check at a previous usage. (cherry picked from commit d9105d434ac6127f151843c7a7dbcd16257fcc0b) Change-Id: I8ebb4f41b9c83d59e65563c26729e899d45881b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126014 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-26tdf#145814 fill format mode is mostly disabledCaolán McNamara2-8/+2
when it shouldn't Change-Id: Ic282c313a6986d7d08f54b475c5d2ce32098ada1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>