summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2021-05-02tdf#135997: fix toolbar controlMike Kaganski1-2/+2
This is the same as fc7b4bfeba39a2479c9a2c9c8ef5ced5ab3c0de7, just for the toolbar control (the older one was for special character dialog). The problem was present since 800ac37021e3f8859a52c5eebca261a5d3bc5a11. Change-Id: Ib86aa7336a3078ff28b417de37fbd5bc492c85c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114719 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit b27de500b1412bacefc7144b5222c307ca1ae0fe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114853 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 31736f5f0abc09eb4066d09fd9e7394d844f9748) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114862 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-01tdf#139039 sfx2 store: fix export to PDF when dir name is URL-encodedMiklos Vajna4-10/+140
Regression from commit 5259ab8104cfba60c40748ed0cd59d93df038c5b (sfx2 store: create temp files next to local files, 2018-01-08), the problem was that the directory hosting the input ODT file was called "Bugzilla%C3%BF" (URL-encoded from "ÿ"), we got this as "Bugzilla%25C3%25BF" (encoded from directory name), but we forgot to decode it before passing this URL to the utl::TempFile ctor as a parent directory, which resulted in failing to save as PDF, and crashing on DOCX export. Note that in practice this only caused a problem on Windows. (cherry picked from commit aaf7fe0326b3be088a5440525363317fb3d0f158) Change-Id: I5fc8a356b63efc2f16405a14ee59a061b52c5205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111372 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111747
2021-01-30Improve macro checksSamuel Mehrbrodt2-6/+22
Change-Id: Ie40801df8866b52c1458e020ffa9cba120720af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109552 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 1dc71daf7fa7204a98c75dac680af664ab9c8edb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110057 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-27tdf#138727 help browser didn't flow textCaolán McNamara2-4/+2
because of its size request, while the paned shrink lets the pane shrink below the size request the contents stay at a min of the size request and aren't really shrunk, just clipped. Instead don't let the pane shrink but don't set a size.request letting it shrink to its natural min of its contents which are then truly resized so the text flow works. Change-Id: Iaf6738ace28c82379ac6322310de9a22f9653473 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109984 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-15Resolves: rhbz#1916640 pFocusWin can be nullCaolán McNamara1-2/+2
Change-Id: Ib901b1d849b2e54c61bd3e8626eb8262e73b832d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109359 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-07Missing construction of SfxCmisVersionsDialog::m_xVersionBoxStephan Bergmann1-0/+1
...ever since b1baf73dc671069bedec18d170f8199b0766ea60 "weld SfxCmisVersionsDialog". (Found by GCC 11 trunk with --enable-optimized, > sfx2/source/dialog/versdlg.cxx: In constructor ‘SfxCmisVersionsDialog::SfxCmisVersionsDialog(weld::Window*, SfxViewFrame*)’: > sfx2/source/dialog/versdlg.cxx:435:36: error: ‘this’ pointer null [-Werror=nonnull] > 435 | m_xVersionBox->set_size_request(m_xVersionBox->get_approximate_digit_width() * 90, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 436 | m_xVersionBox->get_height_rows(15)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I2720d6bc49af717951a0af6a262fb013a27e09df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108886 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 29e36c699c610be4fe6f8a2fe21ae3e4c8bdbd38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108909 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23Delete Category dialog includes '~' text in the titlebarCaolán McNamara1-1/+2
Change-Id: I8581e5219ffc690e686a0d563463c19b682ea04b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107911 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-12-17tdf#138935 rsDeckId is invalid by the time collectUIInformation is calledCaolán McNamara1-2/+2
Change-Id: I4afc1ed1bbbfbbd510617a51b9aa6d627471d80d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107706 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-11tdf#138762: crash when trying to open sidebar w chart in WriterAron Budea1-4/+7
In Writer when in chart edit mode, and the chart is deselected, the object selection remains. Opening Properties sidebar at this point crashed. Calc and Impress were unaffected. Regression from b5fdb148fe87a90f3e586efcea7aa6ef865fa42a Change-Id: I356c3a42c41dd38e4739df27c72c6d67722b1dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107500 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 7e5991dc695d1e590483615c2907811ce4117834) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107543 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-07Remove remaining bogus use of objc_msgSend()Tor Lillqvist1-15/+3
Follow-up to 5bf61e98b0746a4afeb68a80e54b4eb4bf4ea89f. Should avoid crashes when running as arm64 code on macOS on arm64. Change-Id: Id05d182684df82c8a7bf09f6bb7e8ccb01997b62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107259 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107327 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24Avoid unused parameter 'pImpl'Tor Lillqvist1-4/+6
Change-Id: I8dd30ed3ffffa0e5340b32ce4399dd05cc57e2b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105962 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106258 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106457 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10tdf#126700 handle Impress default documentsJan-Marek Glogowski1-1/+2
Impress has a two stage load, eventually because of the optional template manager. Since I don't know, what the 2nd load URL "private:object" is used for otherwise in LO, this just marks the empty and default documents as replaceable in Impress. Regressed-by: 61e1e0413296928d929f99c0f006c6cbbcf4ac40 Change-Id: Ief8d9eeaa65e8fb40400e64c16768d37ca343893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104581 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit d4892e5452bff155da6c34063ffe8c331284d8e9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105065
2020-10-30tdf#137754 Crash in styles tree in sidebar in impressNoel Grandin1-0/+2
this is a timing bug - easier to hit on a slow machine, or with a debug build - it happens when mouse movement triggers a request for a tooltip in the tree, but the tree is in a transition state. Change-Id: Ibed7ffd01483b26f2debb1aa9cc99e23b38ba950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9f6fbe36da3d53df0b64c41e9ea51cc20d442a30) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104962 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-29tdf#137643 Revert "lock refreshing font data when loading a document"Caolán McNamara1-4/+0
from tdf#69060, to replace with an alternative solution This reverts commit 98d71c4e0847797a4ba9229a8e6d832a8a3d5e0f. and This reverts commit 64d8e5f8db70f4f913abb902b41f4cff8dd1cdad. Change-Id: I384e994b54aa1bfc735c6ab591b9b1410058451f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104950 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-28tdf#136555 apply window bg color for button boxesJan-Marek Glogowski2-37/+70
The default background color of the frame is APPBACKGROUND, which is matched to GetWorkspaceColor(). That color is visible in Writer as the default document workspace background. Originally I just saw the dark background of the button box in the start center, and thought the workspace color in Qt is wrong and changed it in the reverted commit, missing the change of the color around the Writer document. Now that the button boxes's background color isn't fixed via the "branding" setting, we also must react to changed style settings, so we override the DataChanged function. This also reverts commit ef267dc5c1e46d236478ff32fc14925a0eeb0266. Regressed-by: a927e0964ba0442d53fffb22c577e54bcf183ed7 Change-Id: I62396355054523baef1197a8a8af61c2f0d29ef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104743 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2020-10-28tdf#116214 Allow for scientific notation in Custom PropertiesBartosz Kosiorek1-3/+4
To keep compatibility with OOXML format, it should be allowed to use Scientific Format in Custom Properties. The solution is backward compatible with standard numbers (it is still possible to write integer numbers and fractions). With that fix it is also possible to store very small and very big numbers in scientific notation. Change-Id: Ic788a6e3f4f748b905828f3d6c8c40dc7e46ba52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104569 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b73151c8f8fd4e67dc5674ebb6538783bdfb91df) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104842 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-27tdf#135082 fix print selectionSrijan Bhatia1-9/+1
Change-Id: Id4d48f25161aac20e8594b5e32c5dbe09e78ccc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99790 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104879
2020-10-17tdf#133771: remove encryption data during SaveAsVasily Melenchuk1-3/+30
If document was password protected but during SaveAs it wasn't selected to use a password we should remove EcnryptionData. But we should not do this unconditionally: in general case we should try to keep all encryption metadata. Change-Id: Id91a88790deccd7377fb5d394b36395d13748c31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104454 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit dd4670b976b00d643f335516fe5fd0c880d58025) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14tdf#136555 drop custom start center button colorsJan-Marek Glogowski2-18/+0
Custom button text or background colors don't play nice with any complex theming. Maybe we should still allow a custom background color for the button bar, but probably that attempt is also futile and clashes with theming easily. As long as the botton bar uses themable push-buttons as a control custom coloring will break at some point, as these buttons can have too many states, which curently depend on the theme. There is no way for LO to know, if a roll-over button will return with a different backround or just some changed border from a themed paint call. So this reverts the button part of tdf#90452. It doesn't affect the preview area, as that is a custom widget, which doesn't use any theming, but has it's own setting - for better or worse. Change-Id: I1ef17a50d15a5876a11bce89ae3f764aa91f66bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103041 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit a927e0964ba0442d53fffb22c577e54bcf183ed7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104048 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14tdf#128174: Master password dialog misplacedAyhan Yalçınsoy1-0/+1
Change-Id: Ib8834c58e6c3af88de3eb7b450076c79fb5edda5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103745 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 8a4ed7b0040e10cc75d015f244934d00478df7c6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104165 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-01tdf#134598 call FmtSelect to update watercanCaolán McNamara1-2/+7
Change-Id: Idd88acfdaac66b999b0bcd8cf0a4fe69f7ae6ac5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102926 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-28tdf#136133: AppendInfoBar can return nullJulien Nabet1-11/+16
2 cases: 1) When set Donate property to false value in /org.openoffice.Office.UI.Infobar/Enabled and LastTimeDonateShow with 1 in /org.openoffice.Setup/Product (Expert Configuration) See https://bugs.documentfoundation.org/attachment.cgi?id=164702 2) GetInvolved = false and LastTimeGetInvolved = 1 See https://bugs.documentfoundation.org/attachment.cgi?id=164703 Change-Id: I2da22616fb6f3fb4e42bf6b5e5c29cc094dc2fd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101391 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit be4fcac736fccce8ee7d4550a860b0127e7601bb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101456 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-06Revert "tdf#130863: autoredact, disable useless checkboxes for regex"Julien Nabet1-10/+2
This reverts commit b53fbe19dfd39d27868d616afb4f743b1237229b. See details here: https://bugs.documentfoundation.org/show_bug.cgi?id=130863#c26 Change-Id: I431094784106c9aad2a11b37b5ea849ba924b60f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100191 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit f615a3366e502884a15bbbf07c2fb1e70eb9dbfa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100210 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-07-30tdf#128838: autoredact, change Content UI according to Type when editing targetJulien Nabet1-0/+1
Change-Id: I99806c7a7629329a98ade23a3ad1f4c4921ec3ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99213 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit c61f3f47280334c9589fe37742cad93501540857) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99208 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-30tdf#130862 Remove wrong size values from individual buttons; use HIG spacingAdolfo Jayme Barrientos1-19/+23
Change-Id: I2dd1a796d94aa33d4dcbf676d0f66d6d256969bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99293 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-30tdf#130863: autoredact, disable useless checkboxes for regexJulien Nabet1-2/+10
Change-Id: Ic2bebfb24b8630c6135500a872eb6d6dee7935f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99227 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit b53fbe19dfd39d27868d616afb4f743b1237229b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99201 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-23tdf#135032: autoredaction, take into account emails in lowercaseJulien Nabet1-1/+1
Change-Id: Ie922a9e7203e46b19a0c7418983b1d0d7e787f02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99216 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 26357bcb3838698e041d7079105144dfb72856e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99209 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-21tdf#121191 Fix PDF viewer after "Export..."Pierre MARTY1-0/+6
* Add '.pdf' file extension detection: | if the file is actually a PDF then modify the 'nStoreMode' value | to 'EXPORT_REQUESTED | PDFEXPORT_REQUESTED' Change-Id: I2c950dc424fd62f004bb3eb6860621561669f547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92715 Tested-by: Jenkins Reviewed-by: Pierre Marty <pmarty@linagora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99143 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-21Revert "configure: add a --with-product-flavor switch"Heiko Tietze3-31/+0
This reverts commit c540483134482d437ea6e02390ff429f4300cbb0. Reason for revert: https://blog.documentfoundation.org/blog/2020/07/20/update-on-marketing-and-communication-plans-for-the-libreoffice-7-x-series/ Conflicts: icon-themes/colibre/brand/shell/logo_flavor.svg (cherry picked from commit bb47ca165959f73929211a736aa8d810fe110e43) Change-Id: Id9a2313d0bce496cb838e4eab448bea1722bc441 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99054 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-10tdf#134582 sfx2: when storing, set Version on embedded object storageMichael Stahl1-0/+30
This previously wasn't needed because there was only one version for which it was checked (1.2) but since commit a541cd91951eca15e40764244b34c72b347f9f26 there's a second version so when loading an existing embedded object in one version and storing it in another, the Version must be updated so the attribute in META-INF/manifest.xml matches the one in content.xml. Change-Id: Ic2fc303c6f6bc254050d531d578029377976ecb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98521 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98459 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-03tdf#134320: fix XInfobarProvider appendInfoBar for showCloseButtonJulien Nabet1-2/+1
There was a mix of arguments which caused misinterpretation. Like this since initial commit: 9e3ba7c3036c4d21e01d6f75ed29a1e8c4208141 author Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> 2019-11-18 09:08:03 +0100 committer Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> 2019-11-19 08:51:43 +0100 commit 9e3ba7c3036c4d21e01d6f75ed29a1e8c4208141 (patch) tree c648a26f2445955be14aa6e96815c14ec193dddc parent b234743dd26e0be4be272d2d2c82f90c67e192b7 (diff) tdf#97926 Add UNO API for Infobar This allows creating, updating and removing infobars from macros/extensions. It also extends the infobar with a primary and a secondary text, so there can be a bold summary at the beginning at the infobar with a longer text following in normal letters. ... Change-Id: Ic3e0b6a9da4da574eb7ca440a881fdcee1dd1132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97349 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit c49ea906358f99cc2fca16d790b51f8e2855f9ff) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97370 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-02Fix PanelLayout Task::SetPriority warningJan-Marek Glogowski1-1/+2
SetStyle will tigger a resize event, which in turn will start the m_aPanelLayoutIdle, before it's actually prepared, resulting in the Task::SetPriority SAL_WARN_IF triggering. Change-Id: Ide48d6004e242cf75bb48dc9f5e8dc3aa5ff809b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97664 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit fc8cf3afa29909a6c37beaf8021c531ae12773da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97671 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-01configure: add a --with-product-flavor switchMiklos Vajna3-0/+31
Defaults to Personal to point out this is supported by volunteers. This affects the splash screen, the window title, the about dialog and the start center. (cherry picked from commit c540483134482d437ea6e02390ff429f4300cbb0) Change-Id: I216a7f547618377ed268454ebfd2801c4c3901b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97638 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-01Resolves tdf#130436: Crash on redaction without DrawMuhammet Kara1-0/+32
Change-Id: Iaa418e9ad5c6e9ba1892cbb428a8a381f52c4246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97458 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit be85a4d7cc7c15472de9d1584837d5bff7640bf9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97505 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-19tdf#128006 allow documents inside odbs to be as trusted as their containerCaolán McNamara1-0/+5
Change-Id: Id19d3805ef2e3282c1a8e89dd8edcccbf4ac4db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96210 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-04Resolves tdf#130936 - Proper Icon Size for MIME type Icon in Start CenterHeiko Tietze2-8/+9
Icons are now in 48px Change-Id: I484458adf047999bc2ea0cbf16e7ff3fff131eec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95028 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 997a504f33bbd43c02a96a2a593a03e58bd3b72c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95416 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-03tdf#130354 sfx2: make PDF signing UI work againMiklos Vajna1-0/+4
Regression from commit 9112c18524c9f5e67d6cbb282586a439e3020cdb (Don't create unnecessary tempfiles for opened doc, 2019-10-18), restore the temporary file creation for the PDF case, as it's needed for PDF signing to work. Change-Id: I945f04f6ab90d0e04fb14a7634ec877fb0af1a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95367 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 058caeef45f9abf12e4e243aafbbb1c2ebcbc057) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95324
2020-05-27Related: tdf#133385 set cursor in row on right clickCaolán McNamara1-0/+1
if the target row is not already selected Change-Id: I7cb39118f4a695546d8d2251390d6d3279e82bc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit bcbbd77f42ac03bbe9d0754051b72e0faed20b11) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94954
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann3-7/+7
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26make highlight of get_dest_row_at_pos optionalCaolán McNamara1-1/+1
Change-Id: I280e1a49e938f45402f373896669fd6f7e8a66fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26tdf#133094 NotebookbarToolBox is not in the sidebarCaolán McNamara6-16/+22
though it is inheriting from SidebarToolBox and we're distinguish the sidebar case from the non-sidebar case wrt certain color toolbuttons Change-Id: Ieffe45adfab95d426bb36296ee3428b6bd3dbd3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-25[MS-OFFCRYPTO] convert oox implementation into UNO serviceVasily Melenchuk1-1/+2
To permit pluggable crypto services, abstract existing implementation behind an XPackageEncryption API. Previous code already had two halfway-polymorphic classes (agile and standard 2007 engine), so we're not adding much additional layers. As MS crypto always uses OLE storage to wrap content into one single file, current implementation passes all substorage names down into XPackageEncryption APi, so different downstream implementations (e.g. for MS RMS, or Azure AIP) are possible. Because OleStorage classes are internal to LibO core, access is provided via XInput/XOutput stream API function. Change-Id: Icc32a4e0ce215090c3b739f1dcaa0654b36b7f08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84436 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-25sfx2 UNO API: XModel2::setArgs() now also supports "EncryptionData"Vasily Melenchuk1-0/+5
XModel2::setArgs() only permits hand-picked set of media descriptor parameters. Add one more in preparation to API-based MS crypto rework. Change-Id: I179a1cfc2cdd7b04becba0d7dfe9740d920ae4ee Reviewed-on: https://gerrit.libreoffice.org/80432 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84434 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-22Resolves: tdf#133183 select style under mouse on right click context menuCaolán McNamara2-4/+30
Change-Id: I4317f6702b7a0e172d059fe83614aab94845b201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22Resolves: tdf#133180 use full width of canvas for preview renderCaolán McNamara1-3/+4
Change-Id: I1fa3f0fd8505712155c72c25b67da1ab6d4753e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22move InterimItemWindow to vclCaolán McNamara4-5/+5
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21drop some unnecessary includesCaolán McNamara1-3/+0
Change-Id: Idf507ea5a9790bf54ef98ed4f0cc89e2c01cc8eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21use for-range on Sequence in sfx2..swNoel Grandin1-6/+6
Change-Id: I09806869f2fdbae61f4c5d5c9db6859202bb63b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-18Create weld::Builder implementation for JSDialogSzymon Kłos1-1/+6
and use for WordCountDialog on mobile Change-Id: I12c3455ff9b16c30918067f9282b72f49141a308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94041 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94055 Tested-by: Jenkins
2020-05-18officecfg,unotools,cui: add ODF 1.2 Extended / ODF 1.3 versionsMichael Stahl1-1/+1
... to configuration and UI. The new default is ODF 1.3 Extended, which is now ODFVER_LATEST and stored as value "3" in configuration. Adapt a few places related to DocumentDigitalSignatures etc. to new default. Change-Id: I420da4f7787cc864c6bd88470d61b146b9399aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93177 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>