summaryrefslogtreecommitdiff
path: root/sfx2/source
AgeCommit message (Collapse)AuthorFilesLines
2017-11-23Related: tdf#113160 set a temporary dialog parent during type detectionCaolán McNamara1-1/+9
to get warning dialogs that don't block the existing windows but whose lifecycle can be controlled to avoid crashes during exit Change-Id: I57965301c3d8a031acb33e83bf7715fe132385d0 Reviewed-on: https://gerrit.libreoffice.org/45044 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23move preventduplicateinteraction from framework to sfx2 consumerCaolán McNamara2-3/+235
Change-Id: I1388a88ba20b5cde65cd1d88694775b071a0dff6 Reviewed-on: https://gerrit.libreoffice.org/45099 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin2-2/+2
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22tdf#113935 Switching from read-only to edit mode slowNoel Grandin1-0/+5
Regression introduced by commit 389da66dfc96d06c407bff156c4ea21e940c5e06 remove unused uno::Reference vars I'm guessing this variable keeps some kind of cache alive which prevents us from re-parsing the PDF file when we switch to edit mode - which is clearly what we are doing when I remove the line. Change-Id: Iea2cf9640d876028a78806e717b930d4a063dc9b Reviewed-on: https://gerrit.libreoffice.org/45093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann1-1/+1
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22replace check of eof and GetError with goodCaolán McNamara1-1/+1
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291 Reviewed-on: https://gerrit.libreoffice.org/45076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara2-2/+2
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin1-2/+2
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20cosmetics: Drop duplicate semicolonTakeshi Abe1-1/+1
Change-Id: I96d2ffb903f9ed15070572552c9564b5089df12f Reviewed-on: https://gerrit.libreoffice.org/44914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin4-11/+11
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-18Updated liborcus to 0.13.1.Kohei Yoshida1-3/+3
Change-Id: Id5aa07f87603879fe7a21dc96cad207f1b168286 Reviewed-on: https://gerrit.libreoffice.org/44850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-11-17Notebookbar: PriorityMergedHBox, OptionalBoxSzymon Kłos9-196/+575
Change-Id: I7822fb1b6a342065d66a3fd62f1277e43c2562dd Reviewed-on: https://gerrit.libreoffice.org/44694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-17TSCP: disable toolbar pop-up if category was set with dialogTomaž Vajngerl2-22/+115
In addition move reading of origin to classificationhelper as we need to read it there. Change-Id: I472b073587e68e6896f915477603a25db9b310d3 Reviewed-on: https://gerrit.libreoffice.org/44848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17TSCP: resolve identifier to name, abbr. name is for category onlyTomaž Vajngerl1-0/+15
In paragraph classification we store only the identifier and not the name, but for the ClassificationDialog we use the name as an identifier, so we need to resovle the identifier to the name when reading in the input classification results. It might make sense to switch to identifiers in the dialog also as they are language independent. Abbreviated name is only for the classification category and has no effect for other classefication elementslike markers and IP parts, so always fill them with the full name directly. Change-Id: I23bd0e8e92b16807a5b4d3162e503b799aa40718 Reviewed-on: https://gerrit.libreoffice.org/44845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-15lokdialog: Expose cursor visible statusPranav Kant1-3/+11
Change the notifyDialog API a bit. Use a std::vector to keep track of each payload item that needs to be fed to the resulting JSON. Change-Id: If3229a88d2df5368e14290a0e80ebe6206780639 Reviewed-on: https://gerrit.libreoffice.org/44722 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-14Translate German comments and debug stringsJohnny_M2-3/+3
Change-Id: I12c92ecc270e65cb99e38e9179cf354a8c0708aa Reviewed-on: https://gerrit.libreoffice.org/44633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-13Fix typosAndrea Gelmini3-3/+3
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-12use copy constructor to clone PoolItemsJochen Nitschke3-5/+5
Change-Id: I2a45a62fd56cc5a768406c7a6e4c72456f962367 Reviewed-on: https://gerrit.libreoffice.org/44648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-11sfx2: Replace SfxViewShell::DiscardClients_Impl()Takeshi Abe3-23/+2
with DisconnectAllClients() because both do the same ever since 17a91c18edea240a35a12a573933917240e9fb4a. Change-Id: I17639670d0fb787c69a53e8992f706937665d7b3 Reviewed-on: https://gerrit.libreoffice.org/44447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10rework tdf#113647 solution to be safeCaolán McNamara3-6/+23
rather than passing the pointer around, tragic use of uno apis means monstrous awt::Window thingy has to be passed around and still smuggled through the dispatch arguments to get through the eye of the XDispatch::dispatch needle Change-Id: I353f8a3b0bb698bb58f75576e49efd701f3db8bf Reviewed-on: https://gerrit.libreoffice.org/44585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-09TSCP: restore paragraph classification from DOC(X)Ashod Nakashian1-0/+3
Change-Id: I81f9a98f618b32e13c5ce92489846a4e20cc23d7 Reviewed-on: https://gerrit.libreoffice.org/44325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-09new loplugin simplifydynamiccastNoel Grandin3-8/+8
simplify dynamic_cast followed by static_cast Change-Id: I965afcf05d1675094cfde53d3590a0fd00f26279 Reviewed-on: https://gerrit.libreoffice.org/44460 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-09fix bugs in StateView_Impl and TransformItemsNoel Grandin2-2/+6
where it was only incrementing the pointer once, meaning it was not iterating in pairs Change-Id: I26cc9b4262bc869c72231ef9eabca2d29da0a724 Reviewed-on: https://gerrit.libreoffice.org/44462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-09lokdialog: Support painting parts of the dialogPranav Kant1-4/+7
Pass the dimensions of the region to the paintDialog call to paint only that much of the region in the dialog. The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in the payload that tells the region of the dialog invalidated. It can be used in combination with the new paintDialog call then to paint only the invalidated region in the dialog. Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906 Reviewed-on: https://gerrit.libreoffice.org/44472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-09rename AvoidConfig to FuzzingCaolán McNamara7-16/+16
cause that's what its really used for and a couple of cases are not specifically about avoiding config but avoiding uninteresting disk acccess and what not Change-Id: I4c6454f98388579fcd0bf9798321d30408ab65ee Reviewed-on: https://gerrit.libreoffice.org/44491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08ofz#4106 Integer-overflowCaolán McNamara1-8/+15
Change-Id: I91109f652bc032811ade350b77d30424b5764ad8 Reviewed-on: https://gerrit.libreoffice.org/44449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08tdf#100922 Refactor Custom Properties pageSzymon Kłos1-153/+204
This commit solves problems with big number of entries. Window is loaded quickly and is responsive even with over a thousand custom properties. Change-Id: I4745c69aaff95661ca930e303ab65591e374a24d Reviewed-on: https://gerrit.libreoffice.org/44429 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-08sw lok: add Accept/Reject All tracked changes, tdf#101977Henry Castro1-1/+4
Change-Id: I04d747343e24cb498a621c965d034d0791411d83 Reviewed-on: https://gerrit.libreoffice.org/44311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-11-07sfx2: SfxInPlaceClientList is just a std::vectorTakeshi Abe2-19/+3
Change-Id: I6b676d17d9592a0ca998cdafb25b1aa12e11b6d6 Reviewed-on: https://gerrit.libreoffice.org/44384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-07ofz#3577 TimeoutCaolán McNamara1-8/+7
little speculative given https://github.com/google/oss-fuzz/issues/960 Change-Id: Ie844ebdd1e693ce8589fba9b7370d55914d844a7 Reviewed-on: https://gerrit.libreoffice.org/44377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-07sfx2: Simplify SfxVersionTableDtor's code with std::unique_ptrTakeshi Abe1-19/+7
Change-Id: I8279f7ae14301f485c2678271939fb6ad72d4721 Reviewed-on: https://gerrit.libreoffice.org/44350 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-11-04lok: temporary workaround: disable formula mode for onlineMarco Cecchetti1-0/+31
- Start empty spreadsheet, open it with two users (let's call them A & B). - Type "=" with user A. - Start moving around to different cells with user B. => Cell name of user B's selected cell is entered in user A's formula. This is due to the fact that ScModel::GetInputHandler() returns always the input handler which is handling the edited formula and not the input handler of the current view. That really messes up collaborative editing, so better to disable it, until we implement an alternative solution. Change-Id: I6e779cba3f377d12b7a4a19a6ee53c924fc9ba20 Reviewed-on: https://gerrit.libreoffice.org/43035 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-04sfx2: Omit unnecessary indirection of SfxFrameDescriptor_ImplTakeshi Abe1-14/+6
Change-Id: I43c9df757d78420bd119a06e7f7224e40690b753 Reviewed-on: https://gerrit.libreoffice.org/44255 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-11-03Revert "Replace list by vector in filtergrouping (sfx2)"Michael Stahl1-20/+21
This reverts commit 62896fb7a5983eb13ee87b94ae803e6552626d8d. The usage of iterators in CreateEmptyClassRememberPos operator() is bogus and causes: Error: attempt to dereference a singular iterator.
2017-11-03TSCP: use the BAC identifier as the RDF keyAshod Nakashian1-2/+19
DOCX RDF -> SmartTag logic expects urn:bails namespace to dump the RDF, and it also needs to have the rdf file in tscp/bails.rdf, hence the move. Change-Id: I9ae496c97abe97d3596de46ffccd5f7c80e37d34 Reviewed-on: https://gerrit.libreoffice.org/44116 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-03sfx2: Simplify SfxDocTemplate_Impl with std::unique_ptrTakeshi Abe1-23/+13
Change-Id: Ie736bcb6ca636cd5f34f12f7b4fdb234d18f3999 Reviewed-on: https://gerrit.libreoffice.org/44202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03Replace list by vector in filtergrouping (sfx2)Julien Nabet1-21/+20
Change-Id: Ic5170843d8f47f92c7975cceaa9c33d278445b98 Reviewed-on: https://gerrit.libreoffice.org/43378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03ofz#3577 TimeoutCaolán McNamara1-18/+18
Change-Id: I723552fe277a9a16c8a14c01f4701e1077ddfac3 Reviewed-on: https://gerrit.libreoffice.org/44223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-01sfx2: Simplify RegionData_Impl's code with std::unique_ptrTakeshi Abe1-20/+11
Change-Id: I87dba62abc48e70cfb019ddaa4cc93779ee844b5 Reviewed-on: https://gerrit.libreoffice.org/44155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31sfx2: Kill dead codeTakeshi Abe1-40/+0
which has been obsoleted since 387a35cedd74fee295dfeb2ad59a74cd8dabc451. Change-Id: Icd3f0044ea67b0cecf4491399e875197282ea476 Reviewed-on: https://gerrit.libreoffice.org/44106 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-31loplugin:constantparam in sfx2Noel Grandin4-18/+11
Change-Id: Id52809401fb848d7169a665903e67ba28f4af598 Reviewed-on: https://gerrit.libreoffice.org/44084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31loplugin:constantparam in sal,saxNoel Grandin2-3/+3
Change-Id: I7ca2fd05d1cf61f9038c529a853e72fedb1c9ed0 Reviewed-on: https://gerrit.libreoffice.org/44087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31sfx2: Kill useless mutex guardTakeshi Abe1-1/+0
Change-Id: Idcbb1eff983bb82d29b8e53f09c0b7e73a8aab39 Reviewed-on: https://gerrit.libreoffice.org/44046 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30'r' means C++ reference, but this mormal local OUString variable is not thatTor Lillqvist1-2/+2
Change-Id: I56d21c3dc09f972a415bbd74dc635b231373d9f3
2017-10-30tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+Furkan Tokac1-9/+11
Change-Id: I32aab185cd0572353f4d94cfe4b16af25a665ef4 Reviewed-on: https://gerrit.libreoffice.org/43684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-28lokdialog: Use UNO name as dialog id when invoking lok callbacksPranav Kant1-2/+2
... not the frame id from the .ui file Remove temporary hacks introduced earlier in GTV also. Change-Id: I71290a5fac6547a5584094da21e2301ef8fbce0c Reviewed-on: https://gerrit.libreoffice.org/43957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-28TSCP: bump the doc classification if lower than paragraphAshod Nakashian1-5/+27
The document classification should not be lower than the highest-classificed paragraph. This insures that the document classification is as high as the highest classified paragraph upon saving. Change-Id: Ic838b886ecf97da2eca56870f68aa3e51c7291f6 Reviewed-on: https://gerrit.libreoffice.org/43772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-27loplugin:includeform: sfx2 (Windows)Stephan Bergmann1-1/+1
Change-Id: I2ce3e5012b368a9e390d927a3dfd2150c0d5d9f7
2017-10-27sfx2: Drop unnecessary abstraction of SfxFrameArr_ImplTakeshi Abe5-68/+9
Instead, use plain std::vector<SfxFrame*>. Change-Id: Ib32e748a0ce744d15cbe48f5d03e28c57b731394 Reviewed-on: https://gerrit.libreoffice.org/43938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26Avoid undefined left shift of signed integerStephan Bergmann1-3/+3
...after 022b1b2a40fcaf8d201081dead44c1d3346d1972 "tdf#96505 Get rid of cargo cult long integer literals" Change-Id: I9e5cc9d63c2eddd1ad766c2f6b01a9ff49a09bfd
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-16 21:47:15 +0000