summaryrefslogtreecommitdiff
path: root/sfx2/source
AgeCommit message (Collapse)AuthorFilesLines
2014-08-12Resolves: #i125386# secured user request and changed some bools to bitfieldArmin Le Grand1-1/+11
(cherry picked from commit 5e3cbe056c19bea5018dbf1fd4b2bc8f8b030ff3) Conflicts: comphelper/inc/comphelper/embeddedobjectcontainer.hxx comphelper/source/container/embeddedobjectcontainer.cxx sfx2/source/appl/linkmgr2.cxx svtools/source/misc/embedhlp.cxx (cherry picked from commit d005acae3aa315921f2c331612131626c470bd22) Conflicts: include/comphelper/embeddedobjectcontainer.hxx Change-Id: I7e9b20a87ca6afe8cb91c577860a6c6b72368ee9 Reviewed-on: https://gerrit.libreoffice.org/10882 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-12Related: #i125226# expect DDE servers to be already upHerbert Dürr1-61/+11
"soffice" is always up anyway and other DDE apps should be started manually (cherry picked from commit e0bfdb26cef87c8d3b3435293116a33cf99c11f0) Conflicts: sfx2/source/appl/impldde.cxx (cherry picked from commit f4a8d7cd10cda57143b22519e16cdf8d5f19e759) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I52ebb26528952a4abf33ac95cb67c598f08b2790 Reviewed-on: https://gerrit.libreoffice.org/10297 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-07rhbz#1079672: FileDialogHelper: don't hand out stale preview GraphicMichael Stahl1-13/+10
The maGraphic is updated from a timer, and if you double-click on a file then the dialog may exit with the previous file still previewed in maGraphic, so the wrong image is returned by the dialog. Change-Id: I99094d85d8d68d5c8a842f52e7039dbbbf095995 (cherry picked from commit f1589f768bbd1d8baea6e442f392831851bdbb3b) Reviewed-on: https://gerrit.libreoffice.org/10804 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-04avoid buffer overflow by using wrong bufferMarkus Mohrhard1-1/+1
Found by Asan. (regression from CWS mba34issues01) Change-Id: Ia7159c9bed9d7f823448acd02e18568a5f3f2093 Reviewed-on: https://gerrit.libreoffice.org/10717 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 955c5539a1ea5e971f111989d6c5bec11d936416) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2014-07-29Related: fdo#81641 create new styles with an initial nameCaolán McNamara2-11/+19
instead of creating with a blank name and changing it later this way undo of a style creation is initialized with its name and so create a style followed by deleting a style and undoing all those steps doesn't crash (cherry picked from commit e904562af54545684b32d2042ded6bdb9459edca) Conflicts: include/sfx2/styledlg.hxx sw/source/uibase/app/docst.cxx Change-Id: Ida7a34410d5d7b05edcb86950aabb3c672b82c8f style category listbox depends on being unsorted regression from commit 6ecfbf153a7c11c63d208630ac6a27064058099d Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Mar 13 15:10:25 2013 +0000 drop unused resources and toggle label to activate replacement widget Change-Id: I65ca8ec58ed984120f3c2e7ba68507cbf8acf089 (cherry picked from commit 11fab6b705638359b2ca0e3e85590aa7cc70a03a) Related: fdo#81641 exclude 'all styles' category from organizer page it doesn't make sense to be able to assign a style to 'all styles' Change-Id: I632c62f293b553e436ceb8da0baf2bb39941fd39 (cherry picked from commit 2223ff6cb99df097a357674801835c7a260b551d) Resolves: fdo#81641 the new style shouldn't be a conditional style regression from commit 715d79bcc59d68c77dc84a1038998dd873df92e9 Author: Cédric Bosdonnat <cedric.bosdonnat@free.fr> Date: Fri Nov 30 11:51:46 2012 +0100 Styles & Formatting: added SFXSTYLEBIT_ALL_VISIBLE and show hidden styles commit 2fd9c2bf9af0c50dae3af3dbe5e22965ccdb4ae7 Author: Cédric Bosdonnat <cedric.bosdonnat@free.fr> Date: Sun Nov 25 15:24:42 2012 +0100 Allow to hide styles in the "Styles & Formating" dialog In its current state, the feature only hides the styles. Things to sort out are: + Add some automatic filter to show hidden styles + Make the visibility persist in the file format (cherry picked from commit 1af0e46102350114dd5e854b7692c640dae2727f) Conflicts: sw/source/uibase/app/docst.cxx Change-Id: I7244d424765db0d5ed3aeaf380a8e1af56aa7eaf Reviewed-on: https://gerrit.libreoffice.org/10503 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-25Related: fdo#81457 skip setting an empty allocationCaolán McNamara1-19/+44
if the dimension is 0, don't bother calculating a bunch of <= 0 sizes, rely on the parents clipping to hide the lot instead (cherry picked from commit 13807fbf9f3a4aae6767da8bcf796bea4b065159) and Related: fdo#81457 quadratic time required when setting a11y name when calling SetAccessibleName GetAccessibleName is called in order to send a name changed a11y event. Getting an Accessible Name is very slow in a non-layout aware widget because it scans for a "nearby" label and there is none in this widget, but it has a huge pile of other widgets to iterate over. call add_mnemonic_label before hand to cut off that entire branch. While we're at it, only call InitControl to adjust to a new width if the new width is different from the old width (cherry picked from commit aff263c8b814c6bf352312403d3c1e448c8013a3) Conflicts: include/sfx2/dinfdlg.hxx Change-Id: Ie4ba1276127226e49442278e46447b84bbeb1cde Reviewed-on: https://gerrit.libreoffice.org/10463 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-22fdo#81304 don't parse file name as part of URLDavid Tardon1-1/+2
... because the name is not URL-encoded at this point, so parsing it as a part of the URL will interpret special characters, e.g. #. Change-Id: I780baed1753e9674d835dc296d31c088b67d8ba7 (cherry picked from commit f3d7734af45f30a87d6de76aa3de7593d541bdc8) Reviewed-on: https://gerrit.libreoffice.org/10295 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-07-15fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida1-1/+18
(cherry picked from commit 1d38cb365543924f9c50014e6b2227e77de1d0c9) Signed-off-by: Andras Timar <andras.timar@collabora.com> Conflicts: xmloff/source/chart/SchXMLExport.cxx sd/source/ui/view/sdview3.cxx chart2/source/controller/chartapiwrapper/WrappedNumberFormatProperty.cxx chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx chart2/source/controller/main/ChartTransferable.cxx chart2/source/controller/main/ChartTransferable.hxx chart2/source/model/main/Axis.cxx chart2/source/model/template/ChartTypeTemplate.cxx chart2/source/tools/AxisHelper.cxx chart2/source/view/main/ChartView.cxx comphelper/source/container/embeddedobjectcontainer.cxx dbaccess/source/ui/browser/dbexchange.cxx dbaccess/source/ui/inc/JoinExchange.hxx dbaccess/source/ui/inc/TableRowExchange.hxx dbaccess/source/ui/inc/dbexchange.hxx dbaccess/source/ui/querydesign/JoinExchange.cxx dbaccess/source/ui/tabledesign/TableRowExchange.cxx embeddedobj/source/commonembedding/persistence.cxx embeddedobj/source/inc/commonembobj.hxx include/comphelper/embeddedobjectcontainer.hxx include/svtools/embedtransfer.hxx include/svtools/stringtransfer.hxx include/svtools/transfer.hxx include/svx/dbaexchange.hxx include/svx/dbaobjectex.hxx include/svx/fmview.hxx include/svx/galmisc.hxx include/svx/svdobj.hxx include/svx/svdoole2.hxx include/svx/svdxcgv.hxx include/svx/view3d.hxx include/svx/xmlexchg.hxx include/xmloff/xmlexp.hxx reportdesign/source/ui/dlg/GroupExchange.cxx reportdesign/source/ui/dlg/GroupExchange.hxx reportdesign/source/ui/inc/dlgedclip.hxx reportdesign/source/ui/report/dlgedclip.cxx sc/inc/column.hxx sc/source/ui/app/drwtrans.cxx sc/source/ui/app/lnktrans.cxx sc/source/ui/app/seltrans.cxx sc/source/ui/app/transobj.cxx sc/source/ui/inc/drwtrans.hxx sc/source/ui/inc/lnktrans.hxx sc/source/ui/inc/seltrans.hxx sc/source/ui/inc/transobj.hxx sc/source/ui/inc/viewfunc.hxx sc/source/ui/view/viewfun5.cxx sc/source/ui/view/viewfun7.cxx sd/source/ui/app/sdxfer.cxx sd/source/ui/dlg/sdtreelb.cxx sd/source/ui/inc/TabControl.hxx sd/source/ui/inc/View.hxx sd/source/ui/inc/sdtreelb.hxx sd/source/ui/inc/sdxfer.hxx sd/source/ui/view/sdview2.cxx sd/source/ui/view/tabcontr.cxx sfx2/source/doc/objxtor.cxx svtools/source/misc/embedtransfer.cxx svtools/source/misc/stringtransfer.cxx svtools/source/misc/transfer.cxx svtools/source/misc/transfer2.cxx svx/source/engine3d/view3d.cxx svx/source/fmcomp/dbaexchange.cxx svx/source/fmcomp/dbaobjectex.cxx svx/source/fmcomp/xmlexchg.cxx svx/source/form/fmexch.cxx svx/source/form/fmview.cxx svx/source/gallery2/galmisc.cxx svx/source/inc/fmexch.hxx svx/source/svdraw/svdoole2.cxx svx/source/svdraw/svdxcgv.cxx svx/source/tbxctrls/colrctrl.cxx sw/source/core/uibase/dochdl/swdtflvr.cxx sw/source/core/uibase/inc/swdtflvr.hxx sw/source/core/undo/unins.cxx Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a (cherry picked from commit 4ee53683df4beda260aff26d2c9e56fe643f45bb) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2014-07-11Related: #i125226# don't try to access known-bad DDE serversHerbert Dürr1-4/+15
(cherry picked from commit 88de6a59d9d7933b86fdcba733277aa4fbd5e132) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: If4dcd49cfe15188d06e4e06cd8e58cdcc66ed5a4 (cherry picked from commit b16f164650f8345e51bf0b0c73bf9c8eee775bc2) Related: #i125226# some macro preferences are directly... applicable to DDE servers (cherry picked from commit 2c835e761e1e9ddb6794895e6f3538b918160dd1) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: Ic16b3df34ac1b003a8a5cabab15ea655d05bdd18 Related: #i125226# typo fix (cherry picked from commit 727ea069c6342e01a50c8b068ec302574b251cbd) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I8db53b7e8529d05e660a2d69e669b44c9045712c (cherry picked from commit 13b68e24db26374ca17572de9abb429edeac32e9) Related: #i125226# disallow absolute and relative paths for DDE servers (cherry picked from commit 6b64ada6e3a902ac4b44fe49476514d49138d4d4) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I127add375a127dbbd0eaf12a10884e2636f1a332 (cherry picked from commit d1fc47793c1efbe9ff5271656283211647dd0b33) Reviewed-on: https://gerrit.libreoffice.org/10202 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-06-10Resolves: fdo#79360 impress hangs on using sidebar new styleCaolán McNamara3-47/+21
because those styles are "pseudo-styles" and a new one cannot be added. The possibility is supposed to be disabled, and it is disabled in the floating stylelist. The old code assumes there can only be one of these stylelists and when a stylelist queries if the "new" should be disabled the callback asks the stylelist what family is selected, but only asks the floating one. So, floating closed, sidebar open, the new is not disabled. Implement the ancient TODO now that we have to. Instead of asking the stylelist what family is selected, query the frame for what is the current SID_STYLE_FAMILY as set by whatever is the active stylelist. What's disturbing is the SID_STYLE_FAMILY values are not SfxStyleFamily, but indexes that have to be mapped to SfxStyleFamily. I bet there are a pile of bugs around that, especially with little islands of different conversion codesites (cherry picked from commit 7a211e834fc271d3f28d7f8c49197c925242d862) Conflicts: sfx2/source/appl/appmisc.cxx convert from NId to FamilyId instead of FamilyId to NId should be equivalent for comparison purposes (cherry picked from commit f48f5138ecedd3bb9ec0b454b9fe216001610156) remove unused virtual method, slim this down initially (cherry picked from commit fa551c422426962194b6bff4234f12eb5bdf57ca) (cherry picked from commit 3988f17d14ee28b4bb117ca9961708ad3a867fb1) Conflicts: sd/source/ui/view/drviewsf.cxx sfx2/source/appl/appmisc.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/inc/templdgi.hxx sw/source/core/uibase/app/docst.cxx Change-Id: I85c8032d7c26ae6eea245685748f89b2a860e767 Reviewed-on: https://gerrit.libreoffice.org/9573 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2014-05-22fdo#78742: SfxFilterMatcher: respect requested document service if setMichael Stahl1-1/+3
sfx2::DocumentInserter::CreateMediumList() creates a SfxFilterMatcher that should match Writer filters only, but actually Calc filters may be returned; check that the document service matches. (regression from 3da8f3680556e0163f660a0a159930337c8c32ff) Change-Id: I6208d38c1110355105aa5d1ffa1b57142193a4d7 (cherry picked from commit 805fd1ca343d6295b8114a24cc29bdac332f266d) Reviewed-on: https://gerrit.libreoffice.org/9404 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-05-22Use varying aElement nameStephan Bergmann1-1/+1
Change-Id: Idc135ef5031a01961cc18d897a734b598bc833f4
2014-05-22valgrind: SfxBaseModel's pImpl of fallback TargetDocument for paste leaksCaolán McNamara1-0/+5
e.g. repeatedly pasting a metafile into writer and deleting it. ==13369== 342 (232 direct, 110 indirect) bytes in 1 blocks are definitely lost in loss record 19,396 of 22,170 ==13369== at 0x4A06965: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==13369== by 0x686D72E: SfxBaseModel::SfxBaseModel(SfxObjectShell*) (sfxbasemodel.cxx:518) ==13369== by 0x288CA9C1: SvxUnoDrawingModel::SvxUnoDrawingModel(SdrModel*) (unomod.cxx:255) ==13369== by 0x28961055: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, char const*) (xmlexport.cxx:164) ==13369== by 0x28960FA2: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&) (xmlexport.cxx:148) ==13369== by 0x2896175E: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) (xmlexport.cxx:254) ==13369== by 0x240B1002: SwFEShell::Paste(SvStream&, unsigned short, Point const*) (fecopy.cxx:1333) ==13369== by 0x247B981A: SwTransferable::_PasteSdrFormat(TransferableDataHelper&, SwWrtShell&, unsigned short, Point const*, unsigned char, bool) (swdtflvr.cxx:2207) ==13369== by 0x247B678E: SwTransferable::PasteData(TransferableDataHelper&, SwWrtShell&, unsigned short, unsigned long, unsigned short, bool, bool, Point const*, signed char, bool) (swdtflvr.cxx:1481) ==13369== by 0x247B5AE4: SwTransferable::Paste(SwWrtShell&, TransferableDataHelper&) (swdtflvr.cxx:1150) ==13369== by 0x2488FCCE: SwBaseShell::ExecClpbrd(SfxRequest&) (basesh.cxx:277) Reference< lang::XComponent > xTargetDocument( xComponent ); if( !xTargetDocument.is() ) { > xTargetDocument = new SvxUnoDrawingModel( pModel ); pModel->setUnoModel( Reference< XInterface >::query( xTargetDocument ) ); } (cherry picked from commit fdca15fb864aca975533257d5ee83440992d8a7e) Conflicts: sfx2/source/doc/sfxbasemodel.cxx Change-Id: I3bd0fc983d9b6bdcdc91071a4ec3d2c584397ebf Reviewed-on: https://gerrit.libreoffice.org/9384 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-05-20fdo#78536: sfx2: template dialog: make the am-i-dead-yet check reentrantMichael Stahl2-4/+11
In the fine tradition of our enterprise-grade code base, this lets the check in SfxCommonTemplateDialog_Impl::Execute_Impl() do an early return if the "this" instance has signalled its untimely demise even if there are multiple calls of Execute_Impl() on the stack; extending the scheme with further epicycles to make it work if the Execute_Impl() calls happen on 2 different threads is left as an exercise for the interested reader. (regression from bcc52fb2ebdf77a1cc089857775fd742085b45b6) (cherry picked from commit 838c580fdba8b1c72bc854d101d302be0e3861d5) Conflicts: sfx2/source/dialog/templdlg.cxx Change-Id: I1d9f0d82bf6d9f5da8f9bd2be57d01937d71fd26 Reviewed-on: https://gerrit.libreoffice.org/9406 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-07Resolves: fdo#68600 limit comment widthCaolán McNamara1-3/+2
(cherry picked from commit 087fcc43b13985b03d935dfd1e25a0d36d58cb1e) Conflicts: sfx2/source/dialog/dinfdlg.cxx Change-Id: I7060ae18a98e0793a936834b398f1e232d336672 Reviewed-on: https://gerrit.libreoffice.org/9269 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-05-06fdo#76261 Get rid of unneeded and malfunctioning maItemListRect.Andrzej Hunt1-11/+3
maItemListRect serves as a sort of bounding box for what items /could/ be visible on screen, however it is only used for determining the id of an item we have just clicked on -- given that we already know that we are clicking inside the visible area this is an unnecessary check. In fact this check is erronous as we no longer limit ourselves to "whole" rows as of 806919adf9c9bafbaba92c2d2ab35d2e2f9863f8 -- i.e. the previous assumption was that a view large enough for n rows will show precisely n (whole) rows, whereas we might be showing (n-1) complete rows, and a fraction of a row at the top and bottom of the screen, i.e. a total of n+1 rows, where maItemRect only encloses the top n rows, meaning we were erronously ignoring clicks on the (partly visible) lowest n+1 row. Change-Id: Ia52ed2e0d217a9f077cef86ee9c1847252844995 (cherry picked from commit fb0ca7eff0e16fa8dd1a4c8d75fef23830903a3f) Reviewed-on: https://gerrit.libreoffice.org/9255 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-06fdo#73766 TemplateManager: construct toolbars in focus traversal order.Andrzej Hunt1-1/+1
Focus traversal happens in the order that UI items are initialised. As the "TemplateBar" (i.e. actions that can be used on a selected template) is to the left of the "ActionBar" (i.e. search/etc.), the TemplateBar would be expected to be first in the traversal order. This patch is only relevant for LibreOffice 4.2 -- in master (to become 4.3) this dialog has already been converted to .ui, and focus traversal works as expected. Change-Id: I3328f2e79a8e5a781aceb29f79d0c54d4b421e74 Reviewed-on: https://gerrit.libreoffice.org/9257 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-30fdo#72006 Populate "Load URL" dropdown from picklist.Andrzej Hunt1-1/+1
f7feb4227d83f4f095597a44826277aaae2bc0df stopped any newly opened documents from being added to the "History" list (and instead adds them to the picklist), since the history list is not used anywhere else, and since the picklist performs an equivalent function, it makes most sense just to use the picklist to populate the list of URLs. Change-Id: I5a06e7fefe3dc1fbe266f3191de4fbac03601858 Reviewed-on: https://gerrit.libreoffice.org/9104 Tested-by: Andrzej Hunt <andrzej.hunt@collabora.com> Reviewed-by: Andrzej Hunt <andrzej.hunt@collabora.com> (cherry picked from commit b8315b1c2f43ab44651e5089a63fb63e23a1ea73) Reviewed-on: https://gerrit.libreoffice.org/9172 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-25fdo#77242 fix crashAndras Timar1-1/+11
Change-Id: Ic28b2dccc02627446a794929fe970495b15eb0e1 Reviewed-on: https://gerrit.libreoffice.org/9154 Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-04-22adjust output file extension when exporting (bnc#870581)Luboš Luňák1-0/+3
If foo.odt is open, 'foo.odt' is the file name passed to the file dialog for File->Export to PDF (simply because it's the document name). If automatic file extension is enabled, the file dialog will fix this to the PDF file type, but if disabled, the default filename will remain foo.odt, possibly overwriting the source file if the user confirms without checking. (cherry picked from commit cadf6cc31ffa000d1fe8e42cc3e6cd427e0104bd) Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I46504630b5f4e489d5a0cedf0b2b358305763722
2014-04-16fdo#72287 Scroll automatically to show selected item when keyboard used.Andrzej Hunt1-4/+11
806919adf9c9bafbaba92c2d2ab35d2e2f9863f8 added finer-grained scrolling using the scrollbar / scrollwheel, but inadvertently prevents the display from scrolling when an item is selected that is currently offscreen (e.g. by using the down-arrow button on the keyboard). Change-Id: Iaa3a7dc6d214741d37cf4ec78c00ed0034ed1e42 (cherry picked from commit 717aa1ac75ddd54fdf72cd4de6551f1fb536da9b) Reviewed-on: https://gerrit.libreoffice.org/9017 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-16Fix fdo#71423 - crash while editing Impress tables.Thorsten Behrens1-1/+3
Band-aid fix for this nasty crasher, seems sometimes the family item is not found. Change-Id: I7f78d59cbf2c9595ad512fa7a78370629924cd06 (cherry picked from commit 058cfa72dcdd91df302be45f7fc59b0d961a420b) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2014-03-12hidpi: Sidebar, fontwork, autoformat and other improvements.Keith Curtis5-23/+55
This is a second batch of HiDPI changes. It fixes the following areas: Sidebar * Impress Master pages preview * deck title height * tab (icon) bar * valueset dropdown control * wider maximum width * Draw and other misc. buttons which didn't get fixed by earlier change to Toolbar.SetItemImage There are several more sidebar issues, but it is much improved. Other changes * Writer and Calc auto-format dialog text * file-properties document image * fontwork gallery preview size * Calc table border control Change-Id: I95a0169a3b011836b1c75b3dcacb2733c9567ef3 Reviewed-on: https://gerrit.libreoffice.org/8519 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-10fdo#75243: MSO export: save custom properties with empty valueTarun Kumar1-1/+1
LO removes empty properties while saving the doc. This is required in some business scenarios. bSkipEmpty is set to false by default to enable LibreOffice to save even empty properties. Change-Id: I7aafe0c0be02a98fa6e72d73e9e4348a015da61f (cherry picked from commit 3ba58a22bdd51cd4221547e0a0e95b6d2b987358) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2014-03-07fdo#74787, rhbz#1072553: Fix deselection problems of template viewZolnai Tamás2-2/+7
deselectItems() were added to make recent docs view work, but it is unneccessary to affect template view too. (regression from 0314034d8b23d5b69399cfcdf6b2f2add73f9f47) Conflicts: sfx2/source/control/recentdocsview.cxx Change-Id: I0c805774321939991e308e9c8c669604e81dbad5 Reviewed-on: https://gerrit.libreoffice.org/8490 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-24fdo#73869 fix highlight RTL Problem at the StartCenter window.Faisal M. Al-Otaibi1-1/+1
Change-Id: I2fb5bf97941478781c0a77b55d4454acd00f903b Reviewed-on: https://gerrit.libreoffice.org/8199 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: CUPS printing: notify user if spooling failedMichael Stahl1-0/+1
CUPS does not accept jobs for a printer that has been stopped; pop up an error message in this case instead of silently ignoring failure. Change-Id: I1bc9120c9c9f438e350c964ed7ef29924a72ce78 (cherry picked from commit cdb405f4e4b168d1e2f6dea9ac985df319a76015) Reviewed-on: https://gerrit.libreoffice.org/8115 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-17Resolves: fdo#72233 too long style names over-stretch dialogCaolán McNamara1-0/+5
Change-Id: Id6f102a3def1928ad8f6b4d27eb32f8c69bdba49 Reviewed-on: https://gerrit.libreoffice.org/8084 Tested-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2014-02-10related fdo#65430: forgot to 'unlink' setOpenTemplateHdlJoren De Cuyper1-0/+1
This was introduced in 96e7225260aac0815643a4043f4ddb4e6b5764a1 Conflicts: sfx2/source/doc/templatedlg.cxx Change-Id: I9bb8abbc9e9167b1e43bebf4477cf73010bf2d92 Reviewed-on: https://gerrit.libreoffice.org/7959 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07fdo#74506 fdo#74291 -Template manager-store selection before calling dialogJoren De Cuyper1-6/+16
It looks like calling a dialog/querybox result in a deselection of the selected ThumbnailViewItem(s). Therefore lets save this selection first, before calling such dialog. Change-Id: I45a1da4307759ca6472f793fff29b1e2507fd5c9 Reviewed-on: https://gerrit.libreoffice.org/7902 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a411bf38da3668094698c06c8424aa9d68c85702) Reviewed-on: https://gerrit.libreoffice.org/7925
2014-02-07fdo#65430 add OnItemDblClicked and setOpenTemplateHdl in templateSearchViewJoren De Cuyper3-0/+19
Currently only templateAbstractView had such handler, which are templateLocalView and templateRemoteView are based on. Change-Id: I6694d0804a8b7e58abc0ddc970e811d053394d6f Reviewed-on: https://gerrit.libreoffice.org/7918 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 96e7225260aac0815643a4043f4ddb4e6b5764a1) Reviewed-on: https://gerrit.libreoffice.org/7923
2014-02-07fdo#74148: sfx2: fix crash when editing templateMichael Stahl1-1/+3
SfxTemplateManagerDlg::OnTemplateEdit() accesses invalid iterator because during loadComponentFromURL() it happens that ThumnailView::LoseFocus() is called and maSelTemplates is cleared. Change-Id: I074a70e5ce8bc89a38b720ddd0325c69c1d2b9ff (cherry picked from commit c8e206fdaab7490fb6e62bc7ab475888236179c2) Reviewed-on: https://gerrit.libreoffice.org/7904 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2014-02-04fdo#72338: startcenter: Show busy mouse pointer when starting apps.Jan Holesovsky1-0/+3
Change-Id: I8f254419ea7bb4e3e9835bd9fab8229ed89cd0e9 Reviewed-on: https://gerrit.libreoffice.org/7828 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04startcenter: Don't cut off the thumbnails.Jan Holesovsky1-1/+1
Change-Id: Ie5ad5f5be48aa873df94a31e980aaabc4ac24868 Reviewed-on: https://gerrit.libreoffice.org/7827 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-03Related fdo#65826: Set StartCenter's min width to display one column of docsZolnai Tamás3-8/+40
If there is document to display. Otherwise set minimum to the width of greating background text. Updating minimum size is needed only when the list is cleared. Change-Id: Ic089571fd21d5ab9ded0f4cde7e1aa72fd508d32
2014-02-03fdo#65826 and fdo#73605: set a minimum size to start centerZolnai Tamás3-1/+25
This minimum size calculated like this: width: sidebar optimal width + width of text appearing in the thumbnail view when no recent document is available. height: menu width + optimal width of GtkBox containing buttons. Change-Id: Ic1fd6e33a1ec93e61318af02c09ee88909a76cf4 Reviewed-on: https://gerrit.libreoffice.org/7505 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann6-22/+22
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. (cherry picked from commit a3f32769fc4bb23c64168b412dd10ec769a3854d) Conflicts: sc/source/ui/unoobj/nameuno.cxx sc/source/ui/unoobj/styleuno.cxx sfx2/source/appl/sfxhelp.cxx stoc/source/security/permissions.cxx sw/source/core/unocore/unocrsrhelper.cxx (None of those bogus startsWith calls seem problematic enough to warrant backporting also to libreoffice-4-2-0.) Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21 Reviewed-on: https://gerrit.libreoffice.org/7578 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21fdo#72639: send proper ACTIVE_DESCENDANT_CHANGED eventsJacobo Aragunde Pérez3-3/+52
At ThumbnailView::SelectItem the piece of code in charge of the accessible events related to selection change was mistakenly using the accessibility helper class ThumbnailViewAcc instead of ThumbnailViewItemAcc which is the proper one for managing the events related to ThumbnailViewItem objects. The methods FireAccessibleEvent and static getImplementation had to be added to ThumbnailViewItemAcc to provide the full functionality required. Change-Id: Ia5ffb24c920f3c48854021700819be683c979411 Reviewed-on: https://gerrit.libreoffice.org/7551 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 01a9f7b2fb6b3445ba9a93a4278ffa3821f7d04b)
2014-01-13fdo#72420 Startcenter: help button point to local/wiki help, ui partZolnai Tamás1-3/+0
Not handle clicking help button manually but use the default gtk-help button which will point to the corresponding help files depend on helpids. (cherry picked from commit 55fcca64a7d006f8cb10268fd2e1e09b1618a800) Change-Id: I7ac4b51868d1a5828c810b1ac629d5a56ffb6f50 Reviewed-on: https://gerrit.libreoffice.org/7365 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-10fdo#72947 Startcenter: handle file urls and non-file urls on a different wayZolnai Tamás1-1/+6
Thanks Stephan Bergmann for the idea. Change-Id: Ifdde1b7eaaefd30a176c47385bc9bfec48d5b86c (cherry picked from commit 340e70e248824a3a4959fa1dee90c5650f257ae8) Reviewed-on: https://gerrit.libreoffice.org/7377 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-10Startcenter: ignore repeated clicks inside recent docs viewZolnai Tamás1-1/+1
Change-Id: Ia433adb26e820b89c4d207d018d0daf42654b4a0 (cherry picked from commit 264fc270a73de32a7a4d86442c06d14acdd14ef2) Reviewed-on: https://gerrit.libreoffice.org/7374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-10fdo#72947 Startcenter: display more userfriendly file urls in tooltipsZolnai Tamás1-3/+3
Use INetURLObject to get a readable url (it displayes special characters too). It is a side effect that 'file:///' prefix disappear which seems a good thing. Plus some cleanup: remove second INetURLObject. Change-Id: I4aab5e2546ae70e5a3d85b12e26e021bfa244999 (cherry picked from commit 31dfeee42e9b08ed7031b6c50d0c674122d5245c) Reviewed-on: https://gerrit.libreoffice.org/7366 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-09Startcenter: use PAPER_SCREEN_4_3 as default paper for presentationsZolnai Tamás1-3/+18
Remove static to able to construct items with different paper info. (cherry picked from commit 5ab1fb926e984780380665ae185646b603292a6e) Change-Id: Ifba44675f6126ebfccf26f53f226214bed92352c Reviewed-on: https://gerrit.libreoffice.org/7339 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-09fdo#71628 Startcenter: remove thumbnail selection when focus is moved awayZolnai Tamás1-33/+2
mnHighItemId is never assaigned with a valid value and there is no sense to store one selected element's index anyway, because there can be more. The bMove parameter of ImplGetItem is never used and doesn' work so remove it. Change-Id: I91d6bc3fd13a2b44e6961fea66d02702a8f31c2b (cherry picked from commit 0314034d8b23d5b69399cfcdf6b2f2add73f9f47) Reviewed-on: https://gerrit.libreoffice.org/7340 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-09Remove unused private member: pAccExecZolnai Tamás1-3/+1
Change-Id: Ie21f8a62213954da7f66c1fbe890ba9dee93cf77
2014-01-09Startcenter: Refresh RecentDocsView when select 'Clear list' menu optionZolnai Tamás3-3/+58
Change-Id: I9cbe647563699b9b610661003084d2cd16093f9a (cherry picked from commit d930cefbe65d8b7f21100fcbf2ddcd977dd15cb1) Reviewed-on: https://gerrit.libreoffice.org/7304 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-09Startcenter: when screen is small make doc thumbails smallerZolnai Tamás1-2/+3
(cherry picked from commit 42c1463b8914cf51dd778ff4b22c56e57a935ccf) Change-Id: If4fbb66992318221a687710afa77fc98e4f111c3 Reviewed-on: https://gerrit.libreoffice.org/7331 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-09Startcenter: double click opens file only onceZolnai Tamás1-0/+3
Change-Id: I0d99a905cc8c94d39bfe802b2c597275c81f0b4f (cherry picked from commit c22f8faa7103a8a49b6a872293104b50f9c5d951) Reviewed-on: https://gerrit.libreoffice.org/7332 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-08tweak button order for alien warn dialogCaolán McNamara1-1/+1
Change-Id: I6e51951df3bff0d1829bff8e2a436e4030247baf (cherry picked from commit 2e8a1e1121bc23d442bf7be27e2ae6c15d101980)
2013-12-17Fixed the update to working copy and back after (cancel) checkout: fdo#64533Cédric Bosdonnat2-9/+8
After Checkout, simply set medium name and update the medium: at least we are sure it works in more situations than the other function we used. After cancel checkout, call SID_RELOAD to actually revert any local change. Change-Id: I3dc296a74726770c4f47d9653c382108f7baccad (cherry picked from commit a68e0e334df02c1ca47601575523b23c6db13470) Reviewed-on: https://gerrit.libreoffice.org/7068 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-18 02:29:14 +0000