summaryrefslogtreecommitdiff
path: root/sfx2/source
AgeCommit message (Collapse)AuthorFilesLines
2016-02-06vcl: remove boost/signal2/signal.hpp from headerMichael Stahl2-0/+3
The most relevant signal member function appears to be connect(), so let's create a wrapper function for that now, without the more esoteric ordering features for now. Move the signal member itself to a new pImpl. The benefits are worth it: preprocessor input reduced by 2.8GB, that's 9% of the total (excluding system headers which are not counted because they don't generate dependencies). Change-Id: I0aaeda51a5630a348bb12c81a83f67afbd508a14 (cherry picked from commit 20bd0a2ee9ed899ea542c2de08efda243dbef446)
2016-02-06Fix typosAndrea Gelmini2-3/+3
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit e544f449eded2738b45de4be13c72b128a16bafe)
2016-02-06remove some unnecessary typedefs to pointerNoel Grandin1-2/+1
that were really not helping make the code any clearer. Found with a search git grep -P 'typedef\s+\w+\s*\*\s*\w+\;' and manual inspection (cherry picked from commit d16d9f950f8cb6d8948875372c9ff1f0aae9fb7a) Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9
2016-02-06Fix typosAndrea Gelmini1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 1a8915ef8302b13b781977209ae1fa41f5f659dc) Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
2016-02-06loplugin:loopvartoosmallNoel Grandin15-33/+33
(cherry picked from commit 6140ca9f1d728475e332f9fa96ee62dda58687ea) Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2016-02-06Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 69c88a32aad2cafde197e98557868ad069795d60)
2016-02-06Revert "Typo: iff->if"Julien Nabet4-7/+7
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo (cherry picked from commit 2a65bf32ec270484dcea4d22d3c93552dc0c24dd)
2016-02-06Typo: iff->ifJulien Nabet4-7/+7
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3 (cherry picked from commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d)
2016-02-06new uno sidebar api tdf#91806Laurent Godard58-2076/+1281
the entry point is SfxBaseController::getSidebar() the Decks and panels are now per SidebarController and not global anymore ' macro example Sub testSidebarApi controller = thisComponent.currentcontroller frameIni = thisComponent.currentcontroller.frame sidebar = thisComponent.currentcontroller.getSidebar() sidebar.setVisible(true) frame = sidebar.getFrame() decks = sidebar.getdecks() c = decks.count h = decks.hasElements() e = decks.getElementNames() a = decks.hasByName("MyDeck") deck = decks.getByName("MyDeck") deck.activate(true) t = deck.getTitle() deck.setTitle("new deck title") deck.moveFirst() deck.moveLast() deck.moveUp() deck.moveDown() index = deck.getOrderIndex() panels = deck.getPanels() ep = panels.getElementnames() ap = panels.hasByName("aPanelName") panel = panels.getByName("aPanelName") panel.setTitle("new panel title") panel.collapse() panel.expand(true) ' expand and collapse other index = panel.getOrderIndex() panel.moveLast() panel.moveFirst() panel.moveDown() panel.moveUp() End Sub Change-Id: I7a4b953f2277dea483bb296ba6ead35de7205ace Reviewed-on: https://gerrit.libreoffice.org/15856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit a64999511ae654131d997eec9a3d78478cfc1c75)
2016-02-06Fix typosAndrea Gelmini2-2/+2
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce Reviewed-on: https://gerrit.libreoffice.org/16373 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 9ed033917b0bdaeb663395224a5e5b8b20a67169)
2016-02-06Fix typosAndrea Gelmini2-2/+2
Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit ae150c6a5424d021ce5eb46dc9573f12a4d05445) Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
2016-02-06Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe3-5/+4
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 09800956191c90035872cbc18cd304fee043c710) Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
2016-02-06Fix typosAndrea Gelmini1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 3fa7b0b70f8f21c65603aa2b7db53392fdbceec4) Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e
2016-02-06Fix typosAndrea Gelmini1-1/+1
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 814af9f1e59d1a76473b2c72cae4ba8afe1c52d4)
2016-02-06Fix typosAndrea Gelmini1-2/+2
Change-Id: I549635318f46718042e50c8f89ce3c620cade990 Reviewed-on: https://gerrit.libreoffice.org/16281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit ca9de688c2c263c51dca1cbbf2892e3b419f921e)
2016-02-06Fix typosAndrea Gelmini1-1/+1
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 01532b1ab8f34ac0a87c17efaa2e6c7e9ac29b3b)
2016-02-06Fix typosAndrea Gelmini1-1/+1
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 9b7e1bf43dcb25acabc15fb2bfb30e2a1dd249df)
2016-02-06Revert "std::list for Scheduler"Stephan Bergmann1-1/+1
This reverts commit 1289d3c42af66990a2c8e5a7a38e51b6cd51c7eb, plus follow-ups 762e90ffa0cd5f85dadd9bad93391d105e60e418 "vcl: loplugin:pointertobool" and 863e5685dda88efd0bee3177a08eedffd4730e33 "Fix funny line-ends," as it causes memory corruption, see valgrind "make CppunitTest_sw_ooxmlexport4" output: > Invalid write of size 1 > Scheduler::ImplInvoke(unsigned long) (/vcl/source/app/scheduler.cxx:40) > Scheduler::ProcessTaskScheduling(bool) (/vcl/source/app/scheduler.cxx:128) > Scheduler::CallbackTaskScheduling(bool) (/vcl/source/app/scheduler.cxx:112) > SalTimer::CallCallback(bool) (/vcl/inc/saltimer.hxx:53) > SvpSalInstance::CheckTimeout(bool) (/vcl/headless/svpinst.cxx:191) > SvpSalInstance::Yield(bool, bool) (/vcl/headless/svpinst.cxx:307) > ImplYield(bool, bool) (/vcl/source/app/svapp.cxx:353) > Application::Reschedule(bool) (/vcl/source/app/svapp.cxx:377) > framework::StatusIndicatorFactory::impl_reschedule(bool) (/framework/source/helper/statusindicatorfactory.cxx:528) > framework::StatusIndicatorFactory::end(com::sun::star::uno::Reference<com::sun::star::task::XStatusIndicator> const&) (/framework/source/helper/statusindicatorfactory.cxx:229) > framework::StatusIndicator::end() (/framework/source/helper/statusindicator.cxx:70) > non-virtual thunk to framework::StatusIndicator::end() (/framework/source/helper/statusindicator.cxx:57) > writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) (/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:531) > WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/writerfilter/source/filter/WriterFilter.cxx:191) > non-virtual thunk to WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/writerfilter/source/filter/WriterFilter.cxx:126) > SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) (/sfx2/source/doc/objstor.cxx:2271) > SfxObjectShell::DoLoad(SfxMedium*) (/sfx2/source/doc/objstor.cxx:767) > SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/sfx2/source/doc/sfxbasemodel.cxx:1859) > non-virtual thunk to SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/sfx2/source/doc/sfxbasemodel.cxx:1810) > (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (/sfx2/source/view/frmload.cxx:703) > non-virtual thunk to (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (/sfx2/source/view/frmload.cxx:615) > framework::LoadEnv::impl_loadContent() (/framework/source/loadenv/loadenv.cxx:1122) > framework::LoadEnv::startLoading() (/framework/source/loadenv/loadenv.cxx:383) > framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/loadenv/loadenv.cxx:164) > framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/desktop.cxx:566) > non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/desktop.cxx:552) > unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/unotest/source/cpp/macros_test.cxx:50) > SwModelTestBase::load(char const*, char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:580) > SwModelTestBase::executeImportExportImportTest(char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:219) > testTrackChangesDeletedParagraphMark::Import_Export_Import() (/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx:132) > CppUnit::TestCaller<testTrackChangesDeletedParagraphMark>::runTest() (/workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166) > CppUnit::TestCaseMethodFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32) > (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/test/source/vclbootstrapprotector.cxx:57) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (in /home/sbergman/lo/core/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.13.so.0.0.2) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (in /home/sbergman/lo/core/workdir/LinkTarget/Library/unobootstrapprotector.so) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (in /home/sbergman/lo/core/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.13.so.0.0.2) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (in /home/sbergman/lo/core/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.13.so.0.0.2) > CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (in /home/sbergman/lo/core/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.13.so.0.0.2) > CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77) > CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181) > CppUnit::TestCase::run(CppUnit::TestResult*) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91) > CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64) > CppUnit::TestComposite::run(CppUnit::TestResult*) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23) > CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64) > CppUnit::TestComposite::run(CppUnit::TestResult*) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23) > CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47) > CppUnit::TestResult::runTest(CppUnit::Test*) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148) > CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96) > Address 0x2c9ece48 is 40 bytes inside a block of size 104 free'd > operator delete(void*) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) > (anonymous namespace)::ImpTimedRefDev::~ImpTimedRefDev() (/drawinglayer/source/primitive2d/textlayoutdevice.cxx:84) > std::default_delete<(anonymous namespace)::ImpTimedRefDev>::operator()((anonymous namespace)::ImpTimedRefDev*) const (/usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/bits/unique_ptr.h:76) > std::unique_ptr<(anonymous namespace)::ImpTimedRefDev, std::default_delete<(anonymous namespace)::ImpTimedRefDev> >::reset((anonymous namespace)::ImpTimedRefDev*) (/usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/bits/unique_ptr.h:344) > comphelper::unique_disposing_ptr<(anonymous namespace)::ImpTimedRefDev>::reset((anonymous namespace)::ImpTimedRefDev*) (/include/comphelper/unique_disposing_ptr.hxx:41) > (anonymous namespace)::ImpTimedRefDev::Invoke() (/drawinglayer/source/primitive2d/textlayoutdevice.cxx:93) > Scheduler::ImplInvoke(unsigned long) (/vcl/source/app/scheduler.cxx:39) > Scheduler::ProcessTaskScheduling(bool) (/vcl/source/app/scheduler.cxx:128) > Scheduler::CallbackTaskScheduling(bool) (/vcl/source/app/scheduler.cxx:112) > SalTimer::CallCallback(bool) (/vcl/inc/saltimer.hxx:53) > SvpSalInstance::CheckTimeout(bool) (/vcl/headless/svpinst.cxx:191) > SvpSalInstance::Yield(bool, bool) (/vcl/headless/svpinst.cxx:307) > ImplYield(bool, bool) (/vcl/source/app/svapp.cxx:353) > Application::Reschedule(bool) (/vcl/source/app/svapp.cxx:377) > framework::StatusIndicatorFactory::impl_reschedule(bool) (/framework/source/helper/statusindicatorfactory.cxx:528) > framework::StatusIndicatorFactory::end(com::sun::star::uno::Reference<com::sun::star::task::XStatusIndicator> const&) (/framework/source/helper/statusindicatorfactory.cxx:229) > framework::StatusIndicator::end() (/framework/source/helper/statusindicator.cxx:70) > non-virtual thunk to framework::StatusIndicator::end() (/framework/source/helper/statusindicator.cxx:57) > writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) (/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:531) > WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/writerfilter/source/filter/WriterFilter.cxx:191) > non-virtual thunk to WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/writerfilter/source/filter/WriterFilter.cxx:126) > SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) (/sfx2/source/doc/objstor.cxx:2271) > SfxObjectShell::DoLoad(SfxMedium*) (/sfx2/source/doc/objstor.cxx:767) > SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/sfx2/source/doc/sfxbasemodel.cxx:1859) > non-virtual thunk to SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/sfx2/source/doc/sfxbasemodel.cxx:1810) > (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (/sfx2/source/view/frmload.cxx:703) > non-virtual thunk to (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (/sfx2/source/view/frmload.cxx:615) > framework::LoadEnv::impl_loadContent() (/framework/source/loadenv/loadenv.cxx:1122) > framework::LoadEnv::startLoading() (/framework/source/loadenv/loadenv.cxx:383) > framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/loadenv/loadenv.cxx:164) > framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/desktop.cxx:566) > non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/desktop.cxx:552) > unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/unotest/source/cpp/macros_test.cxx:50) > SwModelTestBase::load(char const*, char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:580) > SwModelTestBase::executeImportExportImportTest(char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:219) > testTrackChangesDeletedParagraphMark::Import_Export_Import() (/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx:132) > CppUnit::TestCaller<testTrackChangesDeletedParagraphMark>::runTest() (/workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166) > CppUnit::TestCaseMethodFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32) > (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/test/source/vclbootstrapprotector.cxx:57) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (in /home/sbergman/lo/core/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.13.so.0.0.2) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (in /home/sbergman/lo/core/workdir/LinkTarget/Library/unobootstrapprotector.so) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (in /home/sbergman/lo/core/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.13.so.0.0.2) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (in /home/sbergman/lo/core/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.13.so.0.0.2) > CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (in /home/sbergman/lo/core/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.13.so.0.0.2) > CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77) > CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181) > CppUnit::TestCase::run(CppUnit::TestResult*) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91) > CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) (/workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64) (cherry picked from commit 09c5a9d41e03b3137ce47b9f9419290525458337)
2016-02-06remove unnecessary check for null when calling deleteNoel Grandin3-13/+6
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763 (cherry picked from commit 4729774b244db7a175077ed0c70aa48be62bc60e)
2016-02-06cppcheck:unreadVariableNoel Grandin2-4/+3
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522 (cherry picked from commit dcf6abfcdf3f4b7aec5796c9f6c806889328135f)
2016-02-06cppcheck:redundantAssignmentNoel Grandin1-2/+2
(cherry picked from commit 4ea281a3ccb5bd21e1808d8cb127a91a1bb72691) Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2016-02-06std::list for SchedulerJuergen Funk1-1/+1
Re-factor the scheduler to use std::list Because - ImplSchedulerData - remove: mbInScheduler, mnUpdateTime, mnUpdateStack that is scheduler stuff - this struct is only a container for the scheduler-list - UpdateMinPeriod - the scheduler is the pure-virtual-class then the idle-class must override this method - ImplDeInitScheduler(bool All=true) - this patch 2e29a518b04250b5f9cc9d0d77da3df076834d60 remove all scheduler tasks and the scheduler, but after that, the scheduler is using, then crash. With this fix, only delete the scheduler-list, but not the scheduler The next steps - split the scheduler from the scheduler-list-handling the scheduler-list-handling need a static class - remove the scheduler from the timer-handling staff Change-Id: I8d4d4f27b2bc9684a48c2afafd0b3edd0716c71d Reviewed-on: https://gerrit.libreoffice.org/16148 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1289d3c42af66990a2c8e5a7a38e51b6cd51c7eb)
2016-02-06convert expressions like 'size() == 0' to 'empty()'Noel Grandin2-6/+6
(cherry picked from commit 776a3f14f2d987312b926ebc1ad09321a3a87f0d) Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2016-02-05Typo: emty->emptyJulien Nabet1-1/+1
Change-Id: I495ae28194da449ab1b31b2b5ec0d9e08fbcc291 (cherry picked from commit c27798b20097602739e3e81a5063109b8c66447d)
2016-02-05cppcheck: noExplicitConstructorCaolán McNamara8-16/+16
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92 (cherry picked from commit 8e22cd40ec9f7d97bde49dd4c8593fc5bfb52e29)
2016-02-05convert GETFOCUS constants to scoped enumNoel Grandin1-3/+3
Change-Id: I7c324bb6358be28c119592850eb7607479279f09 (cherry picked from commit 4c93c30c79ae885d488a8a04d383fe5308a1d520)
2016-02-05convert INVALIDATE constants to scoped enumNoel Grandin2-3/+3
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the IDL docs for XWindowPeer Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d (cherry picked from commit bb7ce3137dbe12d67f393b95a437b18e3a63f8e7)
2016-02-05convert TOTOP constants to scoped enumNoel Grandin2-2/+2
Change-Id: I85ba631ba298f1034dc5b6a04a5ff3d509c41bcb (cherry picked from commit c7efb51e31a4eea48ffed291e5c7fb907b1811e4)
2016-02-05convert SHOW constants to scoped enumNoel Grandin4-8/+8
(cherry picked from commit b419da0f53cf7f65b1d0c58351176ece23fbfe1f) Change-Id: I2712a0901049885502cade31f9757f712048bb33
2016-02-05loplugin:constantfunctionNoel Grandin1-10/+0
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448 (cherry picked from commit 24600dcf3118cb01d57c31518d36be870f73e79c)
2016-02-05convert SWIB constants to scoped enumNoel Grandin3-14/+13
Change-Id: If64368f22e748cc646a726cb962e60ad29a66df9 Reviewed-on: https://gerrit.libreoffice.org/15840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit cf991bf352d64021e872ab1f8d82cb0f3cea37f3)
2016-02-05convert MENUBAR_MODE constants to scoped enumNoel Grandin2-2/+2
Change-Id: Ie4cda46d02e82cca1710603cfb3af379c702d9d7 (cherry picked from commit 5b248f1348260f953686b20621255aece57358fe)
2016-02-05convert CVT constants to scoped enumNoel Grandin3-9/+10
Change-Id: I7703816b6a1df2bf24c06cdf9992f9982ae724e8 Reviewed-on: https://gerrit.libreoffice.org/15826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 431598b97b47b13c8b241f587b5eea21bf134893)
2016-01-19LOK: include ModifiedStatus in CALLBACK_STATE_CHANGEDMiklos Vajna1-1/+2
Change-Id: Ic44a9266a67bfad8b0490a8acb4a419af99ea42c (cherry picked from commit abbfbb4d35d6fa9edbb8f331a9d9503183eb0356)
2016-01-18fix a crash found in passingCaolán McNamara1-1/+3
save a spreadsheet with an embedded formula in it to xlsx and alt tab away before the save has completed Change-Id: I9df996d4cb459a2aa688d06a7d53465518bebf5c (cherry picked from commit 50c2d561981d99abad9978811655365ff9884c87) (cherry picked from commit 12bc593da98be68961a9ea7d31619a7718fd1d4b) Reviewed-on: https://gerrit.libreoffice.org/21578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 86a15daa99f57ddf5ddbdb2d67ed9d69e3bbbf37)
2016-01-14sfx2: Convert the exception to one that we actually announce.Jan Holesovsky1-1/+10
Otherwise saving to a non-existing http:// URL leads to a crash. Change-Id: Ia4b49e2872616545dcedb2fc5553cf5a20a1f97d
2015-12-21fix missing BaseURL when loading embedded objectsMichael Stahl1-0/+6
When the object is edited in the UI, the m_xClient is set to a SfxInPlaceClient and the DocumentBaseURL is retrieved from it. But if the object is not edited, it will be loaded during export via the API and without a m_xClient; in this case the DocumentBaseURL must have been set previously to be available during import. There appears to be no way to get the URL of the document via the API while it is being imported; SfxBaseModel's m_sURL is unfortunately only initialized from SfxObjectShell::FinishedLoading(). During ODF import, the SvXMLEmbeddedObjectHelper creates the embedded object, so let's make it pass in the parent's BaseURL. The "DefaultParentBaseURL" parameter already exists but was unused previously. (cherry picked from commit b0fc09daf1086423a9bd457d9a2c043e7ff41451) (cherry picked from commit 4118f8f4c20ae711b95ab3052656bde673aa8852) sw: loading embedded ODF objects requires unordf component (cherry picked from commit b3b7982f4690f4ac0f0e9680970ba544157c36dc) Change-Id: I3d1ed29b3a2c0e77ec606a1d09f7bc07e7860733 Reviewed-on: https://gerrit.libreoffice.org/20761 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit fe4c7f20c272cf7a984d0db79199fe74bd31fc86)
2015-12-21sfx2: fix valgrind warningMichael Stahl1-0/+3
==7727== Conditional jump or move depends on uninitialised value(s) ==7727== at 0x9121E24: SfxDockingWindow::Resize() (dockwin.cxx:451) ==7727== by 0x3CADFAC3: SmElementsDockingWindow::Resize() (ElementsDockingWindow.cxx:753) Change-Id: Ie6e8a61f6c295373e5ccad409e2557e7c2dd6c1a (cherry picked from commit 8831281942b0ffe3dbdcea6febcda97a2ab665b3) (cherry picked from commit 5d9a20b3ab3167242a41a6f5ea951d426677ec29) Reviewed-on: https://gerrit.libreoffice.org/20756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit a3eb2cfdb136ab2d20e21421f0400e2eeca4ff8f)
2015-12-18LOK: get feedback for all of the font/back color commandsMihai Varga1-2/+5
Change-Id: Id4aac707666420752b985bcfd03b5b9bb99f79f1
2015-12-13LOK: get state change feedback for more uno commandsMihai Varga1-5/+9
I've also ordered them alphabetically so we can read them easier. Change-Id: Ia332f1662a91de4a4068f0056a3d969fe978a744
2015-12-10Memory leakStephan Bergmann2-3/+3
(cherry picked from commit 5ac6e00274e732435b55c2908db9cea658fe549b) Conflicts: sfx2/source/dialog/backingwindow.cxx Change-Id: Ica40750d628946678019376d91db67ba3f9ed67e Reviewed-on: https://gerrit.libreoffice.org/20601 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 75f25d00848068c677fca450d35aa59af0422c60)
2015-12-10Missing deleteStephan Bergmann1-0/+1
Change-Id: I8ba75fcd2f98a49fe9d620af6b248f32911d7fe8 (cherry picked from commit de7018f755af0b2372c0e261f53d57de6cf77c38) Reviewed-on: https://gerrit.libreoffice.org/20464 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2ecbb6a54b08a20639de560e5fd77d9a487f74e3)
2015-12-06Resolves: tdf#95960 displaced field value in user-defined propertiesCaolán McNamara1-6/+9
Change-Id: Idc9e8fd0c35de48a2366dca3850bcc4e69ef997f (cherry picked from commit afc565bf26464a4999b45d8bc57545fa1ff534e5) (cherry picked from commit 46c5197feec5e64544433f2d6e22cf986408552a) Reviewed-on: https://gerrit.libreoffice.org/20368 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 69725ffe0d17811984c8d52073262b5e76ae7080)
2015-12-06tdf#94689 fix crash on new file, close file, open fileLászló Németh1-0/+1
partially cherry-picked from the commit 187445b2d2885ced92be37ffb11cd2a9bb11f8d6 Change-Id: I9e74fb41448c6be0b8daa6c0f8a0e207be0be6d6 Reviewed-on: https://gerrit.libreoffice.org/20250 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 6d101b6296962b444f535eeb2ff37580dc9bb60c)
2015-11-10tdf#89852 on Windows do not decode the filename for email subjectAndras Timar1-0/+4
... because MAPISendMail does not accept Unicode Change-Id: Id48a41d1cf25d1a991b0f83fd5daa1a65896e958 (cherry picked from commit 77ff51623eab0c5908c84400c6eb8448ddb1e9c8) Reviewed-on: https://gerrit.libreoffice.org/19830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit cf4b042c934913785ea8886b6a6b3871926c53a3)
2015-11-10tdf#92866 startcenter: Make the accellerators work again.Jan Holesovsky2-13/+5
I still have no idea what is the root cause here (why the accellerators do not work 'automagically') - I suspect it is because we don't have a shell there, and instead only a vcl::Window, or something like that :-) Either way, when we handle the accellerators already in PreNotify(), it works as expected, so let's live with that for the time being. (cherry picked from commit 51c14b1c262bced0cb61c943caad044be9e95c15) Conflicts: sfx2/source/dialog/backingwindow.hxx Change-Id: Id050fd8f5fff38914821cb64eaa3ae7281fc6d50
2015-11-03tdf#85767: Make also sidebar toolbox item order RTL-sensitiveKatarina Behrens1-2/+28
do more-less the same as 2fd93f19cf6c1ce808214c does for main app toolbars Change-Id: If271bbb049915f4201fbce2ea587b753940a8de7 Reviewed-on: https://gerrit.libreoffice.org/19451 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 07f75f6e645eca4825541f57e9d5e9479a17c559) Reviewed-on: https://gerrit.libreoffice.org/19728 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5a5963b2f1b108db4f0089f41db74b673ba038af)
2015-10-29LOK: font/back color callback - use sal_Int32 instead of longMihai Varga1-1/+1
Change-Id: I2e2ebc5a12794e9641a6195f07fa4b2d1a7369a9
2015-10-29LOK: font/back color feedbackMihai Varga1-0/+7
This is used to know the current font/back color Change-Id: Ic524fcb5c26e1c15ec9c50b2879465152ac8ee34
2015-10-21tdf#95095: Rename "AvoidRecentDocs" to "PickListEntry" for consistency.Jan Holesovsky2-3/+3
It turns out that Base already has a similar property called "PickListEntry". Let's make it consistent then, and rename "AvoidRecentDocs", so that it works in all the apps the same way. So instead of setting "AvoidRecentDocs" to true, set "PickListEntry" to false. Change-Id: Idf0dd8e8892218f387944f0ad43b292c4b052be6