summaryrefslogtreecommitdiff
path: root/sfx2/source/sidebar
AgeCommit message (Collapse)AuthorFilesLines
2014-11-05fdo#67627 fdo#85791 Allow to show/hide sidebar decks with the same commandSamuel Mehrbrodt5-3/+35
This also reintroduces the code to switch the decks asynchronously (removed unintentionally before) Change-Id: I825b4d7c5777097e9d3b3d82adbe1f646510dc9d
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin1-4/+4
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin1-1/+1
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-29coverity#1028106 Dereference before null checkCaolán McNamara1-16/+0
Change-Id: I77a910542cf1b7889f69a1d3b7989779d9ecc7e8
2014-10-24loplugin: cstylecastNoel Grandin1-1/+1
Change-Id: Ia0f5f0d0efbe4693aba347bff32cd694117251fe
2014-10-17Revert "fdo#67627 Clicking on icons of the sidebar should both open and ↵Samuel Mehrbrodt1-7/+0
close Decks" This caused a regression, see fdo#84351 This reverts commit 04e96b6d6eb55b9ff2a6ec9c4ce52260e33df121.
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann2-5/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin1-2/+2
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-09-23fdo#82577: Handle WindowNoel Grandin31-86/+86
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22remove unused fields pName and pMethodName in SfxSlot classNoel Grandin1-3/+2
Change-Id: Icca5a0dee296fae1abeb78ea8ffa2f9e934bb111
2014-09-22fdo#84086 Fix assorted use-after-free bugsMatthew J. Francis1-6/+6
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65 Reviewed-on: https://gerrit.libreoffice.org/11553 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-18fdo#82577: Handle FontNoel Grandin1-2/+2
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann1-1/+1
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-10vcl: sal_Bool -> boolStephan Bergmann1-1/+1
Change-Id: Iff4da6d6281eb9194db348ebc10fbe7718538401
2014-09-06Related fdo#82088: removing aliases in headersStefan Weiberg22-66/+59
Change-Id: Id3496d1720630dd7a873edd04b664fc279c1c25e Reviewed-on: https://gerrit.libreoffice.org/11294 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-03Related fdo#82088: removing another bunch of aliasStefan Weiberg13-67/+64
Change-Id: I6e2ab6d20723803aedb530b4d25aa79ec0edbb8f Reviewed-on: https://gerrit.libreoffice.org/11260 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-28Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann1-0/+1
Change-Id: I786e07caf28b2f5f898b50fc2a46247d821248cf
2014-08-28callcatcher: update unused codeCaolán McNamara2-27/+0
Change-Id: I6cb74836f98d7507359f39e1fd03a1462b2e0c31
2014-08-27callcatcher: update unused codeCaolán McNamara2-19/+0
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-24fdo#73151 Make better use of the sidebarSamuel Mehrbrodt1-3/+1
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery) Changes: * Show the sidebar by default in Writer & Impress * Remove the Gallery floating window (Gallery now always opens in the sidebar) * Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer (since they have an icon in the sidebar and the sidebar is shown by default now) * When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151 Change-Id: I3a0461d1472711da7121801000af294b432fccb1 Reviewed-on: https://gerrit.libreoffice.org/11077 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-24Sidebar: Ensure Deck is open, if we choose an element from the Deck popup menu.Thomas Arnhold1-0/+3
Otherwise the Deck will be changed, but not shown... Change-Id: I4be7756542a8c21a616e7615ef40535e7310b90c
2014-08-24fdo#67627 Clicking on icons of the sidebar should both open and close DecksThomas Arnhold1-0/+7
Change-Id: I921a8a0b749df62c50f0ae8cb2de85f6cb459784
2014-08-24Sidebar: Use proper default value for DeckThomas Arnhold1-2/+2
gsDefaultDeckId is "PropertyDeck". Deck "default" does not exist and triggers a fallback, which is the first Deck in the list, which is "PropertyDeck", too. Change-Id: If2daa53d002c6547cc5f6fbed1408719c10b149d
2014-08-24Sidebar: Remove hightlight from TabBar after Deck closeThomas Arnhold3-0/+17
After clicking on "Close Sidebar Deck" the highlighted icon will now lose its highlight. Change-Id: Iee947641343d46c84af7afb93cd52101e39149f7
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist2-4/+3
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-07-01Related: fdo#80633 cache optimal sizeCaolán McNamara1-2/+2
Change-Id: Ic2c3aefebd3061d294f339c6d262a3c3e381fbe4
2014-06-27remove SFX_APP() macro that was a mer wrapper for SfxGetApp()Norbert Thiebaud1-1/+1
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27Related: fdo#65634 make sidebar react to resizes when floatingCaolán McNamara1-29/+41
the parent isn't a SfxSplitWindow in this case, but it should still react to the resize Change-Id: Ia298d45b33fc272d6169df12cf2c58a881255163
2014-06-27Resolves: fdo#65634 improve wheel-scrolling sidebar panelsCaolán McNamara2-36/+3
Change-Id: I213d85a1e2bbd2377f6f0326433ddd57dc346721
2014-06-18coverity#1028261 Uncaught exceptionCaolán McNamara1-7/+3
Change-Id: I7dd08c182657084ffa635e1960f4d0def6d7a6bb
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin6-30/+6
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-10-Werror,-Wtautological-undefined-compareStephan Bergmann1-4/+1
Change-Id: I2e05bcf91c534d2aed6e296fe03d367c4c1b7212
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin6-25/+5
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-05-29remove unnecessary NULL parameter passed to UNO ExceptionNoel Grandin1-2/+2
.. now that we have a default value for that parameter Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-25Resolves: fdo#79161 sidebar crash on deactivatingCaolán McNamara1-1/+4
Change-Id: I0d559bd8c16243fdc398f6bff0aa915a83a29dff
2014-05-22cppcheck: Function parameter 'aFocusLocation' should be passed by referenceThomas Arnhold2-11/+11
Change-Id: I2d2b9ae3ea81bd725be2af460f6c57bd0897883c
2014-05-20Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18Julien Nabet1-5/+5
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20enhance pass-by-ref plugin to detect large argumentsNoel Grandin2-2/+2
Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-07The opaque PostUserEvent IDs are actually pointersStephan Bergmann1-1/+3
...so declare them as such. This avoids the recurring mistake of storing such IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to potentially not remove the event, it thus firing "too late" and probably causing a crash. While at it, consolidate the trivially unnecessary overloads of both Application::PostUserEvent and Window::PostUserEvent. And in each of them, it looks like deleting the mpLink member was missing from the failure branch. Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-06remove uncompiled source filesThomas Arnhold7-565/+0
how to find possible candidates: find . -name *.cxx | grep -v compilerplugins > cxx.list for i in `cat cxx.list`; do basename $i .cxx; done > cxx.base.list for i in `cat cxx.base.list | sort -u`; do echo $(git grep -w $i -- '*.mk' | wc -l) $i; done > cxx.count Change-Id: I15c6cc7195e58d79967388850a0c90b915b001b7
2014-05-06Move a few more headers that are included only in sfx2 to sfx2Tor Lillqvist2-2/+2
Change-Id: I8bd81a45f5ef1b76fce1563b06e05a4eefcff0ec
2014-04-10Clean up function declarations and some unused functionsStephan Bergmann2-11/+0
Change-Id: I9d6e9df0b686c61597aaa0e194ab321445671a20
2014-04-07sfx2: sal_Bool->boolNoel Grandin2-3/+3
Change-Id: I48ae51781f64e60deb0c03352087100729c8c3cd
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann15-57/+57
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-24callcatcher: update unused codeCaolán McNamara4-47/+1
Change-Id: I48990c044e4583e835f3e995527ba423e8c459fb
2014-03-14sfx2: sal_Bool->boolNoel Grandin1-1/+1
Change-Id: I626371bac4fbd9c6a2cdc5a57a3022f8b6ac55b2
2014-03-13Related: #i124392# fill in SidebarDockingWindow::DoDisposeAndre Fischer1-0/+6
(cherry picked from commit 952f581cb77f52e9aaa974496dc8d86b335cb424) Conflicts: sfx2/inc/sfx2/sidebar/SidebarChildWindow.hxx sfx2/source/dialog/templdlg.cxx sfx2/source/inc/templdgi.hxx Change-Id: Idf06437dfc45e02d9e2303df84d52ba0837de108
2014-03-12coverity#1027775 Dereference null return valueCaolán McNamara1-3/+9
Change-Id: I27dc7645969e6311bc6c0a3d593924ea41dfdf5d
2014-03-03remove unused code in sfx2::sidebarNoel Grandin11-65/+8
sfx2::sidebar::ContextList::IsEmpty() sfx2::sidebar::Deck::PrintWindowTree(std::vector<sfx2::sidebar::Panel*> > const&) sfx2::sidebar::EnumContext::EvaluateMatch(sfx2::sidebar::EnumContext const&) const sfx2::sidebar::EnumContext::GetContext() const sfx2::sidebar::Paint::Set(sfx2::sidebar::Paint const&) sfx2::sidebar::Panel::PrintWindowTree() sfx2::sidebar::SidebarDockingWindow::GetChildWindow() Change-Id: I285567320677a831b2b786f4f73b000eed39987b
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann8-35/+35
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 11:41:34 +0000