Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I53f9965609c04fd2f0b955fd04de8fc953917344
|
|
Change-Id: Ibff26c023655d36f0fa71ead399a6116c2988607
|
|
and clean up the duplication of constants between filter/ and
comphelper/ in the process
Change-Id: I0d1525b559c63a3d39deae51accff5dcdbb0aa82
Reviewed-on: https://gerrit.libreoffice.org/17446
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: Iee6d0493172b7b776ac8c5b05f675cd28091f8b4
|
|
Change-Id: Ic9eebca9d8fe3e9173b1873bdc7800e5161f9999
|
|
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
|
|
They need to be wrapped in ScopedVclPtr in order to be disposed properly.
Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
|
|
Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133
Conflicts:
sw/qa/tiledrendering/tiledrendering.cxx
|
|
and fix issues in iterating through o3tl::enumarray
Change-Id: Ia59ef9be44d8c92c2e406fa71aa92269578e26e3
|
|
Change-Id: I59526bea5104def80e98902e4cf16e7bcfaa250c
|
|
Change-Id: Iefd4d375a0dfb36732233852f906c6b85dccc2a5
|
|
Change-Id: I310099e8e12fb6440e98fbca97af512a4f872ac0
|
|
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
|
|
of which there are several.
There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
numeric values to the underlying code, but perhaps further fixing is necessary?
Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
|
|
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
|
|
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
Change-Id: Ie5e9e21f4c592c58094afc954f1de54512719fd5
|
|
sfx2::DocumentInserter::CreateMediumList() creates a SfxFilterMatcher
that should match Writer filters only, but actually Calc filters may be
returned; check that the document service matches.
(regression from 3da8f3680556e0163f660a0a159930337c8c32ff)
Change-Id: I6208d38c1110355105aa5d1ffa1b57142193a4d7
|
|
Change-Id: Ica30df49caf79117bbce36ec461ec5ef37bef20c
|
|
Change-Id: Ia7f59631da21b81f0c7e450c885b759cdce5a140
|
|
Change-Id: I48ae51781f64e60deb0c03352087100729c8c3cd
|
|
Change-Id: I8768ebc523b03a469f8b9bb49e015ca7d140fc96
|
|
Change-Id: Ifd9bc57fd0c6d32796013cb9fca9c935a2f71e54
|
|
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
|
|
Change-Id: I4a09bffccc0049d81ea3113e79184f64b026a4ba
|
|
Change-Id: I58b6c311e9f13e433468863e639467428e5b268e
|
|
Change-Id: I5f90d0acff506955d1cc5a44944311012f3b04b9
|
|
Change-Id: Ibfcd2954b20def05d2a7db36f5ccc0b570305441
|
|
Convert code like
if( !aStr.isEmpty() && aStr[0] == 'x' )
to
if( aStr.startsWith("x") )
Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
|
|
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks
configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and
SvxBrushItem::GetGraphicObject. Checking in additional places will probably be
necessary to block /all/ unwanted communication. Also, some places marked
/*TODO?*/ currently pass in an empty referer (which is always considered
trusted) and will probably need to be adapted.
Ideally, Referer URIs would never be empty (and consistently use something like
<private:user> for cases where access is explicitly initiated by the user and
should never be blocked), but that's a very daunting task, so start small by
identifying the places that potentially need blocking and adding appropriate
Referer URIs there. Also, Referer information should always be computed as
freshly as possible from the context in which an access attempt is made, but,
again, always carrying the information from the context all the way to the
relevant functions is a very daunting task, so for now store the information
upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...).
The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already
used to track macro execution, and there is one place in
SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked
by the user) is done that needs the current document's URI as Referer to check
execution of macro URIs but needs an empty (or <private:user>, see above)
Referer to not block non-macro URIs. Special code has been added there to
handle that.
Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
|
|
...so it will be able to use SvtSecurityOptions internally.
Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
|
|
Change-Id: I63de4bc034020d19abd20f301194482da9a604f4
|
|
Change-Id: Ieafc413136a9b4b907de034914d918212e4c16e3
|
|
Change-Id: I7429af4dc64ec6c69b6b9297779e51614362cf52
|
|
Change-Id: I984ca2833d65ce37967058b1cb5800c61defe88c
|
|
the only method it declares no longer exists, to inline its
includes into the places using it.
Change-Id: I1fed09835f221a34722dbdd3f33a079a373d8b36
|
|
Change-Id: I4a03dfba5b1779a061d01026640f2f6bdc154c0b
|
|
not like there never was a sfx1 anyway... perhaps we should rename the
whole module...
Change-Id: I50c7302f84f15a1d778eca19507694a3bd070b22
|
|
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*
Change-Id: I9a7cce0d3abef42c9d9d0ad56609d94d504854cb
Reviewed-on: https://gerrit.libreoffice.org/4128
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
First SfxFilterMatcher_Impl::InitForIterating() will set pList to either
the global filter array matcher pFilterArr, or to a new SfxFilterList_Impl.
This new SfxFilterList_Impl should be deleted in the destructor.
Second getSfxFilterMatcher_Impl() keeps a cache of SfxFilterMatcher_Impls.
If a SfxFilterMatcher_Impl for a given name doesn't exist yet a new one
will be created. But the cache stored objects by service name (aName), but
looked object up by factory name (rName). So it always created a new
SfxFilterMatcher_Impl instead of using the one from the aImplArr cache.
Change-Id: I7840aaddc861f609fbe14d5b6c0ea20d997f690f
Reviewed-on: https://gerrit.libreoffice.org/3989
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
|
|
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
|
|
But this occasionally crashes.
Change-Id: I0a18d0e210639b43b89b966a54de541b9a43e329
|
|
Change-Id: I647b9e4de54fdcfadcf17ac7e161b245f3dea546
|
|
Change-Id: I279441c1e1a271c76a2fec92711765134da90cac
|
|
Change-Id: I28fd84b89a8d443e502d2c0e76f38cf006a57d4a
|
|
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
|
|
FDO:60724
Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|