summaryrefslogtreecommitdiff
path: root/sfx2/source/bastyp/fltfnc.cxx
AgeCommit message (Collapse)AuthorFilesLines
2015-09-21cppcheck: noExplicitConstructorCaolán McNamara1-7/+7
Change-Id: I53f9965609c04fd2f0b955fd04de8fc953917344
2015-08-11loplugin: defaultparamsNoel Grandin1-1/+1
Change-Id: Ibff26c023655d36f0fa71ead399a6116c2988607
2015-07-31fix crash in writer, thanks to my new assert in typed_flags_setNoel Grandin1-0/+1
and clean up the duplication of constants between filter/ and comphelper/ in the process Change-Id: I0d1525b559c63a3d39deae51accff5dcdbb0aa82 Reviewed-on: https://gerrit.libreoffice.org/17446 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-05-29tdf#91702 - fix stack-based MessBox allocation.Michael Meeks1-2/+2
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-10Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann1-2/+2
Change-Id: Iee6d0493172b7b776ac8c5b05f675cd28091f8b4
2015-04-30Use typed MaybeFile LinkStephan Bergmann1-3/+3
Change-Id: Ic9eebca9d8fe3e9173b1873bdc7800e5161f9999
2015-04-10Automated conversion of VclPtr construction to use Instance template.Michael Meeks1-1/+1
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
2015-04-10vclwidget: fixup locally allocated vcl::Window objectsNoel Grandin1-1/+1
They need to be wrapped in ScopedVclPtr in order to be disposed properly. Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
2015-04-09vclwidgets: wrap all vcl::Window subclasses allocated on stack in VclPtrNoel Grandin1-2/+2
Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133 Conflicts: sw/qa/tiledrendering/tiledrendering.cxx
2015-04-07convert SvtModuleOptions::EFactory to enum classNoel Grandin1-2/+2
and fix issues in iterating through o3tl::enumarray Change-Id: Ia59ef9be44d8c92c2e406fa71aa92269578e26e3
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann1-1/+1
Change-Id: I59526bea5104def80e98902e4cf16e7bcfaa250c
2015-03-25Typo: formated->formattedJulien Nabet1-1/+1
Change-Id: Iefd4d375a0dfb36732233852f906c6b85dccc2a5
2015-03-19WaE: -Werror=maybe-uninitializedCaolán McNamara1-1/+1
Change-Id: I310099e8e12fb6440e98fbca97af512a4f872ac0
2015-03-19convert SFX_FILTER_ constants to enum classNoel Grandin1-14/+16
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
2015-03-18create new 'enum class' SotClipboardFormatId to unify typesNoel Grandin1-4/+4
of which there are several. There are some issues here I am unsure of - the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids Perhaps I should change them to use the common values and create new enum values where necessary? - the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff numeric values to the underlying code, but perhaps further fixing is necessary? Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2014-08-01typo: more then -> more thanTakeshi Abe1-1/+1
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-06-24new compilerplugin returnbyrefNoel Grandin1-3/+3
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-13loplugin:staticcallStephan Bergmann1-2/+2
Change-Id: Ie5e9e21f4c592c58094afc954f1de54512719fd5
2014-05-19fdo#78742: SfxFilterMatcher: respect requested document service if setMichael Stahl1-1/+3
sfx2::DocumentInserter::CreateMediumList() creates a SfxFilterMatcher that should match Writer filters only, but actually Calc filters may be returned; check that the document service matches. (regression from 3da8f3680556e0163f660a0a159930337c8c32ff) Change-Id: I6208d38c1110355105aa5d1ffa1b57142193a4d7
2014-05-19valgrind: memory leakCaolán McNamara1-4/+20
Change-Id: Ica30df49caf79117bbce36ec461ec5ef37bef20c
2014-05-14sfx2: remove SAL_INFO's that only mark function entryNoel Grandin1-1/+0
Change-Id: Ia7f59631da21b81f0c7e450c885b759cdce5a140
2014-04-07sfx2: sal_Bool->boolNoel Grandin1-5/+5
Change-Id: I48ae51781f64e60deb0c03352087100729c8c3cd
2014-03-27sfx2: why is this debug stuff WNT-only?Michael Stahl1-1/+1
Change-Id: I8768ebc523b03a469f8b9bb49e015ca7d140fc96
2014-03-14sfx2: sal_Bool->boolNoel Grandin1-10/+10
Change-Id: Ifd9bc57fd0c6d32796013cb9fca9c935a2f71e54
2014-02-23Remove unneccessary commentsAlexander Wilms1-13/+13
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-06Typo: seam(s) -> seem(s)Julien Nabet1-1/+1
Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
2014-01-28bool improvementsStephan Bergmann1-3/+3
Change-Id: I4a09bffccc0049d81ea3113e79184f64b026a4ba
2014-01-23Bin useless as96863, mb93783, mv76033 verbiage from SAL_INFO outputTor Lillqvist1-1/+1
Change-Id: I58b6c311e9f13e433468863e639467428e5b268e
2014-01-22bool improvementsStephan Bergmann1-7/+4
Change-Id: I5f90d0acff506955d1cc5a44944311012f3b04b9
2014-01-15remove sfx2/appuno.hxxMatúš Kukan1-1/+0
Change-Id: Ibfcd2954b20def05d2a7db36f5ccc0b570305441
2013-12-12simplify - use OUString::startsWith where possibleNoel Grandin1-1/+1
Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann1-0/+6
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14Move MediaDescriptor from comphelper to unotoolsStephan Bergmann1-8/+8
...so it will be able to use SvtSecurityOptions internally. Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-11sfx2: include <> for external includesNorbert Thiebaud1-2/+2
Change-Id: I63de4bc034020d19abd20f301194482da9a604f4
2013-11-08remove unnecessary use of OUString constructor in SFX2 moduleNoel Grandin1-6/+6
Change-Id: Ieafc413136a9b4b907de034914d918212e4c16e3
2013-09-18sal_Bool -> boolJulien Nabet1-2/+2
Change-Id: I7429af4dc64ec6c69b6b9297779e51614362cf52
2013-08-29convert sfx2/source/bastyp/* from String to OUStringNoel Grandin1-22/+22
Change-Id: I984ca2833d65ce37967058b1cb5800c61defe88c
2013-08-29remove unnecessary header sfx2/source/inc/fltfnc.hxxNoel Grandin1-1/+0
the only method it declares no longer exists, to inline its includes into the places using it. Change-Id: I1fed09835f221a34722dbdd3f33a079a373d8b36
2013-08-29convert include/sfx2/fcontnr.hxx from String to OUStringNoel Grandin1-15/+15
Change-Id: I4a03dfba5b1779a061d01026640f2f6bdc154c0b
2013-07-08rename sfx2 log area to sfxMichael Stahl1-4/+4
not like there never was a sfx1 anyway... perhaps we should rename the whole module... Change-Id: I50c7302f84f15a1d778eca19507694a3bd070b22
2013-06-10fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFORadu Ioan1-5/+4
- replaced RTL_CONTEXT_ with SAL_INFO - replace OSL_* with SAL_* Change-Id: I9a7cce0d3abef42c9d9d0ad56609d94d504854cb Reviewed-on: https://gerrit.libreoffice.org/4128 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-05-21Fix two SfxFilterMatcher_Impl memory leaks.Mark Wielaard1-1/+9
First SfxFilterMatcher_Impl::InitForIterating() will set pList to either the global filter array matcher pFilterArr, or to a new SfxFilterList_Impl. This new SfxFilterList_Impl should be deleted in the destructor. Second getSfxFilterMatcher_Impl() keeps a cache of SfxFilterMatcher_Impls. If a SfxFilterMatcher_Impl for a given name doesn't exist yet a new one will be created. But the cache stored objects by service name (aName), but looked object up by factory name (rName). So it always created a new SfxFilterMatcher_Impl instead of using the one from the aImplArr cache. Change-Id: I7840aaddc861f609fbe14d5b6c0ea20d997f690f Reviewed-on: https://gerrit.libreoffice.org/3989 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist1-3/+3
2013-04-15fdo#60724 informations -> informationThomas Arnhold1-1/+1
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-13Manage to use orcus to import ods, xlsx, and csv.Kohei Yoshida1-1/+1
But this occasionally crashes. Change-Id: I0a18d0e210639b43b89b966a54de541b9a43e329
2013-04-09String cleanup inside SfxFilter.Kohei Yoshida1-2/+2
Change-Id: I647b9e4de54fdcfadcf17ac7e161b245f3dea546
2013-04-09com::sun::star cleanup.Kohei Yoshida1-42/+44
Change-Id: I279441c1e1a271c76a2fec92711765134da90cac
2013-04-09Make the member mutable to avoid ugly casting.Kohei Yoshida1-6/+6
Change-Id: I28fd84b89a8d443e502d2c0e76f38cf006a57d4a
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák1-49/+49
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-02Typo fix: informations -> information and a few other adjacent typos.Gregg King1-2/+2
FDO:60724 Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b Reviewed-on: https://gerrit.libreoffice.org/2479 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>