summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)AuthorFilesLines
2016-12-21ODR violation (base class must be the same across compilation units)Stephan Bergmann19-155/+117
Change-Id: Ieb98d8984c8d39fb72afbceccca29a2d402dc41e
2016-12-13Revert "verify SolarMutex when ref-counting VclPtr" seriesNoel Grandin4-4/+0
This reverts the following commits: commit 722f4e1d86710f2facd37d7e040df9e1fd585e26 tdf#104573 - Assertion failed: SolarMutex not locked commit f04ec99f5e6a543b8191ced61db4710c3c0de356 tdf#104573 - Assertion failed: SolarMutex not locked commit 71b1e3ff6374c23e65200d3bcafca387d29af04f tdf#104573 - Assertion failed: SolarMutex not locked when trying commit e794ce1eef6730e5a46d5fb0aa6db2895ede85e7 verify that we hold the SolarMutex when ref-counting VclPtr IRC discussion: <noelgrandin> sberg, maybe I should revert this whole "VclPtr assert" series, I don't have mental bandwidth to sort this out properly now <sberg> noelgrandin, what I fear is that you'll end up adding lots of SolarMutex locks to small places, where the proper fix would be to add it further out; and once such a dreaded recursive SolarMutex lock is in place (but needlessly so, once the proper fix is done), it's hard to clean that up again <noelgrandin> sberg, yeah, in that case I'll just remove all of this, leave it for another day Change-Id: Ie4f84b72b79a1b7e80164b5c7693af398c2c569a Reviewed-on: https://gerrit.libreoffice.org/31946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in avmedia..canvasNoel Grandin1-9/+9
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
2016-12-12OSL_TRACE->SAL in sd..sdextNoel Grandin7-41/+7
Change-Id: I6b224fa890dc96aada7140af27078da5e25c3ff8 Reviewed-on: https://gerrit.libreoffice.org/31898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08verify that we hold the SolarMutex when ref-counting VclPtrNoel Grandin4-0/+4
Change-Id: If0c5a8c99f0f853c9ecad0f1a4a7299d69805b34 Reviewed-on: https://gerrit.libreoffice.org/31755 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05loplugin:unnecessaryoverride (dtors) in sdextStephan Bergmann7-54/+2
Change-Id: I02dd087722aa7df299ca09ba55bb32d5402319fc
2016-11-23presenter console: fix STL assert when exiting slide showMichael Stahl1-1/+5
AtkListener::handleChildRemoved() calls removeAccessibleEventListener(), apparently without the listener being registered, so the remove() returns end(), which isn't valid for erase(). (probably happens since e4e208fa2b0930be5a7cbbe2fab2ff2fe2c4a1ff) Change-Id: Ia0de1bafe214f5a46f250d6573d8c4b408c9cf26
2016-11-09spelling mutext->mutexNoel Grandin1-1/+1
Change-Id: If844c07d0d50d1bb9b0a1877c0fde4a198bcf781
2016-11-07loplugin:unnecessaryvirtual in sd..sdextNoel Grandin2-4/+3
Change-Id: Id0bc82210fadc138b55d1abe4e06b1d2ed564df3 Reviewed-on: https://gerrit.libreoffice.org/30659 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04loplugin:unusedmethodsNoel Grandin1-8/+0
Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e Reviewed-on: https://gerrit.libreoffice.org/30524 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02loplugin:singlevalfieldsNoel Grandin2-12/+1
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76 Reviewed-on: https://gerrit.libreoffice.org/30476 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke1-1/+1
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01loplugin:oncevar in sd..svgioNoel Grandin1-17/+8
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c Reviewed-on: https://gerrit.libreoffice.org/30459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31Make stable sort more stable :)Mike Kaganski1-8/+20
Account for negative widths/heights; only apply text fudge factor to text elements. This prevents debug asserts that "less" comparison is invalid. Change-Id: Ifb46bb873bfc80fc8c07af4923073d2042d30b3a Reviewed-on: https://gerrit.libreoffice.org/30391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-31Omit comparator which is the same as default std::less<key_type>Takeshi Abe4-19/+5
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da Reviewed-on: https://gerrit.libreoffice.org/30369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-27loplugin:expandablemethods in sdextNoel Grandin14-126/+50
Change-Id: I7d375d6eafdd450ac165539f8f7dd3d02826ac5b Reviewed-on: https://gerrit.libreoffice.org/30323 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20loplugin:expandablemethodds in scaddins..sdextNoel Grandin1-6/+1
Change-Id: Ife021e368efaafe9097750b4ca1a5472e94352a9 Reviewed-on: https://gerrit.libreoffice.org/30054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke1-1/+1
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke1-1/+1
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-16clang-cl loplugin: sdextStephan Bergmann2-4/+4
Change-Id: I9f5e73b6f561ccb635217227787c6e8a574bdc97 Reviewed-on: https://gerrit.libreoffice.org/29854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-13xmlsecurity: add initial PDFSignatureHelperMiklos Vajna1-1/+1
This splits most of the PDF signature code out of the pdfverify executable, and puts it into the xmlsecurity library instead. The PDFSignatureHelper now attempts to verify PDF signatures, and code in sdext / sfx2 also calls it (even if PDF is not a ZIP-based format). Change-Id: I7b8b3ac9c976e4ea4f3796b1cda07c8a2c97bd02 Reviewed-on: https://gerrit.libreoffice.org/29751 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-06CPPUNIT_ASSERT[_DOUBLES]_EQUALStephan Bergmann1-6/+5
Change-Id: I417cea926abcc511e74a090ee90a851c138ac0c0
2016-10-01Fix typosAndrea Gelmini1-1/+1
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9 Reviewed-on: https://gerrit.libreoffice.org/29436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin5-51/+0
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann42-79/+79
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-10loplugin:constantparam in sdNoel Grandin5-15/+7
Change-Id: I2bc989802c12b379a1ba4202f54ecfef1f339c8c Reviewed-on: https://gerrit.libreoffice.org/28774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-30Break test::setUpVcl into a test-setupvcl library of its ownStephan Bergmann1-1/+0
...so it can be gb_CppunitTest_use_library_objects-included in upcoming <https://gerrit.libreoffice.org/#/c/28322/> "tdf#99402: fix Metafile Font handling". Executable_pdf2xml.mk linked against test since b0da8f00a0d41f2b17639fcee4ed4956421e55c5 "Make pdf2xml usable at least from within buildenv again", but that seems unnecessary and would now cause problems when linking the pdf2xml executable on Linux, as the linker for whatever reason wouldn't find the libtest-setupvcl.so referenced from libtest.so, even though the latter has a proper DT_RPATH. Change-Id: Iba5d80266520ce1f5dafedffa520d18e853f7ec5 Reviewed-on: https://gerrit.libreoffice.org/28473 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-25loplugin:staticaccess: Extend loplugin:staticcall to cover all access...Stephan Bergmann2-4/+4
to static members (data, in addition to function) via class member access syntax. Also covers the (somewhat obscure) access to enumerator members. Change-Id: Iec54b8df2fdb423c0caf21a0dd0f9fe8fdf33897
2016-08-18coverity#1371125 Copy-paste errorCaolán McNamara1-2/+5
this went wrong with commit 9b9e5cfd2fa629b2e1dc4a193e48a4a4e8d34126 Date: Mon Jun 20 17:40:13 2016 +0300 tdf#99589 - tolower / toupper - dangerous to Turks ... restore the logic to the original logic, but with the new api Change-Id: I445064b19eeefabbd25849bae9ca569710cdfac5
2016-08-18cppcheck: nullPointerRedundantCheckCaolán McNamara1-2/+1
Change-Id: I9d6c38ad3104369c7661bc8a8561807598aecfcb
2016-08-02loplugin:countusersofdefaultparams in sdNoel Grandin9-11/+11
Change-Id: I848d9b555a26e9d343efdfaaaec44a2c7d8be5b5 Reviewed-on: https://gerrit.libreoffice.org/27765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-29Resolves: tdf#84121 wrong password passed to xpdfimportCaolán McNamara1-7/+0
regression from... commit eb276d11a652601f743d69ada7a38016bd97d73e Author: Fridrich Štrba <fridrich.strba@bluewin.ch> Date: Mon Jul 8 14:01:17 2013 +0200 fdo#38878: Upgrading internal xpdf -> poppler before this the hashed _OOO_pdfi_Credentials_ was used in the removed OOoImportSecurityhandler::authorize but after this the hashed password continued to be passed through stdin, while the unhashed password was the required data. Change-Id: Iadc8a372abcfab514f724dd95f05776e5153d007
2016-07-27improve passstuffbyref return analysisNoel Grandin9-12/+12
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann7-10/+10
Change-Id: I3774f16c09b89fc6888bff3a388c290c32bb8a14
2016-06-30loplugin:unusedfieldsNoel Grandin1-7/+0
Change-Id: If06fffa8db050df0f9c1c7da6163575bf522382e Reviewed-on: https://gerrit.libreoffice.org/26754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28loplugin:singlevalfields in variousNoel Grandin2-4/+2
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-27loplugin:singlevalfields in sdextNoel Grandin10-68/+14
Change-Id: I9bf194fb58b3bd37071647a83a629b6782836890 Reviewed-on: https://gerrit.libreoffice.org/26659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu1-2/+4
Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683 Reviewed-on: https://gerrit.libreoffice.org/26537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-20tdf#96080 PDF Import: fix incorrect whitespace characters sequenceVort1-0/+7
Change-Id: I0f8e0217cb661be318af611216191def1b209ea1 Reviewed-on: https://gerrit.libreoffice.org/26426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko1-4/+1
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann2-2/+2
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-06Reintroduce some code removed with "Remove unneeded Pane code in ..."Jan Holesovsky1-1/+6
This code was removed in 71cf1aefca1ecf10272308d7c75201bd39d3b0f6, but it was guarded by an "ifndef", not by an "ifdef", so it should still stay (unless I'm missing something). Change-Id: Ib344e73d39d1fcd3b84784977769708726d8ed1e
2016-06-06Remove unneeded Pane code in Presenter ConsoleBryan Quigley4-729/+1
This code hasn't been touched (on purpose) in years, it appears to have been used to resize part of the console. (It's prefed off) Change-Id: Iaaeaa8a95c71ae91299bbeeea24869bf2a237b6b Reviewed-on: https://gerrit.libreoffice.org/24663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin2-5/+6
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in sdNoel Grandin6-26/+2
Change-Id: I27da3e7afd86217ec9f75958775da9c144d7a0a5 Reviewed-on: https://gerrit.libreoffice.org/25111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin2-3/+3
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13sdext: replace boost::bindMichael Stahl2-15/+8
MSVC 2013 with non-debug runtime requires an additional assignment operator in OUStringBufferAppender. Change-Id: Ic93fc8d6b1d4760f0eb89e34beb1fcb18e783f73 Reviewed-on: https://gerrit.libreoffice.org/24980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-12loplugin:stringconstantStephan Bergmann1-1/+1
Change-Id: I5515f35871b23b67564d5eda52bf3323e7e047bb
2016-05-12sdext: replace boost::bind with C++11 lambdas, part 2Michael Stahl8-29/+42
Change-Id: Ife5fbf7a7a41182de00dca339cba160e3bb0062f
2016-05-12loplugin:stringconstantTor Lillqvist1-1/+1
Change-Id: I9eed9713a0d208e7aa4cdddc0cedb97edf831239
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-23 23:12:19 +0000