summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)AuthorFilesLines
2018-06-27tdf#118374: fix crash from loplugin:useuniqueptr in sdextJulien Nabet2-3/+0
See bt: https://bugs.documentfoundation.org/attachment.cgi?id=143105 Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=a9ef943769b06e6bdffe7326f288b27e08a95698 Change-Id: I285f00cb6ede3d952a794b60ff64586fe2224e5f Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 4964cb80ec603a1ce9937f230fc6ed6b761a6e1f) Reviewed-on: https://gerrit.libreoffice.org/56509 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-17loplugin:unusedfields in sdNoel Grandin2-2/+0
Change-Id: I01e6431279b71d0cff8f44614b3cad17f0f89460 Reviewed-on: https://gerrit.libreoffice.org/54452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16loplugin:constantparamNoel Grandin4-12/+9
Change-Id: I0110e0c662004456e4bc8f8082e2e2fea59e0148 Reviewed-on: https://gerrit.libreoffice.org/54385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-24fix build with poppler 0.64Rene Engelhard2-0/+14
GooString became const... Change-Id: Icc95be2e8603a4e22c6a9ac2008986bacd0bfba5
2018-04-20loplugin:constantparamNoel Grandin1-21/+15
Change-Id: Ia58d8950b3b9e48bbe9f075b9fe1eed62d9abf0d Reviewed-on: https://gerrit.libreoffice.org/53188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-11new loplugin:unusedvariablemoreNoel Grandin2-10/+1
collection of heuristics to look for local variables that are never read from i.e. do not contribute to the surrounding logic This is an expensive plugin, since it walks up the parent tree, so it is off by default. Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06 Reviewed-on: https://gerrit.libreoffice.org/52450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-09use more DBG_UNHANDLED_EXCEPTIONNoel Grandin2-2/+4
so we get nice logs of the exception dynamic type for UNO exceptions. Change-Id: Ic0b10dc14d354a2c9a0591b3a51d2f1640d54bdb Reviewed-on: https://gerrit.libreoffice.org/52465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke1-1/+0
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-27loplugin:expressionalwayszero improvementsNoel Grandin1-12/+0
Change-Id: I00bdbc58d2295a0be30b47c85eae6b9abfec17b2 Reviewed-on: https://gerrit.libreoffice.org/51868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-21pdf: refactor poppler importerAshod Nakashian1-0/+21
This paves the way to add pdf parsing via pdfium. Change-Id: I384687bcdce3011682ebeec18ee3de44759feb1a Reviewed-on: https://gerrit.libreoffice.org/51254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-03-18fix crash on pdf import of fdo30892-1Caolán McNamara1-1/+0
after commit a9ef943769b06e6bdffe7326f288b27e08a95698 Date: Wed Feb 28 11:09:43 2018 +0200 loplugin:useuniqueptr in sdext Change-Id: I964e2319d583455c2c698f895e0b675d69256e38 Reviewed-on: https://gerrit.libreoffice.org/51475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16fix crash on pdf import of tdf59883-2Noel Grandin1-1/+0
after commit a9ef943769b06e6bdffe7326f288b27e08a95698 Date: Wed Feb 28 11:09:43 2018 +0200 loplugin:useuniqueptr in sdext Change-Id: I3f54002764ee42162279bade49a3e3b21e136917 Reviewed-on: https://gerrit.libreoffice.org/51402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-14Moving XSAXDocumentBuilder2 to use XFastDocumentHandler:Mohammed Abdul Azeem5-0/+7
This is used in parsing of meta Contexts across different modules. This also involved moving to XFastParser for parsing xml filters in sw, sd, starmath. Change-Id: Ic663aaac6cb20ee8ce5b97cae87c93220f5a2929 Reviewed-on: https://gerrit.libreoffice.org/42989 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-13change minimizer extension to not use GraphicUrl and FillBitmapUrlTomaž Vajngerl3-9/+6
Change-Id: I3a0c22d0e9411e5a427efce6adee0679e2c2de68 Reviewed-on: https://gerrit.libreoffice.org/51109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-07sdext: document the secondary screen of Presenter ConsoleMichael Stahl1-0/+5
Change-Id: I539a698994b5fa20e3d371ae56d9aaf3001dba2b
2018-03-06loplugin:useuniqueptr in sdextNoel Grandin9-269/+263
Change-Id: I0870d4b1e85465b07e3d9cdb05520fcb37dfc267 Reviewed-on: https://gerrit.libreoffice.org/50659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21New loplugin:nestedunnamedStephan Bergmann1-43/+36
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c Reviewed-on: https://gerrit.libreoffice.org/50048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-15sdext: disable the warnings TWICE because they're sneaky bastardsMichael Stahl1-2/+12
Let's hope this will finally work, it was like this before commit 4e102d6a4b483098e80ca86e19ee8576ae5356f1 Change-Id: I6337d4f1abc386e71747b2a37e55a3578bcbf340
2018-02-15sdext: MSVC 2015 is trashMichael Stahl1-4/+2
Change-Id: I8549b52417520c0fe52977137fc570d65b0800fc
2018-02-15sdext: if all else fails USE BIGGER HAMMERMichael Stahl1-4/+4
Change-Id: I83803461310580c47886322e20c0949a371a0407
2018-02-15sdext: suppress another MSVC warningMichael Stahl1-0/+1
Somehow a8ea79b10bfc4851d092270f02fa8c817c9bc0d9 caused another warning to appear in the MSVC 2015 that is used in jenkins builds. Whyever. Change-Id: Iba73de5739078972129d0a2de7d8a6437c12b2e0
2018-02-15sdext: disable MSVC 2017 warnings from boost headersMichael Stahl1-0/+11
Change-Id: I6eb816f155a222ca4299fd425c79d38bf2d464dc
2018-02-02Simplify sortElements in pdfiprocessor (sdext)Julien Nabet2-25/+5
For explanation, see: http://nabble.documentfoundation.org/About-simplifying-sortElements-in-pdfiprocessor-sdext-tt4231909.html Change-Id: I53fb732d776d7152279e5fc1440eafac1cfd71fe Reviewed-on: https://gerrit.libreoffice.org/49127 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-02Blind fix for MSVC warning C4101: 'rError': unreferenced local variableStephan Bergmann1-0/+2
...after 4e102d6a4b483098e80ca86e19ee8576ae5356f1 "sdext: MSVC: pragma warning: make more specific, remove obsolete" Change-Id: Ibd198ef24aa67c4c98bc1f504deccb1fdf28d054
2018-02-02sdext: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski3-22/+2
Change-Id: I317b952c27fd052d4f19aa0dfc4ee9ce1e4705ad Reviewed-on: https://gerrit.libreoffice.org/49046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01Fix typosAndrea Gelmini1-4/+4
Change-Id: I455efa82de60b764a500e1cc092ae08e800ec824 Reviewed-on: https://gerrit.libreoffice.org/49068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-25loplugin:datamembershadow in PresenterPaneNoel Grandin6-21/+9
the subclass field is just a copy of the parent field, so drop the subclass, and consequently simply the CreateCanvases method, we don't need to pass the parameter down, can just access the parent field. Change-Id: I3be448a06b32d01cdda4fc36b78cafb4488e2913 Reviewed-on: https://gerrit.libreoffice.org/48553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:constparamsNoel Grandin1-1/+1
Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504 Reviewed-on: https://gerrit.libreoffice.org/48392 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23new loplugin: pointerboolNoel Grandin1-1/+1
look for possibly bogus implicit conversions to bool when passing (normally pointer) args to bool params. this plugin comes in the wake of a couple of bugs caused by refactoring, where some of the call sites were not currently updated. Of the changes, the following are real bugs: desktop/../dp_persmap.cxx StartInputFieldDlg in sw/../fldmgr.cxx which occurred as a result of commit 39d719a80d8c87856c84e3ecd569d45fa6f8a30e Date: Tue May 3 11:39:37 2016 +0200 tdf#99529 sw: don't pop up input field dialog before inserting field CSerializationURLEncoded::encode_and_append in forms/../serialization_urlencoded.cxx XclExpCFImpl::XclExpCFImpl in sc/../xecontent.cxx I have no idea how to properly fix this, just made a guess. SwDocTest::test64kPageDescs in sw/qa/core/uwriter.cxx which looks like a simple copy/paste error. Change-Id: I795ebd5ef485a1d36863dc27fe13832989f5a441 Reviewed-on: https://gerrit.libreoffice.org/48291 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann1-2/+2
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-22gbuild: always compile as C++17 with MSVC 2017Michael Stahl1-0/+6
The current update MSVC 2017.5 supports fancy new C++ features, but unfortunately in its default C++14 mode it falls over and dies with an internal compiler error as soon as it sees the WeakImplHelper variadic template. In order to work around the ICE, build everything as C++17, which somehow doesn't crash. This causes loads of deprecation warnings about obsolete std::this and badly designed std::that, almost all of them from boost headers, which are well known for following every best practice in the C++ book. Liberally sprinkle macros around to suppress the warnings for now, like we already do with the other million warnings from boost headers. Change-Id: Ia6b6ef5e457b5fe3c8cfe361ba5da39376bb7c4c Reviewed-on: https://gerrit.libreoffice.org/48225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22boost: upgrade to release 1.66.0Michael Stahl1-0/+1
This claims to support Visual Studio 2017.4, but not the current 2017.5. * remove boost.auto_link.patch; it does not apply; not sure why we need this if we can just define BOOST_ALL_NO_LIB (see commit 7f2e168421c3cd928a31a52a8b5afe97e931d3ba) * remove some hunks from clang-cl.patch.0 that look fixed upstream * add a global workaround for spurious GCC warning: oox/source/drawingml/shape.cxx:921:54: error: ‘oShadowColor.boost::optional_detail::tc_optional_base<int>::m_storage’ may be used uninitialized in this function [-Werror=maybe-uninitialized] aFormat.Color = *oShadowColor; Change-Id: I1eb1d8b66554a84a7d7269f1faaa98695fe2f501 Reviewed-on: https://gerrit.libreoffice.org/48187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-19loplugin:unusedmethods also check for functions returning boolNoel Grandin4-7/+4
we were previously excluding them Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11 Reviewed-on: https://gerrit.libreoffice.org/48167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-17Fix typosAndrea Gelmini1-1/+1
Change-Id: Id1c7ddf6c49ec709e38947a82731fe31a64aad04 Reviewed-on: https://gerrit.libreoffice.org/48076 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16tdf#114939 sdext: don't use StarOffice MD5 in PDF importMichael Stahl2-38/+35
Always use real MD5 here, to avoid interop issues. Change-Id: Id6f43952bace1654ac761aecc77676d933737d1d
2018-01-15More loplugin:cstylecast: sdextStephan Bergmann1-1/+1
Change-Id: Ib0b6f3d07c7c596f6eed291587db8bba207c8b7d
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin1-1/+1
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: sdextStephan Bergmann17-117/+117
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Ie9eca6a78912a62f5a46ecacb1da052621c79ea4
2018-01-08Allow building with poppler-0.62Dominique Leuenberger1-2/+8
Change-Id: Ia627f1628a67dd8ece7d9318639d9ccd06b89765 Reviewed-on: https://gerrit.libreoffice.org/47460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-04loplugin:unusedfieldsNoel Grandin3-10/+2
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03Silence loplugin:unreffun with --disable-assert-always-abortStephan Bergmann1-0/+2
Change-Id: I1b5a7a6aa2436aa5b8297d5de172035cff3f1306 Reviewed-on: https://gerrit.libreoffice.org/47318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-29loplugin:passstuffbyref improved return in ucb,connectivityNoel Grandin1-2/+2
Change-Id: Ib2590648c9dced87693a58a506cb62d04e37b18d Reviewed-on: https://gerrit.libreoffice.org/47149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-24pdf: use bimap for GraphicsContext-id mapAshod Nakashian2-13/+15
In some large PDFs the two maps for mapping GraphicsContext to ID and finding GraphicsContext given and ID are huge (over 160 MB in one case). By using a bimap the footprint went down to 110 MB. Reviewed-on: https://gerrit.libreoffice.org/45380 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 551543bf359f644f727fd1aa86e2c5ae499f88ce) (cherry picked from commit ac328157460e9e6a9ca6834e8233a28e845c2806) Change-Id: I59a444b5efa09fcabc26fa492de723ca063e14a4 Reviewed-on: https://gerrit.libreoffice.org/46988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-19remove unused typedefsNoel Grandin1-1/+0
Change-Id: I6fd7a9fed3a80c91a3766fceefd43c5db0aa5275 Reviewed-on: https://gerrit.libreoffice.org/46763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11loplugin:salcall fix functionsNoel Grandin3-4/+4
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10Modernize code in sdextJulien Nabet2-17/+12
Change-Id: I2257014cf77b14aba263718b4730744960cc1dc2 Reviewed-on: https://gerrit.libreoffice.org/46178 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-07loplugin:constparamsNoel Grandin3-6/+6
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b Reviewed-on: https://gerrit.libreoffice.org/45959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30loplugin:unnecessaryparenStephan Bergmann1-2/+2
Change-Id: I981372300b03ecd7b46e08d6a279f5438b46d8df
2017-11-27loplugin:unnecessaryparen: Warn about parentheses around literalsStephan Bergmann1-3/+3
...that are not composed of multiple tokens, like ("foo" "bar"). Also don't yet warn about Boolean literals, which are sometimes wrapped in parentheses to silence unreachable-code warnings. To avoid multiple warnings about code like f((0)) switch to generally using a set of ParenExpr to keep track of which occurrences have already been handled. Change-Id: I036a25a92836ec6ab6c56ea848f71bc6d63822bc Reviewed-on: https://gerrit.libreoffice.org/45317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin2-3/+3
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-23 13:56:35 +0000