summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)AuthorFilesLines
2014-03-25coverity#982469 Unchecked dynamic_castCaolán McNamara1-2/+2
Change-Id: I6fa95fbd64f69cca1837b57f9c632f0bdbaec1d0
2014-03-25coverity#982468 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: Ie98fa4199ebfa96495bdb7fa4582b09926fac8f1
2014-03-23fdo#44710 PDF Import: Correction of position of rotated textVort2-57/+9
Change-Id: Ie53b25a6cec88c07a317c50bd0965282fac64ff0 Reviewed-on: https://gerrit.libreoffice.org/8725 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin1-1/+1
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-12Remove unused HelpCloseListenerStephan Bergmann2-41/+0
Change-Id: I9040a1262b31f8d0f19594b6efcf12b2c38be7be
2014-03-03fdo#40513 PDF Import: Hack: Replace incorrect values of font's ascent propertyVort1-1/+18
Change-Id: Ib7bd6e15fff5213b5d935c6f03f2c65ea3f6ca50 Reviewed-on: https://gerrit.libreoffice.org/8416 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann62-645/+645
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from sdextAlexander Wilms12-45/+45
Change-Id: I792249b9e92db9af4daee0bd835e04044d29bca5 Reviewed-on: https://gerrit.libreoffice.org/8308 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms28-94/+94
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23coverity#983817 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I91883489d9557c5e3779c6b16bf377c1b95e49da
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert5-0/+5
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20fdo#75195 PDF import: Revert commit 128adf7e5c06fff378c8d72b44ec4be1e462984fVort1-34/+5
Change-Id: Icb03088809e57a388317f98046f9de3197772a41 Reviewed-on: https://gerrit.libreoffice.org/8126 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20cid#983380 Dereference before null checkNoel Grandin1-5/+0
Change-Id: I9504738a5291b85362a80e630d9e413825fa6572
2014-02-18fdo#37246 PDF Import: Color to string conversion fixVort1-3/+3
Change-Id: I5ec9f0246f6c2d1b12a389906d04133b2f5a6f9f Reviewed-on: https://gerrit.libreoffice.org/8106 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-12fdo#45003 PDF import: Implementing linejoin and linecap propertiesVort1-0/+32
Change-Id: I4b09cd7b970d5aca4500ae333edef0e4c2f618b9 Reviewed-on: https://gerrit.libreoffice.org/8009 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-08cppcheck: duplicateExpressionJulien Nabet1-1/+1
See http://nabble.documentfoundation.org/Cppcheck-Same-expression-on-both-sides-of-in-PresenterPaneBorderManager-cxx-sdext-td4094873.html Change-Id: I7dbb8d0254ca77127250d6ca02de7b945ef8051e
2014-02-08Rename makefile to match the name of test.Matúš Kukan2-1/+1
Change-Id: I00f11f644b92f18f7a139bb8ece67c57a971f17e
2014-02-04fdo#35143 PDF import: Reimplementation of whitespace detection functionVort2-232/+42
Change-Id: I5b230aaebf72b70bbb7e206414a5ac0e01f01f86 Reviewed-on: https://gerrit.libreoffice.org/7564 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-02fdo#54938 Convert basctl, mysqlc, sdext, svgio, writerp. to cppu::supportsSer.Alexandre Vicenzi1-31/+2
Change-Id: I60128dbb5bf83f25eea847fe655d7126c9077414 Reviewed-on: https://gerrit.libreoffice.org/7756 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-01-28bool improvementsStephan Bergmann1-1/+1
Change-Id: I969de97522ae2e3f8693e82a500a73e28451ef77
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann1-4/+4
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-10Use proper bool operationsStephan Bergmann1-1/+1
Change-Id: If9d439faba5a02b50152dfa1090b9eb1afa0fc18
2013-12-20typo fixesAndras Timar1-1/+1
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-18fdo#72598 Remove SunStudio cruft from code baseJelle van der Waa1-4/+0
Change-Id: I8dfbbb36cca3cf71c8d347b248dd206c447db6d2 Reviewed-on: https://gerrit.libreoffice.org/7136 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-17No need for implbase1.hxx to include XComponentContext.hppStephan Bergmann2-0/+6
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up, of course. Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17fdo#72598 Remove SunStudio cruft from code baseJelle van der Waa2-15/+5
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc Reviewed-on: https://gerrit.libreoffice.org/7104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann3-8/+6
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17Unnecessary use of OUString constructor inside OUStringBuffer constructorNoel Grandin1-1/+1
Convert code like: OUStringBuffer sVal(OUString("0x")); to: OUStringBuffer sVal("0x"); Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
2013-12-17Remove unnecessary use of OUString constructor in OUStringBuffer::append callsNoel Grandin3-4/+4
Convert code like aStrBuffer.append(OUString(" AS ")); to aStrBuffer.append(" AS "); Change-Id: I8c1884b5a875f40f0b5e511b6ef38c6c8eeee656
2013-12-17Remove unnecessary use of OUString constructor in + expressionsNoel Grandin1-4/+4
Convert code like aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp"); to aFilename = OUString::number(nFilePostfixCount) + ".bmp"; Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-05sdext: clean up some pointless #ifdefsMichael Stahl1-9/+5
Change-Id: Ic23c0ccc45d7a98b3581feab43fc4c8c8aef9013
2013-12-02Drop duplicate #includeTakeshi Abe1-1/+0
Change-Id: Ife8ebbb5e46704c5d2ff46cc345b4ed926e7dc12
2013-11-29Further XCanvas != XBitmapCanvas cleanup.Thorsten Behrens1-2/+2
It seems I missed a few places in 21ec9beae29b19b8ec6f0a16fd0e708e4f210208, getting that straight now hopefully. Change-Id: I34fc8df2d1ee65bef0639b3de9487ff311bed89a
2013-11-29Fix fdo#71527 no unguarded ptr dereference here.Thorsten Behrens1-1/+2
This is the real problem - mxPane can be validly NULL. Change-Id: Ie8d055db9bfb68cb9031fa970518343f5aec6619
2013-11-29Revert "Resolves: fdo#71527 don't crash in presenter console"Thorsten Behrens1-2/+1
This reverts commit bae01385c895a100b5371879889e606927cff877. Change-Id: Id149bae0904fd6c2120209d69490d0b257ac3f64
2013-11-21remove unnecessary RTL_CONSTASCII_STRINGPARAM in OUString::equalsLNoel Grandin1-4/+4
Convert code like this: if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aStr == "rem") which compiles down to the same code. Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
2013-11-20Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"Noel Grandin1-4/+4
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295. I mistakenly converted OUString::equalsL calls to OUString::startsWith calls.
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL callsNoel Grandin1-4/+4
Convert code like: if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aByteStr.startsWith("rem")) Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20cppcheck: Variable is reassigned a value before the old one has been usedCaolán McNamara1-1/+0
Change-Id: Ifc16473c426bca2235e84b0d71291756074712bb
2013-11-20Resolves: fdo#71527 don't crash in presenter consoleCaolán McNamara1-1/+2
but we're now dropping slides in there for some reason so this is just a don't crash band-aid and not the fix for the deeper problem Change-Id: I2f70471d03979ffb86b6289e7a432f4505c1b556
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin1-4/+4
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin4-7/+7
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-14GCC diagnostic push / pop requires HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPEMichael Stahl1-2/+2
Change-Id: I0765649b94b370caf92a29a8ff2224e335196612
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-22/+0
SimpleView had been unused since its inception in b561e658ebed8cfcfd18dc90bd25de9134341fb3 "INTEGRATION: CWS presenterview." Change-Id: Ieb3af55c4cfebd24fe229c847f38ca108ae3401e
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-2/+0
Change-Id: Ie8f3502c735cf38e21f2f55f27d384dbe3d8d5ef
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-20/+0
Change-Id: I745ceb72423b120ef42437778e3a5fe05bd7b42b
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-2/+0
Change-Id: I17160893b759f4dee1871e8f6d6525d327cf8cd6
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-130/+0
...the whole ChooserDialogHandler class is unused since before bdc71b3e4112b5c83a6aec61403981fcdd156138 "remove non-compiled code" removed its sole, #if'ed out use. Change-Id: If94db1c98074132952dd204864a478e1e12d455d
2013-11-14-Werror,-Wunused-exception-parameterStephan Bergmann1-1/+2
Change-Id: Ibcda8d872ad89a363f71bc4d5aa92b6bae2d2608
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin5-19/+19
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec