summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)AuthorFilesLines
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann1-4/+4
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. (cherry picked from commit a3f32769fc4bb23c64168b412dd10ec769a3854d) Conflicts: sc/source/ui/unoobj/nameuno.cxx sc/source/ui/unoobj/styleuno.cxx sfx2/source/appl/sfxhelp.cxx stoc/source/security/permissions.cxx sw/source/core/unocore/unocrsrhelper.cxx (None of those bogus startsWith calls seem problematic enough to warrant backporting also to libreoffice-4-2-0.) Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21 Reviewed-on: https://gerrit.libreoffice.org/7578 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-02Resolves: fdo#71527 make presenter console not crash/uselessThorsten Behrens1-2/+2
Basically reverts the pieces of 21ec9beae29b19b8ec6f0a16fd0e708e4f210208 to make XSpriteCanvas a XBitmapCanvas again Otherwise PresenterHelper::loadBitmap is not an XBitmapCanvas and so VclFactory::createBitmap cannot succeed (cherry picked from commit 639aa8e72639fd01e9004977f1cfaafc13b1e45f) Revert "Resolves: fdo#71527 make presenter console not crash/useless" This reverts commit 639aa8e72639fd01e9004977f1cfaafc13b1e45f. (cherry picked from commit 72aa51185fb7b1ff2ad9006f2067a680b70ab66d) Revert "Resolves: fdo#71527 don't crash in presenter console" This reverts commit bae01385c895a100b5371879889e606927cff877. (cherry picked from commit b807b2d9291a2328a55de55d67c4874803d8b7fd) Fix fdo#71527 no unguarded ptr dereference here. This is the real problem - mxPane can be validly NULL. (cherry picked from commit 1b10205c2cb952ab43e30706c05f78d6e8f642c3) Further XCanvas != XBitmapCanvas cleanup. It seems I missed a few places in 21ec9beae29b19b8ec6f0a16fd0e708e4f210208, getting that straight now hopefully. (cherry picked from commit 05d2994c136650deca2d80fedf6b14d10109986e) 0ac1a7ada530791e2d34d2f0802213c869ea48a1 d149bae0904fd6c2120209d69490d0b257ac3f64 e8d055db9bfb68cb9031fa970518343f5aec6619 34fc8df2d1ee65bef0639b3de9487ff311bed89a Change-Id: I197adf98e915102f383ee050a8ea16d1e41cecf2
2013-11-20Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"Noel Grandin1-4/+4
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295. I mistakenly converted OUString::equalsL calls to OUString::startsWith calls.
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL callsNoel Grandin1-4/+4
Convert code like: if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aByteStr.startsWith("rem")) Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20cppcheck: Variable is reassigned a value before the old one has been usedCaolán McNamara1-1/+0
Change-Id: Ifc16473c426bca2235e84b0d71291756074712bb
2013-11-20Resolves: fdo#71527 don't crash in presenter consoleCaolán McNamara1-1/+2
but we're now dropping slides in there for some reason so this is just a don't crash band-aid and not the fix for the deeper problem Change-Id: I2f70471d03979ffb86b6289e7a432f4505c1b556
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin1-4/+4
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin4-7/+7
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-14GCC diagnostic push / pop requires HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPEMichael Stahl1-2/+2
Change-Id: I0765649b94b370caf92a29a8ff2224e335196612
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-22/+0
SimpleView had been unused since its inception in b561e658ebed8cfcfd18dc90bd25de9134341fb3 "INTEGRATION: CWS presenterview." Change-Id: Ieb3af55c4cfebd24fe229c847f38ca108ae3401e
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-2/+0
Change-Id: Ie8f3502c735cf38e21f2f55f27d384dbe3d8d5ef
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-20/+0
Change-Id: I745ceb72423b120ef42437778e3a5fe05bd7b42b
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-2/+0
Change-Id: I17160893b759f4dee1871e8f6d6525d327cf8cd6
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-130/+0
...the whole ChooserDialogHandler class is unused since before bdc71b3e4112b5c83a6aec61403981fcdd156138 "remove non-compiled code" removed its sole, #if'ed out use. Change-Id: If94db1c98074132952dd204864a478e1e12d455d
2013-11-14-Werror,-Wunused-exception-parameterStephan Bergmann1-1/+2
Change-Id: Ibcda8d872ad89a363f71bc4d5aa92b6bae2d2608
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin5-19/+19
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14remove more pragma instances of GCC system_headerMichael Stahl1-2/+9
Use "#pragma GCC diagnostic ignored" instead which does not prevent generation of dependencies. Change-Id: Ic9034f20ef71c1ee6e5363b73c831142c2813d20
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin5-28/+27
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin1-1/+1
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11remove unnecessary use of OUString constructorNoel Grandin2-23/+23
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-05fixincludeguards.sh: sdextThomas Arnhold67-148/+148
Change-Id: I5cb8f7fb35121f41aedeff46f50d51d2ee039206
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin2-4/+4
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-31Resolves: #i123433# Detect pseudo-vertices at svg import...Armin Le Grand3-5/+5
unify svg:d handling, correct svg:d import for relative sub-polygons in svg import; changed default for moveto writes for svg:d in ODF to absolute (cherry picked from commit f15874d8f976f3874bdbcb53429eeefa65c28841) Conflicts: basegfx/inc/basegfx/polygon/b2dpolygontools.hxx basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx basegfx/inc/basegfx/polygon/b3dpolypolygontools.hxx basegfx/source/polygon/b2dpolypolygontools.cxx basegfx/source/polygon/b2dsvgpolypolygon.cxx basegfx/source/polygon/b3dpolypolygontools.cxx basegfx/source/tools/makefile.mk basegfx/test/boxclipper.cxx basegfx/test/clipstate.cxx basegfx/test/genericclipper.cxx canvas/source/tools/surfaceproxy.cxx sdext/source/pdfimport/tree/drawtreevisiting.cxx sdext/source/pdfimport/tree/writertreevisiting.cxx xmloff/inc/xexptran.hxx xmloff/source/draw/XMLImageMapContext.cxx xmloff/source/draw/XMLImageMapExport.cxx xmloff/source/draw/shapeexport2.cxx xmloff/source/draw/shapeexport3.cxx xmloff/source/draw/xexptran.cxx xmloff/source/draw/ximp3dobject.cxx xmloff/source/draw/ximpshap.cxx xmloff/source/style/MarkerStyle.cxx xmloff/source/text/XMLTextFrameContext.cxx xmloff/source/text/txtparae.cxx Change-Id: I5171b4a3559ea116bea45152e1f2685666463635
2013-10-30Remove unnecessary #includesTakeshi Abe16-22/+2
and add them to a couple of appropriate headers Change-Id: I500765df767319a0a75ea2446f4fec591a34da58
2013-10-29Drop unnecessary #includeTakeshi Abe6-7/+0
Change-Id: I20448aebfae86c097413660e9ec836a786507a85
2013-10-28gbuild: set Package default target to INSTDIRMichael Stahl1-2/+0
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28extras: don't hardcode shareMichael Stahl1-1/+1
Change-Id: I78b08f653407c5889e0f24ef6d38e9f9d1817df9
2013-10-24sdext: deliver that weird pdf file to INSTDIRMichael Stahl1-1/+3
Change-Id: I3d5daf2ab957eb98c80e936406721a7eb627c436
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist1-1/+1
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-15Minimizer: *.mini was saved w/o .odp etc. extension (and clean up)Stephan Bergmann1-24/+7
Change-Id: I4626794f7816ae455a392cdc0acbac42c866fff4
2013-10-15fdo#61950 De-extensionize presentation minimizer: post cleanDavid Ostrovsky1-4/+5
Change-Id: I7d21f1d67b13fcd83792503e8c72ccf16fbda1ec Reviewed-on: https://gerrit.libreoffice.org/6247 Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de> Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2013-10-15could not convert from ‘const char*’ to ‘rtl::OUString’Eike Rathke4-146/+146
Since 3eb84bcb4580af50c2ded9f48749384b8455258e which apparently Clang has no problem with. Change-Id: I21af4e20dd116705e53d73a968fde478bff142bb
2013-10-15Remove unnecessary TK_LastStephan Bergmann2-6/+1
Change-Id: Ia5095646f01a76258d69df866e3c803f8691915b
2013-10-15Small simplification (and exit loop early)Stephan Bergmann1-3/+3
Change-Id: I076307174fdd63b58a8cb9c9690f50dae746c289
2013-10-15Simplify PPPOptimizerTokenEnum -> OUStringStephan Bergmann2-6/+5
Change-Id: I8be2a1d603afd26de11e737586590ebb7adcbc42
2013-10-15Simplify PPPOptimizerTokenEnum -> OUStringStephan Bergmann3-5/+5
Change-Id: I88176f00c5fb356d63ecfdd291c006e88606a604
2013-10-15Simplify TKGet(TK_FOO) -> "FOO"Stephan Bergmann6-414/+414
Change-Id: I06e3134aeef27f13969f6d9d7d81b916bc93e8e2
2013-10-14Remove unused fileStephan Bergmann1-2/+0
...was referenced from removed sdext/source/minimizer/description.xml Change-Id: I501860640eb899742f7850f626008b930bf8eab4
2013-10-14Remove file apparently unused since inceptionStephan Bergmann1-106/+0
Change-Id: Ib2522c943df37c0b299120fcbdb262a74ee5f5f7
2013-10-14No need to have com.sun.star.comp.PPPOptimizer as a serviceStephan Bergmann5-111/+17
After de-extension-alization of Presentation Minimizer, it is important that its UNO implementation names are different from the ones used by the extension (in case the extension ever is installed as shared or per-user). For com.sun.star.comp.PPPOptimizer it appears to be easiest to not advertise this as a service at all, but rather instantiate the object directly where used. (For com.sun.star.comp.PresentationMinimizerImp the necessary renaming had been done in the previous commit already.) Change-Id: I954b715f2d434cecf9abd2776b39c4ed3152c5ec
2013-10-14fdo#61950 De-extensionize presentation minimizerDavid Ostrovsky15-1089/+16
Change-Id: I87805ceacf184d5aa5faae68e8bb932391ace7fb Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-10little String to OUString + documentationThomas Arnhold1-1/+1
Change-Id: I982e44150fd2909da0571409f16051d79377d7a3 Reviewed-on: https://gerrit.libreoffice.org/6192 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-10-10Normalize ENABLE_PDFIMPORT: TRUE or emptyTor Lillqvist1-1/+1
Change-Id: I962b37757dbf3569df73e70ae2d7c666d7cdf43e
2013-10-07XCanvas does no longer imply XBitmapCanvasThorsten Behrens1-0/+1
Remove the implication that XCanvas IS-A XBitmapCanvas, i.e. one can access underlying pixels. That's a preparation for display-list based canvas implementations, and was a rather silly assumption in the first place. Also fixes up all client sites. Change-Id: I7a3d6f68ef46fe94b23cce7759cc0b8b6ca4dae9
2013-10-02gbuild: kill gb_XcsTarget_get_outdir_targetMatúš Kukan1-1/+1
No idea what the '--path $(gb_Configuration_registry)' parameter was for. Change-Id: I892e178a62fa2ea971101815ea558f79d32f85ed
2013-10-02sdext: kill Package_pdfimport_xcu.mkMatúš Kukan3-17/+1
Change-Id: I88a402bf26852e8e216de11d71cbd42edb0aff23
2013-10-02WaE: unused variableTor Lillqvist1-1/+0
Change-Id: I0e344a64da4166b99be6887df384224042172454
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-2/+0
Change-Id: If23f88f35e5200cdcc271143d87c8c40b7fd65da
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-4/+0
Change-Id: I393816c526764c21762e5bc19318f862d0f91de5
2013-09-20fix Windows build, dbglevel=2Andras Timar1-4/+4
Change-Id: I7dba2852a32a1b1c8309b5981e6b535c6dfb1b8c