summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)AuthorFilesLines
2015-04-29tdf#63054: pdf_string_parser incorrectly handles escapesMike1-2/+2
This patch fixes the escapes handling by avoiding boost built-in functions that skip whitespaces behind the scenes. Change-Id: I9607ecd9e2e052aadcba69cf30ec25c981743c49 Reviewed-on: https://gerrit.libreoffice.org/15562 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-04-27More loplugin:simplifyboolStephan Bergmann2-5/+5
Change-Id: I4ea5c7e9f807dfd5242c8e87a87d9ad604ebd035
2015-04-24loplugin:simplifyboolStephan Bergmann2-3/+3
Change-Id: If5f4042642364424f8d7e1e13b6285503df1d381
2015-04-23loplugin:staticmethodsNoel Grandin4-18/+7
Change-Id: I6207b475127099872c6f3764331006688129b673
2015-04-21No more need for PartialWeakComponentImplHelper hereStephan Bergmann1-10/+1
...since 70626249cd247d9acdad417b8eaf252bae22c059 "API CHANGE a11y unpublishing and add/removeListener rename." Change-Id: I89d81326d97712abcac94c3436a13905954c55cf
2015-04-21Make cpp/poppler-version.h header optionalTomáš Chvátal1-0/+8
Older popler (SLE11) does not have this header yet. With the code simply if the header not found define version to oldest possible working candidate and also raise the .pc check to the same. Change-Id: I039c879879188fe2eb90cd119b80a1d6354a6a9c Reviewed-on: https://gerrit.libreoffice.org/15339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin60-720/+720
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-07loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
2015-04-07loplugin:staticmethodsNoel Grandin5-16/+16
Change-Id: Ibaad2adabecb878411fdd66383bca91f034477af
2015-04-02loplugin:staticmethodsNoel Grandin5-21/+21
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
2015-04-02loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: I3ae555fd9f0dc3c11ea301ee1cb2c799fbec820d
2015-03-30loplugin:staticfunctionNoel Grandin26-74/+69
Change-Id: I4b7b04031fa74956379c5a1b21abe10b0717f3e9
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann2-3/+3
Change-Id: I525293c6baaa2ab13db8f3205782a0d206d9d7ca
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann3-3/+3
Change-Id: I207f23b084013f9ce2fcf087a7f335bd8a194f50
2015-03-18fix higher debug levelsCaolán McNamara1-1/+1
Change-Id: I10556946c4bd6c60adcd9f662462b0f4b73781a2
2015-03-17Fix various XServiceInfo implementationsStephan Bergmann9-19/+135
...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann1-2/+4
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-03-12add accel. to switch monitors to pres. consoleDavid Tardon1-1/+4
Change-Id: I86c458f2c0a1c6a6baa6461a44b68c5f48ea55b0
2015-03-09V801: Decreased performanceCaolán McNamara2-13/+13
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-03-09V801: Decreased performanceCaolán McNamara3-19/+19
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-02cppcheck: duplicate inherited memberNoel Grandin5-8/+3
Change-Id: Iee20ca4523739eb082ea1fa8c1145891c0caed29
2015-03-01Typo: embeded->embeddedJulien Nabet1-1/+1
Change-Id: I27d0cdac158a674274647fe0081a8d8c046fe0ea
2015-02-17SkipImages option for PDF importMihai7-17/+86
This option allows images and drawings to be skipped while importing a PDF, the main reason was performance improvement where images were not needed. Change-Id: Ibca342ff6e7005bedf7b16869473832ce2576fb2 Reviewed-on: https://gerrit.libreoffice.org/14470 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-07loplugin:deletedspecialStephan Bergmann1-20/+13
Change-Id: I4b7583a69ddd8de0e428a0ce848c95f805433952
2015-02-05Updated all precompiled headers.Ashod Nakashian2-0/+2
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin4-17/+17
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-22fdo#79045 PDF Import: fix text displacementVort1-1/+10
Change-Id: I22e3b90671f1dc4f9720758a7a5b79f56fa2ff49 Reviewed-on: https://gerrit.libreoffice.org/14098 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2015-01-22pdf import: Kill cut'n'paste, and fix a memory leak.Jan Holesovsky1-48/+22
Change-Id: I9460e458e9ac5274d68bd11b0ed77b06d664ce0e
2015-01-21fdo#85174 PDF Import: fix character positions without modifying popplerVort2-18/+17
Change-Id: I4ec6409e8fa13161c5cd37fcae2055b4bc5ecfd4 Reviewed-on: https://gerrit.libreoffice.org/14066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-20continue to implement drawChar for unpatched popplers without drawChar2 hackCaolán McNamara2-0/+14
Change-Id: Id4ad86f3f563d88777352722e397cd77cfad45e4
2015-01-20fdo#85174 PDF Import: fix character positionsVort2-6/+4
Change-Id: I0aa75b6cb834341e47bbeeaa15d39387a8cb5240 Reviewed-on: https://gerrit.libreoffice.org/14029 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-20Some more loplugin:cstylecast: sdextStephan Bergmann2-10/+10
Change-Id: Id98eab748280cd9c9c6e34cc3f6938ff6911361a
2015-01-19fdo#88465 PDF Import: fix scale and rotate image transformationsVort2-117/+56
Change-Id: I64bb088320099303b0da6d272c3cd6a9ba954f87 Reviewed-on: https://gerrit.libreoffice.org/13957 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl1-1/+1
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-04boost::unordered_map->std::unordered_mapCaolán McNamara16-48/+48
Change-Id: I82f668ef72e916d2ff11df5cda2a02653999f66f
2014-12-23fdo#39440 reduce scope of local variablesMichael Weghorn1-2/+1
This addresses some cppcheck warnings. Change-Id: I404f121ee2e5020359a662f54ffe341f466cd1d5 Reviewed-on: https://gerrit.libreoffice.org/13608 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-18sdext: Use appropriate OUString functions on string constantsStephan Bergmann5-9/+7
Change-Id: I6815b791b935bffe6409af2bcfdd6d6adceb2252
2014-12-15sdext: Use appropriate OUString functions on string constantsStephan Bergmann4-22/+22
Change-Id: I0e9800f1c828294e5b97e513dae30a4f2d1161fe
2014-12-05fdo#38835 strip out OString globalsNoel Grandin1-8/+8
Change-Id: Id2eb27132fd6c1734e50c02617ce1bbb75e294a0
2014-11-26fix higher debug level buildCaolán McNamara1-0/+1
Change-Id: Ibc2b9e56882fac4ebd181ef9fd66d91981951d32
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl10-0/+10
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14coverity#1019392 Uncaught exceptionCaolán McNamara1-0/+5
Change-Id: Iab953700c9aa95fc3acd5f25233a942a31b7f5ad
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava4-9/+9
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann4-7/+9
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin4-9/+7
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06Resolves: fdo#76581 copy-and-paste -> slideshow crash in presenter consoleCaolán McNamara1-8/+20
crash started after... commit 0218b0e2fa510d7acd7413dbedefd9ad50257f76 Date: Mon Jul 15 19:45:44 2013 +0300 fdo#65457 - Provide visual clues in presenter view. Change-Id: I19d84800bd5924f2dcc9e5debcf18ef95577105c
2014-11-05coverity#1019393 Uncaught exceptionCaolán McNamara1-28/+36
Change-Id: I818a91a3090392efed46700b5e2d77d7f1e3bdb9
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin3-10/+8
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin13-13/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628