summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)AuthorFilesLines
2018-06-01sd: import PDFs as images using Pdfium new SdPdfFilterAshod Nakashian5-6/+21
LOK now opens PDFs as images using Pdfium, which has a superior accuracy and support to poppler, the default pdf reader. (cherry picked from commit 0e8f4f45b44935c7c8002d606b97a48e60e37b23) Change-Id: Ifbbecf7f048f001836fb98886705cba47e6bed4e
2018-04-26fix build with poppler 0.64Rene Engelhard2-0/+14
GooString became const... Change-Id: Icc95be2e8603a4e22c6a9ac2008986bacd0bfba5 Reviewed-on: https://gerrit.libreoffice.org/53422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 106b2c96e9807af14d6eb6e8f83dcf25095a093e)
2018-03-20pdf: use bimap for GraphicsContext-id mapAshod Nakashian2-13/+15
In some large PDFs the two maps for mapping GraphicsContext to ID and finding GraphicsContext given and ID are huge (over 160 MB in one case). By using a bimap the footprint went down to 110 MB. Reviewed-on: https://gerrit.libreoffice.org/45380 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 551543bf359f644f727fd1aa86e2c5ae499f88ce) (cherry picked from commit ac328157460e9e6a9ca6834e8233a28e845c2806) Change-Id: I59a444b5efa09fcabc26fa492de723ca063e14a4 Reviewed-on: https://gerrit.libreoffice.org/46988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 653736fb23346e07e8c0e6e0125689ae1f49f0f7)
2018-01-29Allow building with poppler-0.62Dominique Leuenberger1-2/+8
Change-Id: Ia627f1628a67dd8ece7d9318639d9ccd06b89765 Reviewed-on: https://gerrit.libreoffice.org/47460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 38368be8527ca655854ee1231d9f355b8c0591ec) Reviewed-on: https://gerrit.libreoffice.org/48809 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2017-11-17loplugin:useuniqueptr in PDFContainerNoel Grandin5-48/+41
Change-Id: I25c2a5a078450ed921c7e981f4c9fac242aa7178 Reviewed-on: https://gerrit.libreoffice.org/44863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10sdext: document 2 different canvasesMichael Stahl1-0/+5
Change-Id: Icb8815ed20b06d2f43fbfb0088e6bdd0d5b389f6
2017-11-06loplugin:constparams in various(2)Noel Grandin1-1/+1
Change-Id: I533a7eb724b15e168a28dc92cd5962a39bc96e7c Reviewed-on: https://gerrit.libreoffice.org/44313 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31loplugin:constantparam in sdNoel Grandin1-20/+15
Change-Id: I1c5e5a26d343ac3aa244d7b053f2ec6922edbb21 Reviewed-on: https://gerrit.libreoffice.org/44085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27loplugin:constantparam in sd,sdextNoel Grandin2-35/+44
Change-Id: Idc3507b80da046aca00283e99fdca35cb624c3da Reviewed-on: https://gerrit.libreoffice.org/43952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26More loplugin:unnecessaryparenStephan Bergmann1-2/+2
81892b2037453108b9bde1512a500cf3b2ce438a "loplugin:unnecessaryparen when compiling as C++17, so the ParenExpr is no longer hidden behind ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in loplugin:unnecessaryparen. However, that would still not look through implicit CXXConstructExpr, so would still not have found the occurrences in 81892b2037453108b9bde1512a500cf3b2ce438a when compiling in pre-C++17 mode. Therefore, let ignoreAllImplicit also look through CXXConstructExpr. (I am not entirely sure in which situations non-implicit CXXConstructExpr---that should thus not be ignored---would occur, but assume they would be underneath something like a CXXFunctionalCastExpr, which is not ignored.) Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843
2017-10-23loplugin:includeform: sdextStephan Bergmann32-130/+130
Change-Id: Ieb9641b9846ecfed8d1a022a48defe7644405690
2017-10-23overload std::hash for OUString and OStringNoel Grandin7-18/+15
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17Move sdext/source/pdfimport/tree include files to common include directoryStephan Bergmann5-9/+9
...that are included from various source directories. Change done in preparation of loplugin:includeform. Change-Id: Ie46f4b940ceeb34fd8883dc17f56a072f625ee3a Reviewed-on: https://gerrit.libreoffice.org/43442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin5-7/+7
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-29loplugin:flatten check for throw in then clauseNoel Grandin2-15/+9
also make the plugin ignore the case where we have var decl's in the clause we want to flatten, which could lead to problematic extension of variable lifetime Change-Id: I3061f7104e8c6a460bf74f5eac325a516ec50c59 Reviewed-on: https://gerrit.libreoffice.org/42889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist6-16/+16
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-23loplugin:flatten in sdext..stocNoel Grandin2-103/+95
Change-Id: I460e813e20a691c53738373376d3363f553bbab2 Reviewed-on: https://gerrit.libreoffice.org/42636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-22Fresh run of bin/update_pch.shMike Kaganski2-7/+42
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-15Resolves: tdf#112408 crash with nan with bad ascentCaolán McNamara1-0/+3
bad ascent in the common case is probably fixed with tdf#107249 Change-Id: I0a06de06cb07277c50dcffd1b6a1121398e84e42 Reviewed-on: https://gerrit.libreoffice.org/42328 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-12clang-tidy modernize-use-emplace in sdNoel Grandin6-15/+14
Change-Id: I2e3000f7bd0f3beed8309e0e3dd18e6ed4b8feee Reviewed-on: https://gerrit.libreoffice.org/42184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-05Drop lazywrite property, which is silently ignored by configmgr anywayStephan Bergmann2-4/+2
...at least ever since the "new" configmgr reimplementation, 6b849a6aeeb9ea8b1e25e28d5a8be390e425f84e "#i101955# initial work in progress of a configmgr reimplementation (for now in an extra module 'configmgr2')" et al Change-Id: I43430d991647fb2e26762463d51175247db0604b
2017-08-31sdext: fix loplugin:constparams warningsMiklos Vajna1-4/+4
Change-Id: I1dd57031f8c83241ef4cfa5b22db7a34657ab0bd
2017-08-31class ViewDescriptor is unusedNoel Grandin1-6/+0
since commit 990691b144c1292f0263e0a8b8704b0ccbd7a168 Date: Mon Nov 23 09:58:38 2015 +0200 loplugin:unusedfields in sdext/ Change-Id: I89b7e59d37af8ba4093ca2e941219b29fd7bd726
2017-08-21Fix typosAndrea Gelmini1-1/+1
Change-Id: I3f3abc3c6e12536d4bc38f0c676d5fc20532a1e3 Reviewed-on: https://gerrit.libreoffice.org/41370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-18Fix typosAndrea Gelmini1-1/+1
Change-Id: If13c1408a3e597c6f9b21d209722ef6bc87c0c94 Reviewed-on: https://gerrit.libreoffice.org/41270 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11convert std::map::insert to std::map::emplace IINoel Grandin1-2/+1
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-03loplugin:checkunusedparams in variousNoel Grandin1-3/+1
Change-Id: I4f54940a9ebdcd47776b2a5f7bae6e49b633ee44 Reviewed-on: https://gerrit.libreoffice.org/40706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02remove unnecessary use of 'this->'Noel Grandin1-1/+1
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31loplugin:constparams in extensions,scripting,sdextNoel Grandin6-7/+7
Change-Id: I3d47e144db17358bf6e2e5e3f4ad29de888c01b1 Reviewed-on: https://gerrit.libreoffice.org/40583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31loplugin:oncevarNoel Grandin2-2/+2
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25use more comphelper::InitAnyPropertySequenceNoel Grandin2-24/+13
Found with: git grep -n -A10 'Sequence.*Any' -- *.cxx | grep -B5 -w PropertyValueProvider and: git grep -n 'Sequence.*Any.*( *&' Change-Id: Icb18c98bdd3f8352817e443ff78de5df042859ad Reviewed-on: https://gerrit.libreoffice.org/40389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-21de-hrc various thingsCaolán McNamara2-31/+5
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-18loplugin:constparams in sdextNoel Grandin13-30/+28
Change-Id: Ia5d2c00b02bf1758f7502065dd109f0f54fda2d3 Reviewed-on: https://gerrit.libreoffice.org/40124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14 use more OUString::operator== in scaddins..sdextNoel Grandin5-13/+13
Change-Id: I8bc5c925f940283bc54698bbcba77efcca883273 Reviewed-on: https://gerrit.libreoffice.org/39937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-13loplugin:oncevar: empty strings: sdextStephan Bergmann1-2/+1
Change-Id: I4685380e343370757cc9b9ebcc0af35c8918b1e3
2017-07-11replace 'resize(size+1)' with emplace_backNoel Grandin1-1/+1
which is considerably faster if we're dealing with a std::list, and just easier on the eyes if we're dealing with a std::vector Change-Id: I373689205ebc048689f29ab80a7ee8551b20cc96 Reviewed-on: https://gerrit.libreoffice.org/39816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-11simplify calls OUString::copy in foo.copy(x, foo.getLength() - x)Noel Grandin1-1/+1
Change-Id: I20318c77dcc3bc2a64336541ef5a3f412bfd9483 Reviewed-on: https://gerrit.libreoffice.org/39803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-11use more range-for on uno::SequenceNoel Grandin1-5/+3
Change-Id: Ifad32425d79be5a22d33d721bdc5fb993f699759 Reviewed-on: https://gerrit.libreoffice.org/39763 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin1-2/+2
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06use OString::operator== in preference to ::equalsNoel Grandin3-3/+3
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf Reviewed-on: https://gerrit.libreoffice.org/39646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-05loplugin:unnecessaryparenStephan Bergmann1-1/+1
Change-Id: Ifeacfc198c71ae1224ef38a4c8b95b31364f8227
2017-07-04loplugin:unusedfields in sdNoel Grandin3-7/+1
Change-Id: I42def3dc21ae1a18e1c98d1aeeff4ed4425e941a Reviewed-on: https://gerrit.libreoffice.org/39479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-02loplugin:casttovoid: sdextStephan Bergmann25-307/+114
Change-Id: I557d59a4bfb9cab17a2cb00c3a80f85a6ef9671b
2017-07-02Text::Paint rOffset parameter is unusedStephan Bergmann1-15/+4
...ever since the code's introduction with 89efcae67e166f88a0e63f51af146fdfc8e41edd "INTEGRATION: CWS presenterscreen" Change-Id: Idcf76dbfff67270ae12780d3e460e1fe39897c52
2017-07-02StyleAssociationContainer::ProcessStyleAssociation rReadContext unusedStephan Bergmann1-9/+3
...ever since the code's introduction with 405451ce720564a936341ca24868a8ba1138ea5f "INTEGRATION: CWS presenterview" Change-Id: I150803e64c44046cbec1e268d04ad510b17fb295
2017-07-02PresenterTheme::Theme::ProcessFont rReadContext parameter is unusedStephan Bergmann1-5/+2
...ever since the code's introduction with fdc701b1e152dfce94f880099b8d1a04f36671d6 "INTEGRATION: CWS presenterscreen" Change-Id: I7fd71ccd034b21439b375a8df843c3306a30c6ac
2017-07-02PresenterSlideSorter::SetActiveState does nothingStephan Bergmann5-23/+0
...ever since d3ff78188fd08422586e7a884a31e185ecdde34c "INTEGRATION: CWS presenterscreen" Change-Id: Ideca940c514c60188040d5ebe75b95cc4f2b816b
2017-06-27Remove unused ItemProcessor argumentStephan Bergmann5-25/+9
Change-Id: Ie650f8c046f60a749999e1819edb5abad79e5362
2017-06-27PresenterPaneBorderPainter::Renderer::PaintBitmap rpBackgroundBitmap is unusedStephan Bergmann1-21/+13
...ever since 4d91841e0bc18d5b01fe85eb03eb0be589cf0c74 "INTEGRATION: CWS presenterscreen". (But PresenterTheme::GetBitmap is called with "Background" at least also from PresenterWindowManager::SetTheme in sdext/source/presenter/PresenterWindowManager.cxx, so that code cannot be cleaned away.) Change-Id: I2cdf96ce4d27af2d0beca51e5769fbf148973431
2017-06-27PresenterPaneBase::PaintBorderBackground does nothingStephan Bergmann2-32/+1
...ever since 1eeb7358933afbb8d673c16c92bfd8492e8b5620 "INTEGRATION: CWS presenterscreen" Change-Id: Ibb5bf69eb3d11aa3c3b67ed0b342ca95ecf40bfe