summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2020-03-17pdfium: Make Insert -> Image... use VectorGraphicData for PDF.Jan Holesovsky2-12/+12
In principle, the current Svg/Emf/Wmf and PDF handling is trying to achieve the same thing: Keep the original stream untouched, provide a replacement graphics, and a kind of rendering. To hold the data, the Svg/Emf/Wmf and PDF were using different structures though. This commit consolidatates that, and makes the Insert -> Image... (for PDF) actually using the VectorGraphicData to hold the original stream. This breaks loading the PDF as a document via PDFium - I'll fix it in the next commit(s). Change-Id: Iac102f32b757390a03438c165e430283851cc10b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90561 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-17sd lok: Implement execution of SID_SPELLCHECK_APPLY_SUGGESTIONTamás Zolnai2-0/+27
Used by online spellchecking context menu. Change-Id: I9d7430b4ef45af1641fc985cf4588d45ba497ee9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90598 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17sd lok: Implement execution of SID_SPELLCHECK_IGNORE_ALLTamás Zolnai2-0/+27
Used by online spellchecking context menu. Change-Id: Iad3dafedbfed1605ba06f7f87ed91117c9b1a8e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90597 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17sd lok: Implement execution of SID_LANGUAGE_STATUS...Tamás Zolnai1-8/+56
Also for selection and paragraph which is used by the spellchecking context menu. Change-Id: Ie242175605185b3083aa529b54acc183aee1d47b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90596 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-16remove unnecessary Window::Update() calls, which immediately follow InvalidateNoel Grandin1-1/+0
Update() is effectively "paint immediately". Rather just let the invalidate do it's thing and have the widget paint on the next paint loop, along with the rest of the stuff. This is probably mostly cargo-cult, from the days when our invalidate/paint timer could take a long time to kick in. Change-Id: Idff06526e9a2892244cfd8ce6947916032b0d1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90567 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2020-03-15editeng: lok: send cursor visibility event when restoring update modeAshod Nakashian1-1/+184
When the default text is removed from a TextBox within a slide, the cursor visibility is inadvertendly set to false and never restored (because the LOK notification is disabled due to treating the ShowCursor during SetUpdateMode as an activation of the TextBox, and that is supressed to avoid messing up the cursor when creating a new view). We add a new flag to SetUpdateMode to flag whether this is an activation or we are restoring a previously active window (TextBox) due to a temporary disabling (to clear the default text). Four unit-tests added not just to check and validate the fix, but to also simulate two different ways of entering edit mode, first by single-clicking on the text and then double-clicking outside the text, but within the TextBox. Change-Id: Icaaabc2a897f614f5ce162b71fadccff22ecda02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90301 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 6b84dfabbb5f6930f9ac582f8c1dd9f467fd068c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90298 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-12Revert "loplugin:constfields in sd"Noel Grandin96-210/+210
This reverts commit 453879cfd8f4a8e22847043231a0929e4d50f238. Change-Id: Ic542fd6b1f09d71d8e6c9530198fe45151d75e16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-10tdf#61274 sd PDF export: fix links ending up on wrong pages with hidden slidesMiklos Vajna1-0/+8
SdPage::IsExcluded() decides if a slide is hidden, SdXImpressDocument::render() checks for this and returns early if needed. In that case PDFExport::ExportSelection() detects that the produced metafile has no actions and avoids creating a PDF page. Then Impress links are created using the vcl::PDFExtOutDevData::CreateLink() call in drawinglayer::processor2d::VclMetafileProcessor2D::processTextHierarchyFieldPrimitive2D(), not specifying the PDF page number explicitly. This means the link is created on the "current" page number, set in vcl::PDFExtOutDevData::SetCurrentPageNumber(), called by PDFExport::ExportSelection(), but that filter/ code can't know about hidden slides in sd/. Fix the problem by setting the page number again in SdXImpressDocument::render(), that way the link created by drawinglayer will end on the correct page. Change-Id: Ic29e345d45bc7c944d65e6e450f1d742dd0e9f8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90299 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-09tdf#131208 Don't try to set cursor focus after style applyJim Raykowski1-1/+1
It seems after a style is applied, the outliner view pointer points to an OutlinerView that has been removed. This results in a crash when trying to access OutlinerView functions to set cursor focus to the document. Avoid this by checking if a style has just been applied. Change-Id: Idda11567506fcc60a830dce70b86e12e2079c7a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90198 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-03-09improve loplugin:unusedfieldsNoel Grandin14-28/+14
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-07clang-format sd with under 5-percent lines of changeMuhammet Kara10-39/+43
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I08c01d7069b041964614c233d452d70f332228f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90145 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-06Regression from 6d9930f307f08d2c32ee1bcca577cf643955cec9Julien Nabet1-1/+1
Thank you Caolán ! Change-Id: I3f93b4de15c6154c5cf709f5f708dfcb4c3cd5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90135 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-06tdf#131137: Fix Checkbox "Do not distort objects in curve" does nothingJulien Nabet3-7/+11
See https://bugs.documentfoundation.org/show_bug.cgi?id=131137#c3 and above all https://bugs.documentfoundation.org/show_bug.cgi?id=131137#c4 Change-Id: Ibd38d13be7ef6956d6c26e6f5f71a6751a56b25e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90054 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I818852494e26a3a12b7210c8c3a06890759fa580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89957 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-04tdf#131033 consider 20° tilt of 3D in 2D projectionRegina Henschel2-0/+26
Error was, that the default 20° tilt of a newly created 3D scene was not applied to the rectangle for the 2D projection and therefore the projection was not high enough. The used method is the same as used when dragging a scene to tilt it. I don't know whether there exists a simpler way. Change-Id: Ic9745cc17ed520cd9e00b123e235fe0e93100073 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89901 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-03-04tdf#125757 Impress context menu add animation commandandreas kainz14-0/+14
Change-Id: I8d063fc432506fd620e99f561bca37c3dfb5a01e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89934 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-03-04Impress context menu add slide transition and slide move/navigateandreas kainz1-0/+18
Change-Id: I7168701de59f4b625f1ca5bb2fc9d06f521c681d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89935 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-03-04tdf#120705 Impress/Draw multiselect context menu add ExportToandreas kainz2-0/+4
Change-Id: Id8b8e8d1676260d4a075166156c60965242c9fd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89936 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-03-03Fix typoAndrea Gelmini1-2/+2
Change-Id: Idd102b386c19ed699761428b3347f438a42a1878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89898 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-03Removed execution bit on pptx fileAndrea Gelmini1-0/+0
Change-Id: I003dd9e82e7ee5924064e34306de1abed8cdf4ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89899 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-03tdf#80194 editeng: fix auto subscript calculationsJustin Luth2-0/+424
...and auto superscript too (although not as noticably). THIS WILL CHANGE THE POSITION OF EDITENG SUBSCRIPTS AND SUPERSCRIPTS IN EXISTING DOCUMENTS! That is because they were very poorly placed before - using a formula that is very different from how Writer does it. Everyone in the bug reports indicates that Writer does it good, but Impress does it really bad. (tdf#89849, tdf#63083) FOR EXAMPLE, when the char-size is reduced to the default OF 58%, it will now be raised by 33%, not 42%. Likewise, the subscript will now be lowered by 8%, not 42%. THIS AFFECTS/FIXES Writer textboxes, Calc, Draw/Impress. "Automatic" indicates that there is not a "correct" answer, but that the computer should make it "look good", so the user should be able to accept this change in positioning, as long as it looks good. The number of documents affected might be less than one would expect. By default .uno:SuperScript does NOT set auto mode (although Format-Character does). Since most people would use the toolbar instead of the format menu to create a superscript, auto will be rare. So there will be relatively few cases where subscripts are automatic in editeng, especially since it looks so poor that most people probably turned automatic off... This patch has no effect on non-automatic escapement. It uses the same fomula that calculated DFLT_ESC_SUB (since it isn't an arbitrarily chosen value). This is an approximation of the formula that Writer uses (since Writer does exact calculations based on each font's metrics). This Writer-inspired formula was introduced in LO 6.4 for more accurate exporting to MSO word processing formats (tdf#127316). Change-Id: I0267810efe31a2b3be41bf2d39e2278ce9bc99e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88911 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-03-03tdf#101181 Implement glow effect on shapesTamas Bunth3-0/+37
Glow effect is a color-blurred outline outside of the shape. In ooxml document it is specified with the <a:glow> element. The commit contains the following: - Add support for importing and exporting <a:glow> from ooxml documents. - Assign new properties to XShape which stores glow-related attributes. - A new 2D primitive is introduced in module 'drawinglayer' which is responsible for representing the glow primitive which is to be rendered. + A glow primitive is a clone of the original shape which has been scaled up slightly and a new color has been assigned to it. The radius of the glow effect and the color is defined in the <a:glow> element being imported. - A blur algorithm is introduced in module 'vcl', which is called during rendering the primitive. + The blur algorithm works on a bitmap. + Since the algorithm is CPU-intensive, the result is cached in the processor and it is recalculated only if needed. - Add support for importing and exporting glow effect to ODF format. For that, new attributes of element <style:graphic-properties> has been added: + loext:glow, which can have the values "visible" or "hidden" + loext:glow-radius: which holds the radius of the glow effect in cm. + loext:glow-color: holds the color of the glow effect - Tests have been added to assert properties after pptx import and export. Change-Id: I836aeb5e0f24e2c8d5725834c8c0f98083bc82e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89125 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2020-03-02tdf#118893: avoid nullptr dereferenceMike Kaganski1-1/+1
Change-Id: I56ada18348ed1b1ebe5e1d6f000391965d822b4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89815 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-01lok: Set default text for new text box on mobileMuhammet Kara2-0/+4
Change-Id: I0b6056e9dbf5fb81d092092cc183b05120b95d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89352 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89710 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-01cid#1459028 various checked_return warningsCaolán McNamara1-1/+1
and cid#1459027, cid#1459026, cid#1459025, cid#1459024, cid#1459021, cid#1459018 Change-Id: If92e7665fcf947c5daf3094b9003e85c5c51f48f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89763 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-01cid#1459022 Uninitialized membersCaolán McNamara1-0/+1
Change-Id: I672c55ac562836f5ca7fe9e8c6a9d313dbbc40a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89762 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-29tdf#130988 add y-axis up<->down in create 3D objRegina Henschel2-0/+26
Creating the matrix aLatheMat uses a coordinate system with y-axis pointing up, but aPolyPoly2D and ctor of E3dLatheObj uses y-axis pointing down. Converting was missing. The error was inherited from OOo2. Change-Id: Id5b2f769b8f940bd0028d0386d7ce8b80bf17b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89730 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-02-28weld calc navigatorCaolán McNamara2-2/+3
note: non-standard dnd via parent so the treeview triggers the dnd but doesn't itself strictly speaking drive the dnd, see copying a range from the navigator where the calc main edit window shows the outline where the copy of the range from the calc main window will go Change-Id: Ideecbe779e3d9bb5b392357a93ec25f625180ba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-28android: Hardcode the 'double-tap' in case of the native app.Jan Holesovsky2-12/+34
We know we are mobile, so why bother... We could go even further, and do that directly in the comphelper, but that would need more testing I guess. Change-Id: Ia371d42fe0e31b5c6f17313fbf6baad4c256cbe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89236 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89695 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-28tdf#43157: Clean up OSL_ASSERT, DBG_ASSERT, etc.Pelin Kuran1-6/+5
Change-Id: I07bafce9360ea06bf7053f1c1f76a0e2a9559079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89256 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-02-27convert AnimationImport to fast-parser APIsNoel Grandin1-1/+1
And... (*) space out the namespace constant values so I dont keep forgetting and making them overlap. (*) Remove CreateDocumentContext from SvXMLImport since it is now unused. Change-Id: I30f54bfc1389e91b18e4fee8b83e1b297419899b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27Related: tdf#130725: use strtod also in rtl::math::stringToDoubleMike Kaganski1-1/+1
Size of buffer on stack is 256 characters. Logging function usage in make check, of >1 100 000 invocations, the longest string was 80 characters, average being 4.6 characters. So heap allocation is unlikely in scenarios with intensive function usage. Several existing unit tests had to be fixed. Usually, the change is either minimal or getting closer to what Excel returns (for Calc tests). But in case of AMORDEGRC, I had to change rate value passed to the function from 0.3 to 0.31. It's because the closest double value for 0.3 is 0.29999999999999999, which is a bit less than 0.3; multiplied by 1.5, this gives 0.44999999999999996, and then rounding the result of multiplication of the latter by cost gave the result 1 less than before, when 0.3 was imported as 0.30000000000000004. Now the function returns a value 1 less than Excel for that set of arguments. I don't see how to fix that. Having rate slightly different gives consistent result between Calc and Excel. Change-Id: Icae5ce374fe0c31a1aa10cee815e65ef0014f382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89422 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-26weld impress navigatorCaolán McNamara17-1527/+785
complicated by the effort to keep the non-standard behaviour of commit f3c68cdf8f6a0273c62b493552f78af0138a44e8 Date: Wed Feb 21 17:27:53 2018 +0100 tdf#115873 sd navigator: allow selecting but not focusing on objects and the self-dnd code Change-Id: I29c224739463d1d44690f30ed29db3fe2b16b4a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89045 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-26tdf#129532 tdf#98839 fixes for mirror of custom shapesRegina Henschel2-1/+30
tdf#98839 In case a sheared custom shape was mirrored, the shear angle in draw:transform had a wrong sign in the saved file. tdf#129532 Mirroring given in draw:transform in file or via macro was wrongly applied. Errors: 1)Mirroring from draw:transform attribute had overwritten already existing mirroring in the enhanced-geometry. 2)Mirroring from draw:transform attribute was set in enhanced- geometry attributes but not really applied. Change-Id: Ifa52f3606b5a33e6492a02d6e19c883d28752da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85670 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-25inherit SdTransferable from TransferDataContainer instead of TransferableHelperCaolán McNamara1-1/+1
Change-Id: I0c3628e5e280e8060f0e6890902253ad455d6293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25loplugin:referencecastingNoel Grandin4-46/+26
getting --enable-pch=normal working with clang means that the plugins now have a better view on some stuff, so trigger more warnings Change-Id: I83ca010c0ef07c8106068362bb50a354e3cf7dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-24IsDropFormatSupported(...::SIMPLE_FILE) is always falseCaolán McNamara1-46/+16
for this navigator as far as I can tell so reduce accordingly Change-Id: I8c8b62487d6aa94114c523d8d4a9ebb71a0896c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-24workaround GCC 9.2.1 -Og -Werror=maybe-uninitializedMichael Stahl1-4/+10
vcl/unx/generic/gdi/salbmp.cxx:727:32: error: ‘pixmapHandle’ may be used uninitialized in this function [-Werror=maybe-uninitialized] vcl/unx/gtk3/gtk3gtkinst.cxx:7336:16: error: ‘eRet’ may be used uninitialized in this function [-Werror=maybe-uninitialized] etc. One looks like it might occur in practice. Change-Id: I09af7d36b134b31cb7bd8047b5c73f4a49c9d9b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89351 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-24tdf#130717 Adding 3D Window option to Format MenuShivam Kumar Singh1-0/+1
Change-Id: Iae57419519ea0ff43549c9283e591e2d76eea7ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89237 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-24tdf#130716 Adding Connector option to Format menuShivam Kumar Singh1-0/+1
Change-Id: I39a1ebc1ffe91a1fbc036033f95ea6c4d4d885bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89234 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-24tdf130839: Corrects second level left margin in SmartartGülşah Köse1-4/+15
Change-Id: Ifec339759427336fd53012e0a8a906d240be9654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89085 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann7-15/+15
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20uitest: forgot to uncomment this lineXisco Fauli1-1/+1
introduced in ae17b8481532fa192f3f93a6dcf687fed394cf58 Thanks to Stephan for pointing out Change-Id: I4124762e4cb600773e4f471a10a8b4736434679f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89075 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-20uitest: comment out problematic assertXisco Fauli1-2/+3
> The new test appears to be unreliable. At least > <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/28839/>, > <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/28823/>, and > <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/28822/> all failed > with > > > FAIL: test_run (tdf130440.tdf129346) > > ---------------------------------------------------------------------- > > Traceback (most recent call last): > > File "/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/sd/qa/uitest/impress_tests/tdf130440.py", line 34, in test_run > > self.assertEqual(document.CurrentController.getCurrentPage().Number, 2) > > AssertionError: 1 != 2 7ed602a3b8c0ffe922b4f082cd4cdaa5a8f0d64c aimed to fix it but it still fails sometimes I believe it fails because both slides are selected at the same time in the slide pane. Change-Id: Ie9757d1122e278b0d49ca9a09caf1765d2df154d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89048 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-20tdf#130776 Show the bullet on second level in smartart.Gülşah Köse2-0/+26
Change-Id: Ie35867862d30d490a97dc6f245b50c7311dafe50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88993 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-02-19set correct initial drag imageCaolán McNamara1-0/+2
Change-Id: Ic2ec18432de7a73356e12c46b7e70ecae8c0ffb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19Resolves: tdf#129446 explicitly pass the mouse event windowCaolán McNamara1-1/+1
instead of letting it pick the main-window as the event window Change-Id: I953968025717ac5ba6f41e8f2db90c9f4d24800f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89015 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara2-4/+3
Change-Id: I636eb7bfd0c1d523751661a35edaa30181491de1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17sd: Unit test to check the fill style of odg object.Shivam Kumar Singh2-0/+15
Checks if the Fill Style is FillStyle_NONE . Change-Id: Ib2aff22fe9a4bcf9b483b7e3ac77df7bddf9415c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87440 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-17Resolves tdf#129032 - Missing warning when renaming pageHeiko Tietze3-0/+8
Edit field has type normal or error now Edit field and okay button return feedback per tooltip Change-Id: Ib2caf3280227cb00af25889ed111503745b471dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85101 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 07:32:19 +0000