summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2017-12-17tdf#91857 Round of improvements to Impress's menus for 6.0Yousuf Philips1-29/+39
Change-Id: I844b8396a55820da904d4813cbb84c56c33af51c Reviewed-on: https://gerrit.libreoffice.org/46583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-17coverity#1426171 Unchecked dynamic_castCaolán McNamara1-40/+44
and coverity#1426170 Unchecked dynamic_cast coverity#1426164 Unchecked dynamic_cast coverity#1426165 Unchecked dynamic_cast and duplicated lines look like cnp gone wrong Change-Id: I195204e9d0a4d591fbe210241203a17b22b25ec1 Reviewed-on: https://gerrit.libreoffice.org/46603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-16sal_uIntPtr->SfxItemPropertyMapEntry* in SdExtPropertySetInfoCacheNoel Grandin2-2/+3
Change-Id: I65d284cc1fbc013a17d4bb2f0dd7d7d8d3ccf56f Reviewed-on: https://gerrit.libreoffice.org/46507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16convert EETextFormat to scoped enumNoel Grandin3-12/+12
and drop unused BIN constant Change-Id: I4ecda96f39147f7e9bceb11ecdb4f0ffe42d2053 Reviewed-on: https://gerrit.libreoffice.org/46589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15sal_uIntPtr/sal_uLong->void* in Popover idsNoel Grandin2-4/+4
Change-Id: Ifd7eeadeacffb90ea303c1e6bca807d310098f66 Reviewed-on: https://gerrit.libreoffice.org/46484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15tdf113594: marking gluepoints immediately.Mark Hung1-1/+1
pPV was for the parameter of MarkGluePoint that was removed in ec38966951f2, and was kept somehow and is converted to bool here. Just replace the default boolean value to false ( that means marking instead of unmarking. ) Change-Id: I4c4b9dd368537b7b90cc4effae482a7b8a41eec9 Reviewed-on: https://gerrit.libreoffice.org/46472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15tdf#114477: Can't set character highlighting on a text box using sidebarTamás Zolnai1-0/+10
Change-Id: I9ef9d6dacc87fb26351eae5eaedd72fd0a081672 Reviewed-on: https://gerrit.libreoffice.org/46494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-14tdf#81475 Organize the form toolbarsYousuf Philips4-48/+44
Change-Id: Ic79b326c4c15f656ce533eb37bbd27853b8f4af7 Reviewed-on: https://gerrit.libreoffice.org/43861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-13tools: reimplement SVLIBRARY macro & remove it from solar.hMichael Stahl1-0/+1
Change-Id: I03f8f5fd656d62410821f2f2851f1c584c97d1f4
2017-12-13tools: remove unused #include from solar.hMichael Stahl3-0/+3
Change-Id: I214e13add371380701ae39403d90a574a63e495d
2017-12-13tdf#114310 Removed '(in current document)' from compatibility optionsHeiko Tietze1-1/+1
Change-Id: Ie91ca2c9aac9b3ab7ca103bf2e6b55d453255d77 Reviewed-on: https://gerrit.libreoffice.org/46242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-12-13use std::unique_ptr in SdrModelNoel Grandin1-1/+1
Change-Id: I1475a12b600fdb693bad71d27dc628992b92588a Reviewed-on: https://gerrit.libreoffice.org/46346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13sal_uIntPtr->sal_Int32 in SdrMarkViewNoel Grandin8-18/+18
Change-Id: Iec5c9e45ec753de98142615fdde16f61c393a6e2 Reviewed-on: https://gerrit.libreoffice.org/46311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13sal_uIntPtr->sal_Int32 in SdrDragStatNoel Grandin2-2/+2
also fix the X& X() methods to be normal void SetX(X const &) methods Change-Id: Id2999b09535ce560110eda646d3d5bbbedf87326 Reviewed-on: https://gerrit.libreoffice.org/46309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11Fix typos and grammarIlmari Lauhakangas2-2/+2
Change-Id: I4143da3c5a809118d57849664f6ab1d2e775837f Reviewed-on: https://gerrit.libreoffice.org/46253 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-11loplugin:salcall fix functionsNoel Grandin33-51/+51
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10remove unused osl/time.h includes ..Jochen Nitschke1-2/+0
and some more in base64.cxx Change-Id: I31c9f23d3bd11f5482774e976a7c40025ffcfb86 Reviewed-on: https://gerrit.libreoffice.org/46157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08GetMarkableObjCount() is only compared against 1Matteo Casalin1-1/+1
Change-Id: I390b260fe481c7db73a065dd271c78a5df188ccc
2017-12-08tdf#68759 PPTX: Export IsMirroredPaul Trojahn2-0/+21
Change-Id: I6bab00f79f1cb122344e4bb9fd62eb4c48a1838b Reviewed-on: https://gerrit.libreoffice.org/45808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-07lokit: add .uno:DocumentRepair commandHenry Castro2-1/+55
Change-Id: I5b13ea6f4785bc91c29111fa63c4a1b0ea9b2660 Reviewed-on: https://gerrit.libreoffice.org/38908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-07tdf#89466 Fix minor localization bugsYousuf Philips3-6/+8
Change-Id: I1ee93f81dcd83b5a9277ea444ec8e10db7d790df Reviewed-on: https://gerrit.libreoffice.org/45958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-07tdf#57950 replaced some O(U)StringBuffer::append() with operator+ekuiitr1-3/+1
Change-Id: Idd32e3f68787186c157ba7382cab39b0b974ac20 Reviewed-on: https://gerrit.libreoffice.org/45879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:constparamsNoel Grandin2-2/+2
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b Reviewed-on: https://gerrit.libreoffice.org/45959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann2-0/+2
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06tdf#114207 create commands for slide number and slide fieldsYousuf Philips1-4/+4
Change-Id: I5b7cfaf602568d9254dfeafd6afe27b9b0895d37 Reviewed-on: https://gerrit.libreoffice.org/45722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-06tdf#101014 Keyboard between textboxes - part 2Marina Latini1-2/+2
Fixed the a11y issue in layout AUTOLAYOUT_TITLE_2CONTENT_CONTENT now the selection via keyboard works as requested Change-Id: I034776393c8cca68d5cb3702f12111a057d4134b Reviewed-on: https://gerrit.libreoffice.org/45907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-06coverity#1401328 Uncaught exceptionCaolán McNamara1-1/+2
Change-Id: I358b3c410bc7871c7184da4959b24b9f52b4a4d7 Reviewed-on: https://gerrit.libreoffice.org/45892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06loplugin:salcall handle virtual methodsNoel Grandin1-2/+2
Change-Id: Iab95db31188ea2914a46d63a7ebef3d825e6ec42 Reviewed-on: https://gerrit.libreoffice.org/45851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05tdf#113856 Navigator: Bad behaviour of controllers when changing slidesmartinb2141-0/+1
Change-Id: I11e9cb607c36112f19f7cace1d8c5b7559ebf2a1 Reviewed-on: https://gerrit.libreoffice.org/45423 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I085d0346d6f7aebc6e685bc1c2407535eb227dfc Reviewed-on: https://gerrit.libreoffice.org/45835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin6-6/+6
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05loplugin:countusersofdefaultparams in editeng..packageNoel Grandin1-2/+2
Change-Id: I4c20235a04d9ab5ea5edbb6b1b2413677b18a305 Reviewed-on: https://gerrit.libreoffice.org/45795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05remove some unused definesNoel Grandin2-6/+0
and move the script to python Change-Id: I97bca04053d9d38b59c74fcf61caafbc2c137cc9 Reviewed-on: https://gerrit.libreoffice.org/45776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04silence coverity#1405937 Uncaught exceptionCaolán McNamara1-2/+5
Change-Id: I40e9827f1ff2fb7f5121da95c4f502de11f3f612 Reviewed-on: https://gerrit.libreoffice.org/45760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-04new loplugin salcall: remove unnecessary SAL_CALLNoel Grandin1-2/+2
In this first commit, I use the plugin to verify the consistency of our SAL_CALL annotations. The point being to make the next commit more mechanical in nature, purely using the rewriter. There are various chunks of unix-only code that have never had to be compiled by MSVC, hence the inconsistencies. In bridges, I had to inline some typedefs to make the verification code happy, since it cannot see into typedefs. Change-Id: Iec6e274bed857febf7295cfcf5e9f21fe4a34da0 Reviewed-on: https://gerrit.libreoffice.org/45502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-03fixed interface domain.Kiyotaka Nishibori2-2/+2
translatable strings in sd/uiconfig/simpress/ui/*.ui are extracted as parts of 'pot/sd/messages.pot'. the domains should not be 'sw' but 'sd'. Change-Id: I59bf51c5c329988c1c75cb82e518250ff1eccde7 Reviewed-on: https://gerrit.libreoffice.org/45588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-01tdf#101014 Keyboard navigation between textboxesMarina Latini1-4/+4
The tab sequence in layouts AUTOLAYOUT_TITLE_4CONTENT and AUTOLAYOUT_TITLE_6CONTENT has been modified from left to right on each line for a better a11y Change-Id: I92379358860d6866414ceda430a9bd90b63e2743 Reviewed-on: https://gerrit.libreoffice.org/45638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-01Use for-range loops in ViewShellManager (sd)Julien Nabet1-23/+14
Change-Id: I753e3536b18bae5a162f78a8e30dc3bd89fa80a3 Reviewed-on: https://gerrit.libreoffice.org/45620 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-30silence various coverity warningsCaolán McNamara2-3/+4
Change-Id: I9ac4c179c30efa9d5950aa2106639d3781dd0308 Reviewed-on: https://gerrit.libreoffice.org/45583 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30coverity#1424266 Uncaught exceptionCaolán McNamara1-1/+2
Change-Id: I63b04fba25b09753baa1dd1cac18f44860cdb264 Reviewed-on: https://gerrit.libreoffice.org/45581 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30loplugin:unnecessaryparen: signed numeric literalsStephan Bergmann1-1/+1
Change-Id: I75c8224452ca9c3711a2ccaca9ecf549fa59cb64 Reviewed-on: https://gerrit.libreoffice.org/45549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30catch IllegalArgumentException tooCaolán McNamara1-0/+3
Change-Id: Ib34bb87d94f8cc6d381e65ffbfe186e8d76d4e83 Reviewed-on: https://gerrit.libreoffice.org/45587 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30catch SAXException in pptx testingCaolán McNamara1-0/+3
Change-Id: I9379ae268d5c42723a34d6f9e677fe800873ebfa Reviewed-on: https://gerrit.libreoffice.org/45580 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29tdf#76646 don't open link on Ctrl-click if not requiredSzymon Kłos1-0/+2
Change-Id: Ie081f8144e50f576b9f8acb2ddd5b1c891533964 Reviewed-on: https://gerrit.libreoffice.org/45499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-29tdf#76646 Ctrl-click required for hyperlinks in draw/impressSzymon Kłos1-0/+6
If "Ctrl-click required to follow hyperlinks" is set in Options -> LibreOffice -> Security -> Options open the link only with Ctrl key pressed. Change-Id: Icf57b4deedabd51f31f04021ba3f6bddc3829931 Reviewed-on: https://gerrit.libreoffice.org/45437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-29add pptx support to fftesterCaolán McNamara1-0/+45
Change-Id: I517fa449ec75d8817cc3e03d0d90ab4c289a7c0f Reviewed-on: https://gerrit.libreoffice.org/45477 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29lokdialog: Move the LOKWindowId <-> VclPtr<Window> mapping to Window.Jan Holesovsky2-9/+0
This allows registering & de-registering of non-sfx windows too, and makes the Calc autofilter popup to appear. Change-Id: I7cbbe94d208115aabcb6fa5f964646c7b7ce4c93
2017-11-29lokdialog: Move the painting down to Window, and enable Calc and Impress.Jan Holesovsky2-0/+9
Tested with .uno:FormatCellDialog in Calc, Impress not tested. Change-Id: I6d911c29616988db0625be9e2a63cf2172c69ee8
2017-11-29loplugin:countusersofdefaultparams in sdNoel Grandin16-21/+21
Change-Id: I6eb55d450d02615526e78fb69337c66c840ef8a3 Reviewed-on: https://gerrit.libreoffice.org/45463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28coverity#1421075 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I23463d4610f886d5c817f3682e08c0f683c8de98 Reviewed-on: https://gerrit.libreoffice.org/45395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>