summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2020-01-07tdf#107604 Handle predefined table styles.Gülşah Köse2-0/+30
Handle table styles that we have just style-id and have not corresponding style defination in tableStyle.xml Change-Id: Id06f5508d5eb1330b5bac1634c520c3066c09139 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86068 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86326
2019-12-16Resolves: tdf#129346 if nothing currently selected, select somethingCaolán McNamara1-1/+7
in the slidesorter Change-Id: I66853ba56eab93dfb18de7496212eb64e97cd2bf Reviewed-on: https://gerrit.libreoffice.org/85131 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-29tdf#127090 Export textbox rotation attribute.Gülşah Köse2-0/+14
In case "rotated textbox in a custom shape" handle draw:text-rotate-angle attribute while exporting ODP to PPTX. Change-Id: I13b99da586af5e77e51a7cc93a751ab21bed7170 Reviewed-on: https://gerrit.libreoffice.org/83888 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84023 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-28tdf#113198 set default shape paragraph alignment..Tamas Bunth2-2/+14
to center when importing oox document. Using MS Office, the default aligment of a (text) paragraph inside a shape is centered. Reviewed-on: https://gerrit.libreoffice.org/83193 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 89f0af144c18efafe2573801641689a1432c0cae) Reviewed-on: https://gerrit.libreoffice.org/83971 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Change-Id: Id9bcaaab109df65f4124f733b2cfee438e82b79b Reviewed-on: https://gerrit.libreoffice.org/83988 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-22tdf#128952 Set the position of shape for 180 deg.Gülşah Köse2-0/+17
If the rotation value is 180, 540, 900... degree with mirror pShape->GetRotateAngle() returns 0. In that control 0 means no rotation but that is not true. For that cases (180, 540, 900) after the angle conversition GetRotateAngle() returns 0. We should recalculate the position for 0 too. Change-Id: I14e981235b2d6cd8382d4c9e151bccd2e73a3fd9 Reviewed-on: https://gerrit.libreoffice.org/83468 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit aca2e4d270f472b2cbdb9084a55f1855529ea705) Reviewed-on: https://gerrit.libreoffice.org/83535 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-20tdf#125449 follow-up: unique gradient names in Impress area dlgKatarina Behrens1-0/+10
as seen in tdf#94300 chart prefers to name anonymous (non-preset) gradients all by itself However tdf#99908 shows that ODF import doesn't like anonymous gradients. This is a bug in xmloff style import and should eventually be fixed there. Here we implement the same band-aid solution tdf#99908 implements for Impress sidebar Change-Id: Ia39f581aee875ac95faa5c502a3479ed5d7974d8 Reviewed-on: https://gerrit.libreoffice.org/82522 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 34a3afecaaab3dc4898b33e0981d8b231351fe37) Reviewed-on: https://gerrit.libreoffice.org/83185 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit c00775925325b04b3d707df0d494464f864f6fc0) Reviewed-on: https://gerrit.libreoffice.org/83286
2019-11-17tdf128684: Rotate text in not preset custom shapeTamas Bunth2-0/+29
The TextPreRotateAngle property should be set in case of a not preset custom shape as well during ooxml import. Also add unit test for testing the TextPreRotateAngle property. Change-Id: Ib5b822286f8a78fe8398bf7e2014a36d7e0a24d5 Reviewed-on: https://gerrit.libreoffice.org/82643 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/83021 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-09Fix tdf#124708: CRASH: Selecting all and deletingMuhammet Kara1-2/+6
Change-Id: I0de912dad97f266a56ab52a351b0676f17675ed5 Reviewed-on: https://gerrit.libreoffice.org/82332 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit 8023a613e978be42758c88d23f1973f7b9661676) Reviewed-on: https://gerrit.libreoffice.org/82354
2019-11-07Resolves: tdf#128631 dispatch active ole asyncCaolán McNamara1-9/+6
like we do for the other things that might create dialogs Change-Id: I31ca267526ddeac8d0c7163af45c11be7750cb4c Reviewed-on: https://gerrit.libreoffice.org/82144 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-01Resolves: tdf#128476 limit sidebar navigation panel file name combobox widthCaolán McNamara1-0/+1
Change-Id: I81549ada6f6b736ad54e18a4fec6807b8d0412af Reviewed-on: https://gerrit.libreoffice.org/81876 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-10-31The Bluetooth code doesn't compile with macOS SDK 10.15Tor Lillqvist1-1/+4
Change-Id: I8fffa4cef9628e6872c881cd0cbdfe85495fa324 (cherry picked from commit 1e95c8dd006147f7a94e24135396277ee2f469b8) Reviewed-on: https://gerrit.libreoffice.org/81772 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-30tdf#126060 Handle text camera z rotation while pptx import.Gülşah Köse7-0/+121
Reviewed-on: https://gerrit.libreoffice.org/80587 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> tdf#128209 Add check for crash handling 3D rotation. Handling text 3D z rotation works only for custom shapes. Prevent to use it for other services. Reviewed-on: https://gerrit.libreoffice.org/80974 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> 49e0127419dbad8a75f1899db02115a2fe54aacd Change-Id: Ifa4589fb50affc4c5ffb52288db8533c98ec6dd9 Reviewed-on: https://gerrit.libreoffice.org/80928 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-29tdf#126324 pptx unit test for custom date importTamas Bunth2-0/+17
Add unit test for importing custom date field (<c:fld> element of type "datetime") Change-Id: Ifcb5641c99eeb79afe54b801750e68792880c000 Reviewed-on: https://gerrit.libreoffice.org/81684 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-24Resolves: tdf#128313 disambiguate flow-to search resultsCaolán McNamara2-5/+4
for a11y between find/replace where our result is a single thing, and find-all/replace-all where the result is potentially many things, which allows that searching in a selected calc column will flow-to the current cell, not the entire ~infinite set of cells in the column plus commit... put together the 'magic' flow-to constants as a side note, there's no actual use of FORSPELLCHECKFLOWTO anywhere that I can see Change-Id: Ib3e56fceb90d869f157427f090cdffe986a5a588 Reviewed-on: https://gerrit.libreoffice.org/81397 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-18tdf#127901: pptx export image greyscale, watermark, black/whiteXisco Fauli2-0/+21
Similar to 0db96caf0fcce09b87621c11b584a6d81cc7df86 Change-Id: I5c3ec17c7a3472629ba8a63ab500175add36ee8e Reviewed-on: https://gerrit.libreoffice.org/79994 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit cb5eaa791739865d54b381c16c60224c432171dc) Reviewed-on: https://gerrit.libreoffice.org/80014 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-15tdf#79007: PPTX: reset Contrast and Brightness when we map...Xisco Fauli2-0/+58
...MSO 'washout' to our watermark colormode After d151ed35ad4c4e7aa9fbb807930fcf91dea2eba7, Contrast and Brightness was reset only in writer, so do it earlier for Impress and Writer Reviewed-on: https://gerrit.libreoffice.org/79905 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 727ca36e83868acbe40aaa239cefc69659b9bc39) Change-Id: Icaf2b565880e31d86e09e2f56bac25eba52c8467 Reviewed-on: https://gerrit.libreoffice.org/80003 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-15tdf#128096: pptx: export highlightXisco Fauli2-0/+16
Reviewed-on: https://gerrit.libreoffice.org/80670 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 3e0811660ba4cecd0ab27918c27a5ddab47cc5c5) Change-Id: If3084f7ffaceb774dba1b1f195229313a8f1d04a Reviewed-on: https://gerrit.libreoffice.org/80740 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-10-15tdf#127964 PPTX import: fix shape fill handling: style vs slide backgroundMiklos Vajna2-0/+23
Regression from commit 943a534ac7cb3df513583e226c986dafd8ba246b (tdf#123684 PPTX import: fix wrong background color for <p:sp useBgFill="1">, 2019-04-23), the problem was that we didn't handle the case when a shape had an XML fragment like this: <p:sp useBgFill="1"> <p:style> <a:fillRef idx="1"> <a:schemeClr val="accent1"/> </a:fillRef> </p:style> </p:sp> i.e. the shape both wants to use background fill and it has a style declaring how to fill it as well. We gave the style a priority, while PowerPoint gives the background fill a priority. Fix the problem by not setting the fill from the style in case the background fill is already set. Change-Id: Ie1b56e5615219138a5b7ddd7a2b25295b991bc05 Reviewed-on: https://gerrit.libreoffice.org/80804 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 46d630f98f1c07ec2048da35d1a4804181148ac5) Reviewed-on: https://gerrit.libreoffice.org/80807 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-14ofz#14989 Z_NEED_DICT related infinite loopCaolán McNamara1-0/+0
Change-Id: I31c0d004d717564063c36862f9eef661d18768a9 Reviewed-on: https://gerrit.libreoffice.org/80648 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/80715 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-13tdf#127129: pptx: map highlight to CharBackColorXisco Fauli2-0/+22
Change-Id: I033c15db6848e96ba6b6bd7a2852c9e4d1524a8e Reviewed-on: https://gerrit.libreoffice.org/80630 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 57cfbc6830c3d8dc64107aed4a5555613415f069) Reviewed-on: https://gerrit.libreoffice.org/80738 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-09tdf#128013: fix Crash when linking an odp fileJulien Nabet1-4/+7
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=154847 Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3c86ffd8ded628e6f2b4187948a1b1056f6a0f56 Change-Id: Id9355958b0c4a56215ff98f0e5be13a3074ce45f Reviewed-on: https://gerrit.libreoffice.org/80500 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 1dc4c8266d45eb2f5c3de303eaa9233e3b52f058) Reviewed-on: https://gerrit.libreoffice.org/80506 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-28tdf#125585 write default layer status for OLE objectsRegina Henschel1-0/+9
The layer status is taken from the active view, when saving the document. But embedded documents have no view. Error was, that for all layers value 'false' was written in that case. With this patch the defaults (visible, printable, not locked) (true, true, false) are written. Change-Id: I2388ce31cc208fba075083889ec1bb2f874ef482 Reviewed-on: https://gerrit.libreoffice.org/79701 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 12f9a9f341fd8f8a98f7cd98f296a8729d279e0d) Reviewed-on: https://gerrit.libreoffice.org/79785 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-25Fix stack-use-after-return when moving a slide in the listStephan Bergmann1-1/+1
...very far, so that the list needs to scroll: > ==1676==ERROR: AddressSanitizer: stack-use-after-return on address 0x7f039a1e6420 at pc 0x7f03c34e0658 bp 0x7ffede26b140 sp 0x7ffede26b138 > READ of size 8 at 0x7f039a1e6420 thread T0 > #0 in Point::X() const at include/tools/gen.hxx:78:44 (instdir/program/libvcllo.so +0x5cf6657) > #1 in OutputDevice::PixelToLogic(Point const&) const at vcl/source/outdev/map.cxx:1191:47 > #2 in sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool) at sd/source/ui/slidesorter/controller/SlsDragAndDropContext.cxx:84:47 > #3 in sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0::operator()() const at sd/source/ui/slidesorter/controller/SlsDragAndDropContext.cxx:92:34 > #4 in void std::__invoke_impl<void, sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&>(std::__invoke_other, sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&) at gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/invoke.h:60:14 > #5 in std::enable_if<is_invocable_r_v<void, sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&>, void>::type std::__invoke_r<void, sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&>(sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&) at gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/invoke.h:110:2 > #6 in std::_Function_handler<void (), sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0>::_M_invoke(std::_Any_data const&) at gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/std_function.h:291:9 > #7 in std::function<void ()>::operator()() const at gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/std_function.h:622:14 > #8 in sd::slidesorter::controller::ScrollBarManager::RepeatAutoScroll() at sd/source/ui/slidesorter/controller/SlsScrollBarManager.cxx:518:17 > #9 in sd::slidesorter::controller::ScrollBarManager::AutoScrollTimeoutHandler(Timer*) at sd/source/ui/slidesorter/controller/SlsScrollBarManager.cxx:539:5 > #10 in sd::slidesorter::controller::ScrollBarManager::LinkStubAutoScrollTimeoutHandler(void*, Timer*) at sd/source/ui/slidesorter/controller/SlsScrollBarManager.cxx:537:1 > #11 in Link<Timer*, void>::Call(Timer*) const at include/tools/link.hxx:112:45 > #12 in Timer::Invoke() at vcl/source/app/timer.cxx:75:21 > #13 in Scheduler::ProcessTaskScheduling() at vcl/source/app/scheduler.cxx:479:20 > #14 in Scheduler::CallbackTaskScheduling() at vcl/source/app/scheduler.cxx:287:5 > #15 in SalTimer::CallCallback() at vcl/inc/saltimer.hxx:54:13 > #16 in sal_gtk_timeout_dispatch(_GSource*, int (*)(void*), void*) at vcl/unx/gtk3/gtk3gtkdata.cxx:761:45 > #17 in g_main_dispatch at ../glib/gmain.c:3189:28 > [...] > Address 0x7f039a1e6420 is located in stack of thread T0 at offset 32 in frame > #0 in sd::slidesorter::controller::SelectionFunction::MouseDragged(AcceptDropEvent const&, signed char) at sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:630 (instdir/program/../program/libsdlo.so +0x5c22e1f) > This frame has 1 object(s): > [32, 104) 'aEventDescriptor' (line 631) <== Memory access at offset 32 is inside this variable > HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork > (longjmp and C++ exceptions *are* supported) Presumably a regression introduced with 26912eea7521dd2b84bfac56b322cf0f8b142450 "sd: replace boost::bind with C++11 lambdas and for loops", assuming that boost::bind bound rMousePosition by value. Change-Id: I4cefc5974b7377ff4918d59b51fc8cda41292702 Reviewed-on: https://gerrit.libreoffice.org/78774 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 833c23264b532e34e050e3b8747c02ede6bf7350) Reviewed-on: https://gerrit.libreoffice.org/79553 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-17tdf#127030 PPTX export: keep fixed size of legacy shapesBalazs Varga2-0/+18
Classical/legacy shapes lost their fixed size by exporting them with the option "Resize shape to fit text". Regression from commit 86b14cc8bd910651cef422a0f7408adc0fc51a17 (tdf#119617 Fix export of Autofit property of shapes to PPTX) Change-Id: Iab67db113edc61f4c94a89ec1bb8df0736c26f21 Reviewed-on: https://gerrit.libreoffice.org/77888 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit b50d1a42064c8333926166ec047d3467c83d2fd0) Reviewed-on: https://gerrit.libreoffice.org/79060 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-10tdf#127372: PPTX: Shape's background transparency changes during RTTamás Zolnai21-259/+272
Need to use a better null value for FillTransparenceGradient. Use black-black which has equal effect than having no transparency at all. XFillFloatTransparenceItem has also an enabled attribute, but it can not be accessed via the UNO API. We can acces only the gradient object, so with a better null value we can check whether the API attribute is actually set or not. Change-Id: I480489f588376582f80d5062145b7f398ef61ad7 Reviewed-on: https://gerrit.libreoffice.org/78657 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/78691 Tested-by: Jenkins
2019-09-03tdf#126656 Remove unnecessary items from itemset.Gülşah Köse1-2/+8
Change-Id: I62fc660ea061fe9665e0166a08871ba0a592fc41 Reviewed-on: https://gerrit.libreoffice.org/78332 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 438430904064e667b688275525b317fd7989af2e) Reviewed-on: https://gerrit.libreoffice.org/78414
2019-08-26tdf#126746 Add support for import/export line caps for .pptx formatBartosz Kosiorek3-3/+31
With this commit I have added importing and exporting line caps, which could be (for pptx format: rnd Round Line Cap sq Square Line Cap flat Flat Line Cap Also exporting of these caps are added. Change-Id: I799485048a2a7ac8df89f004e177d507f86ce99d Reviewed-on: https://gerrit.libreoffice.org/77233 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 606a88d2abf85aa6edcc1fa26dc50cab6de3241f) Reviewed-on: https://gerrit.libreoffice.org/77553 Tested-by: Jenkins
2019-08-24Related: tdf#126693 cannot put focus into combobox entryCaolán McNamara2-5/+2
set can-focus=True in internal GtkComboBoxText GtkEntry where the GtkEntry is editable=True Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5 Reviewed-on: https://gerrit.libreoffice.org/78041 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-19tdf#126819 Can't retrieve the mouse position written in the statusbarNoel Grandin1-1/+0
regression from commit 77e260f915e0c77ddb1e915e9fd27ab0bdccc763 Date: Mon Jul 8 11:22:12 2019 +0200 tdf#121793 speedup VCLXAccessibleStatusBarItem::GetItemText Make the custom StatusBarControls set better text on their parent StatusBar. Also remove some unnecessary work being done in the Paint methods, to reduce confusion. Change-Id: I3b0a0af3b01d3b01f85ab335a3eb5993c07a50f4 Reviewed-on: https://gerrit.libreoffice.org/77586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c53f3f8f58f55d0978fb968446975856d72a52f8) Reviewed-on: https://gerrit.libreoffice.org/77697
2019-08-13tdf#125923 Fix reset button.Gülşah Köse2-0/+14
Reset/Revert button worked as cancel, not reset. That commit provides reset button to do its own job. Reviewed-on: https://gerrit.libreoffice.org/76341 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 15664117ef4db51bdcabb46b7990573509da0d73) Change-Id: I82d3e838bff3fd690cb5a901232ecb5f76257b95 Reviewed-on: https://gerrit.libreoffice.org/76345 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-12tdf#126746 Fix exporting closed Polylines to PPTXBartosz Kosiorek2-0/+14
In previous implementation the closed shapes was imported as a polylines without closing joint. As a result the joint style was not applied. This patch fixes that, and allow proper PPTX export. TODO The same issue needs to be fixed for PPT export Change-Id: I557daac1ba02330d8923f7eda3476e67d8711384 Reviewed-on: https://gerrit.libreoffice.org/77179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 3feaff84fafc23c26ff9c6a716709f17a6c8330b) Reviewed-on: https://gerrit.libreoffice.org/77229 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-08-02tdf#39742 tdf#44786 Consider Impress/Draw default printing settingsGabor Kelemen1-7/+31
Default settings can be set under Options - APP - Print but Impress/Draw has not used these as defaults unlike other apps Change-Id: I7d430f8fb24f9626cd628b4fe9e0520d9d42b848 Reviewed-on: https://gerrit.libreoffice.org/76079 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 844be49e7e511f0c397e1faebca10b4fa25ea937) Reviewed-on: https://gerrit.libreoffice.org/76565 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-01tdf#126511 Show only icon names instead of full path.Gülşah Köse1-1/+10
This commit shows only icon names insead of the full path of icon on Bullet and Numbering dialog graphic case on Impress. Change-Id: Iba72bf7c413993bad88add669035765aae521a59 Reviewed-on: https://gerrit.libreoffice.org/76716 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 7c973ea77438273deda909ce0563d8c5c37dad00) Reviewed-on: https://gerrit.libreoffice.org/76745 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-31tdf#126605: Do not end TextEdit when changing an attributeXisco Fauli1-0/+28
otherwise, pTextEditOutlinerView becomes nullptr in svx/source/svdraw/svdedxv.cxx:2184 Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc Change-Id: I9d0645f637dc92b50d01682d119c0db60238e921 Reviewed-on: https://gerrit.libreoffice.org/76609 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-26cid#1448222 Out-of-bounds readCaolán McNamara1-0/+1
possibly gold Change-Id: I170d9ae52e7e2b2869655d6649496fce8661a20b Reviewed-on: https://gerrit.libreoffice.org/76369 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-25tdf#126070 Show scroll bars when preview overflows.Gülşah Köse1-0/+4
Change-Id: Ibb904fc1c5d283d8ca9d8ff8b2249d25d7091b5b Reviewed-on: https://gerrit.libreoffice.org/75954 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 9a516a4b229f9a52c9c1f05d247cebddb1ba5c17) Reviewed-on: https://gerrit.libreoffice.org/76239 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-07-25cid#1448222 Out-of-bounds readCaolán McNamara1-0/+1
possibly coverity gold Change-Id: I6443225482eab5be31e1e12d282e420e767f23b2 Reviewed-on: https://gerrit.libreoffice.org/76276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22tdf#126334 Fix number format array in init controls.Gülşah Köse1-3/+2
Customization changings need only selected number format object but Position changings on bullet need all existing number format array. After merge the customization and position keeping all numbering format objects (10 item) make sense. Change-Id: Iade1e154243deaed43b9d243f2ebd0c5298b42a4 Reviewed-on: https://gerrit.libreoffice.org/75784 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 1f6c4328bfa00da5cf351dd050a80b75e0f1acde) Reviewed-on: https://gerrit.libreoffice.org/75945 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-21NB fix context-MultiObject and 3D in draw and impressandreas kainz2-1/+1
Change-Id: I8b173dc32309d205171524b9cf0249079585b55f Reviewed-on: https://gerrit.libreoffice.org/76001 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-16Follow up patch tdf#126067 Correct indentation.Gülşah Köse1-45/+44
Change-Id: Idfe608afb8b02f8b9f56b9da76e3f2009617b183 Reviewed-on: https://gerrit.libreoffice.org/75676 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 910c65fc640b3e422f3c660ba71844552fa426b3) Reviewed-on: https://gerrit.libreoffice.org/75678
2019-07-16tdf#126067 Fix slide scope feature.Gülşah Köse1-1/+7
Change-Id: I6e2450572b9c6a30526a8a2a91a6e0bf89103475 Reviewed-on: https://gerrit.libreoffice.org/75669 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 40bb9ac690d979ef544d5aa759bd734a176912a0) Reviewed-on: https://gerrit.libreoffice.org/75674 Tested-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-10SmartArt: hide connectors in org chart as they don't work correctlyGrzegorz Araminowicz1-2/+3
Fixing them would require a lot of effort. Changes are needed in data part (connector shapes are not created in group shapes associated with data shapes) and in layout part - routing them differently in all 4 or 5 hierBranch styles, with assistants and without. Change-Id: I48840454b0272dff9ba42db2eb5d65945642459a Reviewed-on: https://gerrit.libreoffice.org/75339 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75348
2019-07-10SmartArt: improve organization chart layoutGrzegorz Araminowicz2-0/+60
layout shapes in two steps: * first calculate vertical child shapes count for every shape (taking into accout hierBranch alg variable) * then actual layout using that count to calculate size for subtrees Change-Id: I2e5ca34ed3383aa9502c52511cc1fb2bee215572 Reviewed-on: https://gerrit.libreoffice.org/75195 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75311
2019-07-09NB tabbed_compact sd apps fix wrong DrawText commandandreas kainz2-2/+2
Change-Id: Icdad248e46172ba161de86bfb3f4edae4ef43139 Reviewed-on: https://gerrit.libreoffice.org/75253 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-08SmartArt: remove calculateHierChildOffsetScale() from org chart algorithmGrzegorz Araminowicz1-2/+3
Its purpose was to center subtree if sibling parent has no children. It was not working correctly for complex charts causing shapes to overlap. Without it chart is still readable (just sometimes not centered). Remove it for now until more universal solution is found. Change-Id: I397bd4264d6ce0fadf5c5fa1352f22e72d5d163a Reviewed-on: https://gerrit.libreoffice.org/75092 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75138 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-05Revert "Colibre, Breeze, elementary, KJ: tdf#107144, Breeze: tdf#126233"Rizal Muttaqin2-5/+5
This reverts commit 000305699b62a09c8d3d580b0fc8d320d9ea34f8. Change-Id: I2bb2d814d28d86afc2d74f549287614ce5db6f3b Reviewed-on: https://gerrit.libreoffice.org/75110 Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-07-05Colibre, Breeze, elementary, KJ: tdf#107144, Breeze: tdf#126233rizmut2-5/+5
- Add Impress transition, 3D related icons - Add many 32 px size for Calc and Draw specific icons - Fix blurred icons - Add more missing menu items Change-Id: I915e31aee51e84c88dd99e1fa3f6d5a4c7ca50d0 Reviewed-on: https://gerrit.libreoffice.org/75106 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 623ad884051ad4ea17ba7baa77076c49000e49fa) Reviewed-on: https://gerrit.libreoffice.org/75109 Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-07-04tdf#126197: EndTextEdit on all views before delete/cut shapeXisco Fauli3-0/+36
Change-Id: I3da93e5c72ee6f6f99120758e870d654e01a0ec7 Reviewed-on: https://gerrit.libreoffice.org/75001 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 80db66c4f345ac469943f871308b14b7f5ed0a11) Reviewed-on: https://gerrit.libreoffice.org/75079
2019-07-04tdf#50530 Make text edit outliner view show cursorJim Raykowski1-0/+6
Change-Id: I73b4dcacdf068daff02b8fe8156c58debfcdf704 Reviewed-on: https://gerrit.libreoffice.org/74613 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 80f18e7e028e9ca431aef281ab98bea99ad19fa3) Reviewed-on: https://gerrit.libreoffice.org/75048 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-04NB impress groupedbar and draw contextual single context-DrawText missingandreas kainz2-0/+2
Change-Id: I36e686283b57342408754ae96aa39d505668de07 Reviewed-on: https://gerrit.libreoffice.org/75063 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>