summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin5-45/+30
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01loplugin:stringconstant handle calls to constructors with one argNoel Grandin1-1/+1
Change-Id: Ide9148a908bef46ba14640dfa6f556beaf6e3f60 Reviewed-on: https://gerrit.libreoffice.org/33772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01defaults are good enough ..Jochen Nitschke2-36/+4
for copy ctor/assignment and dtor. inline MEMBER_CONSTRUCTOR_LIST macro Change-Id: I50296cebca3bc1aa43376ccd538c84df68a232a2 Reviewed-on: https://gerrit.libreoffice.org/33771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31tdf#105623 - Two labels for the same functionOlivier1-1/+1
Change-Id: I0c6e1ed8a7ef90602e3309226481bd91f390f866 Reviewed-on: https://gerrit.libreoffice.org/33751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-31more SAL_WARN_UNUSEDNoel Grandin1-2/+0
Change-Id: Idf44fe0302b4504c443f083e527b63b2461ada85
2017-01-31tdf#105571 Drop toolbar:helpid attribute from toolbar definitionsGabor Kelemen22-250/+250
These are no longer useful. Made with: git grep toolbar:helpid | cut -d : -f1 | sort -u | xargs sed -i -r -e 's/ toolbar:helpid="[0-9]*"//' git grep toolbar:helpid | cut -d : -f1 | sort -u | xargs sed -i -r -e 's/ toolbar:helpid=""//'1 Change-Id: If1bf04265f4e03b44b6a92529f6133aff1589526 Reviewed-on: https://gerrit.libreoffice.org/33642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin3-6/+6
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28loplugin:unnecessaryoverrideJochen Nitschke1-1/+0
seen on tinderbox Linux-F19-x86_64_14-with-check Change-Id: Ic494f75df7b2ca879e7bb312166b4c91263ee214 Reviewed-on: https://gerrit.libreoffice.org/33644 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin1-1/+1
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann162-2779/+1478
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26[API CHANGE] offapi: remove unused xsec_fw UNO servicesMiklos Vajna3-3/+0
This is mostly just the offapi/ part, more C++ code can be removed in xmlsecurity/ after this. SignatureVerifier, SAXEventKeeper, SignatureCreator, XMLSignatureTemplate and XMLEncryptionTemplate was only used inside xmlsecurity, but they all are accessed directly already. Decryptor and Encryptor wasn't even used by internal code since they were added in commit 9f34fde7a8750b856570b5e855d2ecb226bf0c23 (libxmlsec, 2004-07-12). It seems to be unlikely that any of these non-published services were used by 3rd-party code, since they were specific to other xmlsecurity/ code, not generic functionality that could be useful in other contexts. Change-Id: I4bcfa88d11d2b92a440f6617193c6460125ce4fd Reviewed-on: https://gerrit.libreoffice.org/33569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-25move Image ctor variant with mask color to callersCaolán McNamara1-1/+1
Change-Id: I81a52aeb855edca823881360831b26e252780053
2017-01-25Fall back on o3tl::make_unique for nowStephan Bergmann1-6/+7
Change-Id: I58f688004804aed8b749b72caaa53afc06387ec7
2017-01-25Missing includeStephan Bergmann1-0/+4
Change-Id: I60177c2b10b973e9c8f09ea7c71d44df08e50cc4
2017-01-25use a std::unique_ptrCaolán McNamara1-12/+10
Change-Id: I1ab99995e35714d6ef3358400b0805723c44678c
2017-01-25valgrind: fix leakCaolán McNamara1-0/+2
since... commit e94d5233dd7939c54eb52fff456e817cecdf0a4c Date: Fri Mar 11 06:43:06 2016 +0100 work on sane lifecylce for SfxFilter which removed "delete pFilter" though it was pMediumFilter which was in question in this method Change-Id: I598dd44a8498ebd6b3e63d1c89147bee5ab3bb55
2017-01-25tdf#105502 sd increase font size: handle table selectionMiklos Vajna3-0/+96
In part of a table shape is selected, then only operate on the selected cells, not on all of them. Change-Id: I3a9ba2b99bcaa2e355b6fcdafdd142d4a809bce6 Reviewed-on: https://gerrit.libreoffice.org/33524 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-25use rtl::Reference in SdLayerNoel Grandin2-24/+21
instead of storing both a raw pointer and an uno::Reference Change-Id: Id608c50cb4cb3a7cf7ad972303a3c5f9fc8e79b0
2017-01-25loplugin: unnecessary destructor scaddins..sdextNoel Grandin15-38/+0
Change-Id: I6ae02ad25863ec7e0f780020dbc69c9a99488c24 Reviewed-on: https://gerrit.libreoffice.org/33511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24teach unusedvariablecheck plugin about SfxPoolItem subclassesNoel Grandin1-3/+0
which can all be treated as SAL_WARN_UNUSED The eehtml.cxx change probably fixes some CJK/CTL bug somewhere Change-Id: I6852129540f316075aee907971ac19418d71dd9a
2017-01-24coverity#1399550 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I4a1ba212b64c7b561f0c1b1f7f75fe255c8d1415
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski30-47/+45
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23pass ownership by pointerJochen Nitschke3-3/+3
to show the intend of the code. assert on invalid objects. remove useless OSL_ENSURE. make sure list of owning pointers can't be copied. Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c Reviewed-on: https://gerrit.libreoffice.org/33393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-22align commentCaolán McNamara1-7/+7
Change-Id: I50a728e785589e3ec2d9128679f3e69451c5102a
2017-01-21coverity#1399024 Explicit null dereferencedCaolán McNamara1-1/+2
Change-Id: I9e8f4bf693734625ec3544e5d4f35a7d048ea609
2017-01-20Missing 'const'Stephan Bergmann1-0/+1
Change-Id: I203ada1b4c527311ded56e6af0de7a7eb711f3f8
2017-01-20Missing 'const'Stephan Bergmann1-1/+1
Change-Id: Ia1cced46dc8c76a252952129fb93be9d5a281057
2017-01-20don't need an intermediate ImageCaolán McNamara1-9/+7
Change-Id: I23d712846a9b198cc2fcb87f3b097766405f8bce
2017-01-19New loplugin:dynexcspec: Add @throws documentation, sdStephan Bergmann38-9/+82
Change-Id: I01e47c52eb4313cf43561d7a57b71656fb66b2ef
2017-01-19sd: load BitmapEx resources instead of Image onesCaolán McNamara7-67/+57
Change-Id: Ic3f416300194d8fa9dfebc2b7a700396ba5641a5
2017-01-19flatten resource, drop LocalResource classCaolán McNamara6-106/+30
drop cargo-cult second LocalResource use Change-Id: I0c655f8ca15ad146bb11290fdefad67846ec8006
2017-01-19can use Bitmaps directly hereCaolán McNamara2-9/+9
Change-Id: I75f4148ff864657e747b02d80a120177b469f28a
2017-01-19make SfxItemSet with SAL_WARN_UNUSEDNoel Grandin2-2/+0
Change-Id: Ia74ca329d8438f614169031acfbe0406faf7c281 Reviewed-on: https://gerrit.libreoffice.org/33268 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-18new loplugin: useuniqueptr: sdNoel Grandin13-41/+33
Change-Id: I2fc8a2fa57cc00edf2edab9e3722c824e75cb7e5 Reviewed-on: https://gerrit.libreoffice.org/33204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl1-2/+2
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski7-8/+8
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski3-5/+7
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-17sw, sd: fix indentationMiklos Vajna1-1/+1
The indentation in these files is consistent otherwise, let's keep it that way. Change-Id: I1d73caa03425cd4d1c98ff07935512b002fb2c72
2017-01-16Convert RID_MENU_NOTEBOOKBAR to xmlMaxim Monastirsky2-0/+20
Brings a lot of features (icons, keyboard shortcuts, customization, context menu interception etc.) Other changes: - Make SfxDispatcher::ExecutePopup take PopupMenuFlags arg, to be able to pass NoMouseUpClose, so that the menu won't close on mouse-up under anything != gtk3. - Make .uno:OpenFromWriter and .uno:OpenFromCalc async slots, to avoid crash under gtk3 when recycling the current frame. - Don't show the menu in customization dialog, if experimental mode disabled. Change-Id: Ieea2f73f6b48fbaf4bdfc4acf1a33d25422357cb Reviewed-on: https://gerrit.libreoffice.org/33101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-14rename from bmp to pngCaolán McNamara1-24/+24
Change-Id: Ibcb08acfd8ac518388c33b97121fc04a7b7dbf03
2017-01-13tdf#105188 sd: fix shutdown crash after accessing master pagesMichael Stahl4-23/+29
The problem here is that the destructor of SdModule does a lot of things, including destroying an SdXImpressDocument that is referenced from some SdGlobalResourceContainer. This calls SD_MOD() to get the SdModule to get some resource, but at that point SfxApplication::GetModule() returns null, because the sequence was changed from first deleting the SfxModules, then clearing the pointer in ~SfxModule to null, to unique_ptr::reset(), which, at least in libstdc++, is implemented via std::swap, so it clears the pointer before deleting the SfxModule. It appears rather brittle to rely on such a subtle detail, so refactor things so that SdGlobalResourceContainer is no longer owned by SdModule but has its own pet XTerminationListener, which means it will be destroyed earlier, while the SdModule is still fully alive. (regression from f7b1cd66167050afecf487e3d89ea12de74200b5) Change-Id: I7f03f3adf431be8728ef3d65a078b536cb96f959
2017-01-12tdf#64588 - prevent loss of non-uniquely-named slideJustin Luth5-0/+74
Although the UI prevents someone from renaming slides so that two have the same name, it is still possible to have such non-uniquely named pages apparently. Since drag/drop uses the name to add a slide to the clipboard, it resulted in duplicates of the first found instance of the slidename, and loss of the similarly-named slides when they were dragged to a new location. Change-Id: I2986a7c6c3360162adf9430f645d0dfc73f1d4e2 Reviewed-on: https://gerrit.libreoffice.org/32481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-12silence coverity#1371305 Missing move assignment operatorCaolán McNamara1-4/+4
Change-Id: I761e07d1583262d83074addbff4ca67b01640387
2017-01-11tdf#105182 sd: avoid iterating too far in SdOutliner::Initialize()Michael Stahl1-1/+4
Considering the valid indexes are extended by "-1" for backwards iterators and "size()" for forward iterators, it's obvious that a not-yet-at-the-end-in-the-other-direction iterator can be incremented once, but not necessarily twice. Why this code even wants to increment it twice isn't obvious to me. Change-Id: I578c8c6202049ebe6dbed41b8276a6bfa0566bbc
2017-01-11Some loplugin:conststringvar/stringconstant improvements: sdStephan Bergmann1-1/+1
Change-Id: If44cce6e4c241f6a2203d73f6d191f270fb5ca5a
2017-01-10replace namespace url strings with function callsRosemary Sebastian1-9/+10
Change-Id: I1b496a93449caa4a9699f71874f293eeaa1fa320 Reviewed-on: https://gerrit.libreoffice.org/32916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-10tdf#105199: Keep URL intactStephan Bergmann1-1/+1
Change-Id: I85681fcc81246414332f88dc46ce4a4b60896c97
2017-01-10New loplugin:conststringvar: sdStephan Bergmann4-11/+11
Change-Id: I7aa74260f1456a22bae368738e3947ead1ecc7be
2017-01-10Related tdf#100151: use disposeAndClear for mpShowWindow (sd)Julien Nabet1-1/+1
See https://bugs.documentfoundation.org/show_bug.cgi?id=100151#c33 Change-Id: I81e483189eacee086b680367148f8dd3ca2d3493 Reviewed-on: https://gerrit.libreoffice.org/32904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-09Test that patterns are correctly imported for MS binary formatTomaž Vajngerl2-0/+339
Change-Id: I8335ee35bae11c8014d6591744199e55bc3ec41b Reviewed-on: https://gerrit.libreoffice.org/32854 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 18:04:38 +0000