summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2016-06-24loplugin:singlevalfields in svtoolsNoel Grandin2-2/+0
Change-Id: I80fe1d4646af2b8d8e6362a25f6cda4b7ac29eab Reviewed-on: https://gerrit.libreoffice.org/26603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23Remove unused SfxObjectShell::libreOfficeKitCallback()Miklos Vajna2-6/+0
All clients have been converted to use SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: I793dad5194769f331037b12a1b1afba96ddea4ba Reviewed-on: https://gerrit.libreoffice.org/26584 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-23support for ms binary format validation in sd module export testsVasily Melenchuk1-0/+4
Change-Id: Ie03b0485bbe8ecaa452f19fbcbfe3bf5829aff68 Reviewed-on: https://gerrit.libreoffice.org/26515 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin10-34/+31
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-22tdf#93124: The arbitrary number 100 seems to be too high, let's try 50Tor Lillqvist1-1/+1
The test fails on a tinderbox. Adding a temporary printf shows that the number there is 71. Change-Id: Ic8fbaab9e3d3434e20ba6aef5cc1acd66b5f4283
2016-06-21Remove no longer needed vcl::ITiledRenderable::registerCallback()Miklos Vajna2-6/+0
All clients has been changed to use SfxViewShell::registerLibreOfficeKitViewCallback() instead. Change-Id: I2538268dc9c4b449f68b5d2b05a72de584c29fd0 Reviewed-on: https://gerrit.libreoffice.org/26540 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20Remove unused includesStephan Bergmann4-4/+0
Change-Id: I25bb67449c8c572075d354e62b1c731e95655b4f
2016-06-20This code unlikely wants conversion from UNO Bool or Char AnysStephan Bergmann1-2/+1
...which would be the main difference with convertPropertyValue, in addition to throwing an exception upon failure that would be caught directly by the surrounding try-catch block Change-Id: I960e23b797c71be655c4059125effade84d0630c
2016-06-20Remove no longer needed SdrModel::libreOfficeKitCallback()Miklos Vajna2-6/+2
All former clients are changed to call SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: Ic5dcf0a8a4241338fcd6941f13ce438157676481 Reviewed-on: https://gerrit.libreoffice.org/26521 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20tdf#100441: Fix listbox state in master vs. normal modeKatarina Behrens2-10/+27
Events appear in following order: normal -> master: 1. EID_EDIT_MODE_MASTER, 2. EID_EDIT_VIEW_SELECTION master -> normal: 1. EID_EDIT_MODE_NORMAL, 2. EID_END_TEXT_EDIT This is only partial fix, selecting the right master page in other than normal mode is still broken Change-Id: I2dd91e77c4ed5627079fc9d2b39e40c8e74a9f8e Reviewed-on: https://gerrit.libreoffice.org/26484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-18uitest: loplugin:stringconstantMarkus Mohrhard1-1/+1
Change-Id: I863615af7a942b91513511ba515b82f3523c6aa5
2016-06-18uitest: support more impress operationsMarkus Mohrhard2-3/+82
Change-Id: I74ab526dabbee1f8c203274f187c065d9fb413fd
2016-06-18uitest: add initial code for impress main edit windowMarkus Mohrhard5-0/+138
Change-Id: I82eabe1df33878316907e664ddbcd8edf6a73d33
2016-06-18uitest: annotate a few draw/impress windowsMarkus Mohrhard4-0/+15
Change-Id: I6352842535fddc99d30a4d0180ac01e7f8d5cd48
2016-06-17comphelper lok: remove the g_bViewCallback globalMiklos Vajna5-93/+30
Its purpose was to allow incrementally migrate all callers of SdrModel::libreOfficeKitCallback() to use SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only the currently active or all views) instead. That is done by now, so it can go. Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3 Reviewed-on: https://gerrit.libreoffice.org/26413 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16comphelper: enable LibreOfficeKit::isViewCallback() by defaultMiklos Vajna1-8/+14
This requires porting the sw/sd/sc_tiledrendering test code to the new internal API, as only the public LOK API is unchanged. Change-Id: Ic6a2f96421da4a16bdee7d0cbb3f6e35bc6ddff9 Reviewed-on: https://gerrit.libreoffice.org/26379 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16sort the arrayDavid Tardon1-1/+1
Change-Id: Iab15a4344d2174db2763603d0107bc9ec372e4fb
2016-06-16rhbz#1343752 fix view status in menuDavid Tardon1-56/+30
... after commit 229fc164dc1773484b74eca016863cf68860e81b . Change-Id: Ibfbbb86c81527f008b8e1cbe9d8ca3174a944931
2016-06-16tdf#86759 and tdf#89466: Enable Page Background Panel for DrawSusobhan Ghosh2-3/+40
Rename Slide Background Panel to Slide in Impress. Reorder Properties Deck Change-Id: Ib2039c41c56a0182887f19aa362d633dcabfe9dd Reviewed-on: https://gerrit.libreoffice.org/26159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-15SfxObjectShell::Current may return nullptrMarkus Mohrhard1-0/+3
See http://crashreport.libreoffice.org/stats/crash_details/caa7efba-fbe8-4c58-966d-c4bc356b5a63 Change-Id: Idc8b3a2e482a5423080735f46f50d415835f747d Reviewed-on: https://gerrit.libreoffice.org/26341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-15tdf#100209: Master slide of master slide makes no senseKatarina Behrens1-7/+30
so just disable the controls when in master view Change-Id: I9551cc5c0d123e58555d248b78859c1f77de6690 Reviewed-on: https://gerrit.libreoffice.org/26276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-15crashreport: 644837b5-c445-4779-a75d-dd69fc2e3a6fCaolán McNamara1-0/+1
This can be reproduced by switching to master slide sidebar in impress , use the mouse to wheel up and down and then go straight to clicking the window manager close button The dispose doesn't ultimately drop its reference to the document so keeps it open if the scroll-wheel previous event widget vclptr keeps the widget around Change-Id: Ic90bcadf2489094358737be7f522129bd555a1ba
2016-06-15sfx2: bring the view shell's LOK callback up to date with SdrModelMiklos Vajna1-5/+12
This fixes CppunitTest_sw_tiledrendering in the LOK_VIEW_CALLBACK=1 case. Change-Id: Ib79e57908c3edda0154341baba8279ede4281a42 Reviewed-on: https://gerrit.libreoffice.org/26313 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15tdf#61396 Possibility to edit a template not in Template RepositoryAkshay Deep2-1/+5
Menu Sequence: Open Template... Save as Template... ---------------------- Manage Templates Change-Id: I0d0c8ca15d8dc38662e7f84a4f598933c13dd512 Reviewed-on: https://gerrit.libreoffice.org/26179 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-15sc, sd: add per-view support to recently added LOK_CALLBACK_SET_PART callsMiklos Vajna1-3/+12
These caushed an assertion failure when opening a Calc or Impress document in gtktiledviewer. Change-Id: If9cf1ef6c5a9d8e1b0d578b20dd3f513989b669b Reviewed-on: https://gerrit.libreoffice.org/26311 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15LOK: fire SET_PART event when Impress page is changedAshod Nakashian1-0/+5
Change-Id: Iebddffbdc66397b1f2937ed7320f7800c8bab4cc Reviewed-on: https://gerrit.libreoffice.org/26301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-15tdf#42949: clean up includes in include/filter with iwyuJorenz Paragas1-0/+2
Change-Id: Id08a999764bfeeff3bb3409b46f48b278009ccbe Reviewed-on: https://gerrit.libreoffice.org/26238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-14Function to change sidebar panel title, via UNO APIKatarina Behrens2-0/+36
Change-Id: I147da965d71746220958852bf796197c30f219a3 Reviewed-on: https://gerrit.libreoffice.org/26243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-13sd: implement per-view LOK_CALLBACK_SEARCH_RESULT_SELECTIONMiklos Vajna1-7/+46
This way views can search without disturbing each other. Change-Id: I40e69b6102a959ef1f1825a7af1438c2f2fcf807 Reviewed-on: https://gerrit.libreoffice.org/26227 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13sd: implement per-view LOK_CALLBACK_HYPERLINK_CLICKEDMiklos Vajna1-2/+7
Change-Id: If0759525326f963b497a6e011027719fc376eaf9 Reviewed-on: https://gerrit.libreoffice.org/26226 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13sd: implement per-view LOK_CALLBACK_INVALIDATE_TILESMiklos Vajna1-1/+8
With this, gtktiledviewer no longer crashes on load when opening a sample ODP file. Change-Id: I19857d6dcfab74c9fa282754e450c951f7ca564c Reviewed-on: https://gerrit.libreoffice.org/26223 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13sd: implement per-view LOK_CALLBACK_DOCUMENT_SIZE_CHANGEDMiklos Vajna1-2/+22
These callbacks were invoked from the model, so need to iterate over the view shells and invoke them on all the views. Change-Id: Ie8107f4782b513b874d0b94464ea372994dabbe9 Reviewed-on: https://gerrit.libreoffice.org/26221 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13notebookbar: reduced paddingSzymon Kłos1-14/+45
Change-Id: I43df4ba611d7b377829ac3b5f17ff26077e9f13d
2016-06-13Related: tdf#93135 adjust the ui to reflect the text fit options entanglementCaolán McNamara2-2/+8
We have two major groups of text fitting options in draw/impress ones that apply only to custom shapes * Word wrap text in shape * Resize shape to fit text those that apply to other elements, e.g. text boxes, legacy rectangles and lines * Fit width to text * Fit height to text * Fit to frame * Adjust to contour Of the second group, only "fit to frame" is always available. Text boxes have "Fit width to text" and "Fit height to text", while stuff like legacy rectangles and lines etc have "Adjust to contour" instead. A fun issue is that (currently anyway) the bit for "resize shape to fit text" in custom shapes and the bit for "fit height to text" in text boxes is the same bit, SDRATTR_TEXT_AUTOGROWHEIGHT. So before this change in all circumstances the same collection of checkboxes for all settings was visible. With context used to enable or disable which ones could be set according to the type of shape it was. Simultaneously there is logic to enable/disable checkboxes depending on if other checkboxes that control contradictionary options were checked/unchecked. e.g. "Fit to frame" disabled if "fit height to text" is enabled. So its not apparently why some can be enabled and some disabled by clicking about the place in the shared collection. In this commit we split the sizing options into their two families, one frame and column for each of "custom shapes" and "everything else". When adjusting a single selected object we use context to determine which column to show or hide. When editing multiple objects or the underlying graphic styles we show both columns. When editing a presentation style we show just the text box column. (The use of HasText in the original code is a concern, cause it doesn't make sense to me, using it like that means that in the original dialog format->text on an empty text box from F2 shows the contour option, but after entering text and then format->text it shows a set of different text box sizing options, so that's dropped here) Because (currently) the same SDRATTR_TEXT_AUTOGROWHEIGHT bit it used for two apparently different things then we visually toggle on all things that use that bit in multi-column mode when its togged on, i.e. on editing a style visually both "fit height to text" and "resize shape to fix text" are kept in sync when you toggle one or the other. We don't disable the "resize shape to fit text" checkbox (unlike the fit height to text checkbox which controls the same bit) if "fit to frame" and "adjust to contour" are set, and give it additional powers to unset those if clicked. This hopefully makes the ui describe the way things actually are. Because this SDRATTR_TEXT_AUTOGROWHEIGHT is currently sort of doing two purposes selecting a freshly drawn custom rectangle and using format->default formatting will cause it to change properties because the underlying SDRATTR_TEXT_AUTOGROWHEIGHT bit is cleared. The way things should probably be I guess is that there should be a SDRATTR_TEXT_AUTOGROWSIZE property (which used to exist but wasn't hooked up to anything) just for custom shapes which overrides the old family of options if set. Change-Id: I49241c90d919eeb5caa8775beab57746d5c6df04
2016-06-12convert more DBG_ASSERT(false to SAL_WARNNoel Grandin4-6/+6
Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12convert DBG_ASSERT(false, to SAL_WARN(Noel Grandin6-8/+8
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c Reviewed-on: https://gerrit.libreoffice.org/26187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-11coverity#1362678 Dereference after null checkCaolán McNamara2-6/+2
RelocateToWindow is only called by RelocateToParentWindow RelocateToParentWindow is only called by RelocateToWindow and ViewShellWrapper::relocateToAnchor ViewShellWrapper::relocateToAnchor never passes nullptr as its argument to RelocateToParentWindow so presumably this can never be null WriteFrameViewData was never called by that logic and ReadFrameViewData was always called Change-Id: Ida584b330d7c7539515a5e7287206f6469699b98
2016-06-11coverity#1362686 Uninitialized scalar variableCaolán McNamara1-10/+15
Change-Id: Ic077e3324897f427b7d509bce7884ecb5945c725
2016-06-10Clean up uses of Any::getValue() in sdStephan Bergmann7-209/+201
Change-Id: Ie4f165efd14d7cdfc99d600f3ddc000d438e0c6a
2016-06-10css.presentation.PresentationOrder is of UNO type LONGStephan Bergmann2-5/+7
...i.e., sal_Int32, so cannot be read by casting the Any's value to sal_uInt16. When writing out to PPT format, silently clamp the sal_Int32 to the sal_uInt16 range. Change-Id: If428f54f19c347a59719bc457c28a68053b7a9ef
2016-06-10tdf#87667 If image is cropped, set cropped size as original size.Gulsah Kose1-1/+0
Change-Id: Ief76037f087a2225442294b972d331fc4476bbec Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/25486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-06-10no need for this message to be SAL_WARNNoel Grandin1-5/+5
Change-Id: I3861d28cfcab9b5f18451259a996d7561d5f6c00
2016-06-10If we set TextFitToSize we have to unset TextAutoGrow[Height|Width]Caolán McNamara1-0/+9
e.g. like ImpSetAttributesFitToSize and ImpSetAttributesFitToSizeVertical do otherwise you can right click on an outline->text change the value from its default of "fit to frame" to "fit to width" ok, then use rightclick->autofit to toggle "fit to frame" on and now revisit outline->text and all three are set and none can be toggled off Change-Id: I48e2f364679e055ac776f1e7c5a04efaa2b6d0d2
2016-06-10Slideshow: Add 'Oval' Shape Transition variantMayank Gupta5-1/+33
Committer's note: There is no Oval or Ellipse transition in MSO formats, so fallback to circle on export to those. Change-Id: Ibc3d617d3bb94bdd0702bb4d60ce5fbe2eea8e24 Reviewed-on: https://gerrit.libreoffice.org/23661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-10CppunitTest_sd_tiledrendering: replace ifdefs with a single makefile conditionMiklos Vajna2-18/+1
Change-Id: I61e5cad8dee9f6dace6fe78b01a6ecefbd9d8f78 Reviewed-on: https://gerrit.libreoffice.org/26144 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09tdf#84909 Impress: Rearrange the standard toolbarYousuf Philips3-23/+23
Change-Id: Ia2582fa118b5622c36ed80525273ac28a224fc6d Reviewed-on: https://gerrit.libreoffice.org/26070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-06-09Revert "Slideshow: Add 'Oval' Shape Transition variant"jan iversen8-55/+1
The patch caused problems with the export filter tests, to check that you need to add --with-export-validation to your autopen.input see https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/export-validation for more info on how to set it up This reverts commit 248c5ea771255b54e64394458a321ccf829bbd02. Change-Id: Ib3b8fa7bf80630feeca1f24dfb1ceb5a945d7162 Reviewed-on: https://gerrit.libreoffice.org/26114 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09fix mangled indentCaolán McNamara1-40/+35
Change-Id: I48962100019e7bc69601e0da2e729a5c66634c3c
2016-06-09Slideshow: Add 'Oval' Shape Transition variantMayank Gupta8-1/+55
Change-Id: Ibc3d617d3bb94bdd0702bb4d60ce5fbe2eea8e24 Reviewed-on: https://gerrit.libreoffice.org/23661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko8-32/+8
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 02:44:10 +0000