summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2018-04-06tdf#115407: preselect sound file savedJulien Nabet1-3/+5
To display the sound in the dropbox, the complete filename (eg: file:///home/julien/lo/libreoffice/instdir/share/gallery/sounds/pluck.wav) was compared with items of the sound list formed like this: file:///home/julien/lo/libreoffice/instdir/program/../share/gallery/sounds/pluck.wav See https://bugs.documentfoundation.org/show_bug.cgi?id=115407#c1 Since listbox displays only basename, let's just compare basenames Change-Id: I5fb49990322423fa7818e5d6e1cafd828e3500ec Reviewed-on: https://gerrit.libreoffice.org/52476 (cherry picked from commit 23c82e1a377ea6fce65d71277ec59b3ca150b98a) Reviewed-on: https://gerrit.libreoffice.org/52490 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-05tdf#116544 crash on unhandled IllegalArgument exceptionCaolán McNamara1-14/+62
Change-Id: I290ba6097d6d91bf4677e7e92c896bd6359cbc49 Reviewed-on: https://gerrit.libreoffice.org/51835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-03-22tdf#90627 Don't save empty conditionsSzymon Kłos4-32/+44
Change-Id: I5a953c1b0fff7bf41a59360a8f52596264ddf266 Reviewed-on: https://gerrit.libreoffice.org/51293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51411 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-22tdf#104792 Double check for target shapeSzymon Kłos2-0/+16
Change-Id: Ibe23377c7752d9ce97c7b100af4b2759b3ce946f Reviewed-on: https://gerrit.libreoffice.org/51241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51410 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-21tdf#115539, tdf#116238: Don't display the notebookbar in presentation modeXisco Fauli1-4/+2
Change-Id: Ifc64d9a3b5c93b83fa238737375e7a58b2ae86db Reviewed-on: https://gerrit.libreoffice.org/51262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 6a9326803c01f4c9bc7da855053ce4e80646fad8) Reviewed-on: https://gerrit.libreoffice.org/51295 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-14tdf#115429 xmloff: ODF import: fix handling of unknown attributesMichael Stahl2-0/+52
... in SvXMLLegacyToFastDocHandler::startElement(), so that it does not create invalid "-1" tokens that end up stored as empty-string attribute names in SvXMLAttrCollection and ultimately exported as invalid XML. One surprising aspect is that the maNamespaceURL in struct UnknownAttribute stores the namespace prefix in the libreoffice-5-4 branch, as it lacks commit bb59a80ee6000d3922fa95262f67e291fd9d8ee2. The attributes are read and converted again in SvXMLImportContext::startUnknownElement(). Change-Id: Id081c677286a77ec50d9884cdbd9135cf4f6e5b6 Reviewed-on: https://gerrit.libreoffice.org/50583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-12tdf#44774: Parent style's msApiName could yet be empty; use GetApiName()Mike Kaganski2-1/+31
Change-Id: Ie0e218ea83d34aa7ee22fea1f32b2851a942544f Reviewed-on: https://gerrit.libreoffice.org/51069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a8fc81d478f4dcf8600ed9a2b4e0f7adff4a17ee) Reviewed-on: https://gerrit.libreoffice.org/51077 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-28tdf#115873 sd navigator: adapt IsEqualToDoc() to Fill() furtherMiklos Vajna4-34/+104
SdPageObjsTLB::Fill() populates the navigator tree list box, SdPageObjsTLB::IsEqualToDoc() determintes if it has to be refreshed or not. Commit f3c68cdf8f6a0273c62b493552f78af0138a44e8 (tdf#115873 sd navigator: allow selecting but not focusing on objects, 2018-02-21) already brought IsEqualToDoc() closer to Fill() with using the same iteration mode for the SdrObjects, but that's not enough. Fill() uses flat iteration, then checks for group shapes explicitly and visits them recursively. Change IsEqualToDoc() to do the same, this way selecting "Rectangle 3" in the testcase won't result in a jump back to "Slide 1" (as an effect of IsEqualToDoc() returning false for an up to date tree list box). Change-Id: If2543cbc282af06ba43d4804e7ed455c8b9828cd Reviewed-on: https://gerrit.libreoffice.org/50234 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 1f159a4df7dcf9c4b1a35d16aee2303b8fa34b27) Reviewed-on: https://gerrit.libreoffice.org/50346 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-28tdf#115873 sd navigator: allow selecting but not focusing on objectsMiklos Vajna6-2/+125
There were also two cases here: - changing the selection with the keyboard or single-click only updated the selection in the navigator - pressing enter or double-click also selected the shape in the main window and gave the focus away Introduce a 3rd case for single-click: update the shape selection but doesn't give the focus away. This way double-click is not needed to sync navigator -> main doc selection but keyboard navigation should still work. An additional trick is to make sure that the current shell is the draw shell (and not the slide sorter) after navigation, so follow-up operations work with the selected object and not with the whole slide. Finally, a third related problem was that the selection jumped back to the item of the slide after clicking on a shape in the navigator. The reason for this was the navigator list was constantly cleared and re-filled in SdNavigatorWin::InitTreeLB(), as SdPageObjsTLB::IsEqualToDoc() returned false (even if the list was up to date) in case of shapes which had children but no name. Fix this by using the same SdrIterMode::Flat iteration mode that SdPageObjsTLB::AddShapeList() does, so the fill and the equality check of the navigator iterates the same way. Conflicts: sd/qa/unit/tiledrendering/tiledrendering.cxx sd/source/ui/dlg/navigatr.cxx (cherry picked from commit f3c68cdf8f6a0273c62b493552f78af0138a44e8) Change-Id: I0bfc3e8b49f7ef01d5797a68284616dcd2a81c5d Reviewed-on: https://gerrit.libreoffice.org/50159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-27tdf#97614 Fixing initialization code for Bluetooth and IP Server for Impress.Rostislav Kondratenko2-7/+4
Change-Id: Icc385fb760b8a5ff337f58dc95ba3c3f86805eaa Reviewed-on: https://gerrit.libreoffice.org/50108 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit fb5f13671c50f7f84d654a779bc0ff07e31ce95e) Reviewed-on: https://gerrit.libreoffice.org/50414
2018-02-21tdf#110357: Impress table looses selection when clicking on ...Tamás Zolnai3-41/+12
... Increase \ decrease font button Change-Id: I52cf853de01b06c6c9db9779f15174f895789da8 Reviewed-on: https://gerrit.libreoffice.org/43962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50049 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-20tdf#115783 sd: fix lost char attributes during in-table copy&pasteMiklos Vajna3-1/+141
The SvxFontHeightItem (12pt) is originally a character-level property on the table cell (covering the whole cell text) but when the user sets the font height of the cell, sdr::properties::CellProperties::ItemSetChanged() will turn that into a paragraph-level property. This is fine, except that this way the property has unclear semantics when the user pastes single-paragraph content into an existing paragraph. (Keep the old paragraph properties? Use the new ones?) The current behavior is that sd::View::OnEndPasteOrDrop() calls into ContentAttribs::SetStyleSheet() at the end of the paste, which removes paragraph-level formatting (giving visibility to the from-style 18pt font height this way for the existing content), so both the old and the new paragraph formatting is lost. Improve the situation by copying these paragraph-level character properties back to character-level before paste at the paste position (so doc model is back to the state after load), that way font height and similar properties are not removed by the on-end-paste handler. (cherry picked from commit f0c25c751cf8e166a84b289746bce6202a40391d) Conflicts: editeng/source/outliner/outliner.cxx sd/qa/unit/tiledrendering/tiledrendering.cxx sd/source/ui/view/sdview.cxx Change-Id: I43d321dedcda6c0df9b009b9d99c3544f783473c Reviewed-on: https://gerrit.libreoffice.org/49977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-14tdf#114821 calculate better label positionSzymon Kłos2-0/+49
Positioning hack was improved. It calculates position depending on direct chart size factor. Preffered label positions are: top - vertical, and center - horizontal Change-Id: Ic25f08cd0bc3105fe34841dbc3f8aacacb694d43 Reviewed-on: https://gerrit.libreoffice.org/48909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/48928 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-01-09tdf#114848 Don't save empty themesSzymon Kłos3-0/+18
Change-Id: I7136f5c0bc884a2f9ea945b4e0bc093a5ef2d8df Reviewed-on: https://gerrit.libreoffice.org/47481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/47617 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-21tdf113594: marking gluepoints immediately.Mark Hung1-1/+1
pPV was for the parameter of MarkGluePoint that was removed in ec38966951f2, and was kept somehow and is converted to bool here. Just replace the default boolean value to false ( that means marking instead of unmarking. ) Change-Id: I4c4b9dd368537b7b90cc4effae482a7b8a41eec9 Reviewed-on: https://gerrit.libreoffice.org/46472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit bf151f0716910b56e3538579f4af7ede8f51bbcf) Reviewed-on: https://gerrit.libreoffice.org/46497 (cherry picked from commit 715d0f32eb36593a4c9e52763b2ceb17ec1283c5) Reviewed-on: https://gerrit.libreoffice.org/46913 Reviewed-by: Aron Budea <aron.budea@collabora.com>
2017-11-30sd: BestFittingCacheComparer must be irreflexiveMichael Stahl1-3/+3
/usr/include/c++/7/bits/stl_algo.h:4866: Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)). ... when using "Window->New Window" in Impress. Change-Id: I885a59cf378b7020d549580c2fc1cf121c6a59bd (cherry picked from commit d4269c5373cf8ccc0a5631b9d0900227e11e13f1) Reviewed-on: https://gerrit.libreoffice.org/45440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27ofz#4436 check if seek succeededCaolán McNamara1-1/+1
Change-Id: I56d9692647b28c706b56ccacf08d494b3d830d94 Reviewed-on: https://gerrit.libreoffice.org/45296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-11-10tdf#112547 element p to draw:object, import expects it thereRegina Henschel2-0/+221
There exists no documents produced by LibreOffice, where text on OLE objects has worked, because import expects the paragraphs inside the draw:object element, but LO has written them outside. The patch changes LO to write the paragraphs inside the draw:object element. The patch does not enable LibreOffice to read the paragraphs in old documents. But versions at least since 5.1 will be able to read text on OLE objects from documents which were produced by versions with applied patch. Reviewed-on: https://gerrit.libreoffice.org/43696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 21f61ffeb7e72caee98f12cac2dd25fe7ec3a821) tdf#112547 sd: add unit test (cherry picked from commit b3cfb849b19dc1e40c12586bebd2b76fc41007fa) Change-Id: I879135f1a869e46c32361db653ede05227bab95e Reviewed-on: https://gerrit.libreoffice.org/44374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-11-07ODP: export TextPreRotateAngleSzymon Kłos2-0/+24
Change-Id: I13eb005195ebbdee5016bf279cba423e388723a0 Reviewed-on: https://gerrit.libreoffice.org/43910 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/43991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-11-06PPTX export: correct position of rotated groupsSzymon Kłos3-0/+30
* added testcase for tdf#113263 Change-Id: I7abf68d8fb4ffd8b883cfbf4d69916912add8182 Reviewed-on: https://gerrit.libreoffice.org/43794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/43990 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-11-06Resolves: rtl: tdf#60315 slide pane context menu misplacedCaolán McNamara1-10/+5
so use same (slighty crazed) logic as DrawViewShell::Command to get the right place when rtl is enabled Change-Id: Icb4a39310ab98bd186cbafd516ca5f323da8cce1 Reviewed-on: https://gerrit.libreoffice.org/44275 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-11-06PPTX export: remember color schemes in themeSzymon Kłos4-51/+182
Remember color scheme from loaded pptx file or use default values. Change-Id: Icb69c51603afc5f332c20c75e4ed5f659f4b5614 Reviewed-on: https://gerrit.libreoffice.org/43470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/43989 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-10-31SmartArt: export text rotation in the PPTXSzymon Kłos2-1/+13
Slightly modified unittest from master. libreoffice-5-4 doesn't export shape groups so far. Change-Id: I74bfc172fe7434d14de468ecfd3412636e53780c Reviewed-on: https://gerrit.libreoffice.org/43202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/43364 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-24tdf#113227 FILESAVE: PPT: bullets disappear after RTNoel Grandin1-2/+3
regression from commit afa675469cd9894f41a6b9eeb2e7acc8245d256c use SvxExtNumType in SvxNumberType where I managed to put a "default: break" statement in the wrong place Change-Id: Ic821a03208a75363c538c4641077b084f1e2d242 Reviewed-on: https://gerrit.libreoffice.org/43737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit f99767d532dbe2741cb9cccf26db3547cc5e14df) Reviewed-on: https://gerrit.libreoffice.org/43743 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-20tdf#112633 oox: Save backup images to proper path in documentJacobo Aragunde Pérez2-0/+30
Artistic effects on bitmap images in OOXML files create a backup file with the original image. These were not being saved into the proper path for PPTX files because the `/word` directory was hardcoded in the export code. The path saved to the relations file was incorrect too because it was not taking into account that the relations file is saved to a subdir in PPTX and XLSX documents. Finally, added a unit test. Reviewed-on: https://gerrit.libreoffice.org/43338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 55641f5572f3168c09e096eb89ca563652889758) Change-Id: I3e880ce763dc10dbc86ccf0e00871be5d36f6d88 Reviewed-on: https://gerrit.libreoffice.org/43600 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-10-20tdf#97630 xmloff: ODF extended draw:fit-to-size messMichael Stahl2-0/+825
The plan: 1. As Regina points out, there is already (in ODF 1.2, but not ODF 1.1) a style:shrink-to-fit attribute for shapes, so use this to represent the AUTOFIT value. The fallback from AUTOFIT to draw:fit-to-size="true" was a stupid idea anyway, probably "false" is less annoying in practice. There are 2 different shapes that implement TextFitToSize property: a) text shapes already interpret ALLLINES and PROPORTIONAL exactly the same b) fontwork custom shapes interpret ALLLINES but do nothing for PROPORTIONAL As Regina points out, there is no shape that needs to distinguish between ALLLINES and PROPORTIONAL, so we do a minor behavioral API CHANGE and from now on interpret PROPORTIONAL as ALLLINES on fontwork custom shapes. This obviates the need to distinguish the values in ODF and so we don't need a new attribute, just use draw:fit-to-size="true" for both. On import, use MID_FLAG_MERGE_PROPERTY to combine the 2 attributes into one value. 2. Restrict the export of draw:fit-to-size to only the standard values "true"/"false". This implements step 1, the step 2 will be done in the future when most users have the import of the style:shrink-to-fit. Change-Id: I4a378aa110fdb82db7a99a839d7ff207248a73e7 Reviewed-on: https://gerrit.libreoffice.org/43521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 33eb9fdb61033b3fd35d923900b1f5791f4b71c8) Reviewed-on: https://gerrit.libreoffice.org/43595 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-17Resolves: rhbz#1471983 fatal exception on older config without slide bg panelCaolán McNamara1-4/+7
Change-Id: Id437bdd8feac06da42c180ff4f7759ec282fa8d4 Reviewed-on: https://gerrit.libreoffice.org/43280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-04tdf#112836 master view, bottom areas are wrongly positionedNoel Grandin1-1/+1
Bug was introduced in commit 12b2803f196b897ffb901b0eebe271c5ee43d03e "drop unused PRESOBJ_IMAGE" Change-Id: I50be74b505a674439bd8b67545b89a9660a85a33 Reviewed-on: https://gerrit.libreoffice.org/43062 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d352dda3dbfc9e26b7f80746e1502f3cb4cd45c1) Reviewed-on: https://gerrit.libreoffice.org/43066 Tested-by: Jenkins <ci@libreoffice.org>
2017-09-26tdf#112647: Fixed line spacing is saved incorrectly to PPTXTamás Zolnai2-0/+19
The values were not converted to the right unit. Also the spcPts attribute means an exact value not a minimum one. Reviewed-on: https://gerrit.libreoffice.org/42763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit ef2e9b19a52e04ae0ed45900bcf64bf375a910ef) Change-Id: Ia49683e66153611e96a830f821e3a2487adec505 Reviewed-on: https://gerrit.libreoffice.org/42813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-24tdf#112557: Subtitle placeholder shape leads to corrupted PPTX fileTamás Zolnai3-4/+21
Reviewed-on: https://gerrit.libreoffice.org/42611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 238cfa9efa21f08514703ea6cc181ce02d8feb12) Change-Id: I26680ecdb5f0db4f27180c221de062341af0265c Reviewed-on: https://gerrit.libreoffice.org/42650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24tdf#112552: Shape's gray background is lost after saving to PPTXTamás Zolnai2-0/+17
Reviewed-on: https://gerrit.libreoffice.org/42598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 31919b8909fa7b34412dd52c3d4dff17bc5b6fab) Change-Id: I30f371ad301eede82ddcece4d91ffcd32e164115 Reviewed-on: https://gerrit.libreoffice.org/42648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-08Disable test on Linux x86 that makes plain 'make' fail due to -mpfmath=387Stephan Bergmann1-0/+7
...rounding issues, and thus caused LO Flathub builds to fail, see <https://flathub.org/builds/#/builders/3/builds/280>. Change-Id: I91e8662e0a85b4ed8b16719eed4ade3397edfa0c (cherry picked from commit c799497959f82c84ddaf032b096d1a3f8d6e2bcd) Conflicts: sd/qa/unit/import-tests.cxx Reviewed-on: https://gerrit.libreoffice.org/42093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-06tdf#109261: Crash when adding a video to a slide with zero undo stepsTamás Zolnai1-2/+6
When undo is disabled (no undo steps), ReplaceObjectAtView() method frees pPickObj, so we need to save it's reused data first. Change-Id: Icbc800d4d33cf229006aecde7d62aa2a7ea35879 Reviewed-on: https://gerrit.libreoffice.org/41822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 27068e6cc39aed8ebfa5fdd7a67acb89f5adcb89) Reviewed-on: https://gerrit.libreoffice.org/41824 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-06tdf#109052: Crash after PPT import when undo is disabledTamás Zolnai1-1/+2
It was not a good idea to enable undo unconditionally. Use the saved undo state instead. Change-Id: I60875da23466b6ef54f034b447d636bdbab38151 Reviewed-on: https://gerrit.libreoffice.org/41823 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit a726c69ffef2533545e316172e3e1494b8ad327e) Reviewed-on: https://gerrit.libreoffice.org/41825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-29tdf#108926: Notes placeholder text boxes not shown in PPTsTamás Zolnai3-163/+179
Regression from: acb2943c8125f4ceed74f35f31776929dedeb8d8 Call this placeholder related code not only for normal slide pages. Reviewed-on: https://gerrit.libreoffice.org/41517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit b766cab621690a3aaf4e10fcf925ebab1c1925b8) Change-Id: Iae185ac7e5d2505554692045516cc51dbdcd735b Reviewed-on: https://gerrit.libreoffice.org/41529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-22Related to tdf#109863: Crash when close slide style dialog with OKTamás Zolnai2-21/+1
Use item conversion implemented inside the background tab page. Change-Id: I4cb0fa60e6d2024a2e6e08e06af337d85b7f49fa Reviewed-on: https://gerrit.libreoffice.org/41266 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-17tdf#111548: PPTX: ActiveX checkbox control appear as pictureTamás Zolnai2-0/+37
Make ActiveX controls import working again (PPTX / XLSX) It used to work earlier, but there were an issue with the shape id and so controls were not find. Also in PPTX import the persistStorage attribute was handled only for parent controls and not for other kind of controls. Reviewed-on: https://gerrit.libreoffice.org/40751 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit c8e3633a352c2fda3aebb9781288a926e7a88c42) tdf#111548: Better fix for PPTX / XLSX import of ActiveX controls Follow up fix for: c8e3633a352c2fda3aebb9781288a926e7a88c42 Revert part of it and fix the real issue: shapid was messed up. Reviewed-on: https://gerrit.libreoffice.org/40929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 286c27e805c4501451857abff19c23b3719146a3) Change-Id: I9784166b65407b79b6dfed8a38087b55b1b69835 Reviewed-on: https://gerrit.libreoffice.org/41117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-17Resolves: tdf#110077 move the SvxBackgroundColorItem<->SvxBrushItem conversionCaolán McNamara2-26/+2
into the dialog itself Reviewed-on: https://gerrit.libreoffice.org/41029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6284804c2ccb3ad8bb6e1c1dac8d622f66b8c07d) Change-Id: I83db9f02145a4927257dd5691f82dad1a11eaea6 Reviewed-on: https://gerrit.libreoffice.org/41168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-14tdf#109863: Crash while trying to set pattern fill in ImpressTamás Zolnai1-0/+1
This line was missed to add in this commit: 76585ae33f3ca75c05c0ccbf6a621b6e2d42bc00 Change-Id: I2fb8c90b34ecbdfdd2bdc62adaa5e0a0d074ce33 Reviewed-on: https://gerrit.libreoffice.org/41129 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit e980d98dea38e71379f3ec02ab03fbff15022e5c) Reviewed-on: https://gerrit.libreoffice.org/41132 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-11tdf#110743: Use page position to insert master page, not idPranav Kant1-1/+1
Fallback from c454fbb9b62164d5f047990ae63522c9fb932086 Change-Id: I8835f1a23feeb12d77963e621e8d9d59568420f2 (cherry picked from commit f4e5940abbbaa3c2747108b0954e8912d164f3e5) Reviewed-on: https://gerrit.libreoffice.org/40633 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-04Resolves: tdf#111308 crash after load designs with no design selectedCaolán McNamara1-1/+1
Change-Id: Ia7d5e1d0c4c960700d94cfec01a8a01799f89d9a Reviewed-on: https://gerrit.libreoffice.org/40732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e325a5442ab350e8eb66458aed98d38ce21aec06) Reviewed-on: https://gerrit.libreoffice.org/40745 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-02tdf#109223: PPTX: Vertical flip of child shape is not imported correctlyTamás Zolnai2-0/+34
Group shape level vertical flip is not handled well. Recent handling of group shape's transformation makes it hard to import this attribute, but we can import the right text direction at least. Reviewed-on: https://gerrit.libreoffice.org/40554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit d742c0019435d0bc90c9342492583636099a057f) Change-Id: Ib9e39e3dcb28a95fabc61c13152a3f7296fbd4c3 Reviewed-on: https://gerrit.libreoffice.org/40555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-28don't jump back to selected slide on right click context menuCaolán McNamara2-3/+12
i.e. two many slides to fit in slide sorter panel, so scroll bar, select slide one, scroll to the end and right click between slides (or anywhere that isn't a slide) and without this fix the sorter jumps back to make the selected slide 1 visible. The right click menu will offer "new slide", choosing that will insert a slide at the point that was originally clicked, not at the point it was scrolled back to losing focus trigger a (dubious looking) callback to jump to the selected slide, so disable it while context menu is up Change-Id: Ie42bf158258cc38c9b7cfda7672f24d2ac8bfa11 Reviewed-on: https://gerrit.libreoffice.org/40382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-26tdf#100491 fix DOCX import shape line with arrow markerVasily Melenchuk4-20/+596
Line shape with arrow end markers was rendering rather thick arrow, not connected to main line. Moreover, arrow width should depend on actual line width. Change-Id: I8d9a6e7f5d89a1645dcc5939ecc592e86e6fe34f Reviewed-on: https://gerrit.libreoffice.org/40286 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 2d3b7a07c02c90d2d64a630ab84886ef3096edfc) Reviewed-on: https://gerrit.libreoffice.org/40437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-17tdf#107584: Load/save page background transparencyKatarina Behrens2-0/+27
Change-Id: I17bd01dc129f0e530d5e227a5ddc12f11486e85d Reviewed-on: https://gerrit.libreoffice.org/39206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 7562c5f37ca03267da5873143601811bebf6d620) Reviewed-on: https://gerrit.libreoffice.org/40045 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-17tdf#109107: Sidebar's fontheight field is not updated...Tamás Zolnai3-0/+34
... by moving cursor in an Impress table Table controller handles key and mouse events itself, but can't do the invalidation of the slotids which would lead to update sidebar corresponding widgets. Change-Id: I0d1db58ecb714bb16dfb1b5662f0fba7ce69c06f Reviewed-on: https://gerrit.libreoffice.org/39933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 6feb40b950557dcfdc5249f22d72edad397d4c67) Reviewed-on: https://gerrit.libreoffice.org/39949 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-11tdf#108925: Too small bullet size confuses the userTamás Zolnai2-0/+19
Add a constraint for bullet relative size to avoid too small bullets which are hardly recognizable. Use the same 25% lower limit what MSO uses. Change-Id: Id956ecf3ec831c569188b944be58da03bf30a55e Reviewed-on: https://gerrit.libreoffice.org/39696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 11652be4071ef6d1d89b2c397aa1a32476e03bf6) Reviewed-on: https://gerrit.libreoffice.org/39707 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-04tdf#108833 sd: don't unconditionally enable Undo after importMichael Stahl1-1/+2
Change-Id: Id637e649ccf3782658832d909b3a7150a0606229 (cherry picked from commit 3d59018b1ed816b4399cad4c2c4818cf25d4f4a1) Reviewed-on: https://gerrit.libreoffice.org/39420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-04tdf#108863 sd: disable Undo earlier if no Undo StepsMichael Stahl1-0/+10
If 0 Undo Steps, the Undo is disabled by a timer somewhere calling SfxShell::SetUndoManager(). This seems a bit risky, so disable it already when the sd::UndoManager is created. Change-Id: I9caf14fe32251d1f92cb5fa0683838316275eab3 (cherry picked from commit 495284716f49072e432b8425944cc67dfe0df0e0) Reviewed-on: https://gerrit.libreoffice.org/39417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-04tdf#108609 rtl mode set on ruler when it should be ltrNoel Grandin1-1/+1
regression from commit 8ccbc16b5e3f94b8db105232d7085a8553e6bc03 "convert SvxFrameDirection to scoped enum" Change-Id: I2063ddf4344fb41b54f2ad96a471df4d3205406d Reviewed-on: https://gerrit.libreoffice.org/39478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit eb104a28daf5b17f24c95da637fc292593eea99b) Reviewed-on: https://gerrit.libreoffice.org/39485 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 18:16:10 +0000