summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2019-04-30sfx: LOK: notify clients of the sidebar stateAshod Nakashian1-0/+5
Change-Id: I35b174c3a5e302ce52ee4063fa71d47feffab624
2019-04-30sfx: LOK: toggle sidebar decksAshod Nakashian2-2/+2
Change-Id: I0559a2a4ae041bc61cf3a2d5979656a7941f4b02
2019-04-30LOK: sd: no animation preview for LOKAshod Nakashian1-0/+4
Change-Id: I67babe9b340bafd196dedb2918d6a24bfc9c0ad5
2019-04-30sidebar: Add .uno:MasterSlidesPanelAshod Nakashian6-0/+43
Change-Id: I578dc8b1f9c8df7f7cc9108c70d6fad8006871c6
2019-04-30sidebar: hide preview and play controls in lokitAshod Nakashian2-4/+24
Change-Id: I7fc9470082612af4c4d7e56ff704936da5c63ce4
2019-04-30lok: writer: svg export transformed imagesMarco Cecchetti1-17/+19
Change-Id: I908a6e01573c35c0641519f4995730af0b033c33
2019-04-29Add RedactDoc to Tools menu of ImpressMuhammet Kara1-0/+1
Now that we have redaction enabled for Impress, after commit 33e840896a69a66c44e74beb995d558735fb84ad, let's sync the Impress Tools menu with Writer and Calc. Cherry-picked from commit f1c27ccc7ece38cc5395c14d01d634fd4bb77c11 Change-Id: I1af03f6aa2043a70779a3b783045c69adc8641a3 Reviewed-on: https://gerrit.libreoffice.org/71508 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-04-25sd lok: Remove the .uno:LeftPaneImpress call from sd lok initialization.Jan Holesovsky1-11/+0
According to my testing, this makes no difference and the moving of slides and multiple selection behaves the same way with or without this. So let's return to not activating the SlideSorterBar, because otherwise we are doing a lot of pixel bashing behind the scenes unnecessarily. Having said that, if we want to activate it at some stage, it is better to do something like the following (+ remove the explicit LOK-only if's from svtools/source/config/slidesorterbaropt.cxx): SvtSlideSorterBarOptions().SetVisibleImpressView(true); instead (and potentially we can also make it floating not to occupy the space in the main view by GetWindow()->SetFloatingMode(true); in the LOK case in sd/source/ui/dlg/PaneChildWindows.cxxi). Change-Id: I86b23b484674ad4c6a75246ee6186ad9b828931f Reviewed-on: https://gerrit.libreoffice.org/71271 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-25Revert "disable unreliable SdTiledRenderingTest::testPasteTextOnSlide"Jan Holesovsky1-2/+0
This shouldn't be necessary after the patch that removes the .uno:LeftPaneImpress and revert of the unit test changs. This reverts commit 23b03b5e21d936d1fdb2096c1c57b932a1c6f9e3. Change-Id: Ie056d66b1d88c317e1b44ebe290313c307d807ae Reviewed-on: https://gerrit.libreoffice.org/71273 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-25Revert "sd: fix unittest failures due to enabling slide-sorter"Jan Holesovsky1-112/+4
At the moment, the commit that was supposed to fix the unit tests is actually breaking them for me, so let's revert. This reverts commit 72da60a4fac5657de69c0651dd8e0a94fcc49b97. Change-Id: I8ea636985de12ea19ad32a6064ece2d90589b7f9 Reviewed-on: https://gerrit.libreoffice.org/71272 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-24disable unreliable SdTiledRenderingTest::testPasteTextOnSlideco-6.0-28Andras Timar1-0/+2
Change-Id: I5ff8d4f1a9191aec082cacafb571e3171f464550
2019-04-23sd: LOK: publish statechange on entering master viewAshod Nakashian2-0/+10
Change-Id: Ib736800544b9669e3708da0c01370af22cdf3e97 Reviewed-on: https://gerrit.libreoffice.org/69617 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-18Switch redacted export optionsMuhammet Kara1-1/+1
Bring White option to the first place, to save toner on print as users tend to click on the first option. Change-Id: Id63c4402f8dc07a83eef69c3dfde3dd086c899b8 Reviewed-on: https://gerrit.libreoffice.org/70831 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit d5b59b8d9d798b884dbcf0c97f403d739b01e1cc) Reviewed-on: https://gerrit.libreoffice.org/70868 Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-04-17Add direct pdf export to the Redaction toolbarMuhammet Kara1-0/+1
Users need an in-process copy of pdf to share with peers and discuss the redacted areas Change-Id: I68c16c6f09690a9d5cd2df191963107029e5ed88 Reviewed-on: https://gerrit.libreoffice.org/70863 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 06eb265dd65d64b608a71cba5e5fbd906a781e1c) Reviewed-on: https://gerrit.libreoffice.org/70864
2019-04-15LOK: sd: use native SdPage to flag selectionAshod Nakashian1-21/+5
The slide-sorter is actually still necessary to apply/change the master slide of a given slide, so we must enable it. Change-Id: I3f59f58be76ab1c63453b4f6288044572800a556 Change-Id: I7554ba4afd28d7ea4f3ed6ba375d9765a89ef21c Reviewed-on: https://gerrit.libreoffice.org/69618 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-15sd: fix unittest failures due to enabling slide-sorterAshod Nakashian1-4/+112
Change-Id: Ife85b3c728c59f7fb4e0184211efc9b652c5f4e7 Reviewed-on: https://gerrit.libreoffice.org/69615 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-15LOK: sd: initialize slide-sorter in sdAshod Nakashian1-0/+11
Change-Id: I4cb6ce6d961b4ba4d542c14cb37370788cf75e45 Reviewed-on: https://gerrit.libreoffice.org/69613 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-15LOK: support for ordering/moving partsAshod Nakashian2-0/+9
Currently reordering of slides is only supported for presentations, although it is provisioned for spreadsheets as well. Change-Id: I6c35066d6a5ef7586d34a8e8b89db69a20b86572 Reviewed-on: https://gerrit.libreoffice.org/69612 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-15LOK: getPartInfo now returns list of selected partsAshod Nakashian6-13/+70
For spreadsheets, selected parts are still unimplemented, so returns false for all. For presentations, visible parts seem to be always return false at load time. Change-Id: I90c79617f88deec98849bb374ca0ba177cd9c9af Reviewed-on: https://gerrit.libreoffice.org/69611 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-15slide-sorter: multiple selectionAshod Nakashian4-0/+60
Change-Id: I8624de25b0bb66020002890f33758e52059a24ab Reviewed-on: https://gerrit.libreoffice.org/69610 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-13sd: unit-test to check that PDF stream is shared among Graphic instancesAshod Nakashian2-3/+70
Change-Id: Iebd85e5e60c76e6d0756d15e1fa6107a3fcc837d Reviewed-on: https://gerrit.libreoffice.org/70162 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-03pdfium: Delay the swap out.Jan Holesovsky1-4/+10
If we swap out too early, the constructor of GraphicObject forces a swap in, so we'd render everything during the load anyway. Change-Id: I0ea1a755242fd57ef28d082ce4bf534a32199f87 Reviewed-on: https://gerrit.libreoffice.org/56286 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-03pdfium: Avoid unnecessary copying + some warning fixes.Jan Holesovsky1-3/+2
Change-Id: I114fa6b2d3dda86c55eb245d31ca3a1019197ae9 Reviewed-on: https://gerrit.libreoffice.org/56285 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-03pdfium: Import PDF with unloaded images.Ashod Nakashian1-22/+13
Change-Id: I5e4a16ff38b9643127ce16879b35f456c13bcff8 Reviewed-on: https://gerrit.libreoffice.org/56268 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-04-03pdfium: Share the GfxLink for PDF files.Jan Holesovsky1-1/+1
Partially based on work by Ashod Nakashian, thanks! Reviewed-on: https://gerrit.libreoffice.org/56265 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Change-Id: Id7e8c4543368b0caf3e459abaff8c53997779c83 Reviewed-on: https://gerrit.libreoffice.org/69625 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-04-03vcl: share GfxLinkAshod Nakashian1-1/+2
When importing PDF as images, we store the PDF stream in the GfxLink. For large PDFs storing a copy of the full PDF with each page is overkill. For example a 10MB PDF with 200 pages will consume 2GB of memory! Change-Id: I99913514cf5c562683080bc817668095bee69427 Reviewed-on: https://gerrit.libreoffice.org/55571 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/69624 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-03-28Revert "vcl: share GfxLink"Jan Holesovsky1-2/+1
This reverts commit c8f81dbb30e89a19bb7a82f8b52cc02b9049e717.
2019-03-28Revert "pdfium: Share the GfxLink for PDF files."Jan Holesovsky1-1/+1
This reverts commit 62654a8c29b945d00afe9f32e87b44ba0d8b84a2.
2019-03-27Temp icons for the redactedexport commandsMuhammet Kara2-4/+3
Just put some links for now for the icons, and replace the two buttons on the redaction toolbar with the new redactedexporttoolbox Change-Id: Ic1df62d56c965869135ceca97bbeb87efd3aaa0d Reviewed-on: https://gerrit.libreoffice.org/68281 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69838 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Sync fuconbez.cxx with masterMuhammet Kara1-26/+26
Change-Id: I2e898f5bfbbaa55c5e403185cd445af605300d1e Reviewed-on: https://gerrit.libreoffice.org/69837 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Add style options to redaction exportMuhammet Kara5-1/+49
* Add 2 new uno command aliases to handle 2 different styles of redaction export/sanitization: * .uno:RedactedExportBlack & .uno:RedactedExportWhite * Replace the single export button with the 2 new buttons * Add a new toolbox names .uno:RedactedExportToolbox which consists of the new 2 commands. It will be added to the Redaction toolbar after we solve the icon issue. * Now new redaction shapes are named as RectangleRedactionShape or FreeformRedactionShape based on their type. * While exporting to PDF, a seamless step of "Sanitization" takes place, in which, all shapes in the Draw doc are traversed and turned into opaq black or white (with black border) shapes, then the whole doc is converted into bitmap (page by page). * After the export operation is completed. All shapes are converted back to the usual redaction style (gray and transparent). * Icon issue: * We need 2 new icons for our new commands, one for black redaction shapes without border, and one for white redaction shapes with black border. * I tried adding links to a current icon, but it didn't work, so they are iconless for now. * Next to do: Handle icon issue, and take the redaction implementation into a separate helper class because it is growing fast. Change-Id: I9b2b7716289b800cdbe7bf3ffa4a442fe5afc474 Reviewed-on: https://gerrit.libreoffice.org/68072 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69836 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Use named shapes for redactionMuhammet Kara5-6/+23
Change-Id: Ibb55bd503d264b618c3fbebfdbcf3fe9958c6783 Reviewed-on: https://gerrit.libreoffice.org/68031 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69835 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Support bitmap PDF export for RedactionMuhammet Kara1-1/+1
* Add a new parameter IsRedactMode (SID_IS_REDACT_MODE) to .uno:ExportDirectToPDF * Make sure the new param makes it into PDFExport as part of FilterData * Hijack the metafile before being sent to ImplExportPage(), convert to bitmap, and replace the original * Add a new entry to GenericCommands.xcu to make our button with param visible * Nitpick: For things to be included in the bitmap conversion, they need to be added to the metafile before the conversion in PDFExport::ExportSelection(). Things added after that point (inside ImplExportPage() for example) will not be bitmapped/pixelized Change-Id: Iec7020917da920a968ea969b98e53f17eadaa275 Reviewed-on: https://gerrit.libreoffice.org/67108 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69833 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Forge the freeform redaction toolMuhammet Kara3-4/+94
out of the Freeform Line tool in Draw. * Replace .uno:LineToolbox with .uno:Freeline_Unfilled in Redaction toolbar * Add new parameters to .uno:Freeline_Unfilled - SfxUInt16Item Transparence, SfxStringItem Color, SfxUInt16Item Width, SfxBoolItem IsSticky * Handle the params in FuConstructBezierPolygon * Now the freeform line draw tool on the Redaction toolbar works with a default width of 5mm, color of COL_GRAY7, and a transparency of 50%; and it sticks when it is clicked/selected once until user deliberately deselects it by clicking on another tool or by clicking outside of the page. * Known problem: icon is not displayed on the toolbar after adding the params Change-Id: I6b09276ca82782dbf214aab8d2ba3b407fb0d81c Reviewed-on: https://gerrit.libreoffice.org/66916 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69817 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-27Add Redaction ToolbarMuhammet Kara4-5/+124
* Consists of .uno:Rect, .uno:LineToolbox, and .uno:ExportDirectToPDF * Automatically shown when we are in the redaction process * Customizes the rectangle tool for our needs Also: * Adds new parameters to the SID_DRAW_RECT (.uno:Rect) to be able to set transparancy, fill color, and line/border style, and to make our button sticky/permanent Known problem: Button's icon is not shown after adding the parameters Change-Id: I7928264415769f7e0a4ded171b864adb99aed442 Reviewed-on: https://gerrit.libreoffice.org/66706 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69816 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-26pdfium: Share the GfxLink for PDF files.Jan Holesovsky1-1/+1
Partially based on work by Ashod Nakashian, thanks! Reviewed-on: https://gerrit.libreoffice.org/56265 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Change-Id: Id7e8c4543368b0caf3e459abaff8c53997779c83 Reviewed-on: https://gerrit.libreoffice.org/69625 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-03-26vcl: share GfxLinkAshod Nakashian1-1/+2
When importing PDF as images, we store the PDF stream in the GfxLink. For large PDFs storing a copy of the full PDF with each page is overkill. For example a 10MB PDF with 200 pages will consume 2GB of memory! Change-Id: I99913514cf5c562683080bc817668095bee69427 Reviewed-on: https://gerrit.libreoffice.org/55571 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/69624 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-03-15LOK: re-factor async key & mouse event re-posting.Michael Meeks1-40/+4
A fairly pure re-factor, although adding disposed window checking to a number of sites with a warning. Moves the event emission helpers from VCL into SfxLokHelper: we're going to need more view / integration here next anyway. Removes lots of copy/paste horror. Change-Id: I279c11a1d8093b4feeeb6b7850f500806fff80dd Reviewed-on: https://gerrit.libreoffice.org/69218 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69268 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-03-12sd: document the left pane classesAshod Nakashian1-2/+7
Change-Id: Id037e2f5f733ef7266ef6d48ff2ff7dea956ea25 Reviewed-on: https://gerrit.libreoffice.org/69070 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-08Revert "LOK: disable LOKit in unit-tests only after destroying all"Andras Timar1-4/+113
This reverts commit ccb14cca567dc8bbc17fe0abde01effd08b37d4f.
2019-03-07build: support disabling popplerAshod Nakashian2-3/+3
This adds --enable-poppler configure option. Poppler can be enabled/disabled by setting this parameter to yes or no. Change-Id: I42ba2d27de7b5014d28523394310616d20073b71 Reviewed-on: https://gerrit.libreoffice.org/68602 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-05Check svg URLs before exportingSamuel Mehrbrodt2-0/+15
Reviewed-on: https://gerrit.libreoffice.org/68668 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 34ec46571701d639d9bc542b2d19f87a21a83648) Change-Id: I3b86b6b82318b0d201c3d7db516664520eb47bed
2019-03-04sd: LOK: avoid caching pointers and leakingAshod Nakashian2-12/+9
Change-Id: I68163bc30b0655b11dec34bdcc750b495b93365a Reviewed-on: https://gerrit.libreoffice.org/68265 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-04sd: LOK: support localization of slide transition presetsAshod Nakashian2-26/+20
Change-Id: Ic3ea57e537e118e10d155203921574967154c234 Reviewed-on: https://gerrit.libreoffice.org/68264 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-04sd: LOK: support per-user localization of CustomAnimationPresetAshod Nakashian4-29/+30
This only fixes the caching in CustomAnimationPreset and CustomAnimationPane. Other cached labels will be done separately. Change-Id: Iaf511168d26b3a5567ca53556e242d3c071d2623 Reviewed-on: https://gerrit.libreoffice.org/68263 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-01sd: use OSL_DEBUG_LEVEL instead of DEBUGAshod Nakashian2-3/+3
Change-Id: I0703a1564a23657e956e43fe4cbf1d9549acb94f Reviewed-on: https://gerrit.libreoffice.org/68258 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-01LOK: disable LOKit in unit-tests only after destroying allAshod Nakashian1-113/+4
When we disable LOKit at the end of a unit-test, we do so before any of the smart-pointers go out of scope. These instances are then destroyed when LOKit is no longer active, in spite of the fact that they were created while it was. This leaves some dialog/window routing notifiers dangling, which cause assertion failures and access-after-free (when they are invoked on destruction inadvertently). The latter issue was found with 'make CppunitTest_sd_tiledrendering VALGRIND=memcheck'. The fix is to move these flags to the setup and teardown stages of cpp-unit. Change-Id: Ic4481305ca1a5cca14d70a4ebbc820a3fdeea9cc Reviewed-on: https://gerrit.libreoffice.org/68256 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-02-25Fix build when !HAVE_FEATURE_AVMEDIATor Lillqvist1-1/+2
Change-Id: I17fa4d503d197b9b7c7405281001ea92714494a9
2019-02-25Build the sdui library for non-DESKTOP, tooTor Lillqvist1-1/+1
In order to get the Impress-specific dialogs in the (new, Online-based) iOS and Android apps, too. Change-Id: I7400326bafc1b8a0470b5ed0fb631ae984b7b795
2019-02-25Make SdAbstractDialogFactory::Create() do its job also on non-DESKTOPTor Lillqvist1-2/+0
Change-Id: Ife76336dbdeaadf08f631e3542be73a8568f5368
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-07 03:08:59 +0000