summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2017-09-08tdf#112280: Export spin animation in PPTX.Jan Holesovsky3-10/+89
Contains also: tdf#112280: Unit test. Change-Id: I9f13bbc2bd3a3de582491ea5b2ad16535589420a Reviewed-on: https://gerrit.libreoffice.org/42079 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-08tdf#109261: Crash when adding a video to a slide with zero undo stepsTamás Zolnai1-2/+6
When undo is disabled (no undo steps), ReplaceObjectAtView() method frees pPickObj, so we need to save it's reused data first. Reviewed-on: https://gerrit.libreoffice.org/41822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 27068e6cc39aed8ebfa5fdd7a67acb89f5adcb89) Change-Id: Icbc800d4d33cf229006aecde7d62aa2a7ea35879 Reviewed-on: https://gerrit.libreoffice.org/41861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 3ce90f78ed77c76ec6e0af3731f2fb37628ef89c)
2017-09-07tdf#106867: Export videos in PPTX.Jan Holesovsky4-0/+90
Contains also: tdf#106867: Implement pptx export of AnimationNodeType::COMMAND. tdf#106867: Import target for commands in PPTX. tdf#106867: Write also the extended markup to fully support embedded videos. tdf#106867: Unit test for the export of embedded videos. Change-Id: I7f4f389a72aa7ecef65d87f07bb69ba8f3374a14 Reviewed-on: https://gerrit.libreoffice.org/42017 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-07tdf#111884: Implement export of group shapes in pptx.Jan Holesovsky3-16/+36
Contains also: tdf#111884: Unit test. related tdf#111884: GroupShapes are now handled in oox. Change-Id: If12984c0670db6396cbfd0dcb8ae1f5a9b591705 Reviewed-on: https://gerrit.libreoffice.org/41766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/41997 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-06Revert "tdf#111798 Fix deformed export of flipped custom shapes to pptx"Jan Holesovsky2-59/+0
This work is incomplete, rather I'll fix my conflicts. This reverts commit 9c0387ef602d84d0079828f0ad4b53ada7ab1d8a. Change-Id: I20961cee4a5c28fc5486ca385974e9fcd5827dbe Reviewed-on: https://gerrit.libreoffice.org/42012 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-09-06tdf#111798 Fix deformed export of flipped custom shapes to pptxPaul Trojahn2-0/+59
Shapes were deformed because flipping wasn't considered when removing the rotation. Also WriteShapeTransformation needs information about flipping to convert the angle correctly. Change-Id: I7d485e93c00e02b9ec6c73ad6ae2876e5bc6360a Reviewed-on: https://gerrit.libreoffice.org/41462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/41996 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-08-25tdf#108926: Notes placeholder text boxes not shown in PPTsTamás Zolnai3-162/+178
Regression from: acb2943c8125f4ceed74f35f31776929dedeb8d8 Call this placeholder related code not only for normal slide pages. Reviewed-on: https://gerrit.libreoffice.org/41517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit b766cab621690a3aaf4e10fcf925ebab1c1925b8) Change-Id: Iae185ac7e5d2505554692045516cc51dbdcd735b Reviewed-on: https://gerrit.libreoffice.org/41528 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-08-25tdf#111548: PPTX: ActiveX checkbox control appear as pictureTamás Zolnai2-0/+37
Make ActiveX controls import working again (PPTX / XLSX) It used to work earlier, but there were an issue with the shape id and so controls were not find. Also in PPTX import the persistStorage attribute was handled only for parent controls and not for other kind of controls. Reviewed-on: https://gerrit.libreoffice.org/40751 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit c8e3633a352c2fda3aebb9781288a926e7a88c42) tdf#111548: Better fix for PPTX / XLSX import of ActiveX controls Follow up fix for: c8e3633a352c2fda3aebb9781288a926e7a88c42 Revert part of it and fix the real issue: shapid was messed up. Reviewed-on: https://gerrit.libreoffice.org/40929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 286c27e805c4501451857abff19c23b3719146a3) Change-Id: I9784166b65407b79b6dfed8a38087b55b1b69835 Reviewed-on: https://gerrit.libreoffice.org/41117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/41482 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-08-24tdf#110743: Use page position to insert master page, not idPranav Kant1-1/+1
Fallback from c454fbb9b62164d5f047990ae63522c9fb932086 Change-Id: I8835f1a23feeb12d77963e621e8d9d59568420f2 (cherry picked from commit f4e5940abbbaa3c2747108b0954e8912d164f3e5) Reviewed-on: https://gerrit.libreoffice.org/40633 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c9ff6f8f9c7f94070bef0909636f0ec91d9baaf7) Reviewed-on: https://gerrit.libreoffice.org/41430 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2017-08-21tdf#109863: Crash while trying to set pattern fill in ImpressTamás Zolnai1-0/+1
This line was missed to add in this commit: 76585ae33f3ca75c05c0ccbf6a621b6e2d42bc00 Change-Id: I2fb8c90b34ecbdfdd2bdc62adaa5e0a0d074ce33 Reviewed-on: https://gerrit.libreoffice.org/41129 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit e980d98dea38e71379f3ec02ab03fbff15022e5c) Reviewed-on: https://gerrit.libreoffice.org/41131 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 798d9e301d520b2a94cf0cf125ffa96e226e78b0)
2017-08-10tdf#111518 pptx: Add support for export of p:animMotion.Jan Holesovsky3-17/+70
Contains also the following patches: tdf#111518 pptx: Unit test. related tdf#111518 pptx: These attributes are not supposed to be here. Change-Id: Idd5692c803b1e8d434abc0154419a341934d0753 Reviewed-on: https://gerrit.libreoffice.org/40972 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-04Resolves: tdf#111308 crash after load designs with no design selectedCaolán McNamara1-1/+1
Change-Id: Ia7d5e1d0c4c960700d94cfec01a8a01799f89d9a Reviewed-on: https://gerrit.libreoffice.org/40732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e325a5442ab350e8eb66458aed98d38ce21aec06) Reviewed-on: https://gerrit.libreoffice.org/40750 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 2b4ebf00d21f6305966c78f82336f9ac76425804)
2017-08-04tdf#109223: PPTX: Vertical flip of child shape is not imported correctlyTamás Zolnai2-0/+34
Group shape level vertical flip is not handled well. Recent handling of group shape's transformation makes it hard to import this attribute, but we can import the right text direction at least. Reviewed-on: https://gerrit.libreoffice.org/40554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit d742c0019435d0bc90c9342492583636099a057f) Change-Id: Ib9e39e3dcb28a95fabc61c13152a3f7296fbd4c3 Reviewed-on: https://gerrit.libreoffice.org/40556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c49f2c00067cbe5de714525807290b71aec57ea3)
2017-08-03lok - add support for in place chart editingMarco Cecchetti1-9/+51
This commit add a minimal support for editing chart embedded in a spreadsheet or a text document or a presentation. Graphic object can be moved and resized, text object can be edited. Change-Id: I8e637dabf328a94bd6bb0e309a245302cff421d8 Reviewed-on: https://gerrit.libreoffice.org/40681 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-31don't jump back to selected slide on right click context menuCaolán McNamara2-3/+12
i.e. two many slides to fit in slide sorter panel, so scroll bar, select slide one, scroll to the end and right click between slides (or anywhere that isn't a slide) and without this fix the sorter jumps back to make the selected slide 1 visible. The right click menu will offer "new slide", choosing that will insert a slide at the point that was originally clicked, not at the point it was scrolled back to losing focus trigger a (dubious looking) callback to jump to the selected slide, so disable it while context menu is up Change-Id: Ie42bf158258cc38c9b7cfda7672f24d2ac8bfa11 Reviewed-on: https://gerrit.libreoffice.org/40383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 5e0b0be9b34343070b422c8a1cef1671c51f5773)
2017-07-31Windows build fix: ambigous symbolTamás Zolnai1-0/+7
Caused by: ae86557de53a8762924f18c78a556e2d6881002a These namespaces were removed from the cxx file, but not from the header. Change-Id: I5bae177638f0c9d404aac0fa4577689965ef5c26 Reviewed-on: https://gerrit.libreoffice.org/40585 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-26sd lok: disable undo state if conflict with other viewsHenry Castro2-32/+91
Change-Id: I046d118fca32c95f7734d6e29598da56578c9ec0 Reviewed-on: https://gerrit.libreoffice.org/39333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/39400 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-07-26sd lok: fix Undo/Redo Document RepairHenry Castro5-80/+57
REPAIRPACKAGE is sent to enable Undo/Redo actions when two views have conflicts. Change-Id: I58133f5b9006c41a297711c52ed0acfce3c19f92 Reviewed-on: https://gerrit.libreoffice.org/39325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/39398 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-07-20sd pptm: Preserve the VBA stream on export.Jan Holesovsky2-1/+37
This actually implements the reading of the VBA stream in Impress too, so the user will get a warning when opening such a file (that the it contains macros). Change-Id: I1638199529196ed217cbd9ebef88eb7c88f2179a Reviewed-on: https://gerrit.libreoffice.org/40197 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-20sd pptm: Add a separate PPTM filter.Jan Holesovsky4-53/+28
Similarly to commit 697173f6fdfae581022cfdb5ec5171c5a3be58f0, we have to preserve the correct content-type which is not the same for PPTX and PPTM. This commit also changes sdfilt.component to use the constructor feature. Change-Id: I4b334540ec07a53d308e6b9dd6403294842bddf8 Reviewed-on: https://gerrit.libreoffice.org/40195 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-12tdf#103355 Hide Notebookbar during slide showSzymon Kłos1-0/+5
Change-Id: Ie3e1b9f9dfc109ecb48cd384972dfa5a5118c3fa Reviewed-on: https://gerrit.libreoffice.org/34401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/38898 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 4e461f61ac739c6b9ff38c247095ea69b9fb4e21)
2017-07-08tdf#108925: Too small bullet size confuses the userTamás Zolnai2-0/+19
Add a constraint for bullet relative size to avoid too small bullets which are hardly recognizable. Use the same 25% lower limit what MSO uses. Reviewed-on: https://gerrit.libreoffice.org/39696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 11652be4071ef6d1d89b2c397aa1a32476e03bf6) Change-Id: Id956ecf3ec831c569188b944be58da03bf30a55e Reviewed-on: https://gerrit.libreoffice.org/39708 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-06Resolves: tdf#107959 SdrGrafObj leak triggers later crashCaolán McNamara1-10/+7
if the graphic doesn't change, then the cloned SdrGrafObj persists beyond stylesheet destruction and blows up Change-Id: I0013e7e118985c1334ab460507bc5c8271700160 (cherry picked from commit 118401aae4516bf4cc122e96b376d129ab3a3d5e) (cherry picked from commit e4db2fc10ba4447fa5393853d0cfed795b260f0b) Reviewed-on: https://gerrit.libreoffice.org/39261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit c00af602013b840f4f92c15b259ce6cdeeaabcae)
2017-07-05support for saving a modified image instead of original versionMarco Cecchetti1-1/+21
Normally when you save an image through the "Save..." entry in the context menu for an image, the saved image is the original one more eventually applied filters (which are not removeable). Further applied transformations like rotation, cropping, color effects are not included in the saved image. This patch offers the user to choose if saving the original image (with filters) or the modified version through a pop-up dialog. The new feature is available in Writer, Draw and Calc. Change-Id: I4f983e3a5e8a6839fa5789a96c4d8c44477c1fd7 Reviewed-on: https://gerrit.libreoffice.org/39487 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-27Resolves: tdf#108475 swipe only if some reasonable movement was involvedCaolán McNamara1-1/+3
Change-Id: I5ee2a60f80728a2cca1401e43c8e27f852bfc657 Reviewed-on: https://gerrit.libreoffice.org/39118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit be95033358460a3c411016297eb45a042460d4c2)
2017-06-21tdf#89064 Fix import of pages with comments and notesPaul Trojahn2-0/+13
importSlide removes the shapes on the page. It was used to import the comments and authors, which resulted in an empty notes page. Reviewed-on: https://gerrit.libreoffice.org/38648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit c2da33ead8b093b12ebb9a0ea9c06d156c41a3e6) Change-Id: I7d68085b482e5497d46e92328c413c87440714a0
2017-06-15Resolves: tdf#108187 fatal exception on testing if ooxml is a odfCaolán McNamara1-14/+23
Change-Id: Ie88a66aa8d73bb3c4045629604756470ce51b92b Reviewed-on: https://gerrit.libreoffice.org/38354 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 5e0e1facbdf1c4a2a3db253aa39c6253506a2f1b)
2017-06-06tdf#108024 Keep original selection during DrawViewShell::FuTemporary()Takeshi Abe1-1/+2
Otherwise it was disposed in the middle of its own mouse event handler FuSelection::MouseButtonUp(). Change-Id: I0d96048526dece7232e5a777364ad4da1d64c904 Reviewed-on: https://gerrit.libreoffice.org/37976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 96d59ffc572c4cf112405a85aee3366d45bc7757) Reviewed-on: https://gerrit.libreoffice.org/38302 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 64c8c76a1dca96cb2ceed2aced8ff4e5efd60aa9)
2017-05-31lok: impress: add support for undoing comment editingMarco Cecchetti3-5/+30
Conflicts: sd/source/ui/annotations/annotationmanager.cxx Change-Id: I735dd68d658f007ddd44d6acf692ee9b4555eb53 Reviewed-on: https://gerrit.libreoffice.org/37822 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-31lok: impress: undoing comment deletion doesn't workMarco Cecchetti3-58/+82
Conflicts: sd/source/ui/annotations/annotationmanager.cxx Change-Id: I3399ea4131acde42bdd307a8438a9129a83817f2 Reviewed-on: https://gerrit.libreoffice.org/37821 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-16sd: fix atexit crash in CanvasUpdateRequester::maRequesterMapMichael Stahl4-30/+54
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=2c9e4b335a4f17dea5e095f0a3e8f79aa40943cb Clearly it's a really bad idea to own these objects at shutdown, so instead use weak references, and also ensure that the CanvasUpdateRequester is not deleted before the event is dispatched just in case. (cherry picked from commit baa253d00ab6aa67fa100472db00227baa14c87a) sd: oops, skipped one entry on every erase by incrementing Thanks Noel for the hint. (cherry picked from commit 670631cae260263e4822d8aa63bc5c2e4349c796) Change-Id: Iee8a109fe5969b2a3345e0ef266aee014962ae57 Reviewed-on: https://gerrit.libreoffice.org/37263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 0f54a0f218834bfcc74b00f0a105785d3099bd40)
2017-05-11sd: Use unique Page ids for better multi-view support + unit testPranav Kant18-58/+124
... instead of using simple IDs which are assumed to be one greater than the slide position everywhere in the codebase. Use a 16 bit static counter and uniquely assign page ids to SdPage objects. This helps in identifying which slide was already selected in second view before any slide is deleted in the first view. Otherwise, using simple positions to keep track of it leads the second view to end up selecting the wrong slide after any slide is added or removed in the first view. (cherry picked from commit 3065dff28724f5dcf2592ce897f85d529c1f8554) Change-Id: I465cf7ea86899f0e52549062a9e5fa5cd459f978 Reviewed-on: https://gerrit.libreoffice.org/36943 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-10tdf#105703: Make sure we actually have a motion path hereKatarina Behrens2-2/+6
fix regression from my previous commit Change-Id: Iddba458ffaf7b647c1942b35d80aa37e6ff6ed13 Reviewed-on: https://gerrit.libreoffice.org/37216 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 9eae606ebc1ebd20dbc0aeb44e1f760e62afcdbe) Reviewed-on: https://gerrit.libreoffice.org/37226 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8501821f3b5ad541c40b5465aab000a6960b97ba)
2017-05-07Collabora Office: remove Safe Mode from menus and Windows start menuAndras Timar2-4/+0
Change-Id: I9eaf6ef76597be6bc35462308f1cee61cb9bae5a
2017-05-04tdf#105703: Restore user-defined motion paths for animationsKatarina Behrens5-9/+113
Yet another fallback from Google Summer of Regressions. The rest of the functionality has been removed by loplugin and other hyperactive code cleaners, so I've restored it, mostly unmodified. Change-Id: If0576abe9ce86c6f939d54bcf8f872dfce131e68 Reviewed-on: https://gerrit.libreoffice.org/37138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 17495047e53885a224c2180c10ec7ecece35135d) Reviewed-on: https://gerrit.libreoffice.org/37170 Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit fd2fe3b370abb38200da04602a28d9696ad12e12)
2017-04-18tdf#105286: Implement text rotation for Impress tablesTamás Zolnai5-1/+62
Typo: TopToBotton -> TopToBottom Change-Id: I1b4d3ab9ec1d1383d76a56c9662ffeeb9fe69655 Reviewed-on: https://gerrit.libreoffice.org/36014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 334e6e2f1ad3da319be0849ec426aa64b18cb599) Add SvxTextRotateItem inherited from SvxCharRotatItem I will be use it later for text rotation inside a table. Change-Id: I4cbaf05953b0e71331d2f3fdb45b7c4254a2b8cc Reviewed-on: https://gerrit.libreoffice.org/36021 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 1e30d2aface12a31687e5a27126e2061efd4b0cd) Introduce text rotation for Impress tables * Introduce new table property for text rotation * Support only two rotation angle (270° and 90°) * Implement editing and rendering of 270° rotated text (90° rotation was already implemented) (cherry picked from commit c671094154ecec6f3ba5beea9d26ff0d2d4d86ad) Change-Id: Ifc2e0f171e9c840e86b365e9af2c30aa97ecd92e Implement RotateAngle API property for Impress table cells (cherry picked from commit a0755ab8772d01797f4945016a978a2bbd8fdf20) Change-Id: I01379c0fc21e8fe294bc882bf824f64502863ff4 tdf#100926: PPTX import of table with rotated text (cherry picked from commit 2436cf17304f25c7d34da52a321d6da0e9011d19) Change-Id: I05a8e979ac11b179e15784023032a56edc5b569b ODF import / export of rotated text in Impress table (cherry picked from commit bcb371b1a830442610ad7fda476eda5271427a50) Change-Id: I57136e32ed2db5e405a45e8e4bad1b8d459b7ae8 Fix vertical text and bitmap bullet rendering Change-Id: I881fce0511c81b164516d68f72c7e750687d4e0e (cherry picked from commit 15ac3f9f4dc65fc0c6020284064e3725956f5d0a)
2017-03-30tdf#106857: use SfxInt32Item for ATTR_SNAPLINEJulien Nabet1-2/+2
and avoid crash with this bt: 3 0x00007ffff7449ef2 in __GI___assert_fail (assertion=assertion@entry=0x7ffff1f0cdd0 "dynamic_cast<const CntUInt32Item*>(&rItem) != nullptr", file=file@entry=0x7ffff1f0cce8 "/home/julien/lo/libreoffice/svl/source/items/cintitem.cxx", line=line@entry=232, function=function@entry=0x7ffff1f0d0a0 <CntUInt32Item::operator==(SfxPoolItem const&) const::__PRETTY_FUNCTION__> "virtual bool CntUInt32Item::operator==(const SfxPoolItem&) const") at assert.c:101 4 0x00007ffff1dd7ceb in CntUInt32Item::operator== (this=0x7fffffff2380, rItem=...) at /home/julien/lo/libreoffice/svl/source/items/cintitem.cxx:232 5 0x00007ffff1e0136e in SfxItemSet::Put (this=0x7fffffff2490, rItem=..., nWhich=<optimized out>) at /home/julien/lo/libreoffice/svl/source/items/itemset.cxx:510 6 0x00007fffc68c7ba1 in SfxItemSet::Put (this=this@entry=0x7fffffff2490, rItem=...) at /home/julien/lo/libreoffice/include/svl/itemset.hxx:131 7 0x00007fffc68d9052 in SdSnapLineDlg::GetAttr (this=0x55555bd802c0, rOutAttrs=SfxItemSet of pool 0x55555779b070 with parent 0x0 and Which ranges: [(28282, 28284)] = {...}) at /home/julien/lo/libreoffice/sd/source/ui/dlg/dlgsnap.cxx:159 Change-Id: Iebaf8d773a532f64c224c0371382132aa4a8d2eb Reviewed-on: https://gerrit.libreoffice.org/35885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit e1ff3782cc0bef951e7e5f0166c2b2395eaee26b) Reviewed-on: https://gerrit.libreoffice.org/35895 Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit b688a226c5e346e7fb27cdfc22190ed516afc0f4)
2017-03-29Resolves: tdf#106612 fix double click in draw/impress navigatorCaolán McNamara1-0/+3
Change-Id: Ic4b08c6e5cd430b5278bdc2cb7f1205bba160740 (cherry picked from commit 879aa0f71d98969f6bf2e540f1e95c7c9e0e05bf) Reviewed-on: https://gerrit.libreoffice.org/35539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 9fd212c3fbc28868e15f5d8e8ae598ac34176991)
2017-03-22lok sd: Fix crash when searching.Jan Holesovsky1-5/+14
This is a follow-up of ed5450f2a5ed8e72b48b4d976217746cea04a5c9 where the check for the HasView has been removed. Turns out that there are conditions when this really can happen, leading to crashes in the LOK searching. Unfortunately I did not manage to find a reliable reproducer to create a unit test :-( - so I suspect this commit might be more a workaround than a root cause fix. Would be great to find out the exact conditions leading to the situation when the EditEngine does not contain the EditView, and evaluate this fix against that - but that's hard without a reliable reproducer. A unit test for this fix is missing from the same reason. The unit test from ed5450f2a5ed8e72b48b4d976217746cea04a5c9 still passes. Change-Id: I1cca7219817119d27a224b35efb660a84d35b8fa
2017-03-17ofz#877 reference to stack alloced obj outlives objCaolán McNamara2-12/+9
(cherry picked from commit ae174b009bcf0f84073b9ebbf01ad31b274b789e) Change-Id: I8c854e2f651f8bf0018e8249827aae0fe23057e7 Reviewed-on: https://gerrit.libreoffice.org/35271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 037069698c6aa78a3509c0527b0bd00c412ba735)
2017-03-17Resolves: tdf#106557 don't crash on missing line spacing argumentCaolán McNamara1-177/+174
this is all a bit addled, but at least don't crash Change-Id: I19c35205446cebc83b8299839bcab8e02ff7c07d (cherry picked from commit ab10f03ec4dc7d5d7659fb62c59972c80221f733) Reviewed-on: https://gerrit.libreoffice.org/35261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit d0b73f86c667e3637cc439868cb84e7182d98786)
2017-03-14vcl pdf import: change test documents to test bitmap fallbackMiklos Vajna1-0/+0
I.e. the test documents now reflect what is created by LO if you insert a PDF image into a document manually on master. Change-Id: Ibacce15220a21b159b5e987678c381a98a29fd1a (cherry picked from commit b07da72778877f54fb84f091480435a60fb58aa2)
2017-03-14vcl pdf import: use pdfium instead of draw_pdf_importMiklos Vajna2-2/+2
Replace creating a full Draw component with direct pdfium library calls. This also means that the result is now a bitmap, not a metafile for now. Also decouple HAVE_FEATURE_PDFIMPORT and HAVE_FEATURE_PDFIUM, the first is the "import PDF into Draw" feature, the second is the "insert PDF as image" feature. Reviewed-on: https://gerrit.libreoffice.org/34217 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 6657d52417295265367cf3ffe5832b60e3c38011) Conflicts: config_host/config_features.h.in vcl/Library_vcl.mk vcl/source/gdi/impgraph.cxx Change-Id: I72c25642ec84cc831df362e02b1520c6e6d9adcf
2017-03-14Related: tdf#105093 sd PDF export: handle css.presentation.MediaShape as wellMiklos Vajna1-1/+1
It's exactly the same as css.drawing.MediaShape in this context. Change-Id: I4be114ef731e85222f0dd1d897f646ad8da3849d (cherry picked from commit 64d80d22851a38eb3f320f4e2b2bdf875da4d8b4)
2017-03-14tdf#105093 sd PDF export: handle embedded videosMiklos Vajna1-1/+8
In practie embedded files always have a temp file URL, so from the PDF export's point of view they are still URLs, just at the end the contents of the URL is embedded to the PDF, not just the URL itself. So add a SetScreenStream() that's similar to SetScreenURL(), but it's for embedded, not linked videos. Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781 Reviewed-on: https://gerrit.libreoffice.org/32727 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 4ad249af88d15f2c8a09f0721a59d82718fcc201)
2017-03-14Related: tdf#104841 sw PDF export: handle linked videos on non-first pagesMiklos Vajna1-1/+1
Be explicit about the page number, this way a video on the second page doesn't end up as an annotation for the first page. (In the Impress case each slide is exported separately, so there this wasn't a problem.) Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6 Reviewed-on: https://gerrit.libreoffice.org/32696 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 0e71075bb7379af318482bb3abbb630c58db9ec9)
2017-03-14tdf#104841 sd PDF export: handle linked videosMiklos Vajna1-0/+12
Use the screen annotation markup for this purpose. Change-Id: I129111cbe08c19c2f3b3ae046408ff9b2a28520c Reviewed-on: https://gerrit.libreoffice.org/32654 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 9d6a749bc664f1876c938afb9eba4adc9f6ee09a)
2017-03-13sd lok: Don't search on master pages & notes in Impress.Jan Holesovsky2-3/+24
Change-Id: I43ed9f53618dca09e0289bffadc2c05056e0eebb
2017-03-10tdf#106304: Fix newline and empty paragraph font size issues in .pptx exportTor Lillqvist1-3/+3
Output <a:br> instead of &#10; for hard newlines. This fixes the problem that the line before the hard newline in the .pptx export is not centred. The fix for the sd_export_ooxml1 test is a bit hacky, but then so is the code in question. Don't unnecessarily use bogus default char size for a:endParaRPr. Instead use the size last used for an a:rPr below the same WriteText() call. I am not exactly sure about how this hangs together, but this has the desired effect on the exported .pptx. (cherry picked from commit 1154cda87d518156d1e52dfb81d5e23b32ab23d5) (cherry picked from commit 6f93eeb0ba8c4af5c96d1db36f184ffbc71c67ba) Change-Id: Ie23e0c33e6efb303b183d3b2efce6866d0dda4e8 Reviewed-on: https://gerrit.libreoffice.org/34887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 31e6b78a196fbf73d61349ad3530cf49ee145186)
2017-03-01tdf#104222: Put expensive debug code behind #if againMatúš Kukan1-0/+7
dump_pset calls very expensive SdGenericDrawPage::getPropertyValue doing something with GDIMetaFiles. (regression from 5c7ce42dfc35d9cceef5f05a96e813b4e3913d38) (cherry picked from commit 9cbe69f1950115e47af693bd78fc78f96f9b508e) Change-Id: If39e9a451c87754343d77c8a1f840153c6b9de80 Reviewed-on: https://gerrit.libreoffice.org/34643 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit bc3b23f9c07aa2916c648abf1ca8c2af297250d4)
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 00:03:18 +0000