summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2019-09-26Configures page range in print dialogDaniel3-27/+18
Change-Id: I62bd9affc9e065d7afcc60296a72eae4612b0ddd Reviewed-on: https://gerrit.libreoffice.org/55840 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 76e22667625ce8d16dfaa8617a199b774e987a70)
2019-09-24Propagate stock info through slide layouts.Michael Meeks2-4/+8
(cherry picked from commit f107161bbd0eb4ee5766f5f983d18b32b929b15c) Change-Id: If717db82fe6ab14bbf32225c1f1c95f44954f011
2019-09-24Preserve stock images until render time.Michael Meeks1-7/+4
This allows us to choose to render HiDPI images at the right time, when we have the DPI of the device to render to. The first step in a better, and more industry standard way of improving our UI for HiDPI via rendering level scaling that should retain a consistent look across the app with many fewer changes. Change-Id: I36681f3242cb650de4f0b2d0fcdffbe5618e30fc Reviewed-on: https://gerrit.libreoffice.org/64040 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-09-20tdf#127163: Add AutoRedactDoc command to the Tools menuMuhammet Kara1-0/+2
Change-Id: I3a1081c29c222bf868a853ff19d471881fb43ce7 Reviewed-on: https://gerrit.libreoffice.org/78141 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79271 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-09-20Fix build when !HAVE_FEATURE_AVMEDIATor Lillqvist1-1/+2
Change-Id: I17fa4d503d197b9b7c7405281001ea92714494a9 (cherry picked from commit e54e668c51ec9230a3fc6a7cb1080d5696bea14e) Reviewed-on: https://gerrit.libreoffice.org/79172 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-09-20Build the sdui library for non-DESKTOP, tooTor Lillqvist1-1/+1
In order to get the Impress-specific dialogs in the (new, Online-based) iOS and Android apps, too. Change-Id: I7400326bafc1b8a0470b5ed0fb631ae984b7b795 (cherry picked from commit d71c5461704e120af9ae33aeefb79702be475680) Reviewed-on: https://gerrit.libreoffice.org/79171 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-09-20Make SdAbstractDialogFactory::Create() do its job also on non-DESKTOPTor Lillqvist1-2/+0
Change-Id: Ife76336dbdeaadf08f631e3542be73a8568f5368 (cherry picked from commit 056be933ea041939401f945df7f6e0a23e53a616) Reviewed-on: https://gerrit.libreoffice.org/79170 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-09-20We want the function pointer here, but not call it yetTor Lillqvist1-1/+1
We will call it just a few lines later. Change-Id: I967ff4eec2cfb1dcc7e8b02f32232be65b6366db (cherry picked from commit 895573518e84e319655877baadda1adc54003435) Reviewed-on: https://gerrit.libreoffice.org/79169 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-09-19Some !HAVE_FEATURE_AVMEDIA falloutTor Lillqvist1-0/+4
Change-Id: Ie7c2f75ec66ae4c1f8dc49075624617c294cbc25 Reviewed-on: https://gerrit.libreoffice.org/62945 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79131
2019-09-19make Insert->Header and Footer dialog asyncNoel Grandin2-10/+15
Change-Id: Icb2c507970c35a8ddee47912915882dede87ebca Reviewed-on: https://gerrit.libreoffice.org/66099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d095a887a9b0cce81b4f828feed759b5d0b3ad3f) Reviewed-on: https://gerrit.libreoffice.org/79123 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-19make Format->Bullets and Numbering dialog asyncNoel Grandin1-34/+39
Change-Id: Ib69c2be7c8ddaa616c08796ad2b8c8cf20ee2db9 Reviewed-on: https://gerrit.libreoffice.org/66098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a2b78c131db2bbe3555a89dfae32aefcd00949f5) Reviewed-on: https://gerrit.libreoffice.org/79122 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-18tdf#115549 Enable handling background object.Gülşah Köse1-1/+1
Change-Id: Ibb9c01d83572259b812981aa6229e9aa9b7c60f3 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/67215 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/78382 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-06tdf#126959 impress table border resize handle supportTomaž Vajngerl1-0/+5
This adds support to edit the resize handles for the impress. It includes: - sending the positions of handles when table object is selected or changed - a implementaton of SID_TABLE_CHANGE_CURRENT_BORDER_POSITION to perform the changing of the border positions of a table Reviewed-on: https://gerrit.libreoffice.org/78201 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 0285492a45e9cc19c26e14dcdf297bcc491da4d2) Change-Id: I6f60822c5cd9afc3be5c48ea7b775f1860bfa5a7 Reviewed-on: https://gerrit.libreoffice.org/78688 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-06tdf#127379: PPTX: Gradient background fill of a slide is lost during RT.Tamás Zolnai3-1/+28
Change-Id: I149bf161f53d566d461347e00d04fc45394bc051 Reviewed-on: https://gerrit.libreoffice.org/78670 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit ced915bf4c4dfc890193bbea269ef74995ecc888) Reviewed-on: https://gerrit.libreoffice.org/78705 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-09-06tdf#127372: PPTX: Shape's background transparency changes during RTTamás Zolnai21-259/+272
Need to use a better null value for FillTransparenceGradient. Use black-black which has equal effect than having no transparency at all. XFillFloatTransparenceItem has also an enabled attribute, but it can not be accessed via the UNO API. We can acces only the gradient object, so with a better null value we can check whether the API attribute is actually set or not. Reviewed-on: https://gerrit.libreoffice.org/78657 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 0417fb9ccd5a5467107621b5ac5ba1edcda71c68) Change-Id: I480489f588376582f80d5062145b7f398ef61ad7 Reviewed-on: https://gerrit.libreoffice.org/78701 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-09-03Transition sidebar: Apply the transition duration right away.Jan Holesovsky1-0/+2
In the desktop version, the value that is entered there always ends up applied. In the Online, there was a scenario when it did not: enter a value and switch slide by clicking the slide sorter. There is no harm to apply the value right away when the user edits, because in the desktop version, there was no way to avoid applying the value anyway. Change-Id: I519423d60f682735aeb1d471b3397ff9671c15fd Reviewed-on: https://gerrit.libreoffice.org/72923 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 5eea8c955b7632414c1d6c3ec0cbcf86c558efc6) Reviewed-on: https://gerrit.libreoffice.org/78448 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-09-03LOK: sd: no animation preview for LOKAshod Nakashian1-0/+4
Change-Id: I67babe9b340bafd196dedb2918d6a24bfc9c0ad5 (cherry picked from commit 259ce91cb63baa049bc57db79fd922ab5fd8be57) Reviewed-on: https://gerrit.libreoffice.org/78446 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-09-03sd: document the left pane classesAshod Nakashian1-2/+7
Change-Id: Id037e2f5f733ef7266ef6d48ff2ff7dea956ea25 Reviewed-on: https://gerrit.libreoffice.org/69070 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 0b3c2cb3cb8c8b2ddec6063c2ea75b24abf518fc) Reviewed-on: https://gerrit.libreoffice.org/78442
2019-09-03LOK: disable LOKit in unit-tests only after destroying allAshod Nakashian1-55/+3
When we disable LOKit at the end of a unit-test, we do so before any of the smart-pointers go out of scope. These instances are then destroyed when LOKit is no longer active, in spite of the fact that they were created while it was. This leaves some dialog/window routing notifiers dangling, which cause assertion failures and access-after-free (when they are invoked on destruction inadvertently). The latter issue was found with 'make CppunitTest_sd_tiledrendering VALGRIND=memcheck'. The fix is to move these flags to the setup and teardown stages of cpp-unit. Reviewed-on: https://gerrit.libreoffice.org/68256 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit ccb14cca567dc8bbc17fe0abde01effd08b37d4f) Change-Id: Ic4481305ca1a5cca14d70a4ebbc820a3fdeea9cc Reviewed-on: https://gerrit.libreoffice.org/78438 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-03LOK: sd: notify LOK of page size/orientation changeAshod Nakashian1-6/+19
Change-Id: I2eb92d83f50b91b39a10e22298d496668c1cbf72 (cherry picked from commit 50731e73a5e6103ba68b8f5a9143cc223d830410) Reviewed-on: https://gerrit.libreoffice.org/78437 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-03sd: support inserting background image from file via .uno:SelectBackgroundAshod Nakashian6-23/+54
The UNO command always prompted the user via file open dialog. This change allows for passing the filename as an argument to allow for inserting slide background programatically. Also, hide the Insert Image button in the sidebar since we can't use that (just yet), because it invokes .uno:SelectBackground directly. We would need to send LOOL a notification to invoke this on its own end to first prompt the user for a file. (cherry picked from commit 2118143bdd246921439ba9e835207585203dd45f) (cherry picked from commit d581c7723550187f5185ccd22b8c42d34cab64b4) Change-Id: I20c0e33d66f8bcd72a6388e39c4ac92e64978f45 Reviewed-on: https://gerrit.libreoffice.org/78434 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-09-03sd: modernize some loopsAshod Nakashian3-20/+13
(cherry picked from commit beb738eb8688ddaf133a0832328073e3e2b78757) (cherry picked from commit 808359e4def4f9dd1318c7d0330a14eacda7d02c) Change-Id: Ic86960ce2f690bebc51c9120053bdd50232f0358 Reviewed-on: https://gerrit.libreoffice.org/78433 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-09-03ViewShellBase const correctnessAshod Nakashian2-7/+7
Change-Id: I00bffe23f2f850f5e0cbf63a60aa1600f848edac (cherry picked from commit 4e6e33870a60a796c17c1e2d67ac6482b853ad28) (cherry picked from commit e1143d75eea07bdcd1e13d99a6015c1fc32bfb60) Reviewed-on: https://gerrit.libreoffice.org/78432 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-08-29sd lok: extend language status with BCP 47 language tag info in here as wellMiklos Vajna2-2/+19
This brings Impress in sync with Calc, which does this since commit 47025060e4474d23e3bd97053a77b3943eeae724 (Send Bcp47 codes with region, 2019-08-28). (cherry picked from commit 52d7c6be46663d4a28745a0cfa2ced5493637230) Change-Id: I04b92c85b6627e145b5271a6f84780257e8f0d55 Reviewed-on: https://gerrit.libreoffice.org/78258 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-27Set text field modified on edit in ImpressSzymon Kłos1-0/+3
To avoid not saved changes when user enters text field and then closes the browser. Change-Id: Iee06392eedcf8c1875017dbfb55552059f94bba3 Reviewed-on: https://gerrit.libreoffice.org/77504 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-08-15sidebar: Add .uno:MasterSlidesPanelAshod Nakashian1-0/+5
Change-Id: I578dc8b1f9c8df7f7cc9108c70d6fad8006871c6 Reviewed-on: https://gerrit.libreoffice.org/73502 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 11b06f0e00fc21654384e2816842ab101e15010e) Reviewed-on: https://gerrit.libreoffice.org/77492 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-08-15sd: LOK: avoid caching pointers and leakingAshod Nakashian2-12/+9
Change-Id: I68163bc30b0655b11dec34bdcc750b495b93365a Reviewed-on: https://gerrit.libreoffice.org/68265 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit da70e562087b6016aeaffadedc4ce66eaf370919) Reviewed-on: https://gerrit.libreoffice.org/76284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 593bf02c8b65cdea1d77c6800a9af57e1c6cb08b) Reviewed-on: https://gerrit.libreoffice.org/77491 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-08-07sd: LOK: support localization of slide transition presetsAshod Nakashian2-26/+22
Reviewed-on: https://gerrit.libreoffice.org/68264 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 312346531dde33cd000a1d3c95c7b7829b656438) Reviewed-on: https://gerrit.libreoffice.org/76283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3fa4f52ad52a1db53c2336eac8053502b03681e3) Change-Id: Ic3ea57e537e118e10d155203921574967154c234 Reviewed-on: https://gerrit.libreoffice.org/77083 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-07sidebar: hide preview and play controls in lokitAshod Nakashian2-4/+24
Change-Id: I7fc9470082612af4c4d7e56ff704936da5c63ce4 Reviewed-on: https://gerrit.libreoffice.org/73501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a59b4a2dcec4ad2131350a9999185ebcd07c5fc8) Reviewed-on: https://gerrit.libreoffice.org/77082 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-08-07sd: LOK: publish statechange on entering master viewAshod Nakashian2-0/+9
Reviewed-on: https://gerrit.libreoffice.org/69617 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ae2720ab206c2ff4a677e7fad147a3037f07a9be) Change-Id: Ib736800544b9669e3708da0c01370af22cdf3e97 Reviewed-on: https://gerrit.libreoffice.org/77038 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-07sd: LOK: support per-user localization of CustomAnimationPresetAshod Nakashian4-50/+34
This only fixes the caching in CustomAnimationPreset and CustomAnimationPane. Other cached labels will be done separately. Reviewed-on: https://gerrit.libreoffice.org/68263 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit b44679e47211a27f4fe22d05762d9d48c8f88935) Reviewed-on: https://gerrit.libreoffice.org/76241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3b55741586883d4fbb7f3e4c5368b5382c3ce5f8) Change-Id: Iaf511168d26b3a5567ca53556e242d3c071d2623 Reviewed-on: https://gerrit.libreoffice.org/77036 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-06sd: use OSL_DEBUG_LEVEL instead of DEBUGAshod Nakashian2-5/+5
Reviewed-on: https://gerrit.libreoffice.org/68258 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0c4a2b126c4aaa6f87baa1d86973b25fe7691009) Change-Id: I0703a1564a23657e956e43fe4cbf1d9549acb94f Reviewed-on: https://gerrit.libreoffice.org/77010 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-06LOK: sd: use native SdPage to flag selectionAshod Nakashian1-21/+5
The slide-sorter is actually still necessary to apply/change the master slide of a given slide, so we must enable it. Change-Id: I3f59f58be76ab1c63453b4f6288044572800a556 Change-Id: I7554ba4afd28d7ea4f3ed6ba375d9765a89ef21c Reviewed-on: https://gerrit.libreoffice.org/69618 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8213923c183c95c58b8c82ab6ad5e3f1611a4202) Reviewed-on: https://gerrit.libreoffice.org/77009 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-08-05pretty up logging of exceptionsNoel Grandin5-29/+36
Add exceptionToString() and getCaughtExceptionAsString() methods in tools. Use the new methods in DbgUnhandledException() Add special-case case code for most of the exceptions that contain extra fields, so all of the relevant data ends up in the log Change-Id: I376f6549b4d7bd480202f8bff17a454657c75ece Reviewed-on: https://gerrit.libreoffice.org/67857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-05LOK: re-factor async key & mouse event re-posting.Michael Meeks1-40/+4
A fairly pure re-factor, although adding disposed window checking to a number of sites with a warning. Moves the event emission helpers from VCL into SfxLokHelper: we're going to need more view / integration here next anyway. Removes lots of copy/paste horror. Change-Id: I279c11a1d8093b4feeeb6b7850f500806fff80dd Reviewed-on: https://gerrit.libreoffice.org/69218 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-08-05sfx: LOK: notify clients of the sidebar stateAshod Nakashian1-0/+5
Change-Id: I35b174c3a5e302ce52ee4063fa71d47feffab624 Reviewed-on: https://gerrit.libreoffice.org/73520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-05sfx: LOK: toggle sidebar decksAshod Nakashian2-2/+2
Change-Id: I0559a2a4ae041bc61cf3a2d5979656a7941f4b02 Reviewed-on: https://gerrit.libreoffice.org/73518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-05sidebar: Add .uno:MasterSlidesPanelAshod Nakashian6-0/+43
Change-Id: I578dc8b1f9c8df7f7cc9108c70d6fad8006871c6 Reviewed-on: https://gerrit.libreoffice.org/73502 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-05sfx2: Re-enable the sidebars for LOKAshod Nakashian1-61/+1
This re-enables the sidebars for LOK, which were disabled to avoid overheads. Also, fixes a regression where editing stopped when loading a new view because the sidebar window creation killed the edit view. Revert "Avoid various desktop GUI elements when used from LibreOfficeKit" This reverts commit c0b70ec34d5e056bb92a66cbf83838923cb41fee. Also (added by Noel to the above commit) (1) Comment out parts DesktopLOKTest::testPaintPartTile test that trigger a crash. We are installing a callback that points to something on the stack, and then not removing that callback, resulting in calls to random stack memory. There is a further problem in the LOK code in that we cannot uninstall a callback when we have multiple views because the uninstall code in doc_registerCallback can only remove a callback for the __current__ view, which I do not fix here. (2) prevent code from accidentally creating empty entries in the mpCallbackFlushHandlers map, which is what happens when you use the index operator on map, which results in a crash in doc_registerCallback because the std::shared_ptr is empty. (3) In SdTiledRenderingTest, only turn off LOK via LibreOfficeKit::setActive(false) once the document has been torn down. Otherwise, we don't remove entries from the statically allocated s_pLOKWindowsMap map in vcl/source/window/window.cxx, which means that at process exit, we have dangling Window objects. Reviewed-on: https://gerrit.libreoffice.org/71165 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 88565c3662c6fde240c98a9b4f2ce6dfbcf4094e) Change-Id: I06b06a990f05c06b1889fa89b698dff6f494e09c Reviewed-on: https://gerrit.libreoffice.org/76466 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-05lok: re-factor getTextSelection.Michael Meeks5-63/+16
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e Reviewed-on: https://gerrit.libreoffice.org/73626 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-08-05tdf#126605: Do not end TextEdit when changing an attributeXisco Fauli1-0/+28
otherwise, pTextEditOutlinerView becomes nullptr in svx/source/svdraw/svdedxv.cxx:2184 Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc Change-Id: I9d0645f637dc92b50d01682d119c0db60238e921 Reviewed-on: https://gerrit.libreoffice.org/76712 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 4155ed274d84135fc895d761d7ddcf0b462dccba) Reviewed-on: https://gerrit.libreoffice.org/76948 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-08-05tdf#126197: EndTextEdit on all views before delete/cut shapeXisco Fauli3-0/+36
Change-Id: I3da93e5c72ee6f6f99120758e870d654e01a0ec7 Reviewed-on: https://gerrit.libreoffice.org/75001 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 80db66c4f345ac469943f871308b14b7f5ed0a11) Reviewed-on: https://gerrit.libreoffice.org/75079 (cherry picked from commit e79dbb8c6c4d2cf1ce2cf0ce67c53ed4bb09898b) Reviewed-on: https://gerrit.libreoffice.org/75615 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit cbc54319369fc4bf1566bc4f46e53e38ef4e74ae) Reviewed-on: https://gerrit.libreoffice.org/76942 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-08-04tdf#126180: EndTextEdit on all views before delete/cut slideXisco Fauli1-0/+2
This also reworks the fixes tdf#125824 and tdf#111522 to use EndTextEdit instead of blocking the undoing Change-Id: I73c2289a9d950465f020f684e9e736148380f5c5 Reviewed-on: https://gerrit.libreoffice.org/74989 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit e6c7a018a0cfee395ce2886d41c908a2447ef5cc) Reviewed-on: https://gerrit.libreoffice.org/75027 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 1aa93766ee3994af9975e96e8ea60e02078de2d8) Reviewed-on: https://gerrit.libreoffice.org/75031 (cherry picked from commit f160dbfc92b89aff5afc4c87692e52bd50e3f09e) Reviewed-on: https://gerrit.libreoffice.org/76923 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-08-02LOK: getPartInfo now returns list of selected partsAshod Nakashian4-12/+50
For spreadsheets, selected parts are still unimplemented, so returns false for all. For presentations, visible parts seem to be always return false at load time. Change-Id: I90c79617f88deec98849bb374ca0ba177cd9c9af Reviewed-on: https://gerrit.libreoffice.org/69611 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73494 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-08-02LOK: support for ordering/moving partsAshod Nakashian2-1/+29
Currently reordering of slides is only supported for presentations, although it is provisioned for spreadsheets as well. Change-Id: I6c35066d6a5ef7586d34a8e8b89db69a20b86572 Reviewed-on: https://gerrit.libreoffice.org/69612 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73495 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-08-02slide-sorter: multiple selectionAshod Nakashian4-0/+60
Change-Id: I8624de25b0bb66020002890f33758e52059a24ab Reviewed-on: https://gerrit.libreoffice.org/69610 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73493 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-11SmartArt: hide connectors in org chart as they don't work correctlyGrzegorz Araminowicz1-2/+3
Fixing them would require a lot of effort. Changes are needed in data part (connector shapes are not created in group shapes associated with data shapes) and in layout part - routing them differently in all 4 or 5 hierBranch styles, with assistants and without. Change-Id: I48840454b0272dff9ba42db2eb5d65945642459a Reviewed-on: https://gerrit.libreoffice.org/75339 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75397 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-07-11SmartArt: improve organization chart layoutGrzegorz Araminowicz2-0/+60
layout shapes in two steps: * first calculate vertical child shapes count for every shape (taking into accout hierBranch alg variable) * then actual layout using that count to calculate size for subtrees Change-Id: I2e5ca34ed3383aa9502c52511cc1fb2bee215572 Reviewed-on: https://gerrit.libreoffice.org/75195 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75396 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-07-11SmartArt: better detecting connector arrow typeGrzegorz Araminowicz1-0/+0
* basing on provided conn alg params * also moved setting arrow direction from getConnectorType() to algorithms Change-Id: I76898a4ccad961edd389677c31e7d8c05bcdf5fe Reviewed-on: https://gerrit.libreoffice.org/70598 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75395 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-07-11SmartArt: remove calculateHierChildOffsetScale() from org chart algorithmGrzegorz Araminowicz1-2/+3
Its purpose was to center subtree if sibling parent has no children. It was not working correctly for complex charts causing shapes to overlap. Without it chart is still readable (just sometimes not centered). Remove it for now until more universal solution is found. Change-Id: I397bd4264d6ce0fadf5c5fa1352f22e72d5d163a Reviewed-on: https://gerrit.libreoffice.org/75092 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75392 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-21 18:23:54 +0000