summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2017-05-07revert OSL_ASSERT changesChris Sherlock74-241/+241
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert sd module away from OSL_ASSERT to assertChris Sherlock74-241/+241
Change-Id: I1e768d23da6adb1a3fe351a8105286b0cb5b5192
2017-05-05Fix typosAndrea Gelmini1-1/+1
To complete commit 0ef94e2b559547bc4e906e7f24e57ff5d642e108 and f12096272e684ddcd8ffa4e34dcb0a680cc594c2 Change-Id: Ie86bbfbd58dd728a013bef221e4d5c8fbcaf8e03 Reviewed-on: https://gerrit.libreoffice.org/37199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-05Defining SID_UNICODE_NOTATION_TOGGLE once is enoughMaxim Monastirsky1-16/+0
Change-Id: I6d63ee582ad5530ecb713dd65350912ee27dc15d
2017-05-05loplugin:checkunusedparams in svtoolsNoel Grandin3-10/+10
Change-Id: Iea68d7c0683740acaf4f85c14efe2a33e0cf13e7 Reviewed-on: https://gerrit.libreoffice.org/37201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-05loplugin:checkunusedparams in svx(part4)Noel Grandin4-10/+9
Change-Id: I032b49f4e1228ef275d7ff8d87ba969dcef687ab Reviewed-on: https://gerrit.libreoffice.org/37248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-05loplugin:checkunusedparams in svx(part3)Noel Grandin21-55/+55
Change-Id: I4b9b749565750acc7f674957fd619870b0e29237 Reviewed-on: https://gerrit.libreoffice.org/37240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04sd: oops, skipped one entry on every erase by incrementingMichael Stahl1-6/+7
Thanks Noel for the hint. Change-Id: I4992ce6d92ea185c7ab2f3ca452d3920204bb9f7
2017-05-04sd: fix atexit crash in CanvasUpdateRequester::maRequesterMapMichael Stahl4-30/+53
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=2c9e4b335a4f17dea5e095f0a3e8f79aa40943cb Clearly it's a really bad idea to own these objects at shutdown, so instead use weak references, and also ensure that the CanvasUpdateRequester is not deleted before the event is dispatched just in case. Change-Id: Iee8a109fe5969b2a3345e0ef266aee014962ae57
2017-05-04loplugin:checkunusedparams in svx(part1)Noel Grandin1-1/+1
Change-Id: Ie98ec3be5ece2579feca050563c5ab7776ad6a7e Reviewed-on: https://gerrit.libreoffice.org/37227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04loplugin:checkunusedparams in sfx2Noel Grandin2-3/+3
Change-Id: Iea88ddd619f10a2a2586ee24edbf07e246dcbb49 Reviewed-on: https://gerrit.libreoffice.org/37191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04tdf#105703: Make sure we actually have a motion path hereKatarina Behrens2-2/+6
fix regression from my previous commit Change-Id: Iddba458ffaf7b647c1942b35d80aa37e6ff6ed13 Reviewed-on: https://gerrit.libreoffice.org/37216 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini3-3/+3
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04include cleanupJochen Nitschke3-15/+3
after latest loplugin:checkunusedparams in sd Change-Id: I9f35343ed3e7ec2e709d7d910297eb0a63945a34 Reviewed-on: https://gerrit.libreoffice.org/37202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03svx: SdrObjEditView::SdrEndTextEdit() must be called after SdrBeginTextEdit()Michael Stahl1-0/+2
... to prevent disasters with managing the UndoManager, so assert that. Change-Id: Id577ea465e21e3d358b3ff0bb36de0af34e0b69d
2017-05-03loplugin:checkunusedparams in sdNoel Grandin72-248/+188
Change-Id: I217a4177e9c2cdc2d85100d253f7f38ec8aad756 Reviewed-on: https://gerrit.libreoffice.org/37162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03remove empty commentsNoel Grandin1-2/+0
found with: git ls-files | xargs grep -Pzl '/\*\* (\*|\s| )*\*/' Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597 Reviewed-on: https://gerrit.libreoffice.org/37159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03loplugin:checkunusedparams in filterNoel Grandin2-10/+7
Change-Id: Icdfe9c86b78f28fb79b697e769afe6acb1dbc6f6 Reviewed-on: https://gerrit.libreoffice.org/37139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02disable the tiledrendering tests in the headless build modeMarkus Mohrhard1-0/+2
This was pointed out by the Random Config tb. Change-Id: I8a4f70d6661178f2671e4e3588f5873c64885c07 Reviewed-on: https://gerrit.libreoffice.org/37175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-02tdf#105703: Restore user-defined motion paths for animationsKatarina Behrens5-9/+113
Yet another fallback from Google Summer of Regressions. The rest of the functionality has been removed by loplugin and other hyperactive code cleaners, so I've restored it, mostly unmodified. Change-Id: If0576abe9ce86c6f939d54bcf8f872dfce131e68 Reviewed-on: https://gerrit.libreoffice.org/37138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-02untranslated strings are just stringsCaolán McNamara25-116/+116
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-02tdf#77816 Duplicate dlg: enable fractionnal angleLaurent Balland-Poirier2-1/+2
In Duplicate dialog of Draw: Count angle in 100th of degree Change-Id: If1af9a42e7c35d39edbdc3fa624489d7e38b42e1 Reviewed-on: https://gerrit.libreoffice.org/36816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-02loplugin:checkunusedparams in editengNoel Grandin3-5/+3
Change-Id: I2b770d40ac2339cd2b04a765a6d970675d2ea1c1 Reviewed-on: https://gerrit.libreoffice.org/37133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02create SfxGroupId based on o3tl::strong_intNoel Grandin1-2/+2
Change-Id: Iaccf16f29b6f4b1a2c712d1e5e2bd0fa4fdb5e71 Reviewed-on: https://gerrit.libreoffice.org/37108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01sd: Use unique Page ids for better multi-view support + unit testPranav Kant18-58/+124
... instead of using simple IDs which are assumed to be one greater than the slide position everywhere in the codebase. Use a 16 bit static counter and uniquely assign page ids to SdPage objects. This helps in identifying which slide was already selected in second view before any slide is deleted in the first view. Otherwise, using simple positions to keep track of it leads the second view to end up selecting the wrong slide after any slide is added or removed in the first view. Change-Id: I465cf7ea86899f0e52549062a9e5fa5cd459f978 Reviewed-on: https://gerrit.libreoffice.org/36863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-05-01Remove SlotType sdi propertyMaxim Monastirsky2-14/+6
sdi files have two ways to specify the type of a slot: (a) Put it at the beginning of the first line (b) Using the SlotType property Where (b) have higher priority, and (a) is actually ignored for "method slots" (i.e. the ones that have parameter parentheses, even empty, and therefore get the SfxSlotMode::METHOD flag), which is very confusing. The goal here is to make exclusive use of (a) for all kinds of slots, and eventually remove the SlotType support code from svidl (in a follow-up commit). Change-Id: Ib6654d34e2f8aa8ebd0bd3c41aa2a86e30e9a634
2017-05-01Return values of sdi "method slots" were unusedMaxim Monastirsky1-4/+4
Also expand nested methods. Only diff in workdir/SdiTarget is for SID_STYLE_WATERCAN from sw/sdi/_basesh.sdi which changed the .uno name from WatercanStyleModeOnOff to StyleWatercanMode, to match the name in sfx2/sdi/sfx.sdi (it was forced by svidl to have the same name). Change-Id: Iaeac9f4f10a36cb0b3afe3de2b6def8cd90edc6d
2017-04-28loplugin:salunicodeliteral: sdStephan Bergmann5-11/+11
Change-Id: Ide4c05a1c025b4c093daababa499f46f360710c3
2017-04-28loplugin:checkunusedparams in accessibility and avmediaNoel Grandin1-1/+1
Change-Id: I94df9a65578792fb06f3b3259603f70ca1e0b3db Reviewed-on: https://gerrit.libreoffice.org/37059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28clang-tidy readability-simplify-boolean-exprNoel Grandin7-30/+8
Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a Reviewed-on: https://gerrit.libreoffice.org/36450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27tdf#107020: Reintroduce uses of I32S, I64SStephan Bergmann1-21/+21
...that had been removed with 4b788a12380518e31a9064d5839f4880d3f36874 "There should be no need to distinguish between I32S and I64S" (which this commit effectively reverts). I had erroneously assumed that the arguments to I32S and I64S would only be of (signed) integer types, and that it would be irrelevant that they are truncated to sal_Int32 resp. sal_Int64. However, at least oox/source/export/drawingml.cxx called I32S with double values (for which there is an OUString::number overload too), so the resulting strings could be rather different. Change-Id: Ib3887269fad0764740bc9ed3be91f67696a23b55 Reviewed-on: https://gerrit.libreoffice.org/37040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-27can detangle the sdext graphic resource nowCaolán McNamara1-4/+0
Change-Id: I2992b859bbebfa4bfae3ea5bfe76e8aa62193f69
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock5-5/+5
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26remove sd bitmaps from .src filesCaolán McNamara29-1235/+375
and recover referenced, but missing BMP_FOIL_NONE Change-Id: Ief35a3e2f2934cbbed86b2bca3bda4d998f54734 Reviewed-on: https://gerrit.libreoffice.org/36997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-26use strong_int for LanguageTypeNoel Grandin6-14/+14
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25vcl: change ErrorHandlerFlags to DialogMaskChris Sherlock1-2/+2
Change-Id: I1959ac97f679d8d719f851f9869962b39a20ded9 Reviewed-on: https://gerrit.libreoffice.org/36841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tdf#75280: convert sal_uIntPtr to sal_uInt32 for ErrorInfo memberChris Sherlock2-2/+2
Change-Id: I97f3b18604f17b0ccc9fd1bbb0221ff5e11fe826 Reviewed-on: https://gerrit.libreoffice.org/36840 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock6-6/+6
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25make __RSC a builtin define for the RSC compilerNoel Grandin1-2/+0
instead of randomly defining it in only some of .src files Change-Id: Ifec3920740723d248400f451d717b5288c421b8d Reviewed-on: https://gerrit.libreoffice.org/36832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock55-1/+55
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-24Indentation fixesMiklos Vajna1-2/+1
No functional changes intended. Change-Id: Ibc23de9cb33428765b8b0c85a221a2014ad4d7bd
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky6-17/+19
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-23tdf#95845 Use CommandInfoProviderMaxim Monastirsky1-6/+0
And a few unused theUICommandDescription includes. Change-Id: Ic80dbfb91e5e7662723efe0cb4090416994adabd
2017-04-23tdf#104610 Always enabled no-width break formatting marksYousuf Philips1-4/+2
Change-Id: I0708a61d43bfa44dac19683b200975e3a6da788a Reviewed-on: https://gerrit.libreoffice.org/36807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky15-15/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin5-7/+5
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19convert MeasurementSystem to scoped enumNoel Grandin1-1/+1
Change-Id: I5d26c50aa0e2c68edab6ee217ae6bdb0ee45dc09 Reviewed-on: https://gerrit.libreoffice.org/36525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-18remove sfx2/sfxcommands.hCaolán McNamara1-1/+0
Change-Id: Ic131adc90f2891497623441dd94da2d3401a93e5
2017-04-15ODF import / export of rotated text in Impress tableTamás Zolnai2-0/+31
Change-Id: I57136e32ed2db5e405a45e8e4bad1b8d459b7ae8
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-24 00:19:49 +0000