summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2019-11-22tdf#128952 Set the position of shape for 180 deg.Gülşah Köse2-0/+17
If the rotation value is 180, 540, 900... degree with mirror pShape->GetRotateAngle() returns 0. In that control 0 means no rotation but that is not true. For that cases (180, 540, 900) after the angle conversition GetRotateAngle() returns 0. We should recalculate the position for 0 too. Change-Id: I14e981235b2d6cd8382d4c9e151bccd2e73a3fd9 Reviewed-on: https://gerrit.libreoffice.org/83468 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-11-22make some classes module-privateNoel Grandin5-9/+7
Change-Id: If7303a082e06f6937fca911c578a40475546cda2 Reviewed-on: https://gerrit.libreoffice.org/83442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-22cui: add UI for semi-transparent shape textMiklos Vajna1-0/+2
- Make font color only work with the RGB color, otherwise the preview would be white for e.g. half-transparent red. - Add label and widget to see already set transparency. - Add a flag to show these only for Draw/Impress and leave Writer/Calc unchanged. - Update returned item set to contain transparency in case the widget changes. Change-Id: If77771076ff4b10a4a5d468a6583809a94deb57e Reviewed-on: https://gerrit.libreoffice.org/83520 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann55-11/+335
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-21xmloff: add ODF import/export for semi-transparent shape textMiklos Vajna2-0/+86
Test this from sd, so that SdModelTestBase::saveAndReload() calls BootstrapFixture::validate() for us. Change-Id: I6c90a3a71a5603604e69f9b45137bc8e4388dc0f Reviewed-on: https://gerrit.libreoffice.org/83371 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-20Remove comphelper::OUStringLiteralListStephan Bergmann1-3/+6
...that had been introduced with 51eb969cb77f8b54681033f4959b15ce32116b56 "Replace comphelper::ServiceInfoHelper::addToSequence" and obsoleted by <https://gerrit.libreoffice.org/#/c/83291/> "loplugin:redundantfcast: Don't warn about cast from braced-init-list" Change-Id: Ic5bb63cf4f528285587f46437a27bafbb05a07ac Reviewed-on: https://gerrit.libreoffice.org/83315 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-20loplugin:unusedmethodsNoel Grandin1-1/+0
Remove a filtering step in the python script that was hiding some results Change-Id: Id94268f150902405ab197c077f18aaedf98845fc Reviewed-on: https://gerrit.libreoffice.org/83256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20cid#1399334 Uncaught exceptionCaolán McNamara2-2/+2
and cid#1399224 Uncaught exception cid#1399153 Uncaught exception cid#1399090 Uncaught exception Change-Id: Icbafde4a1e1bd1713c25a20337f3e2d0f4103cad Reviewed-on: https://gerrit.libreoffice.org/83240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19tdf#125449 follow-up: unique gradient names in Impress area dlgKatarina Behrens1-0/+10
as seen in tdf#94300 chart prefers to name anonymous (non-preset) gradients all by itself However tdf#99908 shows that ODF import doesn't like anonymous gradients. This is a bug in xmloff style import and should eventually be fixed there. Here we implement the same band-aid solution tdf#99908 implements for Impress sidebar Change-Id: Ia39f581aee875ac95faa5c502a3479ed5d7974d8 Reviewed-on: https://gerrit.libreoffice.org/82522 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-11-18cid#1401321 Uncaught exceptionCaolán McNamara3-5/+7
Change-Id: I94603d614abf73881555c069f51c9c1adb5613b0 Reviewed-on: https://gerrit.libreoffice.org/83075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18convert AccessibilityFlowTo to scoped enumNoel Grandin1-68/+29
and drop the unused FORSPELLCHECKFLOWTO Change-Id: I128e84d386c10d001aa63f93b4b6dcb7238a1242 Reviewed-on: https://gerrit.libreoffice.org/83060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-17Removed executable permission on file pptxAndrea Gelmini1-0/+0
Change-Id: I93dd9533fc4f4d2acc1afe282754af0c78a25f73 Reviewed-on: https://gerrit.libreoffice.org/82985 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann6-0/+26
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16Replace comphelper::ServiceInfoHelper::addToSequenceMike Kaganski2-22/+19
Change-Id: I325e16fdf9bbbc6f2ba2d06c417da5eeb0d48023 Reviewed-on: https://gerrit.libreoffice.org/82975 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-16tdf128684: Rotate text in not preset custom shapeTamas Bunth2-0/+29
The TextPreRotateAngle property should be set in case of a not preset custom shape as well during ooxml import. Also add unit test for testing the TextPreRotateAngle property. Change-Id: Ib5b822286f8a78fe8398bf7e2014a36d7e0a24d5 Reviewed-on: https://gerrit.libreoffice.org/82643 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-11-15sd: define three columns for the slide transition paneHenry Castro1-1/+1
Instead of calculating extra space Change-Id: I26e763e5db0ff05fb1bd6f64f3054d8ef88a2156 Reviewed-on: https://gerrit.libreoffice.org/82526 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 58a3e6ad29eb7b616f03737265ef7a25afe83a36) Reviewed-on: https://gerrit.libreoffice.org/82673 Tested-by: Jenkins
2019-11-14jsdialog: send paragraph margins for impressSzymon Kłos1-0/+50
Change-Id: Ie0d4d3dc33de66609c005b77c1ef9802446ad57c Reviewed-on: https://gerrit.libreoffice.org/82658 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 29733bb39a16fc0e1398a7c18781226cfe755ff3) Reviewed-on: https://gerrit.libreoffice.org/82670 Tested-by: Jenkins
2019-11-14New loplugin:consttoboolStephan Bergmann1-2/+2
...to: "Find implicit conversions from non-'bool' constants (e.g., 'sal_False') to 'bool'". Due to how FALSE is defined as just #define FALSE (0) (i.e., a literal of type 'int') but TRUE is defined as #define TRUE (!FALSE) (i.e., an implicit conversion from 'int' to 'bool') in GLib (see the comment in ConstToBool::VisitImplicitCastExpr), we get more warnings about uses of 'TRUE' than of 'FALSE'. For example, in libreofficekit/source/gtk/lokdocview.cxx there is a warning about the 'TRUE' in g_main_context_iteration(nullptr, TRUE); but not about the 'FALSE' in g_main_context_iteration(nullptr, FALSE); (where the parameter of 'g_main_context_iteration' is of type 'gboolean'). Lets live with that asymmetry for now... (Besides the issues addressed directly in this commit, it also found the two bogus asserts at 7e09d08807b5ba2fd8b9831557752a415bdad562 "Fix useless assert(true) (which would never fire)" and 122a0be8ae480473bd1d7f35e197a2529f4621e3 "Fix useless assert(true) (which would never fire)", plus 5f0d6df7f57ae281fe161e61c7f25d67453fddd2 "Use two-argument form of static_assert".) Change-Id: Id77322de9f94b85a7b65608a03e0e9865d14467b Reviewed-on: https://gerrit.libreoffice.org/82667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-12Related: tdf#121239 missing contour toggle in draw/impressCaolán McNamara3-0/+18
Change-Id: I384ba1f4fc67d1da7738f25f8b5d3fade315342c Reviewed-on: https://gerrit.libreoffice.org/82471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12tdf#121239 give writer, calc and draw/impress the same underline optionsCaolán McNamara9-2/+251
uno:Underline is the "real" deal, and has multiple underline options uno:UnderlineSimple is "some underline on" vs no underline calc and writer had UnderlineSingle, UnderlineDouble and UnderlineDotted for that specific type of underline on vs not-on add those to draw/impress too and then use UnderlineSingle instead of Underline in the format menu so that when UnderlineDouble is applied, UnderlineSingle is not show as applied, instead of using Underline ot UnderlineSimple which would show as on if UnderlineDouble was applied Change-Id: I6f9fcf37c2c90d215ea52b536e4fa84734754850 Reviewed-on: https://gerrit.libreoffice.org/82469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12tdf#128651 SdrObjCustomShape::NbcSetSnapRect needs logic rectRegina Henschel2-0/+39
SdrObjCustomShape::NbcSetSnapRect needs a logic rect in its parameter. A general change to snap rect as input in NbcSetSnapRect is not possible, if the transformation has to be kept. Therefore callers need to be adapted. This is done her for SdrUndoAttrObj. The error was that for a transformed custom shape with text, undo and redo had generated a wrong size of the shape. A least the following actions were affected: extrusion on/off, shadow on/off, and changes in line or fill properties. The unit test uses extrusion on. Change-Id: I8b6990d3d57d25f15f18e8690fc49dbe5e2a2728 Reviewed-on: https://gerrit.libreoffice.org/82367 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-11-12Related: tdf#121239 super/sub not shown as toggles in draw/impressCaolán McNamara2-13/+4
Change-Id: Ibb4a8a638bdba0ec0b2a859c685233d36b6c852e Reviewed-on: https://gerrit.libreoffice.org/82468 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11Related: tdf#121239 overline missing in draw/impressCaolán McNamara3-1/+22
where underline already exists Change-Id: I87df3f3965526266b94f10fa04448b32a81fd99a Reviewed-on: https://gerrit.libreoffice.org/82459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11Fix typoAndrea Gelmini1-1/+1
Change-Id: I234d2a47d5c6717d194cc8407066fa5954c16253 Reviewed-on: https://gerrit.libreoffice.org/82409 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-10tdf#106638 oox: reset font settings if necessary.Mark Hung2-0/+24
Direct formatting was used when symbols were inserted. However when there wasn't any direct formatting of Latin fonts in the following runs, it didn't know how to reset the font. Get the default font with XPropertyState and try to reset to the default value if symbol fonts are set. Change-Id: I83c9317ba61a96375128f1cc3ed478d958ddaa5c Reviewed-on: https://gerrit.libreoffice.org/81956 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-11-08Fix tdf#124708: CRASH: Selecting all and deletingMuhammet Kara1-2/+6
Change-Id: I0de912dad97f266a56ab52a351b0676f17675ed5 Reviewed-on: https://gerrit.libreoffice.org/82332 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-08jsdialogs: apply .uno:FillColor in ImpressSzymon Kłos1-5/+19
Change-Id: Ic85233716998f3a88792501266c4d8214c4ab1a2 Reviewed-on: https://gerrit.libreoffice.org/82292 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82303 Tested-by: Jenkins
2019-11-08jsdialog: apply .uno:XLineColor in ImpressSzymon Kłos1-0/+15
Change-Id: I02bd0ce5d3b71e6acf28f56aead41abc76b42465 Reviewed-on: https://gerrit.libreoffice.org/82280 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82300 Tested-by: Jenkins
2019-11-08jsdialog: apply .uno:LineWidth in ImpressSzymon Kłos1-1/+29
Change-Id: I7b9a3e5d6af5ccf9e9be28c5a1460fbf8553ff08 Reviewed-on: https://gerrit.libreoffice.org/82275 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82281 Tested-by: Jenkins
2019-11-07Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: Ic1fa4455449bab3c83528c5474d478fbe5ce220b Reviewed-on: https://gerrit.libreoffice.org/82055 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-07android: ODR fix of RID_PAGEFORMATPANEL_MARGINS_CM.Jan Holesovsky1-0/+5
Without this, we get a linking error that RID_PAGEFORMATPANEL_MARGINS_CM is defined twice. Change-Id: Ib9c07adcb0a8def991d1e39429c1bb4947cd7d32 Reviewed-on: https://gerrit.libreoffice.org/82159 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-11-06Resolves: tdf#128631 dispatch active ole asyncCaolán McNamara1-9/+6
like we do for the other things that might create dialogs Change-Id: I31ca267526ddeac8d0c7163af45c11be7750cb4c Reviewed-on: https://gerrit.libreoffice.org/82143 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin2-3/+0
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06Impress Options Dialog Print updateandreas kainz1-144/+145
Change-Id: I401562e96c05a6c2af0bbe928bd92f7e611cced6 Reviewed-on: https://gerrit.libreoffice.org/82111 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06SdAbstractDialogFactory::Create is still needed by CppunitTest_sd_dialogs_testStephan Bergmann1-1/+1
This partialy reverts c02c4df9414ed2bef96565522238ca05013d3ac3 "make some classes module-private". Change-Id: Ice669f8a19d2721959b74125a3b2bddb8c06d60d Reviewed-on: https://gerrit.libreoffice.org/82120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-06Impress Print Dialog spacing HIG alignandreas kainz1-2/+2
Change-Id: Ic0d7ade5f8aeb9300ecb8d39c613f155f6587b2a Reviewed-on: https://gerrit.libreoffice.org/82112 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06loplugin:indentation find broken if statementsNoel Grandin4-11/+11
so I don't read the "then" block as being a sequential statements Change-Id: Ib2004acd3518bd4ebd2246f02a26c2c0a8bbab4c Reviewed-on: https://gerrit.libreoffice.org/82069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06Impress Sidebar Tabledesign updateandreas kainz1-7/+9
Change-Id: I54bc3e8a7d7a059311e72bb47b9945359dd32d0e Reviewed-on: https://gerrit.libreoffice.org/82114 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06Impress Options Dialog General updateandreas kainz1-132/+140
Change-Id: I019cba1f1e0031ea16b4c69f3ed2f41a1bd6a39f Reviewed-on: https://gerrit.libreoffice.org/82110 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05restore accessibility relationsCaolán McNamara1-0/+6
that went astray in... commit d3f9ff5202c72220ef3bc7d84d149f9beeb1d290 Date: Tue Nov 5 09:25:39 2019 +0100 Impress update Presentation Dialog Change-Id: I5dafc0a86d42be726d6c4ab5dc14877f4d6eb733 Reviewed-on: https://gerrit.libreoffice.org/82067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05Impress Effects Dialog updateandreas kainz2-165/+226
Change-Id: Ifa9a4c60038cd86e286e7bc1cf9fe97b0eceb5cb Reviewed-on: https://gerrit.libreoffice.org/82064 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05Impress update Presentation Dialogandreas kainz1-30/+42
Change-Id: I31d959bad05844adf77287ef5089cfa8bce5aa3e Reviewed-on: https://gerrit.libreoffice.org/82053 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05make some classes module-privateNoel Grandin3-3/+3
Change-Id: Ice9a57eedb166672dbdfae6da2a172ab77566a19 Reviewed-on: https://gerrit.libreoffice.org/81983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05jsdialogs: .uno:ChartBackColor with string argumentSzymon Kłos1-4/+18
Change-Id: I2f28a0ba957548b020eacf3d630dccef6ebbf5ed Reviewed-on: https://gerrit.libreoffice.org/82057 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-05Impress update Header Footer Dialogandreas kainz1-196/+237
Change-Id: I2662399692b18be511511020b66942c91699dc92 Reviewed-on: https://gerrit.libreoffice.org/82054 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05jsdialogs: .uno:Color with string argumentSzymon Kłos1-1/+28
Change-Id: Ifdc95ff8c6a71340de3ed66cf58bc937e3730810 Reviewed-on: https://gerrit.libreoffice.org/82038 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-03loplugin:stringaddNoel Grandin20-52/+44
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-02New loplugin:conditionalstringStephan Bergmann1-1/+1
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-02cid#1455210 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: Iadf78e41afabc8e3468e23bd5b249e47c019c843 Reviewed-on: https://gerrit.libreoffice.org/81936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455215 Improper use of negative valueCaolán McNamara1-1/+1
Change-Id: I0a397cb54192b613bf61a8faa384507b9731b828 Reviewed-on: https://gerrit.libreoffice.org/81940 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 06:43:27 +0000