summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2018-06-22pdfium: Delay the swap out.Jan Holesovsky1-4/+10
If we swap out too early, the constructor of GraphicObject forces a swap in, so we'd render everything during the load anyway. Change-Id: I0ea1a755242fd57ef28d082ce4bf534a32199f87 Reviewed-on: https://gerrit.libreoffice.org/56286 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-22pdfium: Avoid unnecessary copying + some warning fixes.Jan Holesovsky1-3/+2
Change-Id: I114fa6b2d3dda86c55eb245d31ca3a1019197ae9 Reviewed-on: https://gerrit.libreoffice.org/56285 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-22pdfium: Import PDF with unloaded images.Ashod Nakashian1-21/+13
Change-Id: I5e4a16ff38b9643127ce16879b35f456c13bcff8 Reviewed-on: https://gerrit.libreoffice.org/56268 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-22pdfium: Share the GfxLink for PDF files.Jan Holesovsky1-2/+2
Partially based on work by Ashod Nakashian, thanks! Change-Id: Id7e8c4543368b0caf3e459abaff8c53997779c83 Reviewed-on: https://gerrit.libreoffice.org/56265 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-05-25pdf: preserve the original page dimensions on importAshod Nakashian1-3/+10
Also allow for rendering PDFs to images at custom resolution, instead of hard-coded (old hard-coded value of 96 dpi is now default arguments). Change-Id: Ia5b52f72d6ce7130a2debc7c6f86504aa041bdc8 Reviewed-on: https://gerrit.libreoffice.org/54786 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-05-24sd: make the imported PDF page exactly as originalAshod Nakashian1-31/+6
i.e. no borders or larger page than rendered PDF Change-Id: I1f356cceeec1d5d9f1728f0e29160fdd9241a221 Reviewed-on: https://gerrit.libreoffice.org/54764 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-05-24sd: render the correct PDF page on swapping inAshod Nakashian1-5/+0
Change-Id: I81225e228d9cf2b9849110715dbfdeb59f2805dd Reviewed-on: https://gerrit.libreoffice.org/54746 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-05-22sd: disable pdf import testsAshod Nakashian1-3/+3
Change-Id: Iaee679d2ff322c67d081185588103d5685fa970a
2018-05-22svx: import PDF text using PDFiumAshod Nakashian1-4/+7
Change-Id: I7c75477f5257931f5182b8d65e898857526bf555
2018-05-22vcl: svx: preserve the imported PDF page number in GraphicAshod Nakashian1-0/+1
Change-Id: I1bb3fa7d44d5f92df2bb8c4ed4b85ccd984c2617
2018-05-22svx: sd: cosmeticsAshod Nakashian2-3/+3
Change-Id: Ic82e0b20b6e0f0ecdd308969c85c887ef84d2340
2018-05-22svx: share PDF stream when saving imported PDF as imagesAshod Nakashian1-1/+2
Change-Id: I05dd9ccb8f61c795212f8c587ee0a69c3cd75cf6
2018-05-22sd: import PDFs as images using Pdfium new SdPdfFilterAshod Nakashian4-27/+246
LOK now opens PDFs as images using Pdfium, which has a superior accuracy and support to poppler, the default pdf reader. (cherry picked from commit 0e8f4f45b44935c7c8002d606b97a48e60e37b23) Change-Id: Ifbbecf7f048f001836fb98886705cba47e6bed4e
2018-05-22make animation loop sal_uInt32 consistentlyCaolán McNamara1-4/+4
all this foo is ultimately animated gifs and the count there is limited to unsigned 16bit (cherry picked from commit 81047eaebc0e25ff926bf944c57e082a8727c7f2) Change-Id: Ib6e6dde7355f3619bb7735743e686e6338a235ee
2018-05-22sd lok: Enable mapmode in case of lok to calculate centerPranav Kant5-31/+20
This reverts the solution in 9fee132c18b658c9ea9fb1114c1fefa56b57532a. Also, calculate center using the new function for chart, image, and text shape insertion. Reviewed-on: https://gerrit.libreoffice.org/51343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 1990fc47bb561fcb9f98cbdcb7f986b93a54b876) Change-Id: I3386cf65d28d6537409a9e27e870c195d689ef50 Reviewed-on: https://gerrit.libreoffice.org/51531 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-05-22sd lok: guard all tests with lok flagPranav Kant1-0/+16
This was also the cause of one of the test failure in sd after 263790b806794a69d8f13f470e6a1933a9ebe53c Change-Id: I2a85faf416dad19c8aa8f544b54c7b84e49a8f96 Reviewed-on: https://gerrit.libreoffice.org/51418 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-05-22sd lok: Set the view size to full page size and hide ruler, scrollbarsPranav Kant3-2/+26
... such that during insertion of objects when sd calculates the center of the view to place the object, it is the center of the whole slide, not the center of the default rectangle of 800x600. It's also important to hide rulers, scrollbars so that correct center is calculated; we don't need them anyways in LOK. Change-Id: I1180541c1b8c8a35f39112ca0a670c9d96d1320b Reviewed-on: https://gerrit.libreoffice.org/51357 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-05-22tdf#115675: Shape selection was breaking when changing pos/size from sidebar.Jan Holesovsky4-41/+15
Fixes also other potential breakages with the same root cause. Change-Id: I09b3650189f6edb28ab64652cd411b1dca7dca89 Reviewed-on: https://gerrit.libreoffice.org/51341 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-05-22tdf#44774: Parent style's msApiName could yet be empty; use GetApiName()Mike Kaganski2-1/+31
Reviewed-on: https://gerrit.libreoffice.org/51069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a8fc81d478f4dcf8600ed9a2b4e0f7adff4a17ee) Change-Id: Ie0e218ea83d34aa7ee22fea1f32b2851a942544f Reviewed-on: https://gerrit.libreoffice.org/51101 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-04-07tdf#115407: preselect sound file savedJulien Nabet1-3/+5
To display the sound in the dropbox, the complete filename (eg: file:///home/julien/lo/libreoffice/instdir/share/gallery/sounds/pluck.wav) was compared with items of the sound list formed like this: file:///home/julien/lo/libreoffice/instdir/program/../share/gallery/sounds/pluck.wav See https://bugs.documentfoundation.org/show_bug.cgi?id=115407#c1 Since listbox displays only basename, let's just compare basenames Change-Id: I5fb49990322423fa7818e5d6e1cafd828e3500ec Reviewed-on: https://gerrit.libreoffice.org/52476 (cherry picked from commit 23c82e1a377ea6fce65d71277ec59b3ca150b98a) Reviewed-on: https://gerrit.libreoffice.org/52490 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fce0f5823bbd6297f3455a2a36e4a66c423db9b9)
2018-04-07tdf#116544 crash on unhandled IllegalArgument exceptionCaolán McNamara1-14/+62
Change-Id: I290ba6097d6d91bf4677e7e92c896bd6359cbc49 Reviewed-on: https://gerrit.libreoffice.org/51835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 92a0181d96a43a7a0449f400d38299097e864617)
2018-03-27tdf#84205 If theme not found, use firstSzymon Kłos3-2/+20
Not a complete fix, workaround. Change-Id: If4d765eaeae3419f4f1deb4e1cfbe0113a71da94 Reviewed-on: https://gerrit.libreoffice.org/51440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51458 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 586d56208861135e6548a4d73961e64cd3df5d68)
2018-03-27tdf#104789 Export opacity attribute nameSzymon Kłos3-35/+41
Change-Id: Id47ab6b3cb20fbcebb2d7fa589f3b0d7552e2cce Reviewed-on: https://gerrit.libreoffice.org/51369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51457 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 63f6174b67a7e731389d477e0856b64478e6511d)
2018-03-27tdf#104786 Don't export empty 'to'Szymon Kłos4-9/+33
Change-Id: I16b573fd6455813c6be5c2f5a0f0a820360a239f Reviewed-on: https://gerrit.libreoffice.org/51359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51456 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 16d316c912ef0ebbab30c66f2df898a407ca5c86)
2018-03-27tdf#90627 Don't save empty conditionsSzymon Kłos4-35/+47
Change-Id: I5a953c1b0fff7bf41a59360a8f52596264ddf266 Reviewed-on: https://gerrit.libreoffice.org/51293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51455 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit a21204ec1cf0b5f311f581ecce437785005d0456)
2018-03-27tdf#104792 Double check for target shapeSzymon Kłos2-0/+16
Change-Id: Ibe23377c7752d9ce97c7b100af4b2759b3ce946f Reviewed-on: https://gerrit.libreoffice.org/51241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51454 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 03a5a78a78808e1ec0c1cd4ee41c05cfa49143bd)
2018-03-08oox customXml: Don't write the Relationship to DOCX files twice.Jan Holesovsky2-5/+5
Change-Id: Id3da40138e86c142707e377aa897df372aacb704 Reviewed-on: https://gerrit.libreoffice.org/50943 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-07oox: unit-tests for custom package preservationAshod Nakashian3-8/+36
Change-Id: I69d0d7d6bdc8804d0e56be19cd86a699200fc85f Reviewed-on: https://gerrit.libreoffice.org/50895 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-03-06tdf#97614 Fixing initialization code for Bluetooth and IP Server for Impress.Rostislav Kondratenko2-7/+4
Change-Id: Icc385fb760b8a5ff337f58dc95ba3c3f86805eaa Reviewed-on: https://gerrit.libreoffice.org/50108 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit fb5f13671c50f7f84d654a779bc0ff07e31ce95e) Reviewed-on: https://gerrit.libreoffice.org/50414 (cherry picked from commit 424eb9e4282596818ed39943b9d4a64cb6888eef)
2018-02-26sd lok: Delete selection highlight after cutting text.Tamás Zolnai2-0/+42
Call drawing also after the new selection is set, similar to other cases where DrawSelectionXOR() is called before and after selection change. In desktop LO drawing is always called again and again by timeout, so there the selection is updated anyway, while in LO online painting does not emit a notification. Reviewed-on: https://gerrit.libreoffice.org/50268 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 56629f9797fa1cf8b7c86b93ee2ea62673444c94) Remove accidently committed debug lines (cherry picked from commit c64f2d34c0e62ec288b2e1453bf91f9f650db845) Change-Id: Id083a3bb38ba89e00239e71387377691afd4f31c Reviewed-on: https://gerrit.libreoffice.org/50335 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-24lok: All mouse,key events asyncPranav Kant6-67/+69
custom posting of mouse,key events on main thread This still bypasses vcl while keeping the processing of events on the main thread which is what we want. Change-Id: Ia7a6f5ef1ac546245715abe418d261b49df12d4c Reviewed-on: https://gerrit.libreoffice.org/50274 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-02-22Add some extra assert to this test caseTamás Zolnai1-4/+5
To find out why this test fails for some linux tinderbox. Change-Id: I49d1afbbac631abe49378b12b888615e3e0e1bef Reviewed-on: https://gerrit.libreoffice.org/50121 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 0a46237093c1750ee69ddb6a365098dc1d06b758) Reviewed-on: https://gerrit.libreoffice.org/50178 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-22Revert posting key events on the main threadPranav Kant1-2/+3
This partially reverts commit f2d3192e8a4ae743fcaab27ab6d829d57ae8fb60. Change-Id: Ic273e3f742d48dbfb73060a6ecb4feb80afdcfaa Reviewed-on: https://gerrit.libreoffice.org/50174 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-21lok: Factor out the code for finding vcl::Window of a documentPranav Kant1-15/+9
This should also help with IME input on charts Change-Id: Ie513790a5d0c87397c39301a328a44b59d394a45 Reviewed-on: https://gerrit.libreoffice.org/50094 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-21sd lok: Fix pasting text on slideTamás Zolnai3-1/+73
Use the same solution as for images in this commit: 9fee132c18b658c9ea9fb1114c1fefa56b57532a Place the inserted text shape to the center of the slide for LOK, because we don't get correct window size here. Reviewed-on: https://gerrit.libreoffice.org/50074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit e86fb2edfdca48b92b11c149002ab2b06a630b94) Change-Id: Ie0c3717d22da6b6a988ab8d566bd9759e03f86c8 Reviewed-on: https://gerrit.libreoffice.org/50097 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-19tdf#115639: Align right/center with trailing spaces the same as MS PowerPointTamás Zolnai6-0/+50
* Add HoriAlignIgnoreTrailingWhitespace compatibility option. ** For MSO file formats it is set to true ** For ODP format it's set to false by default ** The flag is saved to ODP format as user data if the document comes from an MSO format. Reviewed-on: https://gerrit.libreoffice.org/49889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 1da3a3cb74a415a76fa547ef0c8f61780e260e7f) Change-Id: Ie22233d33a25e605de46120bfc2195038dffd63c Reviewed-on: https://gerrit.libreoffice.org/49909 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-19PPTX export scale for TextFitToSizeSzymon Kłos2-0/+17
MSO requires to save fontScale attribute to have all the text shown properly (with FitToSize property) Values are approximated, after any modification in MSO scale is recalculated. Squashed: 7a510effa4566d405d2033b6635b42c08d34dec8 2c2919cb591d88b11bb2e25e45d6f75923821457 Change-Id: I73657fdd663b540b436747cfeeef3c76e8fe388c Reviewed-on: https://gerrit.libreoffice.org/49742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/49917 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-15tdf#51340: Line spacing is imported incorrectly from PPTXTamás Zolnai2-0/+42
Move the line spacing member to the TextParagraphProperties class which is used to do the inheritance from master / layout slides. Reviewed-on: https://gerrit.libreoffice.org/49692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 53551d49d3be2301985f2cf2d8bb23ff374ecfd1) Change-Id: I0bf92420963163eae78e06ebc7fdfa1f2c72fdf8 Reviewed-on: https://gerrit.libreoffice.org/49746 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-14lok IME: support dialogs as wellPranav Kant3-30/+15
Change-Id: Ic78da45dadaa5a4e1ca78e20d04974108581121e (cherry picked from commit 44fa8ae7d9bb3a28d860b2cc5871d6a6ccfc8411) Reviewed-on: https://gerrit.libreoffice.org/49728 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-13lok IME: VclEventId does not existPranav Kant1-2/+2
Change-Id: I7fc6cb50043eb9be6a9e53daac7edc8038dc04df Reviewed-on: https://gerrit.libreoffice.org/49661 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-13sd, sc lok: IME support + unit testsPranav Kant3-0/+71
Change-Id: I710ba4347977641102b89fd274a159d34bc29e72 Reviewed-on: https://gerrit.libreoffice.org/49385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit b746577d27437f9298fa111512d083eaccd4fbed) Reviewed-on: https://gerrit.libreoffice.org/49624 Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-12tdf#114821 import/export/place complex data labels in chartsSzymon Kłos2-0/+49
Change-Id: Ia44abcebb4febcabb1704aef85e396730ac2cd6f
2018-02-12tdf#115394 correct transition in case of 0sSzymon Kłos3-5/+21
Change-Id: I23d18acef0bd5db4a4ad6fc67d409e7ed5c93949 Reviewed-on: https://gerrit.libreoffice.org/49462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/49524 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-12tdf#115394 export custom transition time in PPTXSzymon Kłos2-41/+146
Change-Id: Ib8f4cef713895029dc18f68a07baa4b65e4260c0 Reviewed-on: https://gerrit.libreoffice.org/49245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/49522 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-12tdf#115394 export correct slide transition time in PPTSzymon Kłos5-6/+90
Change-Id: Ie293dd4cc128c256e39d54fdcd83bb5e13484662 Reviewed-on: https://gerrit.libreoffice.org/49345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/49523 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-12tdf#115394 import custom slide transition time in PPTXSzymon Kłos4-1/+36
* custom values are imported correctly * standard (fast, slow, medium) values are changed to match values in the MSO Change-Id: I004242afbbf641fe414abc8df248a2844c104502 Reviewed-on: https://gerrit.libreoffice.org/49139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/49521 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-09PPTX Fix export of rotated group shapesPaul Trojahn2-0/+15
The rotation is already applied to the child shapes and must not be added to the group. Reviewed-on: https://gerrit.libreoffice.org/42765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 465092047d5fa6ec6dd369372e712d76554570ff) Change-Id: Ic564cbcf31a81a248878f0179fdd21144f076b61
2018-02-05Resolves: tdf#110077 move the SvxBackgroundColorItem<->SvxBrushItem conversionCaolán McNamara2-26/+2
into the dialog itself Reviewed-on: https://gerrit.libreoffice.org/41029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6284804c2ccb3ad8bb6e1c1dac8d622f66b8c07d) Reviewed-on: https://gerrit.libreoffice.org/41168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit a407285747c65894bc858c4aa722a24e57caca31) Change-Id: I83db9f02145a4927257dd5691f82dad1a11eaea6
2018-01-24lokdialog: Parents for the Impress async dialogs.Jan Holesovsky3-4/+5
After 072e3ce1cfea5bb61cc5f3001c288df6deb45613, the dialogs must have parents, otherwise the LOK notification does not work for them. Change-Id: I46774d05a7d47adaaa0e06104541e47daf68f3db Reviewed-on: https://gerrit.libreoffice.org/48532 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-01-23StartExecuteAsync doesn't need a second paramNoel Grandin3-3/+3
we can just use this to store a keep-alive reference in AsyncContext Change-Id: I0152aef5386aa9753b48afdfc958790f10d13560 Reviewed-on: https://gerrit.libreoffice.org/48294 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/48459 Tested-by: Jan Holesovsky <kendy@collabora.com>