Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I1ab99995e35714d6ef3358400b0805723c44678c
|
|
since...
commit e94d5233dd7939c54eb52fff456e817cecdf0a4c
Date: Fri Mar 11 06:43:06 2016 +0100
work on sane lifecylce for SfxFilter
which removed "delete pFilter" though it was
pMediumFilter which was in question in this method
Change-Id: I598dd44a8498ebd6b3e63d1c89147bee5ab3bb55
|
|
In part of a table shape is selected, then only operate on the selected
cells, not on all of them.
Change-Id: I3a9ba2b99bcaa2e355b6fcdafdd142d4a809bce6
Reviewed-on: https://gerrit.libreoffice.org/33524
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
instead of storing both a raw pointer and an uno::Reference
Change-Id: Id608c50cb4cb3a7cf7ad972303a3c5f9fc8e79b0
|
|
Change-Id: I6ae02ad25863ec7e0f780020dbc69c9a99488c24
Reviewed-on: https://gerrit.libreoffice.org/33511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which can all be treated as SAL_WARN_UNUSED
The eehtml.cxx change probably fixes some CJK/CTL bug somewhere
Change-Id: I6852129540f316075aee907971ac19418d71dd9a
|
|
Change-Id: I4a1ba212b64c7b561f0c1b1f7f75fe255c8d1415
|
|
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:
1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
2. split the inheritance of Idle from Timer again to maintain
different Link<>s and move all common code into a TimerBase.
While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.
And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.
It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).
Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
|
|
to show the intend of the code.
assert on invalid objects.
remove useless OSL_ENSURE.
make sure list of owning pointers can't be copied.
Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c
Reviewed-on: https://gerrit.libreoffice.org/33393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
Change-Id: I50a728e785589e3ec2d9128679f3e69451c5102a
|
|
Change-Id: I9e8f4bf693734625ec3544e5d4f35a7d048ea609
|
|
Change-Id: I203ada1b4c527311ded56e6af0de7a7eb711f3f8
|
|
Change-Id: Ia1cced46dc8c76a252952129fb93be9d5a281057
|
|
Change-Id: I23d712846a9b198cc2fcb87f3b097766405f8bce
|
|
Change-Id: I01e47c52eb4313cf43561d7a57b71656fb66b2ef
|
|
Change-Id: Ic3f416300194d8fa9dfebc2b7a700396ba5641a5
|
|
drop cargo-cult second LocalResource use
Change-Id: I0c655f8ca15ad146bb11290fdefad67846ec8006
|
|
Change-Id: I75f4148ff864657e747b02d80a120177b469f28a
|
|
Change-Id: Ia74ca329d8438f614169031acfbe0406faf7c281
Reviewed-on: https://gerrit.libreoffice.org/33268
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2fc8a2fa57cc00edf2edab9e3722c824e75cb7e5
Reviewed-on: https://gerrit.libreoffice.org/33204
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Check for a macro that is defined by the compiler, we don't really need
one defined by the build system.
Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
|
|
Moves all the "task-specific" stuff into a Task class and just
keeps the "real" static Scheduler functions in the original
Scheduler class.
Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
|
|
In addition to the GDB pretty printer, this annotates a lot more
Timers and Idles.
Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
|
|
The indentation in these files is consistent otherwise, let's keep it
that way.
Change-Id: I1d73caa03425cd4d1c98ff07935512b002fb2c72
|
|
Brings a lot of features (icons, keyboard shortcuts,
customization, context menu interception etc.)
Other changes:
- Make SfxDispatcher::ExecutePopup take PopupMenuFlags
arg, to be able to pass NoMouseUpClose, so that the
menu won't close on mouse-up under anything != gtk3.
- Make .uno:OpenFromWriter and .uno:OpenFromCalc async
slots, to avoid crash under gtk3 when recycling the
current frame.
- Don't show the menu in customization dialog, if
experimental mode disabled.
Change-Id: Ieea2f73f6b48fbaf4bdfc4acf1a33d25422357cb
Reviewed-on: https://gerrit.libreoffice.org/33101
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: Ibcb08acfd8ac518388c33b97121fc04a7b7dbf03
|
|
The problem here is that the destructor of SdModule does a lot of
things, including destroying an SdXImpressDocument that is referenced
from some SdGlobalResourceContainer.
This calls SD_MOD() to get the SdModule to get some resource, but at
that point SfxApplication::GetModule() returns null, because the
sequence was changed from first deleting the SfxModules, then clearing
the pointer in ~SfxModule to null, to unique_ptr::reset(), which, at
least in libstdc++, is implemented via std::swap, so it clears the
pointer before deleting the SfxModule.
It appears rather brittle to rely on such a subtle detail, so refactor
things so that SdGlobalResourceContainer is no longer owned by SdModule
but has its own pet XTerminationListener, which means it will be
destroyed earlier, while the SdModule is still fully alive.
(regression from f7b1cd66167050afecf487e3d89ea12de74200b5)
Change-Id: I7f03f3adf431be8728ef3d65a078b536cb96f959
|
|
Although the UI prevents someone from renaming slides
so that two have the same name, it is still possible to
have such non-uniquely named pages apparently. Since drag/drop
uses the name to add a slide to the clipboard, it resulted
in duplicates of the first found instance of the slidename, and
loss of the similarly-named slides when they were dragged to
a new location.
Change-Id: I2986a7c6c3360162adf9430f645d0dfc73f1d4e2
Reviewed-on: https://gerrit.libreoffice.org/32481
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I761e07d1583262d83074addbff4ca67b01640387
|
|
Considering the valid indexes are extended by "-1" for backwards
iterators and "size()" for forward iterators, it's obvious that a
not-yet-at-the-end-in-the-other-direction iterator can be incremented
once, but not necessarily twice.
Why this code even wants to increment it twice isn't obvious to me.
Change-Id: I578c8c6202049ebe6dbed41b8276a6bfa0566bbc
|
|
Change-Id: If44cce6e4c241f6a2203d73f6d191f270fb5ca5a
|
|
Change-Id: I1b496a93449caa4a9699f71874f293eeaa1fa320
Reviewed-on: https://gerrit.libreoffice.org/32916
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I85681fcc81246414332f88dc46ce4a4b60896c97
|
|
Change-Id: I7aa74260f1456a22bae368738e3947ead1ecc7be
|
|
See https://bugs.documentfoundation.org/show_bug.cgi?id=100151#c33
Change-Id: I81e483189eacee086b680367148f8dd3ca2d3493
Reviewed-on: https://gerrit.libreoffice.org/32904
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8335ee35bae11c8014d6591744199e55bc3ec41b
Reviewed-on: https://gerrit.libreoffice.org/32854
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I753a49c35c0a459f110960c56ac345f8bfc79dee
|
|
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0
Reviewed-on: https://gerrit.libreoffice.org/32682
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Equivalent OOXML markup is <p:sp useBgFill="1">. For now only handle the
case when the slide doesn't have an explicit background, and assume that
in that case we can default to white solid fill.
This partially restores the code removed in
6137b5f72f5ec491ea6bd6631a65484fa24d2973 (coverity#735432 Logically dead
code, 2014-03-25), so that ProcessData::aBackgroundColoredObjects is
actually read.
Change-Id: I9e7a9a41965db50638e9d9d1b2361af9fd7a98ca
|
|
The bugdoc has two shapes. The red rectangle is supposed to be covered
by the other shape, but it wasn't as the fill style was set to none. The
reason for that was we ignored useBgFill, unless the slide had an
explicit fill style. Assume that in that case a white solid fill is the
default.
Change-Id: Iea20e216e44e13db68887f285c10bc1a8feacf0a
Reviewed-on: https://gerrit.libreoffice.org/32786
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
It's exactly the same as css.drawing.MediaShape in this context.
Change-Id: I4be114ef731e85222f0dd1d897f646ad8da3849d
|
|
Fixes size and position issues under gtk3/wayland
Change-Id: I357a5935e2b44fd3d5effde8cf7d3499e26384db
|
|
The problem itself was fixed by commit
2ad50c9a8c8411a57bbbd7a52734e72ffc4cc0ee.
Change-Id: Ie7f0781e1f5a4d6c5297882a5f64a68b85558515
|
|
In practie embedded files always have a temp file URL, so from the PDF
export's point of view they are still URLs, just at the end the contents
of the URL is embedded to the PDF, not just the URL itself.
So add a SetScreenStream() that's similar to SetScreenURL(), but it's
for embedded, not linked videos.
Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781
Reviewed-on: https://gerrit.libreoffice.org/32727
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Be explicit about the page number, this way a video on the second page
doesn't end up as an annotation for the first page. (In the Impress case
each slide is exported separately, so there this wasn't a problem.)
Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6
Reviewed-on: https://gerrit.libreoffice.org/32696
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Nobody can agree on what the poor string should say:
a2a605d864417209f3bfacc858fe9107a1e48531 "Image Styles"
cf5a2811bbf5c013da3c6421ecb013137b2cc595 "Graphic Styles"
b55b96589f7fe0b2f426c2472da7174ab95aab87 "Drawing Object Styles"
a71a562a9958fc58a5fb914bcf7f8056a353f618 "Image Styles"
77ab005ce70938d5541d5ffa7a937fb9e6beba1e "Graphics Styles"
... but since "Image Styles" is clearly wrong, let's try another
innovative variant.
Change-Id: I748a0fd50d6d13a48632f77434c7f3f35cc00050
|
|
Use the screen annotation markup for this purpose.
Change-Id: I129111cbe08c19c2f3b3ae046408ff9b2a28520c
Reviewed-on: https://gerrit.libreoffice.org/32654
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Isolating the patch itself from reorganization/optimization
of variables. No logic change intended.
Change-Id: I9e9008d57b4948372af138fb47224ebcf9c48ceb
Reviewed-on: https://gerrit.libreoffice.org/32480
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
|
|
found thanks to old comment
Change-Id: I9dbdd8c2f17243ce0d89468c18abd852c0e5eb78
Reviewed-on: https://gerrit.libreoffice.org/32420
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|