Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: Idf6a0a1e12fffee6c090add41247723f1d9cf576
|
|
Change-Id: Idf15ee825a34aa7788c422475aa6cea8ff802581
|
|
Change-Id: Ibaa2ed0ee2f1f3f00bceec91ccced968e4913e47
|
|
Change-Id: I297fb09996c694b920b4ae56e6da2f7a009c9386
|
|
Change-Id: Ifa54cc132f0c6591c57639f85e789b08a60b7f4b
|
|
Change-Id: Ib1a8716091a16eb970c9f218f4a8e496de72ff51
|
|
Change-Id: I303684cd0d4e2f3092cc776cd0b77725d6741bc6
|
|
Change-Id: I4ed22a776720bd6de64d08767a03a746276acba4
|
|
Change-Id: I0a2adcd606842c6b39665ecc641d2fd92c4eb7e7
|
|
Change-Id: I4ed28ad5ba94c055fbab51148d9258624dcfdb14
|
|
Change-Id: Ieb9e7f9d2b8ff89aa83e44f4f1d3f634adf71b25
|
|
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
|
|
Change-Id: I51f90299f0a2f9573dd8cfd1e6b875e7c76af125
|
|
Change-Id: Iec39551dafead84f4f0ad246e7e1d1ad16e15b4a
|
|
Change-Id: I9dc8366d2e8bd2ab16ce11c9e69cbdbdca0ccae5
|
|
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks
configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and
SvxBrushItem::GetGraphicObject. Checking in additional places will probably be
necessary to block /all/ unwanted communication. Also, some places marked
/*TODO?*/ currently pass in an empty referer (which is always considered
trusted) and will probably need to be adapted.
Ideally, Referer URIs would never be empty (and consistently use something like
<private:user> for cases where access is explicitly initiated by the user and
should never be blocked), but that's a very daunting task, so start small by
identifying the places that potentially need blocking and adding appropriate
Referer URIs there. Also, Referer information should always be computed as
freshly as possible from the context in which an access attempt is made, but,
again, always carrying the information from the context all the way to the
relevant functions is a very daunting task, so for now store the information
upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...).
The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already
used to track macro execution, and there is one place in
SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked
by the user) is done that needs the current document's URI as Referer to check
execution of macro URIs but needs an empty (or <private:user>, see above)
Referer to not block non-macro URIs. Special code has been added there to
handle that.
Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
|
|
...so it will be able to use SvtSecurityOptions internally.
Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
|
|
Change-Id: Ie6843c4d455dd82a8c1ebd8778165b04e7b94d71
|
|
Change-Id: I4940e801aeebc5e8457e17ca8cdb50d5301a5218
|
|
Change-Id: I7db34329a93c33c425f1e63fa842b218e4c9517c
|
|
Change-Id: I0e7bde090d68f840b4dee0fa27a7dfaf05a21e8a
|
|
Change-Id: I24a86c070d14e151d7fd893e17ccf10cd1b4e6e1
|
|
Change-Id: Id6e605546453a45124acf23cda90fe8a9031f580
|
|
Change-Id: Id1a974507f73193aa788523cebc75abd9fc684c5
|
|
Change-Id: I65ce35a10ea2ac406b9f42a47bd9f5619e136d96
|
|
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
|
|
Change-Id: If384ab765e09a6600d3e9cb559ed58dccb6b18c1
|
|
Change-Id: Ic0cee9c164eb077f76403a154461f1d1f3b52921
|
|
Thanks to Owen Genat for pointing the bug + location of the problem
Change-Id: I5f385f6cb5e9241f4fa65159df1f8bbefd2f383b
Reviewed-on: https://gerrit.libreoffice.org/6624
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
|
|
Previously inserting a new slide required using a context menu
(via right-click) or the main menu-bar. It is now possible
to insert a blank slide by double-clicking in an empty area
of the slide sorter.
Change-Id: Id7ac5f9d3befd02d0a89ad5e1631885c0493ad3d
Reviewed-on: https://gerrit.libreoffice.org/6442
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id3591b232b43deeb70e3e2fffb5c6a8f561223dd
|
|
Change-Id: Id99ba394b898b7da0057d4a145ce8dce46122782
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I7e3922ba635acdb14ca489bda2535a69249cb001
|
|
...the code doesn't make much sense that way.
Change-Id: I506e37b44924701255431f6d20d4610f7f52287d
|
|
Change-Id: I4285ccfb9609305b2e92fec6c3f79b5277016f8b
|
|
Change-Id: Ic3a7b927c4eceb4f059e84d135b710f150ccfc3e
|
|
Change-Id: I949533327ec101a2baef6e6f66e79677a62c3d9f
|
|
Change-Id: I598c7367806a88cd4e582333c1e2fc8b984333e5
Reviewed-on: https://gerrit.libreoffice.org/6561
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38
Reviewed-on: https://gerrit.libreoffice.org/6524
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Convert code like:
if( aStr == OUString("xxxx") )
to this:
if( aStr == "xxxx" )
Change-Id: I8d201f048477731eff590fb988259ef0935c080c
|
|
Change code like this:
aStr = OUString("xxxx");
into this:
aStr = "xxxx";
Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
Change-Id: Ida14cc278187fdc7519137829a920273ed4910b3
|
|
Quality translation by certified German/English teacher.
Change-Id: I4684630004ad2846b6a5ba76e18d30831d20bc26
|
|
unify svg:d handling, correct svg:d import for relative sub-polygons in svg
import; changed default for moveto writes for svg:d in ODF to absolute
(cherry picked from commit f15874d8f976f3874bdbcb53429eeefa65c28841)
Conflicts:
basegfx/inc/basegfx/polygon/b2dpolygontools.hxx
basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
basegfx/inc/basegfx/polygon/b3dpolypolygontools.hxx
basegfx/source/polygon/b2dpolypolygontools.cxx
basegfx/source/polygon/b2dsvgpolypolygon.cxx
basegfx/source/polygon/b3dpolypolygontools.cxx
basegfx/source/tools/makefile.mk
basegfx/test/boxclipper.cxx
basegfx/test/clipstate.cxx
basegfx/test/genericclipper.cxx
canvas/source/tools/surfaceproxy.cxx
sdext/source/pdfimport/tree/drawtreevisiting.cxx
sdext/source/pdfimport/tree/writertreevisiting.cxx
xmloff/inc/xexptran.hxx
xmloff/source/draw/XMLImageMapContext.cxx
xmloff/source/draw/XMLImageMapExport.cxx
xmloff/source/draw/shapeexport2.cxx
xmloff/source/draw/shapeexport3.cxx
xmloff/source/draw/xexptran.cxx
xmloff/source/draw/ximp3dobject.cxx
xmloff/source/draw/ximpshap.cxx
xmloff/source/style/MarkerStyle.cxx
xmloff/source/text/XMLTextFrameContext.cxx
xmloff/source/text/txtparae.cxx
Change-Id: I5171b4a3559ea116bea45152e1f2685666463635
|
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|
|
Inspired by this patch from Ariel Constenla-Haile:https://issues.apache.org/ooo/attachment.cgi?id=80653&action=diff
Change-Id: I8e482d9829eeb81a1f7cc89a4de781ae768f3333
Reviewed-on: https://gerrit.libreoffice.org/6141
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
As we have it globally in sal/types.h those are not necessary.
Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
|
|
So there is no need to do this locally, too.
Change-Id: Ibc623235cae07a86dfd0dbc1d7672ca4273facec
|