summaryrefslogtreecommitdiff
path: root/sd/source/filter
AgeCommit message (Collapse)AuthorFilesLines
2018-07-31crashtesting: failure on exporting tdf112587-1.odp to pptxCaolán McNamara1-1/+1
since... commit 7ff086c9141429e32c733f38d288cf67d6e9e3c9 Date: Tue Jul 17 18:58:27 2018 +0800 tdf#118836: fix grow-shrink animation in saved pptx. Convert AnimeTransform with transform type SCALE to animScale. Change-Id: I098db215b2970f321e2f8b715b1037140f2268be Reviewed-on: https://gerrit.libreoffice.org/58345 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-30Add missing sal/log.hxx headersGabor Kelemen7-0/+7
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories scripting, sd, sdext Change-Id: I47889cd889cf1d68353184229bfd4712f1528fbf Reviewed-on: https://gerrit.libreoffice.org/58220 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-29loplugin:stringloop in sdNoel Grandin1-3/+3
Change-Id: I5b0cd65b6e69490c79e0ac37c137283d19711787 Reviewed-on: https://gerrit.libreoffice.org/58252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25tdf#118836: fix grow-shrink animation in saved pptx.Mark Hung1-1/+29
Convert AnimeTransform with transform type SCALE to animScale. Change-Id: I39dfbdb814afa78ca981238bb1876f4af0995791 Reviewed-on: https://gerrit.libreoffice.org/57790 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24ofz#9261 catch all exceptionsCaolán McNamara1-10/+1
Change-Id: I535c9608bbd554a55edf9ccd58ac71032ba756fc Reviewed-on: https://gerrit.libreoffice.org/57902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24tdf#118835 export animClr element. ( handle AnimateColor ).Mark Hung2-2/+73
Implement PowerPointExport::WriteAnimateColorColor to export to, from, by elements of the animClr element. Change-Id: I0fb81f8838656c127610a9a10654e3e51106bea8 Reviewed-on: https://gerrit.libreoffice.org/57820 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24tdf#118835 fix missing attribute name conversion.Mark Hung1-58/+24
LineColor and LineStyle are missing from the switch-case. Just reuse the conversion list from oox::ppt::getAttributeConversionList(), also reoder the list so that fillcolor is prior than fillColor. Change-Id: Ia78553ad2fc908923da56bc58baf96dbb7d40863 Reviewed-on: https://gerrit.libreoffice.org/57819 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-19tdf#118783 sd:fix spin animation in saved pptx file.Mark Hung1-1/+10
The attribute name of the AnimateTransform is "Transform" but we expect "r" for "Rotate". We need to fix it so that PowerPoint recognize it. Change-Id: I47590d80d28af0a0ac92ef0892b40643f1de3643 Reviewed-on: https://gerrit.libreoffice.org/57579 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-18tdf#118806 sd: specify the motion path origin for pptx.Mark Hung1-0/+1
Motion path animation created by Impress always take the position of the shape as the origin, so set origin=layout. Change-Id: I8b4b579f3a2fc282b41a68c4c8d7573d01ad1aa9 Reviewed-on: https://gerrit.libreoffice.org/57583 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-18tdf#118768 fix pptx export of put on the brake animation.Mark Hung2-18/+20
1. Convert to, by, from based on attribute name for Animate. 2. Export auto reverse (autoRev) attribute. Change-Id: I11ae9997de29a5b0992889eed2eb58d48d81fbb5 Reviewed-on: https://gerrit.libreoffice.org/57554 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-16oox: enum MS_AttributeNames -> enum class AnimationAttributeEnumMark Hung1-2/+2
It's the attribute enum for the target animation. Remove MS_ prefix since it is in oox::ppt namespace and prepend Animation to make the purpose more clear. Change-Id: I0b6bbaf30ae4e2cf1cb0f6d5d24ba9f31e0b0773 Reviewed-on: https://gerrit.libreoffice.org/57353 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-14ofz#9403 null derefCaolán McNamara1-2/+3
Change-Id: I6efa4be9f4feb4f92f96f7030f933e4a0c406b1e Reviewed-on: https://gerrit.libreoffice.org/57435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-13Move convertMeasrue and convertAnimationValue from sd to oox.Mark Hung2-266/+5
1. convertAnimationValue convert the attribute value of a animation target from MS ppt to the format that slideshow understand, moving it so that it can be resued in oox. 2. convertMeasure is used by convertAnimationValue, moving it togehter eliminate the duplicated function in oox. Change-Id: I41cd1cf731b6496d7ae96b174a1748326415593f Reviewed-on: https://gerrit.libreoffice.org/57287 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-12return SvMemoryStream by std::unique_ptrNoel Grandin1-2/+2
Change-Id: I60a41111e76d72a7384cbb15f2d2a73c95af8c2d Reviewed-on: https://gerrit.libreoffice.org/57280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-10Make EscherPropertyContainer::CreatePolygonProperties saferArmin Le Grand1-15/+2
Additionally adapted EscherPropertyContainer's AddOpt methods to be more safe and flexible. Added support for SvMemoryStream. Changed Data handling in EscherPropSortStruct to use std::vector<sal_uInt8>, adapted all usages and converions throgh all modules. This makes memorty handling for these parts much safer (no more local new-ops, no longer delete[] there). Currently there are quite some usages of nProp.size() and &nProp[0] to access the data. but the base for further changes to work more on std::vector is done. Change-Id: I982225c5bfc06fdd9e195d18cd3c550d15f1d48d Reviewed-on: https://gerrit.libreoffice.org/57061 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-10pass SvStream around by std::unique_ptrNoel Grandin4-11/+6
and give utl::OStreamWrapper a new constructor so that it knows it is taking ownership of the SvStream, which appears to fix several leaks Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b Reviewed-on: https://gerrit.libreoffice.org/57187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-07tdf#112721 sd ppt export: don't adjust first line of tableJustin Luth1-1/+1
Round-tripping ppt files with tables was causing the text content to slowly creep downward as space was being added on each save. No unit test. Something is wrong with saveAndReload for PPT. Plus, I don't know what property contains this padding, or whether it is a cell object or what that contains it. Change-Id: I8918718c4ae2c87856910717c3ca8af1cbd86a6e Reviewed-on: https://gerrit.libreoffice.org/56690 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-02pass OutlinerParaObject around by std::unique_ptrNoel Grandin2-0/+2
SdrText::SetOutlinerParaObject was modified to not check for self-assign, and instead assert because the existing check was no longer possible. Fix bug in SdrUndoObjSetText::Undo(), where it was calling SdrText::SetOutlinerParaObject unnecessarily, because NbcSetOutlinerParaObjectForText already does that. Optimise Outliner::GetEmptyParaObject by creating a new constructor for OutlinerParaObject, so we don't need to copy the new object we get back from GetEmptyTextObject, unnecessarily. Change-Id: I57c475583d6c31658c154e24992b3d587bad9841 Reviewed-on: https://gerrit.libreoffice.org/56730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-28tdf#107690 OOXML import/export of setting "Open as read-only"László Németh1-1/+13
Import custom document property _MarkAsFinal as LoadReadonly setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX and PPTX documents. Before this fix, LibreOffice opened read-only OOXML documents as editable, also saved and exported _MarkAsFinal=true silently, resulting unintented read-only warning info bar in MSO. This commit improves interoperability a lot, because this is a basic document protection of MSO, recommended on its UI. Note: LoadReadonly (on File->Properties...->Security, property "Open file read-only") doesn't show "Edit read-only" info bar from commit 630186ff4e0eba7317e542f8c3eca39ebd068721, but it's still possible to switch on editing by Edit->Edit Mode. MSO shows info bar for _MarkAsFinal. (There is an advantage to hide the info bar in LibreOffice in a mixed environment, to avoid overwriting of press-ready MSO files by LibreOffice.) Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal in MSO: (1) Switching on editing doesn't remove the LoadReadonly property automatically in LO. (2) Saving with LoadReadonly doesn't switch off editing of the actual (still opened) document in LO. Change-Id: Ie279c0670090d075103384cfa44ff1c2a2898216 Reviewed-on: https://gerrit.libreoffice.org/56180 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-28tdf#42949 Fix IWYU warnings in include/osl/*hGabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib2301526d7aa6982af6c8c79ed7e9a4c34b7bbf7 Reviewed-on: https://gerrit.libreoffice.org/56491 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-27loplugin:useuniqueptr in PortionObjNoel Grandin3-16/+12
Change-Id: I79fcbaa12def04aa36bdf1928638b70ad490448c Reviewed-on: https://gerrit.libreoffice.org/56494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in EasyFileNoel Grandin1-7/+5
Change-Id: Ic18811145db90a7f9eff61e94069e68b3c80c298 Reviewed-on: https://gerrit.libreoffice.org/56196 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20move SvColorDialog to welded argumentsCaolán McNamara1-6/+6
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20loplugin:useuniqueptr in HtmlExportNoel Grandin2-4/+3
Change-Id: Ib146bdfd04f428d922e23ec6b5054d53326ca5f3 Reviewed-on: https://gerrit.libreoffice.org/56106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-18vcl: share GfxLinkAshod Nakashian1-2/+3
When importing PDF as images, we store the PDF stream in the GfxLink. For large PDFs storing a copy of the full PDF with each page is overkill. For example a 10MB PDF with 200 pages will consume 2GB of memory! Change-Id: I99913514cf5c562683080bc817668095bee69427 Reviewed-on: https://gerrit.libreoffice.org/55571 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-16tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[dDE]*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here and a bit of fallout management. Change-Id: Ie86a34f7f091525f21369f989165a56eace70513 Reviewed-on: https://gerrit.libreoffice.org/55558 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-12simplify calls to *DialogFactory::Create methodsNoel Grandin1-14/+8
we don't need to check for nullptr here, it's never null. Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56 Reviewed-on: https://gerrit.libreoffice.org/55114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-08look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin1-1/+1
Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-07vcl: svx: misc improvements to pdfium importingAshod Nakashian1-1/+1
Change-Id: I58f2fd973a731b148f40b37139cd74bac097a7d2
2018-06-07pdf: preserve the original page dimensions on importAshod Nakashian1-3/+10
Also allow for rendering PDFs to images at custom resolution, instead of hard-coded (old hard-coded value of 96 dpi is now default arguments). Change-Id: Ia5b52f72d6ce7130a2debc7c6f86504aa041bdc8 Reviewed-on: https://gerrit.libreoffice.org/54786 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-07sd: make the imported PDF page exactly as originalAshod Nakashian1-31/+6
i.e. no borders or larger page than rendered PDF Change-Id: I1f356cceeec1d5d9f1728f0e29160fdd9241a221 Reviewed-on: https://gerrit.libreoffice.org/54764 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-07sd: render the correct PDF page on swapping inAshod Nakashian1-5/+0
Change-Id: I81225e228d9cf2b9849110715dbfdeb59f2805dd Reviewed-on: https://gerrit.libreoffice.org/54746 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-07sd: pdf: really share the PDF streamAshod Nakashian1-1/+2
Change-Id: I5b25b3532912c7982a6db9dcc80fb7a72a41af38
2018-06-07svx: import PDF text using PDFiumAshod Nakashian1-4/+9
Change-Id: I7c75477f5257931f5182b8d65e898857526bf555
2018-06-07svx: support breaking PDFs imported as imagesAshod Nakashian1-1/+1
Change-Id: I990c2b3c3055fbffddedc407c34beb5824277b38
2018-06-07vcl: svx: preserve the imported PDF page number in GraphicAshod Nakashian1-0/+1
Change-Id: I1bb3fa7d44d5f92df2bb8c4ed4b85ccd984c2617
2018-06-07svx: sd: cosmeticsAshod Nakashian1-1/+1
Change-Id: Ic82e0b20b6e0f0ecdd308969c85c887ef84d2340
2018-06-07sd: import PDFs as images using Pdfium new SdPdfFilterAshod Nakashian1-0/+171
LOK now opens PDFs as images using Pdfium, which has a superior accuracy and support to poppler, the default pdf reader. Change-Id: Ifbbecf7f048f001836fb98886705cba47e6bed4e
2018-06-04tdf#42949 Fix IWYU warnings in sd/source/filterGabor Kelemen21-88/+88
Found with bin/find-unneeded-includes Removal proposals are dealt with, and necessary fallout management Change-Id: Ibf30bb929d2530572bbfee7ebeaad8a7fea7b3c2 Reviewed-on: https://gerrit.libreoffice.org/55208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-30tdf#42949 Fix more IWYU warnings in sd/inc/Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes A lot of fallout needed fixing, unfortunately Change-Id: I528cf5fe77199ee72f19fce3de08fe67e7f63dbe Reviewed-on: https://gerrit.libreoffice.org/54884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-25SOSAW080: Derive SdrObjGroup from SdrObjListArmin Le Grand3-7/+7
Also simplify parent/child relationships, get rid of double data (SdrPage/Parent infos in SdrObjects, also in SdrObjList). This is all not needed - when a SdrObject is inserted to a SdrPage, get SdrPage by traveling over parents (no double info, member as soon as inserted, ...). More cleanups/reworks included, will need some more cleanups, too. Stabilizing: SetRectsDirty/DefaultStyleSheet Had to correct the SetRectsDirty stuff for 3D due to going down the hierarchy while the 2D implementation goes the other direction -> endless loops. Added special handling for 3D stuff for now (will be chnaged again when SnapRect is no longer needed at SdrObject level). Also had to adapt how the DefaultStyleSheet is set at incarnated SdrObjects - better: their properties. Since we now always have a SdrModel, it is possible to correctly initialize with the correct default StyleSheet from that SdrModel. This needs to be done after ForceDefaultAttributes and in a way that again deletes Items that are set in the StyleSheet. This leads to an error in CppunitTest_sd_import_tests where I checked tdf100491 - it is okay and thus I change the control instance of the imported, XML-dumped file. The less hard attributes, the better for Styles in general. Cleanup of comments for last two commits Corrected SvxShape::getParent() Needed to get the direct parent, so test for SdrObject first (to get SdrObjGroup/E3DScene), for SdrPage second Fixed CppunitTest_sc_subsequent_export_test Several problems arose. The used SdrCaptionObj was Cloned, but the clone not inserted to a SdrPage. This leads to not being able to access a UNO API imlementation of the SdrPage (SvxPage) on lower levels. It worked before due to SdrObject having a SdrPage* additionally to being added to a SdrPage - this is exactly the main cleanup this change does. Looked for why it is cloned, could see no reasons. The SdrCaptionObj exists during all im/export, not difference to other SdrObjects (that do not get cloned). It is not changed in any way. It *might* be to suppress a crash that happened due to UNO API Service emfio/emfio not being available in the UnitTest scenario. Interestingly it did not crash with the cloned SdrCaptionObj, but the Graphic exported was probably wrong. Fixed by no longer Cloning the SdrCaptionObj and adding emfio/emfio UNO API Service. d139f821a5b39535a3e7b9c6261df7e18f8ae8ac 910e7f4bc628a715fda7545dffaf3369d5e76ea0 ca1de01b723051e09ac37d7ec7bba978beea41c5 3a76da1471dfe75e69847f64a6a3519ad21c8c9c Change-Id: I986586e326b563acebf00d931a7084c6eb09e5f8 Reviewed-on: https://gerrit.libreoffice.org/54689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-23sd: convert XGraphic to XBitmap for the "GraphicBitmap" propertyTomaž Vajngerl1-1/+5
Change-Id: Idec08d4823775b11976f8650fe942f296d6dd4ce Reviewed-on: https://gerrit.libreoffice.org/54695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-17tdf#116899: normalize key times during PPT import if neededAron Budea1-3/+12
If TimeAnimationValueListEntry contains time with -1000, key times have to be distributed evenly between 0 and 1. ([MS-PPT] 2.8.31) Change-Id: I67a3b83f1f1832fade5df7908c58032bcb9b73ce Reviewed-on: https://gerrit.libreoffice.org/53284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2018-05-17loplugin:redundantcast improvements for floating-integer conversionsStephan Bergmann1-2/+2
Change-Id: I63dbf18f144a792ae775fe6706da81657f790016 Reviewed-on: https://gerrit.libreoffice.org/54416 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-11weld SdDesignNameDlgCaolán McNamara1-32/+18
Change-Id: Ie8f7a62d55aabb520c234c995b01d85bf9f432b6 Reviewed-on: https://gerrit.libreoffice.org/54093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10loplugin:unnecessaryvirtual improvementsNoel Grandin4-16/+0
look for virtual methods where all of the overrides of the method are empty Change-Id: I87d99a0b647700a8d53498e0ab5f0437d3508553 Reviewed-on: https://gerrit.libreoffice.org/54060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-09Avoid division by zeroStephan Bergmann1-16/+31
...as happens during CppunitTest_sd_export_tests: > sd/source/filter/eppt/epptso.cxx:118:76: runtime error: division by zero > #0 in PPTExBulletProvider::GetId(Graphic const&, Size&) at sd/source/filter/eppt/epptso.cxx:118:76 (instdir/program/libsdfiltlo.so +0x38e7e7) > #1 in ParagraphObj::ImplGetNumberingLevel(PPTExBulletProvider*, short, bool, bool) at sd/source/filter/eppt/pptx-text.cxx:897:46 (instdir/program/libsdfiltlo.so +0x55464d) > #2 in ParagraphObj::ImplGetParagraphValues(PPTExBulletProvider*, bool) at sd/source/filter/eppt/pptx-text.cxx:1114:5 (instdir/program/libsdfiltlo.so +0x54c01d) > #3 in ParagraphObj::ParagraphObj(com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, ParaFlags, FontCollection&, PPTExBulletProvider&) at sd/source/filter/eppt/pptx-text.cxx:741:9 (instdir/program/libsdfiltlo.so +0x54e373) > #4 in TextObj::TextObj(com::sun::star::uno::Reference<com::sun::star::text::XSimpleText> const&, int, FontCollection&, PPTExBulletProvider&) at sd/source/filter/eppt/pptx-text.cxx:1313:47 (instdir/program/libsdfiltlo.so +0x5574a4) > #5 in TextObjBinary::TextObjBinary(com::sun::star::uno::Reference<com::sun::star::text::XSimpleText> const&, int, FontCollection&, PPTExBulletProvider&) at sd/source/filter/eppt/eppt.hxx:141:101 (instdir/program/libsdfiltlo.so +0x4068e7) > #6 in PPTWriter::ImplWritePage(PHLayout const&, EscherSolverContainer&, PageType, bool, int) at sd/source/filter/eppt/epptso.cxx:2367:39 (instdir/program/libsdfiltlo.so +0x3dc5bb) > #7 in PPTWriter::ImplWriteSlide(unsigned int, unsigned int, unsigned short, bool, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) at sd/source/filter/eppt/eppt.cxx:312:5 (instdir/program/libsdfiltlo.so +0x327239) > #8 in PPTWriterBase::CreateSlide(unsigned int) at sd/source/filter/eppt/pptx-epptbase.cxx:399:5 (instdir/program/libsdfiltlo.so +0x49896a) > #9 in PPTWriterBase::exportPPT(std::__debug::vector<com::sun::star::beans::PropertyValue, std::allocator<com::sun::star::beans::PropertyValue> > const&) at sd/source/filter/eppt/pptx-epptbase.cxx:233:15 (instdir/program/libsdfiltlo.so +0x48ff5e) > #10 in ExportPPT at sd/source/filter/eppt/eppt.cxx:1451:17 (instdir/program/libsdfiltlo.so +0x34dfdc) > #11 in SdPPTFilter::Export() at sd/source/filter/sdpptwrp.cxx:173:24 (instdir/program/libsdlo.so +0x26b070d) > #12 in sd::DrawDocShell::ConvertTo(SfxMedium&) at sd/source/ui/docshell/docshel4.cxx:662:29 (instdir/program/libsdlo.so +0x2c454b7) > #13 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1508:19 (instdir/program/libsfxlo.so +0x2baa19d) > #14 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&) at sfx2/source/doc/objstor.cxx:2792:39 (instdir/program/libsfxlo.so +0x2bcdc17) > #15 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objstor.cxx:2650:9 (instdir/program/libsfxlo.so +0x2bc86cf) > #16 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objserv.cxx:302:19 (instdir/program/libsfxlo.so +0x2b69519) > #17 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:2959:46 (instdir/program/libsfxlo.so +0x2cbd740) > #18 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1638:13 (instdir/program/libsfxlo.so +0x2cc26b5) > #19 in SdExportTest::testBulletsAsImage() at sd/qa/unit/export-tests.cxx:934:20 (workdir/LinkTarget/CppunitTest/libtest_sd_export_tests.so +0x8988c) Change-Id: I516bb2367d6a7fae23e2d474e63ab50af925208b Reviewed-on: https://gerrit.libreoffice.org/54034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-09tdf#116272 use correct property name when exporting to PPTTomaž Vajngerl1-2/+2
Change-Id: Ic1f5fb0e00531f9e36f05cbdf68b4c2fa7e98989 Reviewed-on: https://gerrit.libreoffice.org/53987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-08tdf#116977 secured ::Clone methodsArmin Le Grand1-1/+1
Renamed SdrPage::Clone -> SdrPage::CloneSdrPage Renamed SdrObject::Clone -> SdrObject::CloneSdrObject Giving SdrModel is no longer an option, but a must (as reference). This makes future changes more safe by force usage to think about it. Also equals the constructors which already require a target SdrModel. Done the same for ::CloneSdrPage. Change-Id: I06f0129e15140bd8693db27a445037d7e2f7f652 Reviewed-on: https://gerrit.libreoffice.org/53933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-26[API CHANGE] deprecate XGraphicObjectResolverTomaž Vajngerl1-11/+14
XGraphicObjectResolver was used to get the GraphicObject URL from an storage (package) URL. This isn't possible anymore in LO 6.1 since creating GraphicObject from uniqueID was removed for its lifecycle issues. XGraphicObjectResolver is now deprecated and when the "resolveGraphicObjectURL" is called, it throws a RuntimeExeption. In places where XGraphicObjectResolver was used, we now use the XGraphicStorageHandler as the alternative. Both share a common implementation so previously we could cast one to the other at any time. Now only XGraphicStorageHandler is used. GraphicObjectResolver was removed and replaced by the alternative GraphicStorageHandler for instance creation - where needed. Change-Id: I5d3f759c6f95b7dbe2d93688d99c8aa4899ffa84 Reviewed-on: https://gerrit.libreoffice.org/53279 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 11:02:27 +0000