summaryrefslogtreecommitdiff
path: root/sd/source/filter/ppt
AgeCommit message (Collapse)AuthorFilesLines
2015-10-02check stream status and string lengthsCaolán McNamara3-42/+43
(cherry picked from commit 7af19f45b35c428d3e06972806e5a05489f45955) if nSize was 1 with unicode encoding nSize would wrap around in lcl_getMaxSafeStrLen (cherry picked from commit f6368c29bdc3a9017bcae3f064d2cd8c7e37ed10) rework this so we don't read the string, backup and re-read the string again (cherry picked from commit 8523e57e427ef5b0b7f7067dcdd07f01176d2160) Change-Id: I99f3d4a2ec760228f485d01fce856deb9c068431 Reviewed-on: https://gerrit.libreoffice.org/18691 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-10-02reusing i here from the outer loop is definitely bogusCaolán McNamara1-3/+3
(cherry picked from commit 637ad743bb74a826ddd4db5efbcd33779b9132cd) Change-Id: I4ee52c76b2c1723639185bc99b85d83be5b4fdd7 Reviewed-on: https://gerrit.libreoffice.org/18687 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31check stream statusCaolán McNamara1-0/+8
Change-Id: I6b9537cf94ac1c5d996ba64ddf878745dadde254 (cherry picked from commit 452cd9e75de657e996e17510fe5d3539065489d1) Reviewed-on: https://gerrit.libreoffice.org/18129 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-31check stream statusCaolán McNamara1-9/+25
Change-Id: I609c8c4f4e843601361b61f55e0325ad99db3c23 (cherry picked from commit dc1be62d75e654e17c2f4c02804b7fd48d5a2515) Reviewed-on: https://gerrit.libreoffice.org/18119 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31guard against 0 item sizeCaolán McNamara1-2/+9
Change-Id: I9c4c2f0fe2d892615b3c70e08da0cab6da13338a (cherry picked from commit 2aadad1e89e96cb80c15fe1069cb6365f0cade1d) Reviewed-on: https://gerrit.libreoffice.org/18117 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31check seeks and readsCaolán McNamara2-18/+32
Change-Id: I0c5c4784713376e0762bfbd197640f8d31b65562 (cherry picked from commit 1847753ab135f522df6a293a8539155437f0129f) Reviewed-on: https://gerrit.libreoffice.org/18116 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31check for stream status after a read, not after a seekCaolán McNamara1-10/+15
Change-Id: I984e99c1a1484547aa4d60bf301167f3cbc9f716 (cherry picked from commit eea399ddd52a0de368321963bb828bc15632dd0b) Reviewed-on: https://gerrit.libreoffice.org/18075 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31avoid loops in atom chainsCaolán McNamara1-1/+7
(cherry picked from commit de71eae5807ff94c8eace0eccaabf1ffa08e77b6) Change-Id: Icc40c0ee6c7d8d305cf7cc60cbf3e511c763aedd Reviewed-on: https://gerrit.libreoffice.org/18080 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31check status of SeekToCaolán McNamara1-2/+4
(cherry picked from commit 932f6de91904f86f38d2914b9ce07b94dfadac0c) Change-Id: Ia2bb397c3fdd783cab77a6b0dbc31c9e3d19326b Reviewed-on: https://gerrit.libreoffice.org/18081 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31clip strings to max available sizeCaolán McNamara1-7/+20
(cherry picked from commit 580d3837b26f09ed02fe3583de40fa045a3fde0f) Change-Id: Icc1378c9c27b9b6d229bcffc6a63017f82be70d4 Reviewed-on: https://gerrit.libreoffice.org/18101 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31check seek for successCaolán McNamara1-1/+5
Change-Id: I02420ffb3af009d08ce54a0932e2c7a287703a72 (cherry picked from commit 1830b4f2e324090962a993315ce76752d24d4088) Reviewed-on: https://gerrit.libreoffice.org/18078 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31avoid hang in certain pptsCaolán McNamara1-1/+1
Change-Id: Iedba71b72fc815b274ca5e0da0903a558947cb06 (cherry picked from commit 90dc4e38928fffc3ed5fcbed40109712eb97e203) Reviewed-on: https://gerrit.libreoffice.org/18076 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31extend seek, loop ending tests to ppt specific codeCaolán McNamara1-14/+21
(cherry picked from commit c249f93d96ec87b0acbd25ffe087543d6fe9fb14) Change-Id: Id4419b6b902b742117e248870b6a663c9c58955f Reviewed-on: https://gerrit.libreoffice.org/18053 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31various hangs, check seeks and record lengthsCaolán McNamara1-2/+4
(cherry picked from commit a8b2dc80c41022515c3a1df6f7ea245c3390dc39) Change-Id: Ided7f9376f41ee8cb1f6903e54a2d51e0e07e1a7 Reviewed-on: https://gerrit.libreoffice.org/18026 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31don't hang on unreachable record endsCaolán McNamara1-1/+6
Change-Id: I288f7ff0327831603eda6e827c8acbae678dfaff (cherry picked from commit cadac8400a018c8c566379f7767ea5edff78523d) Reviewed-on: https://gerrit.libreoffice.org/18021 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava3-6/+7
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-13loplugin: cstylecastNoel Grandin1-34/+34
Change-Id: I071962c646199c30e842b9ec7673473de237ee45
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-1/+1
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-1/+1
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-10-20coverity#704010 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I90750c51ce3b38defdba7ecdb7734172983efa8c
2014-10-10coverity#1242757 Result is not floating-pointCaolán McNamara1-2/+2
there was two of these, see commit 164bd64255d71d96e35e908f6425acf8372795fb Date: Thu Oct 2 04:44:33 2014 -0500 coverity#1242757 Result is not floating-point Change-Id: I1f66191f329b2d87bdeb52aa1a7528ca662064a6
2014-10-06fdo#75757: remove inheritance to std::vectorTakeshi Abe1-15/+14
from PptSlidePersistList. This also puts in assertions that every entry in a PptSlidePersistList is non-null. Cf. 9536a28ede89e8c29940e8ba225215a45667062c Change-Id: Iea35532ed668e58a3f02d3f3433a66c2d4e1fe2a Reviewed-on: https://gerrit.libreoffice.org/11807 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-04coverity#1242757 Result is not floating-pointNorbert Thiebaud1-2/+2
Change-Id: Iae8ac2ad9d1713512619c5c33eeee9a21b5835f1
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann1-1/+1
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-08-21These "newly added" record types are publicly documented nowadaysTor Lillqvist1-3/+3
Use symbolic names from the MS-PPT RecordType documentation, http://msdn.microsoft.com/en-us/library/dd945336(v=office.12).aspx Change-Id: I1deecfc69dd3360ef982f144d5ff5348a2953280
2014-08-17check TRG_HasMasterPage before TRG_GetMasterPageCaolán McNamara1-1/+1
bff + valgrind Change-Id: Ie08ddfe06dc0850cf44955cc9f9079b3856b19e3
2014-08-04Consistency around SdrOnOffItem in svx/sdtagitm.hxxStephan Bergmann1-1/+1
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-08-04Consistency around SdrMetricItem in svx/sdtditm.hxxStephan Bergmann1-4/+4
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
2014-07-31Consistency around SdrMetricItemStephan Bergmann1-1/+1
...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem while others where of trivial derived classes SdrTextMinFrameHeightItem etc., that appear to only existed for better-named constructors. Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615
2014-07-19XFillStyle -> css::drawing::FillStyleMiklos Vajna1-2/+2
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-06-25remove whitespacesMarkus Mohrhard5-146/+0
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin2-10/+2
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13loplugin:staticcallStephan Bergmann1-2/+2
Change-Id: I502702dfd04405748a314bd171e6298850777c0a
2014-05-30coverity#705222 Missing break in switchCaolán McNamara1-0/+1
Change-Id: Ie127c5238fd2f69f52fb3cbe4090929eb23566f4
2014-05-30coverity#705223 Missing break in switchCaolán McNamara1-0/+1
Change-Id: I7b6f64fccc0fc16dff2d060c035fbad0ebb73335
2014-05-06Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part4Julien Nabet1-6/+6
Change-Id: I8e52c2fd66f8f3291434ee82a745431e11b12caf
2014-04-24sd: sal_Bool->boolNoel Grandin7-127/+127
Change-Id: I3172a42f6b6abe434ffe0475d1201ff50b6c06ea
2014-04-21remove comments why a file gets includedThomas Arnhold2-5/+0
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-14Clean up function declarations and some unused functionsStephan Bergmann1-5/+1
Change-Id: I7a2b5970fd0ab2059b5f5b0100a049e04ba54ee3
2014-04-14typo: atim -> atomThomas Arnhold1-1/+1
2014-04-14typo: suiteable -> suitableThomas Arnhold1-2/+2
2014-04-14typo: secunden -> secondsThomas Arnhold1-1/+1
2014-04-07coverity#708128 Uninitialized scalar fieldCaolán McNamara1-9/+12
Change-Id: Ic22b6640ba6b87769bdf00bc630d463de1ba04ad
2014-04-07coverity#708126 Uninitialized scalar fieldCaolán McNamara1-6/+9
Change-Id: Ib5dfaaf60551ed87c650863388e2e81b899bd253
2014-04-03filter/msfilter: sal_Bool->boolNoel Grandin1-9/+9
Change-Id: I24deda680469ce99ba358a68e83551bdb584751a
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann1-1/+1
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-31coverity#704291 Logically dead codeCaolán McNamara1-39/+25
Change-Id: Icfdb7178ea89f2a3bd9680cf1b2c017b5058bb83
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann1-3/+3
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-11svx: sal_Bool->boolNoel Grandin1-7/+7
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7