summaryrefslogtreecommitdiff
path: root/sd/inc
AgeCommit message (Collapse)AuthorFilesLines
2017-05-02untranslated strings are just stringsCaolán McNamara2-6/+24
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-01sd: Use unique Page ids for better multi-view support + unit testPranav Kant1-0/+6
... instead of using simple IDs which are assumed to be one greater than the slide position everywhere in the codebase. Use a 16 bit static counter and uniquely assign page ids to SdPage objects. This helps in identifying which slide was already selected in second view before any slide is deleted in the first view. Otherwise, using simple positions to keep track of it leads the second view to end up selecting the wrong slide after any slide is added or removed in the first view. Change-Id: I465cf7ea86899f0e52549062a9e5fa5cd459f978 Reviewed-on: https://gerrit.libreoffice.org/36863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-04-27can detangle the sdext graphic resource nowCaolán McNamara1-4/+0
Change-Id: I2992b859bbebfa4bfae3ea5bfe76e8aa62193f69
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock4-4/+4
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26remove sd bitmaps from .src filesCaolán McNamara2-10/+206
and recover referenced, but missing BMP_FOIL_NONE Change-Id: Ief35a3e2f2934cbbed86b2bca3bda4d998f54734 Reviewed-on: https://gerrit.libreoffice.org/36997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-26use strong_int for LanguageTypeNoel Grandin1-2/+2
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock2-2/+2
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock2-0/+2
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky1-1/+0
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-20loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-18remove sfx2/sfxcommands.hCaolán McNamara1-1/+0
Change-Id: Ic131adc90f2891497623441dd94da2d3401a93e5
2017-04-13convert slideshow context menu to .uiCaolán McNamara1-1/+0
Change-Id: I2e15f649ef628903899b5351bd52fc85b50fde8d
2017-04-13convert master page menus to .uiCaolán McNamara1-7/+0
Change-Id: I7ab0ad0f3216b69966f5ff345b052762993eb666
2017-04-11loplugin:mergeclasses merge E3dScene with E3dPolySceneNoel Grandin1-1/+0
Change-Id: I70f28fb4c87ad8c0e0ad46f4ce04914b6536d6b9 Reviewed-on: https://gerrit.libreoffice.org/36376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-01adjust cgm import to make testing easierCaolán McNamara1-3/+4
Change-Id: I2979af77522e085075d4f1e1e379fe82e614163b
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna1-7/+7
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28remove some more unused SID constants and commandsNoel Grandin1-4/+3
Change-Id: Ibf2bb58ca687c18798328ed86cd549d64f3621b4 Reviewed-on: https://gerrit.libreoffice.org/35792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove unhandled SID commands from svxNoel Grandin1-1/+0
In this case, also remove those unhandled commands which are present in a *Commands.xcu file, but not in any other kind of .xcu file. Change-Id: I8b42df7357349872e28d3ee60ec2c0505358cff6 Reviewed-on: https://gerrit.libreoffice.org/35648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27create SfxInterfaceId o3tl::strong_intNoel Grandin2-26/+25
Change-Id: Ie52f63382a9fb36f9a472801be012b140bfb51f6 Reviewed-on: https://gerrit.libreoffice.org/35722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27remove unhandled SID commands in sdNoel Grandin1-6/+3
checked to make sure none of the related .uno commands are present in any .xcu files. Change-Id: Iec555836a0a926e070b7632dc1205decf49d331f Reviewed-on: https://gerrit.libreoffice.org/35615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin2-3/+3
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16remove unused defines from HRC files in sdNoel Grandin1-18/+0
Change-Id: I2cbb6257aa65e45f3e46b64a8f00e36aecd95564 Reviewed-on: https://gerrit.libreoffice.org/35219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15remove unused HRC defines in sd/Noel Grandin1-51/+6
improve the existing 'find unused RID constants' script Change-Id: I6facbf9ef929bd31dc59eba4a1807c72b87cdb2f Reviewed-on: https://gerrit.libreoffice.org/35186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06Dia*Item classes are unusedNoel Grandin1-30/+0
Change-Id: I0546a15300312c19feaf701057ab0191547b9202 Reviewed-on: https://gerrit.libreoffice.org/34858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03convert SfxEnumItem to type-safe template classNoel Grandin1-6/+6
and drop the SvxChartTextOrientItem class, unused. Change-Id: I99100837d1beb953450f57b2cda47d165df1620c Reviewed-on: https://gerrit.libreoffice.org/34747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-22loplugin:unusedfieldsNoel Grandin1-6/+0
Change-Id: I8a114bcda99f123d230d61b0d0595bfe657cc3c0 Reviewed-on: https://gerrit.libreoffice.org/34513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:unusedmethodsNoel Grandin1-2/+1
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21sd lok: Include parthash in annotation list and callbacksPranav Kant1-0/+2
... and update the tests accordingly. Change-Id: Id11f2d19274e743b0e2a0bbeb0c21936f12b7777
2017-02-20Include <xmloff/autolayout.hxx> only where usedTor Lillqvist2-2/+1
Change-Id: Ia2964442a202690ddea9b9f2e976757846cec319
2017-02-20sd lok: Use IDs in ViewAnnotations outputPranav Kant1-0/+2
Change-Id: Ifb1f55ad5a1d21d63f9b37a83e3218c40dfa0b59
2017-02-16Move AutoLayout enum definition to its own file, and start de-duplicating itTor Lillqvist1-56/+2
The mysteriously named AUTOLAYOUT_ENUM had the same value as AUTOLAYOUT_TITLE_CONTENT, and was marked as "deprecated", so just use the latter instead. Use it also in xmloff instead of the magic number 1 in places where comments indicated that AUTOLAYOYT_ENUM was what the 1 meant. Will continue with the other "deprecated" and duplicated enumerators later. (Or you feel free.) Change-Id: Id5d70e07d30b3bf0d62e5d8719edb784bd23f99d
2017-02-15convert EValue to scoped enumNoel Grandin1-1/+1
and drop unused enumerators Change-Id: I22629ee4a514053030d7120ee8a8fb8145163fad
2017-02-15drop unused PRESOBJ_IMAGENoel Grandin1-1/+0
Change-Id: I8fa011bea423e961a3ebe7cd8687e4bce7c4cd77
2017-02-11tdf#89329: Use unique_ptr for pImpl in stlfamilyArnold Dumas1-1/+1
Change-Id: I0c9df5809a906dbc761f9a51c3424cebb215d0bc Reviewed-on: https://gerrit.libreoffice.org/34132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-04flatten STR_IMPRESS_PRINT_UI_OPTIONS resourceCaolán McNamara1-1/+1
Change-Id: Icef2a5ae31973c09620112dba062525d42bdd227
2017-02-03new loplugin:unusedenumconstantsNoel Grandin1-1/+0
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann6-75/+75
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor scaddins..sdextNoel Grandin2-3/+0
Change-Id: I6ae02ad25863ec7e0f780020dbc69c9a99488c24 Reviewed-on: https://gerrit.libreoffice.org/33511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski1-1/+1
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-19New loplugin:dynexcspec: Add @throws documentation, sdStephan Bergmann6-2/+17
Change-Id: I01e47c52eb4313cf43561d7a57b71656fb66b2ef
2017-01-19flatten resource, drop LocalResource classCaolán McNamara1-1/+5
drop cargo-cult second LocalResource use Change-Id: I0c655f8ca15ad146bb11290fdefad67846ec8006
2017-01-18new loplugin: useuniqueptr: sdNoel Grandin1-1/+1
Change-Id: I2fc8a2fa57cc00edf2edab9e3722c824e75cb7e5 Reviewed-on: https://gerrit.libreoffice.org/33204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13tdf#105188 sd: fix shutdown crash after accessing master pagesMichael Stahl1-5/+0
The problem here is that the destructor of SdModule does a lot of things, including destroying an SdXImpressDocument that is referenced from some SdGlobalResourceContainer. This calls SD_MOD() to get the SdModule to get some resource, but at that point SfxApplication::GetModule() returns null, because the sequence was changed from first deleting the SfxModules, then clearing the pointer in ~SfxModule to null, to unique_ptr::reset(), which, at least in libstdc++, is implemented via std::swap, so it clears the pointer before deleting the SfxModule. It appears rather brittle to rely on such a subtle detail, so refactor things so that SdGlobalResourceContainer is no longer owned by SdModule but has its own pet XTerminationListener, which means it will be destroyed earlier, while the SdModule is still fully alive. (regression from f7b1cd66167050afecf487e3d89ea12de74200b5) Change-Id: I7f03f3adf431be8728ef3d65a078b536cb96f959
2017-01-12tdf#64588 - prevent loss of non-uniquely-named slideJustin Luth1-0/+7
Although the UI prevents someone from renaming slides so that two have the same name, it is still possible to have such non-uniquely named pages apparently. Since drag/drop uses the name to add a slide to the clipboard, it resulted in duplicates of the first found instance of the slidename, and loss of the similarly-named slides when they were dragged to a new location. Change-Id: I2986a7c6c3360162adf9430f645d0dfc73f1d4e2 Reviewed-on: https://gerrit.libreoffice.org/32481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-21convert inventorId to scoped enumNoel Grandin2-9/+3
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21new loplugin datamembershadowNoel Grandin1-1/+2
Change-Id: Ib14319848bafd1fe7e0e663c434bbdeef5e98ecf Reviewed-on: https://gerrit.libreoffice.org/30963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18includes should be at the top of the fileNoel Grandin1-2/+2
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17tdf#103950 Undo does not revert bundled font size changes for table cellsNoel Grandin1-0/+3
Change-Id: Id41b7777739bfa93610f955e6c31f8bb979b8e2c Reviewed-on: https://gerrit.libreoffice.org/30902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-17loplugin:unusedfieldsNoel Grandin1-7/+3
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16new loplugin finalprotectedNoel Grandin1-2/+1
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-21 03:39:27 +0000