summaryrefslogtreecommitdiff
path: root/scripting
AgeCommit message (Collapse)AuthorFilesLines
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann15-24/+24
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-25tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu1-4/+2
Improved readability of OUString concatanations. Also removed unused OUStrings "sColor" and "sEntry" from the code. Change-Id: Ie9792f499cd880be72229f8a8c71f05ff8e258b6 Reviewed-on: https://gerrit.libreoffice.org/28375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-19Some clang-tidy misc-move-constructor-initStephan Bergmann2-4/+4
...by turning the relevant ctor parameters into "const &". Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
2016-08-19Revert "coverity#1371372 Resource leak on an exceptional path"Caolán McNamara4-30/+8
seeing as it doesn't build universally, java 1.7 onwards apparently This reverts commit 6830d8c2083fa66cc113f587cbfc4aa5a4f8a535.
2016-08-19coverity#1371372 Resource leak on an exceptional pathCaolán McNamara4-8/+30
and coverity#1371366 Resource leak on an exceptional path coverity#1371376 Resource leak on an exceptional path Change-Id: Ic0fd05f02b1d78a47d4ee924dee8f10811586d0d
2016-08-19coverity#1371367 Resource leak on an exceptional pathCaolán McNamara1-0/+3
Change-Id: I4da5f6d427e8132d62860b46cb4def88b8afb25d
2016-08-09python macros aren't listed under scripting organizeCaolán McNamara1-3/+2
since... commit deb989dd6d1f86e74864131be50ed92d8d43768c Author: Kenneth Koski <mechaxl@gmail.com> Date: Mon Feb 29 22:22:10 2016 -0600 blew away the uno.ByteSequence(str) path Change-Id: I8b73883c4f246ebafd2f810ca61b19da40f833e2
2016-08-05loplugin:countusersofdefaultparams in oox..sdNoel Grandin1-2/+2
Change-Id: I4504939a3957606979c6ac36af6611e1fe072d01 Reviewed-on: https://gerrit.libreoffice.org/27902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01remove dead ASYNC codeNoel Grandin1-47/+4
introduced in commit 0b21b8b146fc4b982c7c9bbb866b9ff18a29332a Author: Noel Power <noel.power@novell.com> Date: Wed Oct 6 10:16:27 2010 +0100 initial commit for vba blob and never activated or touched since then Change-Id: I34f9a5f702dd8f2254aa1efb94de61569220b90c
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara1-1/+1
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-15new loplugin unnecessary overrideNoel Grandin1-11/+0
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann1-5/+5
Change-Id: I678e89d9ff562446e7bbe8542a616c1b083dfcd1
2016-06-24compilerplugins: add OWeakObject::release() override checkMichael Stahl1-5/+2
Change-Id: I767857545d7c91615cf162790c04f0016de9fdf6 Reviewed-on: https://gerrit.libreoffice.org/26555 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-12BASIC : Add SbModule::FindMethodArnaud Versini1-10/+6
Change-Id: I3418c4a3d24b3b6630d6c80a6c8aa9d4ffb7e73a Reviewed-on: https://gerrit.libreoffice.org/24346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove unused imports in java codeNoel Grandin1-1/+0
Change-Id: I95041f49dd22ba9a15da3598b04a010eecf761a8
2016-05-23Convert SbxClassType to scoped enumNoel Grandin1-1/+1
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b Reviewed-on: https://gerrit.libreoffice.org/25259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin1-1/+0
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-15coverity#1361587 Dereference null return valueCaolán McNamara2-24/+26
and coverity#1361588 Dereference null return value Change-Id: Ia282c37e94d9d4131d18b3ccf6a8b7cb12c12344
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin1-6/+6
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-24Don't use SolarMutexGuard for returning a constantArnaud Versini1-2/+0
Change-Id: Ia6e31d7fe9d90f8094e2043de29a896c9e840c53 Reviewed-on: https://gerrit.libreoffice.org/24347 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-21new plugin stylepoliceNoel Grandin1-6/+6
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann6-11/+11
Change-Id: Ic3e7658ccfd23fa29af46eac971deac5a0373377
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin1-5/+4
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin2-2/+2
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin2-3/+3
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan2-5/+3
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #3tymyjan3-5/+3
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4 Reviewed-on: https://gerrit.libreoffice.org/23752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01sequence->vector in scriptingNoel Grandin3-26/+23
Change-Id: I5efd5ed8755b6127f08f711b8b7337b87b89bbd4 Reviewed-on: https://gerrit.libreoffice.org/23700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin1-1/+1
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-17loplugin:constantparam in toolsNoel Grandin1-1/+1
Change-Id: I3774661799c074561c694515baba42a375d0a077 Reviewed-on: https://gerrit.libreoffice.org/23301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-14remove some unused Java codeNoel Grandin2-8/+0
found by UCDetector Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
2016-03-14scripting: JDK 1.5 compatibility: don't use java.awt.Font.MONOSPACEDDouglas Mencken1-1/+1
MONOSPACED is defined in java/awt/Font.java as /* @since 1.6 */ static final String MONOSPACED = "Monospaced"; Change-Id: I31847c939387c139971ff55f786773c7ce51448c Reviewed-on: https://gerrit.libreoffice.org/23164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-09loplugin:constantparam in sfx2Noel Grandin1-1/+1
Change-Id: I50a2d8221f907f0e844e558f3dbdd0346c010201
2016-03-04cid#1326861,1326862: Eq: Problems with implementation of equals()Stephan Bergmann2-27/+1
Cloneable, odd additional equals overloads, odd hasCode implementation---all smells like clueless cargo cult. And I see no place where it would get used. Change-Id: Icca89531ce9181fb47eacfb6fae704f4f45012a9
2016-03-04This ScriptEntry ctor is always called with empty languagedeppropsStephan Bergmann3-10/+4
Change-Id: Ia8ddfecf2f809e9f0132ba59812446973532476c
2016-03-04Scripting.location is unusedStephan Bergmann4-16/+7
Change-Id: Ia534b5aa579a678f8b0273e6c8c12a6ad335c67a
2016-03-04ScriptEntry fields can be finalStephan Bergmann1-6/+6
Change-Id: I7616641584b7ea8192cf3724d8b7d5b88af39da6
2016-03-04Turn forwarding among ScriptEntry ctors around, dropping oneStephan Bergmann1-19/+11
Change-Id: If3c86c7e5c4acaf4a3e48194e24c3c73e4e99499
2016-03-04Remove unusd ScriptEntry ctorStephan Bergmann1-4/+0
Change-Id: I7109877e789659b87cbc16e9c5da39dcc8249e09
2016-03-04Forwarding-only ctor, can be privateStephan Bergmann1-1/+1
Change-Id: I9ed2aa9c2bf2e17705dc711560154a9596c8264a
2016-03-04This ScriptEntry ctor is only needed by ctor of derived class ScriptMetaDataStephan Bergmann1-1/+1
Change-Id: If3e6aae326aa53825edca9d5dc207d185d288cce
2016-03-04Remove unused ScriptEntry.setLogicalNameStephan Bergmann1-4/+0
Change-Id: Iad58e4227433b766bbdce92a53c95aed48320f88
2016-03-04Parcel.getByName apparently wants to return ScriptMetaDataStephan Bergmann3-10/+10
Change-Id: I4a710384ec3a0d719f2ad1fbbe7b43b0be1fa1d9
2016-02-25coverity#1354272 SS: Unread field should be staticCaolán McNamara1-1/+1
Change-Id: Ie9480265be8053805cb48cefe189e65a47ce0908
2016-02-22tdf#98004 Added toolbar to beanshell editor with undo/redo buttonsChirag Manwani3-22/+37
Change-Id: I1d553473f34622e1cb1dab3ffe74ec0c5fa05605 Reviewed-on: https://gerrit.libreoffice.org/22612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-21tdf#97636 Added Undo/Redo functionality to Beanshell EditorChirag Manwani1-1/+66
Change-Id: Ie24f7bb5e59cd78ba2d06a4ed1b6a0bcaf1a3736 Reviewed-on: https://gerrit.libreoffice.org/22500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-18coverity#1326437 Dereference null return valueCaolán McNamara1-1/+1
Change-Id: I9fe5f799b7b47d8dc1fd34893c392fcecef5b5a4
2016-02-18tdf#97637 Fixed Tab size of beanshell editor to 4Chirag Manwani1-0/+1
Change-Id: Ifeb73ab210d9d955e502fab3e3ec993081625945 Reviewed-on: https://gerrit.libreoffice.org/22473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-18tdf#97642 Use native theming for swing controls in Beanshell EditorChirag Manwani1-0/+7
Change-Id: Ifb2f3cfe5132e9b6f7d5d2df5868b09b39c5ec47 Reviewed-on: https://gerrit.libreoffice.org/22429 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>